mirror of
https://github.com/zitadel/zitadel.git
synced 2025-12-06 19:36:41 +00:00
b10455b51f
# Which Problems Are Solved - The previous monorepo in monorepo structure for the login app and its related packages was fragmented, complicated and buggy. - The process for building and testing the login container was inconsistent between local development and CI. - Lack of clear documentation as well as easy and reliable ways for non-frontend developers to reproduce and fix failing PR checks locally. # How the Problems Are Solved - Consolidated the login app and its related npm packages by moving the main package to `apps/login/apps/login` and merging `apps/login/packages/integration` and `apps/login/packages/acceptance` into the main `apps/login` package. - Migrated from Docker Compose-based test setups to dev container-based setups, adding support for multiple dev container configurations: - `.devcontainer/base` - `.devcontainer/turbo-lint-unit` - `.devcontainer/turbo-lint-unit-debug` - `.devcontainer/login-integration` - `.devcontainer/login-integration-debug` - Added npm scripts to run the new dev container setups, enabling exact reproduction of GitHub PR checks locally, and updated the pipeline to use these containers. - Cleaned up Dockerfiles and docker-bake.hcl files to only build the production image for the login app. - Cleaned up compose files to focus on dev environments in dev containers. - Updated `CONTRIBUTING.md` with guidance on running and debugging PR checks locally using the new dev container approach. - Introduced separate Dockerfiles for the login app to distinguish between using published client packages and building clients from local protos. - Ensured the login container is always built in the pipeline for use in integration and acceptance tests. - Updated Makefile and GitHub Actions workflows to use `--frozen-lockfile` for installing pnpm packages, ensuring reproducible installs. - Disabled GitHub release creation by the changeset action. - Refactored the `/build` directory structure for clarity and maintainability. - Added a `clean` command to `docks/package.json`. - Experimentally added `knip` to the `zitadel-client` package for improved linting of dependencies and exports. # Additional Changes - Fixed Makefile commands for consistency and reliability. - Improved the structure and clarity of the `/build` directory to support seamless integration of the login build. - Enhanced documentation and developer experience for running and debugging CI checks locally. # Additional Context - See updated `CONTRIBUTING.md` for new local development and debugging instructions. - These changes are a prerequisite for further improvements to the CI pipeline and local development workflow. - Closes #10276
55 lines
1.6 KiB
YAML
55 lines
1.6 KiB
YAML
name: 🛠️ Improvement
|
|
description: "Create an new issue for an improvment in ZITADEL"
|
|
labels: ["improvement"]
|
|
body:
|
|
- type: markdown
|
|
attributes:
|
|
value: |
|
|
Thanks for taking the time to fill out this improvement request
|
|
- type: checkboxes
|
|
id: preflight
|
|
attributes:
|
|
label: Preflight Checklist
|
|
options:
|
|
- label:
|
|
I could not find a solution in the existing issues, docs, nor discussions
|
|
required: true
|
|
- label:
|
|
I have joined the [ZITADEL chat](https://zitadel.com/chat)
|
|
- type: textarea
|
|
id: problem
|
|
attributes:
|
|
label: Describe your problem
|
|
description: Please describe your problem this improvement is supposed to solve.
|
|
placeholder: Describe the problem you have
|
|
validations:
|
|
required: true
|
|
- type: textarea
|
|
id: solution
|
|
attributes:
|
|
label: Describe your ideal solution
|
|
description: Which solution do you propose?
|
|
placeholder: As a [type of user], I want [some goal] so that [some reason].
|
|
validations:
|
|
required: true
|
|
- type: input
|
|
id: version
|
|
attributes:
|
|
label: Version
|
|
description: Which version of the typescript library are you using.
|
|
- type: dropdown
|
|
id: environment
|
|
attributes:
|
|
label: Environment
|
|
description: How do you use ZITADEL?
|
|
options:
|
|
- ZITADEL Cloud
|
|
- Self-hosted
|
|
validations:
|
|
required: true
|
|
- type: textarea
|
|
id: additional
|
|
attributes:
|
|
label: Additional Context
|
|
description: Please add any other infos that could be useful.
|