mirror of
https://github.com/zitadel/zitadel.git
synced 2025-12-06 16:12:13 +00:00
# Which Problems Are Solved - The previous monorepo in monorepo structure for the login app and its related packages was fragmented, complicated and buggy. - The process for building and testing the login container was inconsistent between local development and CI. - Lack of clear documentation as well as easy and reliable ways for non-frontend developers to reproduce and fix failing PR checks locally. # How the Problems Are Solved - Consolidated the login app and its related npm packages by moving the main package to `apps/login/apps/login` and merging `apps/login/packages/integration` and `apps/login/packages/acceptance` into the main `apps/login` package. - Migrated from Docker Compose-based test setups to dev container-based setups, adding support for multiple dev container configurations: - `.devcontainer/base` - `.devcontainer/turbo-lint-unit` - `.devcontainer/turbo-lint-unit-debug` - `.devcontainer/login-integration` - `.devcontainer/login-integration-debug` - Added npm scripts to run the new dev container setups, enabling exact reproduction of GitHub PR checks locally, and updated the pipeline to use these containers. - Cleaned up Dockerfiles and docker-bake.hcl files to only build the production image for the login app. - Cleaned up compose files to focus on dev environments in dev containers. - Updated `CONTRIBUTING.md` with guidance on running and debugging PR checks locally using the new dev container approach. - Introduced separate Dockerfiles for the login app to distinguish between using published client packages and building clients from local protos. - Ensured the login container is always built in the pipeline for use in integration and acceptance tests. - Updated Makefile and GitHub Actions workflows to use `--frozen-lockfile` for installing pnpm packages, ensuring reproducible installs. - Disabled GitHub release creation by the changeset action. - Refactored the `/build` directory structure for clarity and maintainability. - Added a `clean` command to `docks/package.json`. - Experimentally added `knip` to the `zitadel-client` package for improved linting of dependencies and exports. # Additional Changes - Fixed Makefile commands for consistency and reliability. - Improved the structure and clarity of the `/build` directory to support seamless integration of the login build. - Enhanced documentation and developer experience for running and debugging CI checks locally. # Additional Context - See updated `CONTRIBUTING.md` for new local development and debugging instructions. - These changes are a prerequisite for further improvements to the CI pipeline and local development workflow. - Closes #10276
100 lines
4.8 KiB
TypeScript
100 lines
4.8 KiB
TypeScript
import test from "@playwright/test";
|
|
|
|
test("login with Generic OAuth IDP", async ({ page }) => {
|
|
test.skip();
|
|
// Given a Generic OAuth IDP is configured on the organization
|
|
// Given the user has Generic OAuth IDP added as auth method
|
|
// User authenticates with the Generic OAuth IDP
|
|
// User is redirected back to login
|
|
// User is redirected to the app
|
|
});
|
|
|
|
test("login with Generic OAuth IDP - error", async ({ page }) => {
|
|
test.skip();
|
|
// Given the Generic OAuth IDP is configured on the organization
|
|
// Given the user has Generic OAuth IDP added as auth method
|
|
// User is redirected to the Generic OAuth IDP
|
|
// User authenticates with the Generic OAuth IDP and gets an error
|
|
// User is redirected back to login
|
|
// An error is shown to the user "Something went wrong"
|
|
});
|
|
|
|
test("login with Generic OAuth IDP, no user existing - auto register", async ({ page }) => {
|
|
test.skip();
|
|
// Given idp Generic OAuth is configure on the organization as only authencation method
|
|
// Given idp Generic OAuth is configure with account creation alloweed, and automatic creation enabled
|
|
// Given no user exists yet
|
|
// User is automatically redirected to Generic OAuth
|
|
// User authenticates in Generic OAuth
|
|
// User is redirect to ZITADEL login
|
|
// User is created in ZITADEL
|
|
// User is redirected to the app (default redirect url)
|
|
});
|
|
|
|
test("login with Generic OAuth IDP, no user existing - auto register not possible", async ({ page }) => {
|
|
test.skip();
|
|
// Given idp Generic OAuth is configure on the organization as only authencation method
|
|
// Given idp Generic OAuth is configure with account creation alloweed, and automatic creation enabled
|
|
// Given no user exists yet
|
|
// User is automatically redirected to Generic OAuth
|
|
// User authenticates in Generic OAuth
|
|
// User is redirect to ZITADEL login
|
|
// Because of missing informaiton on the user auto creation is not possible
|
|
// User will see the registration page with pre filled user information
|
|
// User fills missing information
|
|
// User clicks register button
|
|
// User is created in ZITADEL
|
|
// User is redirected to the app (default redirect url)
|
|
});
|
|
|
|
test("login with Generic OAuth IDP, no user existing - auto register enabled - manual creation disabled, creation not possible", async ({
|
|
page,
|
|
}) => {
|
|
test.skip();
|
|
// Given idp Generic OAuth is configure on the organization as only authencation method
|
|
// Given idp Generic OAuth is configure with account creation not allowed, and automatic creation enabled
|
|
// Given no user exists yet
|
|
// User is automatically redirected to Generic OAuth
|
|
// User authenticates in Generic OAuth
|
|
// User is redirect to ZITADEL login
|
|
// Because of missing informaiton on the user auto creation is not possible
|
|
// Error message is shown, that registration of the user was not possible due to missing information
|
|
});
|
|
|
|
test("login with Generic OAuth IDP, no user linked - auto link", async ({ page }) => {
|
|
test.skip();
|
|
// Given idp Generic OAuth is configure on the organization as only authencation method
|
|
// Given idp Generic OAuth is configure with account linking allowed, and linking set to existing email
|
|
// Given user with email address user@zitadel.com exists
|
|
// User is automatically redirected to Generic OAuth
|
|
// User authenticates in Generic OAuth with user@zitadel.com
|
|
// User is redirect to ZITADEL login
|
|
// User is linked with existing user in ZITADEL
|
|
// User is redirected to the app (default redirect url)
|
|
});
|
|
|
|
test("login with Generic OAuth IDP, no user linked, linking not possible", async ({ page }) => {
|
|
test.skip();
|
|
// Given idp Generic OAuth is configure on the organization as only authencation method
|
|
// Given idp Generic OAuth is configure with manually account linking not allowed, and linking set to existing email
|
|
// Given user with email address user@zitadel.com doesn't exists
|
|
// User is automatically redirected to Generic OAuth
|
|
// User authenticates in Generic OAuth with user@zitadel.com
|
|
// User is redirect to ZITADEL login
|
|
// User with email address user@zitadel.com can not be found
|
|
// User will get an error message that account linking wasn't possible
|
|
});
|
|
|
|
test("login with Generic OAuth IDP, no user linked, linking successful", async ({ page }) => {
|
|
test.skip();
|
|
// Given idp Generic OAuth is configure on the organization as only authencation method
|
|
// Given idp Generic OAuth is configure with manually account linking allowed, and linking set to existing email
|
|
// Given user with email address user@zitadel.com doesn't exists
|
|
// User is automatically redirected to Generic OAuth
|
|
// User authenticates in Generic OAuth with user@zitadel.com
|
|
// User is redirect to ZITADEL login
|
|
// User with email address user@zitadel.com can not be found
|
|
// User is prompted to link the account manually
|
|
// User is redirected to the app (default redirect url)
|
|
});
|