mirror of
https://github.com/zitadel/zitadel.git
synced 2025-12-07 03:52:10 +00:00
# Which Problems Are Solved - The previous monorepo in monorepo structure for the login app and its related packages was fragmented, complicated and buggy. - The process for building and testing the login container was inconsistent between local development and CI. - Lack of clear documentation as well as easy and reliable ways for non-frontend developers to reproduce and fix failing PR checks locally. # How the Problems Are Solved - Consolidated the login app and its related npm packages by moving the main package to `apps/login/apps/login` and merging `apps/login/packages/integration` and `apps/login/packages/acceptance` into the main `apps/login` package. - Migrated from Docker Compose-based test setups to dev container-based setups, adding support for multiple dev container configurations: - `.devcontainer/base` - `.devcontainer/turbo-lint-unit` - `.devcontainer/turbo-lint-unit-debug` - `.devcontainer/login-integration` - `.devcontainer/login-integration-debug` - Added npm scripts to run the new dev container setups, enabling exact reproduction of GitHub PR checks locally, and updated the pipeline to use these containers. - Cleaned up Dockerfiles and docker-bake.hcl files to only build the production image for the login app. - Cleaned up compose files to focus on dev environments in dev containers. - Updated `CONTRIBUTING.md` with guidance on running and debugging PR checks locally using the new dev container approach. - Introduced separate Dockerfiles for the login app to distinguish between using published client packages and building clients from local protos. - Ensured the login container is always built in the pipeline for use in integration and acceptance tests. - Updated Makefile and GitHub Actions workflows to use `--frozen-lockfile` for installing pnpm packages, ensuring reproducible installs. - Disabled GitHub release creation by the changeset action. - Refactored the `/build` directory structure for clarity and maintainability. - Added a `clean` command to `docks/package.json`. - Experimentally added `knip` to the `zitadel-client` package for improved linting of dependencies and exports. # Additional Changes - Fixed Makefile commands for consistency and reliability. - Improved the structure and clarity of the `/build` directory to support seamless integration of the login build. - Enhanced documentation and developer experience for running and debugging CI checks locally. # Additional Context - See updated `CONTRIBUTING.md` for new local development and debugging instructions. - These changes are a prerequisite for further improvements to the CI pipeline and local development workflow. - Closes #10276
110 lines
3.8 KiB
TypeScript
110 lines
3.8 KiB
TypeScript
import { expect, Page } from "@playwright/test";
|
|
import { CDPSession } from "playwright-core";
|
|
|
|
interface session {
|
|
client: CDPSession;
|
|
authenticatorId: string;
|
|
}
|
|
|
|
async function client(page: Page): Promise<session> {
|
|
const cdpSession = await page.context().newCDPSession(page);
|
|
await cdpSession.send("WebAuthn.enable", { enableUI: false });
|
|
const result = await cdpSession.send("WebAuthn.addVirtualAuthenticator", {
|
|
options: {
|
|
protocol: "ctap2",
|
|
transport: "internal",
|
|
hasResidentKey: true,
|
|
hasUserVerification: true,
|
|
isUserVerified: true,
|
|
automaticPresenceSimulation: true,
|
|
},
|
|
});
|
|
return { client: cdpSession, authenticatorId: result.authenticatorId };
|
|
}
|
|
|
|
export async function passkeyRegister(page: Page): Promise<string> {
|
|
const session = await client(page);
|
|
|
|
await passkeyNotExisting(session.client, session.authenticatorId);
|
|
await simulateSuccessfulPasskeyRegister(session.client, session.authenticatorId, () =>
|
|
page.getByTestId("submit-button").click(),
|
|
);
|
|
await passkeyRegistered(session.client, session.authenticatorId);
|
|
|
|
return session.authenticatorId;
|
|
}
|
|
|
|
export async function passkey(page: Page, authenticatorId: string) {
|
|
const cdpSession = await page.context().newCDPSession(page);
|
|
await cdpSession.send("WebAuthn.enable", { enableUI: false });
|
|
|
|
const signCount = await passkeyExisting(cdpSession, authenticatorId);
|
|
|
|
await simulateSuccessfulPasskeyInput(cdpSession, authenticatorId, () => page.getByTestId("submit-button").click());
|
|
|
|
await passkeyUsed(cdpSession, authenticatorId, signCount);
|
|
}
|
|
|
|
async function passkeyNotExisting(client: CDPSession, authenticatorId: string) {
|
|
const result = await client.send("WebAuthn.getCredentials", { authenticatorId });
|
|
expect(result.credentials).toHaveLength(0);
|
|
}
|
|
|
|
async function passkeyRegistered(client: CDPSession, authenticatorId: string) {
|
|
const result = await client.send("WebAuthn.getCredentials", { authenticatorId });
|
|
expect(result.credentials).toHaveLength(1);
|
|
await passkeyUsed(client, authenticatorId, 0);
|
|
}
|
|
|
|
async function passkeyExisting(client: CDPSession, authenticatorId: string): Promise<number> {
|
|
const result = await client.send("WebAuthn.getCredentials", { authenticatorId });
|
|
expect(result.credentials).toHaveLength(1);
|
|
return result.credentials[0].signCount;
|
|
}
|
|
|
|
async function passkeyUsed(client: CDPSession, authenticatorId: string, signCount: number) {
|
|
const result = await client.send("WebAuthn.getCredentials", { authenticatorId });
|
|
expect(result.credentials).toHaveLength(1);
|
|
expect(result.credentials[0].signCount).toBeGreaterThan(signCount);
|
|
}
|
|
|
|
async function simulateSuccessfulPasskeyRegister(
|
|
client: CDPSession,
|
|
authenticatorId: string,
|
|
operationTrigger: () => Promise<void>,
|
|
) {
|
|
// initialize event listeners to wait for a successful passkey input event
|
|
const operationCompleted = new Promise<void>((resolve) => {
|
|
client.on("WebAuthn.credentialAdded", () => {
|
|
console.log("Credential Added!");
|
|
resolve();
|
|
});
|
|
});
|
|
|
|
// perform a user action that triggers passkey prompt
|
|
await operationTrigger();
|
|
|
|
// wait to receive the event that the passkey was successfully registered or verified
|
|
await operationCompleted;
|
|
}
|
|
|
|
async function simulateSuccessfulPasskeyInput(
|
|
client: CDPSession,
|
|
authenticatorId: string,
|
|
operationTrigger: () => Promise<void>,
|
|
) {
|
|
// initialize event listeners to wait for a successful passkey input event
|
|
const operationCompleted = new Promise<void>((resolve) => {
|
|
client.on("WebAuthn.credentialAsserted", () => {
|
|
console.log("Credential Asserted!");
|
|
resolve();
|
|
});
|
|
});
|
|
|
|
// perform a user action that triggers passkey prompt
|
|
await operationTrigger();
|
|
|
|
// wait to receive the event that the passkey was successfully registered or verified
|
|
await operationCompleted;
|
|
}
|