mirror of
https://github.com/zitadel/zitadel.git
synced 2025-12-07 07:16:54 +00:00
# Which Problems Are Solved - The previous monorepo in monorepo structure for the login app and its related packages was fragmented, complicated and buggy. - The process for building and testing the login container was inconsistent between local development and CI. - Lack of clear documentation as well as easy and reliable ways for non-frontend developers to reproduce and fix failing PR checks locally. # How the Problems Are Solved - Consolidated the login app and its related npm packages by moving the main package to `apps/login/apps/login` and merging `apps/login/packages/integration` and `apps/login/packages/acceptance` into the main `apps/login` package. - Migrated from Docker Compose-based test setups to dev container-based setups, adding support for multiple dev container configurations: - `.devcontainer/base` - `.devcontainer/turbo-lint-unit` - `.devcontainer/turbo-lint-unit-debug` - `.devcontainer/login-integration` - `.devcontainer/login-integration-debug` - Added npm scripts to run the new dev container setups, enabling exact reproduction of GitHub PR checks locally, and updated the pipeline to use these containers. - Cleaned up Dockerfiles and docker-bake.hcl files to only build the production image for the login app. - Cleaned up compose files to focus on dev environments in dev containers. - Updated `CONTRIBUTING.md` with guidance on running and debugging PR checks locally using the new dev container approach. - Introduced separate Dockerfiles for the login app to distinguish between using published client packages and building clients from local protos. - Ensured the login container is always built in the pipeline for use in integration and acceptance tests. - Updated Makefile and GitHub Actions workflows to use `--frozen-lockfile` for installing pnpm packages, ensuring reproducible installs. - Disabled GitHub release creation by the changeset action. - Refactored the `/build` directory structure for clarity and maintainability. - Added a `clean` command to `docks/package.json`. - Experimentally added `knip` to the `zitadel-client` package for improved linting of dependencies and exports. # Additional Changes - Fixed Makefile commands for consistency and reliability. - Improved the structure and clarity of the `/build` directory to support seamless integration of the login build. - Enhanced documentation and developer experience for running and debugging CI checks locally. # Additional Context - See updated `CONTRIBUTING.md` for new local development and debugging instructions. - These changes are a prerequisite for further improvements to the CI pipeline and local development workflow. - Closes #10276
44 lines
1.4 KiB
TypeScript
44 lines
1.4 KiB
TypeScript
import { Gaxios, GaxiosResponse } from "gaxios";
|
|
|
|
const awaitNotification = new Gaxios({
|
|
url: process.env.SINK_NOTIFICATION_URL,
|
|
method: "POST",
|
|
retryConfig: {
|
|
httpMethodsToRetry: ["POST"],
|
|
statusCodesToRetry: [[404, 404]],
|
|
retry: Number.MAX_SAFE_INTEGER, // totalTimeout limits the number of retries
|
|
totalTimeout: 10000, // 10 seconds
|
|
onRetryAttempt: (error) => {
|
|
console.warn(`Retrying request to sink notification service: ${error.message}`);
|
|
},
|
|
},
|
|
});
|
|
|
|
export async function getOtpFromSink(recipient: string): Promise<any> {
|
|
return awaitNotification.request({ data: { recipient } }).then((response) => {
|
|
expectSuccess(response);
|
|
const otp = response?.data?.args?.otp;
|
|
if (!otp) {
|
|
throw new Error(`Response does not contain an otp property: ${JSON.stringify(response.data, null, 2)}`);
|
|
}
|
|
return otp;
|
|
});
|
|
}
|
|
|
|
export async function getCodeFromSink(recipient: string): Promise<any> {
|
|
return awaitNotification.request({ data: { recipient } }).then((response) => {
|
|
expectSuccess(response);
|
|
const code = response?.data?.args?.code;
|
|
if (!code) {
|
|
throw new Error(`Response does not contain a code property: ${JSON.stringify(response.data, null, 2)}`);
|
|
}
|
|
return code;
|
|
});
|
|
}
|
|
|
|
function expectSuccess(response: GaxiosResponse): void {
|
|
if (response.status !== 200) {
|
|
throw new Error(`Expected HTTP status 200, but got: ${response.status} - ${response.statusText}`);
|
|
}
|
|
}
|