mirror of
https://github.com/zitadel/zitadel.git
synced 2025-12-06 09:42:19 +00:00
2727fa719d
# Which Problems Are Solved
The event execution system currently uses a projection handler that
subscribes to and processes all events for all instances. This creates a
high static cost because the system over-fetches event data, handling
many events that are not needed by most instances. This inefficiency is
also reflected in high "rows returned" metrics in the database.
# How the Problems Are Solved
Eliminate the use of a project handler. Instead, events for which
"execution targets" are defined, are directly pushed to the queue by the
eventstore. A Router is populated in the Instance object in the authz
middleware.
- By joining the execution targets to the instance, no additional
queries are needed anymore.
- As part of the instance object, execution targets are now cached as
well.
- Events are queued within the same transaction, giving transactional
guarantees on delivery.
- Uses the "insert many fast` variant of River. Multiple jobs are queued
in a single round-trip to the database.
- Fix compatibility with PostgreSQL 15
# Additional Changes
- The signing key was stored as plain-text in the river job payload in
the DB. This violated our [Secrets
Storage](https://zitadel.com/docs/concepts/architecture/secrets#secrets-storage)
principle. This change removed the field and only uses the encrypted
version of the signing key.
- Fixed the target ordering from descending to ascending.
- Some minor linter warnings on the use of `io.WriteString()`.
# Additional Context
- Introduced in https://github.com/zitadel/zitadel/pull/9249
- Closes https://github.com/zitadel/zitadel/issues/10553
- Closes https://github.com/zitadel/zitadel/issues/9832
- Closes https://github.com/zitadel/zitadel/issues/10372
- Closes https://github.com/zitadel/zitadel/issues/10492
---------
Co-authored-by: Stefan Benz <46600784+stebenz@users.noreply.github.com>
(cherry picked from commit a9ebc06c77)
93 lines
2.5 KiB
Go
93 lines
2.5 KiB
Go
package execution
|
|
|
|
import (
|
|
"encoding/json"
|
|
"time"
|
|
|
|
"github.com/zitadel/zitadel/internal/eventstore"
|
|
"github.com/zitadel/zitadel/internal/execution/target"
|
|
)
|
|
|
|
const (
|
|
QueueName = "execution"
|
|
)
|
|
|
|
type Request struct {
|
|
Aggregate *eventstore.Aggregate `json:"aggregate"`
|
|
Sequence uint64 `json:"sequence"`
|
|
EventType eventstore.EventType `json:"eventType"`
|
|
CreatedAt time.Time `json:"createdAt"`
|
|
UserID string `json:"userID"`
|
|
EventData []byte `json:"eventData"`
|
|
TargetsData []byte `json:"targetsData"`
|
|
}
|
|
|
|
func NewRequest(e eventstore.Event, targets []target.Target) (*Request, error) {
|
|
targetsData, err := json.Marshal(targets)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
eventData, err := json.Marshal(e)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return &Request{
|
|
Aggregate: e.Aggregate(),
|
|
Sequence: e.Sequence(),
|
|
EventType: e.Type(),
|
|
CreatedAt: e.CreatedAt(),
|
|
UserID: e.Creator(),
|
|
EventData: eventData,
|
|
TargetsData: targetsData,
|
|
}, nil
|
|
}
|
|
|
|
func (e *Request) Kind() string {
|
|
return "execution_request"
|
|
}
|
|
|
|
func ContextInfoFromRequest(e *Request) *ContextInfoEvent {
|
|
return &ContextInfoEvent{
|
|
AggregateID: e.Aggregate.ID,
|
|
AggregateType: string(e.Aggregate.Type),
|
|
ResourceOwner: e.Aggregate.ResourceOwner,
|
|
InstanceID: e.Aggregate.InstanceID,
|
|
Version: string(e.Aggregate.Version),
|
|
Sequence: e.Sequence,
|
|
EventType: string(e.EventType),
|
|
CreatedAt: e.CreatedAt.Format(time.RFC3339Nano),
|
|
UserID: e.UserID,
|
|
EventPayload: e.EventData,
|
|
}
|
|
}
|
|
|
|
type ContextInfoEvent struct {
|
|
AggregateID string `json:"aggregateID,omitempty"`
|
|
AggregateType string `json:"aggregateType,omitempty"`
|
|
ResourceOwner string `json:"resourceOwner,omitempty"`
|
|
InstanceID string `json:"instanceID,omitempty"`
|
|
Version string `json:"version,omitempty"`
|
|
Sequence uint64 `json:"sequence,omitempty"`
|
|
EventType string `json:"event_type,omitempty"`
|
|
CreatedAt string `json:"created_at,omitempty"`
|
|
UserID string `json:"userID,omitempty"`
|
|
EventPayload json.RawMessage `json:"event_payload,omitempty"`
|
|
}
|
|
|
|
func (c *ContextInfoEvent) GetHTTPRequestBody() []byte {
|
|
data, err := json.Marshal(c)
|
|
if err != nil {
|
|
return nil
|
|
}
|
|
return data
|
|
}
|
|
|
|
func (c *ContextInfoEvent) SetHTTPResponseBody(resp []byte) error {
|
|
// response is irrelevant and will not be unmarshaled
|
|
return nil
|
|
}
|
|
|
|
func (c *ContextInfoEvent) GetContent() any {
|
|
return c.EventPayload
|
|
}
|