mirror of
https://github.com/zitadel/zitadel.git
synced 2024-12-13 19:44:21 +00:00
189505c80f
# Which Problems Are Solved ZITADEL uses HTML for emails and renders certain information such as usernames dynamically. That information can be entered by users or administrators. Due to a missing output sanitization, these emails could include malicious code. This may potentially lead to a threat where an attacker, without privileges, could send out altered notifications that are part of the registration processes. An attacker could create a malicious link, where the injected code would be rendered as part of the email. During investigation of this issue a related issue was found and mitigated, where on the user's detail page the username was not sanitized and would also render HTML, giving an attacker the same vulnerability. While it was possible to inject HTML including javascript, the execution of such scripts would be prevented by most email clients and the Content Security Policy in Console UI. # How the Problems Are Solved - All arguments used for email are sanitized (`html.EscapeString`) - The email text no longer `html.UnescapeString` (HTML in custom text is still possible) - Console no longer uses `[innerHtml]` to render the username # Additional Changes None # Additional Context - raised via email --------- Co-authored-by: peintnermax <max@caos.ch> |
||
|---|---|---|
| .. | ||
| domain_claimed.go | ||
| email_verification_code_test.go | ||
| email_verification_code.go | ||
| init_code.go | ||
| notification.go | ||
| otp.go | ||
| password_change.go | ||
| password_code.go | ||
| passwordless_registration_link_test.go | ||
| passwordless_registration_link.go | ||
| phone_verification_code.go | ||
| templateData.go | ||
| types_test.go | ||
| user_email.go | ||
| user_phone.go | ||
| webhook.go | ||
| without_template.go | ||