mirror of
https://github.com/zitadel/zitadel.git
synced 2024-12-15 20:38:00 +00:00
cc3ec1e2a7
# Which Problems Are Solved The current v3alpha actions APIs don't exactly adhere to the [new resources API design](https://zitadel.com/docs/apis/v3#standard-resources). # How the Problems Are Solved - **Breaking**: The current v3alpha actions APIs are removed. This is breaking. - **Resource Namespace**: New v3alpha actions APIs for targets and executions are added under the namespace /resources. - **Feature Flag**: New v3alpha actions APIs still have to be activated using the actions feature flag - **Reduced Executions Overhead**: Executions are managed similar to settings according to the new API design: an empty list of targets basically makes an execution a Noop. So a single method, SetExecution is enough to cover all use cases. Noop executions are not returned in future search requests. - **Compatibility**: The executions created with previous v3alpha APIs are still available to be managed with the new executions API. # Additional Changes - Removed integration tests which test executions but rely on readable targets. They are added again with #8169 # Additional Context Closes #8168
138 lines
4.7 KiB
Go
138 lines
4.7 KiB
Go
package action
|
|
|
|
import (
|
|
"context"
|
|
|
|
"github.com/zitadel/zitadel/internal/api/authz"
|
|
settings_object "github.com/zitadel/zitadel/internal/api/grpc/settings/object/v3alpha"
|
|
"github.com/zitadel/zitadel/internal/command"
|
|
"github.com/zitadel/zitadel/internal/domain"
|
|
"github.com/zitadel/zitadel/internal/repository/execution"
|
|
"github.com/zitadel/zitadel/internal/zerrors"
|
|
object "github.com/zitadel/zitadel/pkg/grpc/object/v3alpha"
|
|
action "github.com/zitadel/zitadel/pkg/grpc/resources/action/v3alpha"
|
|
)
|
|
|
|
func (s *Server) SetExecution(ctx context.Context, req *action.SetExecutionRequest) (*action.SetExecutionResponse, error) {
|
|
if err := checkExecutionEnabled(ctx); err != nil {
|
|
return nil, err
|
|
}
|
|
reqTargets := req.GetExecution().GetTargets()
|
|
targets := make([]*execution.Target, len(reqTargets))
|
|
for i, target := range reqTargets {
|
|
switch t := target.GetType().(type) {
|
|
case *action.ExecutionTargetType_Include:
|
|
include, err := conditionToInclude(t.Include)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
targets[i] = &execution.Target{Type: domain.ExecutionTargetTypeInclude, Target: include}
|
|
case *action.ExecutionTargetType_Target:
|
|
targets[i] = &execution.Target{Type: domain.ExecutionTargetTypeTarget, Target: t.Target}
|
|
}
|
|
}
|
|
set := &command.SetExecution{
|
|
Targets: targets,
|
|
}
|
|
owner := &object.Owner{
|
|
Type: object.OwnerType_OWNER_TYPE_INSTANCE,
|
|
Id: authz.GetInstance(ctx).InstanceID(),
|
|
}
|
|
var err error
|
|
var details *domain.ObjectDetails
|
|
switch t := req.GetCondition().GetConditionType().(type) {
|
|
case *action.Condition_Request:
|
|
cond := executionConditionFromRequest(t.Request)
|
|
details, err = s.command.SetExecutionRequest(ctx, cond, set, owner.Id)
|
|
case *action.Condition_Response:
|
|
cond := executionConditionFromResponse(t.Response)
|
|
details, err = s.command.SetExecutionResponse(ctx, cond, set, owner.Id)
|
|
case *action.Condition_Event:
|
|
cond := executionConditionFromEvent(t.Event)
|
|
details, err = s.command.SetExecutionEvent(ctx, cond, set, owner.Id)
|
|
case *action.Condition_Function:
|
|
details, err = s.command.SetExecutionFunction(ctx, command.ExecutionFunctionCondition(t.Function.GetName()), set, owner.Id)
|
|
default:
|
|
err = zerrors.ThrowInvalidArgument(nil, "ACTION-5r5Ju", "Errors.Execution.ConditionInvalid")
|
|
}
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return &action.SetExecutionResponse{
|
|
Details: settings_object.DomainToDetailsPb(details, owner),
|
|
}, nil
|
|
}
|
|
|
|
func conditionToInclude(cond *action.Condition) (string, error) {
|
|
switch t := cond.GetConditionType().(type) {
|
|
case *action.Condition_Request:
|
|
cond := executionConditionFromRequest(t.Request)
|
|
if err := cond.IsValid(); err != nil {
|
|
return "", err
|
|
}
|
|
return cond.ID(domain.ExecutionTypeRequest), nil
|
|
case *action.Condition_Response:
|
|
cond := executionConditionFromResponse(t.Response)
|
|
if err := cond.IsValid(); err != nil {
|
|
return "", err
|
|
}
|
|
return cond.ID(domain.ExecutionTypeRequest), nil
|
|
case *action.Condition_Event:
|
|
cond := executionConditionFromEvent(t.Event)
|
|
if err := cond.IsValid(); err != nil {
|
|
return "", err
|
|
}
|
|
return cond.ID(), nil
|
|
case *action.Condition_Function:
|
|
cond := command.ExecutionFunctionCondition(t.Function.GetName())
|
|
if err := cond.IsValid(); err != nil {
|
|
return "", err
|
|
}
|
|
return cond.ID(), nil
|
|
default:
|
|
return "", zerrors.ThrowInvalidArgument(nil, "ACTION-9BBob", "Errors.Execution.ConditionInvalid")
|
|
}
|
|
}
|
|
|
|
func (s *Server) ListExecutionFunctions(_ context.Context, _ *action.ListExecutionFunctionsRequest) (*action.ListExecutionFunctionsResponse, error) {
|
|
return &action.ListExecutionFunctionsResponse{
|
|
Functions: s.ListActionFunctions(),
|
|
}, nil
|
|
}
|
|
|
|
func (s *Server) ListExecutionMethods(_ context.Context, _ *action.ListExecutionMethodsRequest) (*action.ListExecutionMethodsResponse, error) {
|
|
return &action.ListExecutionMethodsResponse{
|
|
Methods: s.ListGRPCMethods(),
|
|
}, nil
|
|
}
|
|
|
|
func (s *Server) ListExecutionServices(_ context.Context, _ *action.ListExecutionServicesRequest) (*action.ListExecutionServicesResponse, error) {
|
|
return &action.ListExecutionServicesResponse{
|
|
Services: s.ListGRPCServices(),
|
|
}, nil
|
|
}
|
|
|
|
func executionConditionFromRequest(request *action.RequestExecution) *command.ExecutionAPICondition {
|
|
return &command.ExecutionAPICondition{
|
|
Method: request.GetMethod(),
|
|
Service: request.GetService(),
|
|
All: request.GetAll(),
|
|
}
|
|
}
|
|
|
|
func executionConditionFromResponse(response *action.ResponseExecution) *command.ExecutionAPICondition {
|
|
return &command.ExecutionAPICondition{
|
|
Method: response.GetMethod(),
|
|
Service: response.GetService(),
|
|
All: response.GetAll(),
|
|
}
|
|
}
|
|
|
|
func executionConditionFromEvent(event *action.EventExecution) *command.ExecutionEventCondition {
|
|
return &command.ExecutionEventCondition{
|
|
Event: event.GetEvent(),
|
|
Group: event.GetGroup(),
|
|
All: event.GetAll(),
|
|
}
|
|
}
|