mirror of
https://github.com/zitadel/zitadel.git
synced 2025-12-23 12:26:47 +00:00
cccfc816f6
This pull request introduces a significant refactoring of the database interaction layer, focusing on improving explicitness, transactional control, and error handling. The core change is the removal of the stateful `QueryExecutor` from repository instances. Instead, it is now passed as an argument to each method that interacts with the database. This change makes transaction management more explicit and flexible, as the same repository instance can be used with a database pool or a specific transaction without needing to be re-instantiated. ### Key Changes - **Explicit `QueryExecutor` Passing:** - All repository methods (`Get`, `List`, `Create`, `Update`, `Delete`, etc.) in `InstanceRepository`, `OrganizationRepository`, `UserRepository`, and their sub-repositories now require a `database.QueryExecutor` (e.g., a `*pgxpool.Pool` or `pgx.Tx`) as the first argument. - Repository constructors no longer accept a `QueryExecutor`. For example, `repository.InstanceRepository(pool)` is now `repository.InstanceRepository()`. - **Enhanced Error Handling:** - A new `database.MissingConditionError` is introduced to enforce required query conditions, such as ensuring an `instance_id` is always present in `UPDATE` and `DELETE` operations. - The database error wrapper in the `postgres` package now correctly identifies and wraps `pgx.ErrTooManyRows` and similar errors from the `scany` library into a `database.MultipleRowsFoundError`. - **Improved Database Conditions:** - The `database.Condition` interface now includes a `ContainsColumn(Column) bool` method. This allows for runtime checks to ensure that critical filters (like `instance_id`) are included in a query, preventing accidental cross-tenant data modification. - A new `database.Exists()` condition has been added to support `EXISTS` subqueries, enabling more complex filtering logic, such as finding an organization that has a specific domain. - **Repository and Interface Refactoring:** - The method for loading related entities (e.g., domains for an organization) has been changed from a boolean flag (`Domains(true)`) to a more explicit, chainable method (`LoadDomains()`). This returns a new repository instance configured to load the sub-resource, promoting immutability. - The custom `OrgIdentifierCondition` has been removed in favor of using the standard `database.Condition` interface, simplifying the API. - **Code Cleanup and Test Updates:** - Unnecessary struct embeddings and metadata have been removed. - All integration and repository tests have been updated to reflect the new method signatures, passing the database pool or transaction object explicitly. - New tests have been added to cover the new `ExistsDomain` functionality and other enhancements. These changes make the data access layer more robust, predictable, and easier to work with, especially in the context of database transactions.
80 lines
3.2 KiB
Go
80 lines
3.2 KiB
Go
package domain
|
|
|
|
import (
|
|
"context"
|
|
"time"
|
|
|
|
"github.com/zitadel/zitadel/backend/v3/storage/database"
|
|
)
|
|
|
|
type InstanceDomain struct {
|
|
InstanceID string `json:"instanceId,omitempty" db:"instance_id"`
|
|
Domain string `json:"domain,omitempty" db:"domain"`
|
|
// IsPrimary indicates if the domain is the primary domain of the instance.
|
|
// It is only set for custom domains.
|
|
IsPrimary *bool `json:"isPrimary,omitempty" db:"is_primary"`
|
|
// IsGenerated indicates if the domain is a generated domain.
|
|
// It is only set for custom domains.
|
|
IsGenerated *bool `json:"isGenerated,omitempty" db:"is_generated"`
|
|
Type DomainType `json:"type,omitempty" db:"type"`
|
|
|
|
CreatedAt time.Time `json:"createdAt,omitzero" db:"created_at"`
|
|
UpdatedAt time.Time `json:"updatedAt,omitzero" db:"updated_at"`
|
|
}
|
|
|
|
type AddInstanceDomain struct {
|
|
InstanceID string `json:"instanceId,omitempty" db:"instance_id"`
|
|
Domain string `json:"domain,omitempty" db:"domain"`
|
|
IsPrimary *bool `json:"isPrimary,omitempty" db:"is_primary"`
|
|
IsGenerated *bool `json:"isGenerated,omitempty" db:"is_generated"`
|
|
Type DomainType `json:"type,omitempty" db:"type"`
|
|
|
|
// CreatedAt is the time when the domain was added.
|
|
// It is set by the repository and should not be set by the caller.
|
|
CreatedAt time.Time `json:"createdAt,omitzero" db:"created_at"`
|
|
// UpdatedAt is the time when the domain was last updated.
|
|
// It is set by the repository and should not be set by the caller.
|
|
UpdatedAt time.Time `json:"updatedAt,omitzero" db:"updated_at"`
|
|
}
|
|
|
|
type instanceDomainColumns interface {
|
|
domainColumns
|
|
// IsGeneratedColumn returns the column for the is generated field.
|
|
IsGeneratedColumn() database.Column
|
|
// TypeColumn returns the column for the type field.
|
|
TypeColumn() database.Column
|
|
}
|
|
|
|
type instanceDomainConditions interface {
|
|
domainConditions
|
|
// TypeCondition returns a filter for the type field.
|
|
TypeCondition(typ DomainType) database.Condition
|
|
}
|
|
|
|
type instanceDomainChanges interface {
|
|
domainChanges
|
|
// SetType sets the type column.
|
|
SetType(typ DomainType) database.Change
|
|
}
|
|
|
|
type InstanceDomainRepository interface {
|
|
instanceDomainColumns
|
|
instanceDomainConditions
|
|
instanceDomainChanges
|
|
|
|
// Get returns a single domain based on the criteria.
|
|
// If no domain is found, it returns an error of type [database.ErrNotFound].
|
|
// If multiple domains are found, it returns an error of type [database.ErrMultipleRows].
|
|
Get(ctx context.Context, client database.QueryExecutor, opts ...database.QueryOption) (*InstanceDomain, error)
|
|
// List returns a list of domains based on the criteria.
|
|
// If no domains are found, it returns an empty slice.
|
|
List(ctx context.Context, client database.QueryExecutor, opts ...database.QueryOption) ([]*InstanceDomain, error)
|
|
|
|
// Add adds a new domain to the instance.
|
|
Add(ctx context.Context, client database.QueryExecutor, domain *AddInstanceDomain) error
|
|
// Update updates an existing domain in the instance.
|
|
Update(ctx context.Context, client database.QueryExecutor, condition database.Condition, changes ...database.Change) (int64, error)
|
|
// Remove removes a domain from the instance.
|
|
Remove(ctx context.Context, client database.QueryExecutor, condition database.Condition) (int64, error)
|
|
}
|