mirror of
https://github.com/zitadel/zitadel.git
synced 2025-12-06 02:22:16 +00:00
2727fa719d
# Which Problems Are Solved
The event execution system currently uses a projection handler that
subscribes to and processes all events for all instances. This creates a
high static cost because the system over-fetches event data, handling
many events that are not needed by most instances. This inefficiency is
also reflected in high "rows returned" metrics in the database.
# How the Problems Are Solved
Eliminate the use of a project handler. Instead, events for which
"execution targets" are defined, are directly pushed to the queue by the
eventstore. A Router is populated in the Instance object in the authz
middleware.
- By joining the execution targets to the instance, no additional
queries are needed anymore.
- As part of the instance object, execution targets are now cached as
well.
- Events are queued within the same transaction, giving transactional
guarantees on delivery.
- Uses the "insert many fast` variant of River. Multiple jobs are queued
in a single round-trip to the database.
- Fix compatibility with PostgreSQL 15
# Additional Changes
- The signing key was stored as plain-text in the river job payload in
the DB. This violated our [Secrets
Storage](https://zitadel.com/docs/concepts/architecture/secrets#secrets-storage)
principle. This change removed the field and only uses the encrypted
version of the signing key.
- Fixed the target ordering from descending to ascending.
- Some minor linter warnings on the use of `io.WriteString()`.
# Additional Context
- Introduced in https://github.com/zitadel/zitadel/pull/9249
- Closes https://github.com/zitadel/zitadel/issues/10553
- Closes https://github.com/zitadel/zitadel/issues/9832
- Closes https://github.com/zitadel/zitadel/issues/10372
- Closes https://github.com/zitadel/zitadel/issues/10492
---------
Co-authored-by: Stefan Benz <46600784+stebenz@users.noreply.github.com>
(cherry picked from commit a9ebc06c77)
67 lines
2.0 KiB
SQL
67 lines
2.0 KiB
SQL
with features as (
|
|
select instance_id, json_object_agg(
|
|
coalesce(i.key, s.key),
|
|
coalesce(i.value, s.value)
|
|
) features
|
|
from (select $1::text instance_id) x
|
|
cross join projections.system_features s
|
|
full outer join projections.instance_features2 i using (key, instance_id)
|
|
group by instance_id
|
|
), external_domains as (
|
|
select instance_id, array_agg(domain) as domains
|
|
from projections.instance_domains
|
|
where instance_id = $1
|
|
group by instance_id
|
|
), trusted_domains as (
|
|
select instance_id, array_agg(domain) as domains
|
|
from projections.instance_trusted_domains
|
|
where instance_id = $1
|
|
group by instance_id
|
|
), execution_targets as (
|
|
select instance_id, json_agg(x.execution_targets) as execution_targets from (
|
|
select e.instance_id, json_build_object(
|
|
'execution_id', et.execution_id,
|
|
'target_id', t.id,
|
|
'target_type', t.target_type,
|
|
'endpoint', t.endpoint,
|
|
'timeout', t.timeout,
|
|
'interrupt_on_error', t.interrupt_on_error,
|
|
'signing_key', t.signing_key
|
|
) as execution_targets
|
|
from projections.executions1 e
|
|
join projections.executions1_targets et
|
|
on e.instance_id = et.instance_id
|
|
and e.id = et.execution_id
|
|
join projections.targets2 t
|
|
on et.instance_id = t.instance_id
|
|
and et.target_id = t.id
|
|
where e.instance_id = $1
|
|
order by et.position asc
|
|
) as x
|
|
group by instance_id
|
|
)
|
|
select
|
|
i.id,
|
|
i.default_org_id,
|
|
i.iam_project_id,
|
|
i.console_client_id,
|
|
i.console_app_id,
|
|
i.default_language,
|
|
s.enable_iframe_embedding,
|
|
s.origins,
|
|
s.enable_impersonation,
|
|
l.audit_log_retention,
|
|
l.block,
|
|
f.features,
|
|
ed.domains as external_domains,
|
|
td.domains as trusted_domains,
|
|
et.execution_targets
|
|
from projections.instances i
|
|
left join projections.security_policies2 s on i.id = s.instance_id
|
|
left join projections.limits l on i.id = l.instance_id
|
|
left join features f on i.id = f.instance_id
|
|
left join external_domains ed on i.id = ed.instance_id
|
|
left join trusted_domains td on i.id = td.instance_id
|
|
left join execution_targets et on i.id = et.instance_id
|
|
where i.id = $1;
|