mirror of
https://github.com/zitadel/zitadel.git
synced 2025-04-23 06:01:32 +00:00

# Which Problems Are Solved [A recent performance enhancement]((https://github.com/zitadel/zitadel/pull/9497)) aimed at optimizing event store queries, specifically those involving multiple aggregate type filters, has successfully improved index utilization. While the query planner now correctly selects relevant indexes, it employs [bitmap index scans](https://www.postgresql.org/docs/current/indexes-bitmap-scans.html) to retrieve data. This approach, while beneficial in many scenarios, introduces a potential I/O bottleneck. The bitmap index scan first identifies the required database blocks and then utilizes a bitmap to access the corresponding rows from the table's heap. This subsequent "bitmap heap scan" can result in significant I/O overhead, particularly when queries return a substantial number of rows across numerous data pages. ## Impact: Under heavy load or with queries filtering for a wide range of events across multiple aggregate types, this increased I/O activity may lead to: - Increased query latency. - Elevated disk utilization. - Potential performance degradation of the event store and dependent systems. # How the Problems Are Solved To address this I/O bottleneck and further optimize query performance, the projection handler has been modified. Instead of employing multiple OR clauses for each aggregate type, the aggregate and event type filters are now combined using IN ARRAY filters. Technical Details: This change allows the PostgreSQL query planner to leverage [index-only scans](https://www.postgresql.org/docs/current/indexes-index-only-scans.html). By utilizing IN ARRAY filters, the database can efficiently retrieve the necessary data directly from the index, eliminating the need to access the table's heap. This results in: * Reduced I/O: Index-only scans significantly minimize disk I/O operations, as the database avoids reading data pages from the main table. * Improved Query Performance: By reducing I/O, query execution times are substantially improved, leading to lower latency. # Additional Changes - rollback of https://github.com/zitadel/zitadel/pull/9497 # Additional Information ## Query Plan of previous query ```sql SELECT created_at, event_type, "sequence", "position", payload, creator, "owner", instance_id, aggregate_type, aggregate_id, revision FROM eventstore.events2 WHERE instance_id = '<INSTANCE_ID>' AND ( ( instance_id = '<INSTANCE_ID>' AND "position" > <POSITION> AND aggregate_type = 'project' AND event_type = ANY(ARRAY[ 'project.application.added' ,'project.application.changed' ,'project.application.deactivated' ,'project.application.reactivated' ,'project.application.removed' ,'project.removed' ,'project.application.config.api.added' ,'project.application.config.api.changed' ,'project.application.config.api.secret.changed' ,'project.application.config.api.secret.updated' ,'project.application.config.oidc.added' ,'project.application.config.oidc.changed' ,'project.application.config.oidc.secret.changed' ,'project.application.config.oidc.secret.updated' ,'project.application.config.saml.added' ,'project.application.config.saml.changed' ]) ) OR ( instance_id = '<INSTANCE_ID>' AND "position" > <POSITION> AND aggregate_type = 'org' AND event_type = 'org.removed' ) OR ( instance_id = '<INSTANCE_ID>' AND "position" > <POSITION> AND aggregate_type = 'instance' AND event_type = 'instance.removed' ) ) AND "position" > 1741600905.3495 AND "position" < ( SELECT COALESCE(EXTRACT(EPOCH FROM min(xact_start)), EXTRACT(EPOCH FROM now())) FROM pg_stat_activity WHERE datname = current_database() AND application_name = ANY(ARRAY['zitadel_es_pusher_', 'zitadel_es_pusher', 'zitadel_es_pusher_<INSTANCE_ID>']) AND state <> 'idle' ) ORDER BY "position", in_tx_order LIMIT 200 OFFSET 1; ``` ``` Limit (cost=120.08..120.09 rows=7 width=361) (actual time=2.167..2.172 rows=0 loops=1) Output: events2.created_at, events2.event_type, events2.sequence, events2."position", events2.payload, events2.creator, events2.owner, events2.instance_id, events2.aggregate_type, events2.aggregate_id, events2.revision, events2.in_tx_order InitPlan 1 -> Aggregate (cost=2.74..2.76 rows=1 width=32) (actual time=1.813..1.815 rows=1 loops=1) Output: COALESCE(EXTRACT(epoch FROM min(s.xact_start)), EXTRACT(epoch FROM now())) -> Nested Loop (cost=0.00..2.74 rows=1 width=8) (actual time=1.803..1.805 rows=0 loops=1) Output: s.xact_start Join Filter: (d.oid = s.datid) -> Seq Scan on pg_catalog.pg_database d (cost=0.00..1.07 rows=1 width=4) (actual time=0.016..0.021 rows=1 loops=1) Output: d.oid, d.datname, d.datdba, d.encoding, d.datlocprovider, d.datistemplate, d.datallowconn, d.dathasloginevt, d.datconnlimit, d.datfrozenxid, d.datminmxid, d.dattablespace, d.datcollate, d.datctype, d.datlocale, d.daticurules, d.datcollversion, d.datacl Filter: (d.datname = current_database()) Rows Removed by Filter: 4 -> Function Scan on pg_catalog.pg_stat_get_activity s (cost=0.00..1.63 rows=3 width=16) (actual time=1.781..1.781 rows=0 loops=1) Output: s.datid, s.pid, s.usesysid, s.application_name, s.state, s.query, s.wait_event_type, s.wait_event, s.xact_start, s.query_start, s.backend_start, s.state_change, s.client_addr, s.client_hostname, s.client_port, s.backend_xid, s.backend_xmin, s.backend_type, s.ssl, s.sslversion, s.sslcipher, s.sslbits, s.ssl_client_dn, s.ssl_client_serial, s.ssl_issuer_dn, s.gss_auth, s.gss_princ, s.gss_enc, s.gss_delegation, s.leader_pid, s.query_id Function Call: pg_stat_get_activity(NULL::integer) Filter: ((s.state <> 'idle'::text) AND (s.application_name = ANY ('{zitadel_es_pusher_,zitadel_es_pusher,zitadel_es_pusher_<INSTANCE_ID>}'::text[]))) Rows Removed by Filter: 49 -> Sort (cost=117.31..117.33 rows=8 width=361) (actual time=2.167..2.168 rows=0 loops=1) Output: events2.created_at, events2.event_type, events2.sequence, events2."position", events2.payload, events2.creator, events2.owner, events2.instance_id, events2.aggregate_type, events2.aggregate_id, events2.revision, events2.in_tx_order Sort Key: events2."position", events2.in_tx_order Sort Method: quicksort Memory: 25kB -> Bitmap Heap Scan on eventstore.events2 (cost=84.92..117.19 rows=8 width=361) (actual time=2.088..2.089 rows=0 loops=1) Output: events2.created_at, events2.event_type, events2.sequence, events2."position", events2.payload, events2.creator, events2.owner, events2.instance_id, events2.aggregate_type, events2.aggregate_id, events2.revision, events2.in_tx_order Recheck Cond: (((events2.instance_id = '<INSTANCE_ID>'::text) AND (events2.aggregate_type = 'project'::text) AND (events2.event_type = ANY ('{project.application.added,project.application.changed,project.application.deactivated,project.application.reactivated,project.application.removed,project.removed,project.application.config.api.added,project.application.config.api.changed,project.application.config.api.secret.changed,project.application.config.api.secret.updated,project.application.config.oidc.added,project.application.config.oidc.changed,project.application.config.oidc.secret.changed,project.application.config.oidc.secret.updated,project.application.config.saml.added,project.application.config.saml.changed}'::text[])) AND (events2."position" > <POSITION>) AND (events2."position" > 1741600905.3495) AND (events2."position" < (InitPlan 1).col1)) OR ((events2.instance_id = '<INSTANCE_ID>'::text) AND (events2.aggregate_type = 'org'::text) AND (events2.event_type = 'org.removed'::text) AND (events2."position" > <POSITION>) AND (events2."position" > 1741600905.3495) AND (events2."position" < (InitPlan 1).col1)) OR ((events2.instance_id = '<INSTANCE_ID>'::text) AND (events2.aggregate_type = 'instance'::text) AND (events2.event_type = 'instance.removed'::text) AND (events2."position" > <POSITION>) AND (events2."position" > 1741600905.3495) AND (events2."position" < (InitPlan 1).col1))) -> BitmapOr (cost=84.88..84.88 rows=8 width=0) (actual time=2.080..2.081 rows=0 loops=1) -> Bitmap Index Scan on es_projection (cost=0.00..75.44 rows=8 width=0) (actual time=2.016..2.017 rows=0 loops=1) Index Cond: ((events2.instance_id = '<INSTANCE_ID>'::text) AND (events2.aggregate_type = 'project'::text) AND (events2.event_type = ANY ('{project.application.added,project.application.changed,project.application.deactivated,project.application.reactivated,project.application.removed,project.removed,project.application.config.api.added,project.application.config.api.changed,project.application.config.api.secret.changed,project.application.config.api.secret.updated,project.application.config.oidc.added,project.application.config.oidc.changed,project.application.config.oidc.secret.changed,project.application.config.oidc.secret.updated,project.application.config.saml.added,project.application.config.saml.changed}'::text[])) AND (events2."position" > <POSITION>) AND (events2."position" > 1741600905.3495) AND (events2."position" < (InitPlan 1).col1)) -> Bitmap Index Scan on es_projection (cost=0.00..4.71 rows=1 width=0) (actual time=0.016..0.016 rows=0 loops=1) Index Cond: ((events2.instance_id = '<INSTANCE_ID>'::text) AND (events2.aggregate_type = 'org'::text) AND (events2.event_type = 'org.removed'::text) AND (events2."position" > <POSITION>) AND (events2."position" > 1741600905.3495) AND (events2."position" < (InitPlan 1).col1)) -> Bitmap Index Scan on es_projection (cost=0.00..4.71 rows=1 width=0) (actual time=0.045..0.045 rows=0 loops=1) Index Cond: ((events2.instance_id = '<INSTANCE_ID>'::text) AND (events2.aggregate_type = 'instance'::text) AND (events2.event_type = 'instance.removed'::text) AND (events2."position" > <POSITION>) AND (events2."position" > 1741600905.3495) AND (events2."position" < (InitPlan 1).col1)) Query Identifier: 3194938266011254479 Planning Time: 1.295 ms Execution Time: 2.832 ms ``` ## Query Plan of new query ```sql SELECT created_at, event_type, "sequence", "position", payload, creator, "owner", instance_id, aggregate_type, aggregate_id, revision FROM eventstore.events2 WHERE instance_id = '<INSTANCE_ID>' AND "position" > <POSITION> AND aggregate_type = ANY(ARRAY['project', 'instance', 'org']) AND event_type = ANY(ARRAY[ 'project.application.added' ,'project.application.changed' ,'project.application.deactivated' ,'project.application.reactivated' ,'project.application.removed' ,'project.removed' ,'project.application.config.api.added' ,'project.application.config.api.changed' ,'project.application.config.api.secret.changed' ,'project.application.config.api.secret.updated' ,'project.application.config.oidc.added' ,'project.application.config.oidc.changed' ,'project.application.config.oidc.secret.changed' ,'project.application.config.oidc.secret.updated' ,'project.application.config.saml.added' ,'project.application.config.saml.changed' ,'org.removed' ,'instance.removed' ]) AND "position" < ( SELECT COALESCE(EXTRACT(EPOCH FROM min(xact_start)), EXTRACT(EPOCH FROM now())) FROM pg_stat_activity WHERE datname = current_database() AND application_name = ANY(ARRAY['zitadel_es_pusher_', 'zitadel_es_pusher', 'zitadel_es_pusher_<INSTANCE_ID>']) AND state <> 'idle' ) ORDER BY "position", in_tx_order LIMIT 200 OFFSET 1; ``` ``` Limit (cost=293.34..293.36 rows=8 width=361) (actual time=4.686..4.689 rows=0 loops=1) Output: events2.created_at, events2.event_type, events2.sequence, events2."position", events2.payload, events2.creator, events2.owner, events2.instance_id, events2.aggregate_type, events2.aggregate_id, events2.revision, events2.in_tx_order InitPlan 1 -> Aggregate (cost=2.74..2.76 rows=1 width=32) (actual time=1.717..1.719 rows=1 loops=1) Output: COALESCE(EXTRACT(epoch FROM min(s.xact_start)), EXTRACT(epoch FROM now())) -> Nested Loop (cost=0.00..2.74 rows=1 width=8) (actual time=1.658..1.659 rows=0 loops=1) Output: s.xact_start Join Filter: (d.oid = s.datid) -> Seq Scan on pg_catalog.pg_database d (cost=0.00..1.07 rows=1 width=4) (actual time=0.026..0.028 rows=1 loops=1) Output: d.oid, d.datname, d.datdba, d.encoding, d.datlocprovider, d.datistemplate, d.datallowconn, d.dathasloginevt, d.datconnlimit, d.datfrozenxid, d.datminmxid, d.dattablespace, d.datcollate, d.datctype, d.datlocale, d.daticurules, d.datcollversion, d.datacl Filter: (d.datname = current_database()) Rows Removed by Filter: 4 -> Function Scan on pg_catalog.pg_stat_get_activity s (cost=0.00..1.63 rows=3 width=16) (actual time=1.628..1.628 rows=0 loops=1) Output: s.datid, s.pid, s.usesysid, s.application_name, s.state, s.query, s.wait_event_type, s.wait_event, s.xact_start, s.query_start, s.backend_start, s.state_change, s.client_addr, s.client_hostname, s.client_port, s.backend_xid, s.backend_xmin, s.backend_type, s.ssl, s.sslversion, s.sslcipher, s.sslbits, s.ssl_client_dn, s.ssl_client_serial, s.ssl_issuer_dn, s.gss_auth, s.gss_princ, s.gss_enc, s.gss_delegation, s.leader_pid, s.query_id Function Call: pg_stat_get_activity(NULL::integer) Filter: ((s.state <> 'idle'::text) AND (s.application_name = ANY ('{zitadel_es_pusher_,zitadel_es_pusher,zitadel_es_pusher_<INSTANCE_ID>}'::text[]))) Rows Removed by Filter: 42 -> Sort (cost=290.58..290.60 rows=9 width=361) (actual time=4.685..4.685 rows=0 loops=1) Output: events2.created_at, events2.event_type, events2.sequence, events2."position", events2.payload, events2.creator, events2.owner, events2.instance_id, events2.aggregate_type, events2.aggregate_id, events2.revision, events2.in_tx_order Sort Key: events2."position", events2.in_tx_order Sort Method: quicksort Memory: 25kB -> Index Scan using es_projection on eventstore.events2 (cost=0.70..290.43 rows=9 width=361) (actual time=4.616..4.617 rows=0 loops=1) Output: events2.created_at, events2.event_type, events2.sequence, events2."position", events2.payload, events2.creator, events2.owner, events2.instance_id, events2.aggregate_type, events2.aggregate_id, events2.revision, events2.in_tx_order Index Cond: ((events2.instance_id = '<INSTANCE_ID>'::text) AND (events2.aggregate_type = ANY ('{project,instance,org}'::text[])) AND (events2.event_type = ANY ('{project.application.added,project.application.changed,project.application.deactivated,project.application.reactivated,project.application.removed,project.removed,project.application.config.api.added,project.application.config.api.changed,project.application.config.api.secret.changed,project.application.config.api.secret.updated,project.application.config.oidc.added,project.application.config.oidc.changed,project.application.config.oidc.secret.changed,project.application.config.oidc.secret.updated,project.application.config.saml.added,project.application.config.saml.changed,org.removed,instance.removed}'::text[])) AND (events2."position" > <POSITION>) AND (events2."position" < (InitPlan 1).col1)) Query Identifier: -8254550537132386499 Planning Time: 2.864 ms Execution Time: 5.414 ms ```
1162 lines
37 KiB
Go
1162 lines
37 KiB
Go
package sql
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"database/sql/driver"
|
|
"reflect"
|
|
"regexp"
|
|
"strconv"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/DATA-DOG/go-sqlmock"
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
"github.com/zitadel/zitadel/internal/database"
|
|
"github.com/zitadel/zitadel/internal/database/cockroach"
|
|
db_mock "github.com/zitadel/zitadel/internal/database/mock"
|
|
"github.com/zitadel/zitadel/internal/eventstore"
|
|
"github.com/zitadel/zitadel/internal/eventstore/repository"
|
|
"github.com/zitadel/zitadel/internal/zerrors"
|
|
)
|
|
|
|
func Test_getCondition(t *testing.T) {
|
|
type args struct {
|
|
filter *repository.Filter
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
args args
|
|
want string
|
|
}{
|
|
{
|
|
name: "equals",
|
|
args: args{filter: repository.NewFilter(repository.FieldAggregateID, "", repository.OperationEquals)},
|
|
want: "aggregate_id = ?",
|
|
},
|
|
{
|
|
name: "greater",
|
|
args: args{filter: repository.NewFilter(repository.FieldSequence, 0, repository.OperationGreater)},
|
|
want: `"sequence" > ?`,
|
|
},
|
|
{
|
|
name: "less",
|
|
args: args{filter: repository.NewFilter(repository.FieldSequence, 5000, repository.OperationLess)},
|
|
want: `"sequence" < ?`,
|
|
},
|
|
{
|
|
name: "in list",
|
|
args: args{filter: repository.NewFilter(repository.FieldAggregateType, []eventstore.AggregateType{"movies", "actors"}, repository.OperationIn)},
|
|
want: "aggregate_type = ANY(?)",
|
|
},
|
|
{
|
|
name: "invalid operation",
|
|
args: args{filter: repository.NewFilter(repository.FieldAggregateType, []eventstore.AggregateType{"movies", "actors"}, repository.Operation(-1))},
|
|
want: "",
|
|
},
|
|
{
|
|
name: "invalid field",
|
|
args: args{filter: repository.NewFilter(repository.Field(-1), []eventstore.AggregateType{"movies", "actors"}, repository.OperationEquals)},
|
|
want: "",
|
|
},
|
|
{
|
|
name: "invalid field and operation",
|
|
args: args{filter: repository.NewFilter(repository.Field(-1), []eventstore.AggregateType{"movies", "actors"}, repository.Operation(-1))},
|
|
want: "",
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
db := &CRDB{}
|
|
if got := getCondition(db, tt.args.filter, false); got != tt.want {
|
|
t.Errorf("getCondition() = %v, want %v", got, tt.want)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func Test_prepareColumns(t *testing.T) {
|
|
var reducedEvents []eventstore.Event
|
|
|
|
type fields struct {
|
|
dbRow []interface{}
|
|
}
|
|
type args struct {
|
|
columns eventstore.Columns
|
|
dest interface{}
|
|
dbErr error
|
|
useV1 bool
|
|
}
|
|
type res struct {
|
|
query string
|
|
expected interface{}
|
|
dbErr func(error) bool
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
args args
|
|
res res
|
|
fields fields
|
|
}{
|
|
{
|
|
name: "invalid columns",
|
|
args: args{columns: eventstore.Columns(-1)},
|
|
res: res{
|
|
query: "",
|
|
dbErr: func(err error) bool { return err == nil },
|
|
},
|
|
},
|
|
{
|
|
name: "max column",
|
|
args: args{
|
|
columns: eventstore.ColumnsMaxSequence,
|
|
dest: new(sql.NullFloat64),
|
|
useV1: true,
|
|
},
|
|
res: res{
|
|
query: `SELECT event_sequence FROM eventstore.events`,
|
|
expected: sql.NullFloat64{Float64: 43, Valid: true},
|
|
},
|
|
fields: fields{
|
|
dbRow: []interface{}{sql.NullFloat64{Float64: 43, Valid: true}},
|
|
},
|
|
},
|
|
{
|
|
name: "max column v2",
|
|
args: args{
|
|
columns: eventstore.ColumnsMaxSequence,
|
|
dest: new(sql.NullFloat64),
|
|
},
|
|
res: res{
|
|
query: `SELECT "position" FROM eventstore.events2`,
|
|
expected: sql.NullFloat64{Float64: 43, Valid: true},
|
|
},
|
|
fields: fields{
|
|
dbRow: []interface{}{sql.NullFloat64{Float64: 43, Valid: true}},
|
|
},
|
|
},
|
|
{
|
|
name: "max sequence wrong dest type",
|
|
args: args{
|
|
columns: eventstore.ColumnsMaxSequence,
|
|
dest: new(uint64),
|
|
},
|
|
res: res{
|
|
query: `SELECT "position" FROM eventstore.events2`,
|
|
dbErr: zerrors.IsErrorInvalidArgument,
|
|
},
|
|
},
|
|
{
|
|
name: "events",
|
|
args: args{
|
|
columns: eventstore.ColumnsEvent,
|
|
dest: eventstore.Reducer(func(event eventstore.Event) error {
|
|
reducedEvents = append(reducedEvents, event)
|
|
return nil
|
|
}),
|
|
useV1: true,
|
|
},
|
|
res: res{
|
|
query: `SELECT creation_date, event_type, event_sequence, event_data, editor_user, resource_owner, instance_id, aggregate_type, aggregate_id, aggregate_version FROM eventstore.events`,
|
|
expected: []eventstore.Event{
|
|
&repository.Event{AggregateID: "hodor", AggregateType: "user", Seq: 5, Data: nil},
|
|
},
|
|
},
|
|
fields: fields{
|
|
dbRow: []interface{}{time.Time{}, eventstore.EventType(""), uint64(5), sql.RawBytes(nil), "", sql.NullString{}, "", eventstore.AggregateType("user"), "hodor", eventstore.Version("")},
|
|
},
|
|
},
|
|
{
|
|
name: "events v2",
|
|
args: args{
|
|
columns: eventstore.ColumnsEvent,
|
|
dest: eventstore.Reducer(func(event eventstore.Event) error {
|
|
reducedEvents = append(reducedEvents, event)
|
|
return nil
|
|
}),
|
|
},
|
|
res: res{
|
|
query: `SELECT created_at, event_type, "sequence", "position", payload, creator, "owner", instance_id, aggregate_type, aggregate_id, revision FROM eventstore.events2`,
|
|
expected: []eventstore.Event{
|
|
&repository.Event{AggregateID: "hodor", AggregateType: "user", Seq: 5, Pos: 42, Data: nil, Version: "v1"},
|
|
},
|
|
},
|
|
fields: fields{
|
|
dbRow: []interface{}{time.Time{}, eventstore.EventType(""), uint64(5), sql.NullFloat64{Float64: 42, Valid: true}, sql.RawBytes(nil), "", sql.NullString{}, "", eventstore.AggregateType("user"), "hodor", uint8(1)},
|
|
},
|
|
},
|
|
{
|
|
name: "event null position",
|
|
args: args{
|
|
columns: eventstore.ColumnsEvent,
|
|
dest: eventstore.Reducer(func(event eventstore.Event) error {
|
|
reducedEvents = append(reducedEvents, event)
|
|
return nil
|
|
}),
|
|
},
|
|
res: res{
|
|
query: `SELECT created_at, event_type, "sequence", "position", payload, creator, "owner", instance_id, aggregate_type, aggregate_id, revision FROM eventstore.events2`,
|
|
expected: []eventstore.Event{
|
|
&repository.Event{AggregateID: "hodor", AggregateType: "user", Seq: 5, Pos: 0, Data: nil, Version: "v1"},
|
|
},
|
|
},
|
|
fields: fields{
|
|
dbRow: []interface{}{time.Time{}, eventstore.EventType(""), uint64(5), sql.NullFloat64{Float64: 0, Valid: false}, sql.RawBytes(nil), "", sql.NullString{}, "", eventstore.AggregateType("user"), "hodor", uint8(1)},
|
|
},
|
|
},
|
|
{
|
|
name: "events wrong dest type",
|
|
args: args{
|
|
columns: eventstore.ColumnsEvent,
|
|
dest: []*repository.Event{},
|
|
useV1: true,
|
|
},
|
|
res: res{
|
|
query: `SELECT creation_date, event_type, event_sequence, event_data, editor_user, resource_owner, instance_id, aggregate_type, aggregate_id, aggregate_version FROM eventstore.events`,
|
|
dbErr: zerrors.IsErrorInvalidArgument,
|
|
},
|
|
},
|
|
{
|
|
name: "event query error",
|
|
args: args{
|
|
columns: eventstore.ColumnsEvent,
|
|
dest: eventstore.Reducer(func(event eventstore.Event) error {
|
|
reducedEvents = append(reducedEvents, event)
|
|
return nil
|
|
}),
|
|
dbErr: sql.ErrConnDone,
|
|
useV1: true,
|
|
},
|
|
res: res{
|
|
query: `SELECT creation_date, event_type, event_sequence, event_data, editor_user, resource_owner, instance_id, aggregate_type, aggregate_id, aggregate_version FROM eventstore.events`,
|
|
dbErr: zerrors.IsInternal,
|
|
},
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
crdb := &CRDB{}
|
|
query, rowScanner := prepareColumns(crdb, tt.args.columns, tt.args.useV1)
|
|
if query != tt.res.query {
|
|
t.Errorf("prepareColumns() got = %s, want %s", query, tt.res.query)
|
|
}
|
|
if tt.res.query == "" && rowScanner != nil {
|
|
t.Errorf("row scanner should be nil")
|
|
}
|
|
if rowScanner == nil {
|
|
return
|
|
}
|
|
err := rowScanner(prepareTestScan(tt.args.dbErr, tt.fields.dbRow), tt.args.dest)
|
|
if err != nil && tt.res.dbErr == nil || err != nil && !tt.res.dbErr(err) || err == nil && tt.res.dbErr != nil {
|
|
t.Errorf("wrong error type in rowScanner got: %v", err)
|
|
return
|
|
}
|
|
if tt.res.dbErr != nil && tt.res.dbErr(err) {
|
|
return
|
|
}
|
|
if equalizer, ok := tt.res.expected.(interface{ Equal(time.Time) bool }); ok {
|
|
equalizer.Equal(tt.args.dest.(*sql.NullTime).Time)
|
|
return
|
|
}
|
|
if _, ok := tt.args.dest.(eventstore.Reducer); ok {
|
|
assert.Equal(t, tt.res.expected, reducedEvents)
|
|
reducedEvents = nil
|
|
return
|
|
}
|
|
|
|
got := reflect.Indirect(reflect.ValueOf(tt.args.dest)).Interface()
|
|
if !reflect.DeepEqual(got, tt.res.expected) {
|
|
t.Errorf("unexpected result from rowScanner \nwant: %+v \ngot: %+v", tt.res.expected, got)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func prepareTestScan(err error, res []interface{}) scan {
|
|
return func(dests ...interface{}) error {
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if len(dests) != len(res) {
|
|
return zerrors.ThrowInvalidArgumentf(nil, "SQL-NML1q", "expected len %d got %d", len(res), len(dests))
|
|
}
|
|
for i, r := range res {
|
|
_, ok := dests[i].(*eventstore.Version)
|
|
if ok {
|
|
val, ok := r.(uint8)
|
|
if ok {
|
|
r = eventstore.Version("" + strconv.Itoa(int(val)))
|
|
}
|
|
}
|
|
reflect.ValueOf(dests[i]).Elem().Set(reflect.ValueOf(r))
|
|
}
|
|
|
|
return nil
|
|
}
|
|
}
|
|
|
|
func Test_prepareCondition(t *testing.T) {
|
|
type args struct {
|
|
query *repository.SearchQuery
|
|
useV1 bool
|
|
}
|
|
type res struct {
|
|
clause string
|
|
values []interface{}
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
args args
|
|
res res
|
|
}{
|
|
{
|
|
name: "nil filters",
|
|
args: args{
|
|
query: &repository.SearchQuery{},
|
|
useV1: true,
|
|
},
|
|
res: res{
|
|
clause: "",
|
|
values: nil,
|
|
},
|
|
},
|
|
{
|
|
name: "nil filters v2",
|
|
args: args{
|
|
query: &repository.SearchQuery{},
|
|
},
|
|
res: res{
|
|
clause: "",
|
|
values: nil,
|
|
},
|
|
},
|
|
{
|
|
name: "empty filters",
|
|
args: args{
|
|
query: &repository.SearchQuery{
|
|
SubQueries: [][]*repository.Filter{},
|
|
},
|
|
useV1: true,
|
|
},
|
|
res: res{
|
|
clause: "",
|
|
values: nil,
|
|
},
|
|
},
|
|
{
|
|
name: "empty filters v2",
|
|
args: args{
|
|
query: &repository.SearchQuery{
|
|
SubQueries: [][]*repository.Filter{},
|
|
},
|
|
},
|
|
res: res{
|
|
clause: "",
|
|
values: nil,
|
|
},
|
|
},
|
|
{
|
|
name: "invalid condition",
|
|
args: args{
|
|
query: &repository.SearchQuery{
|
|
SubQueries: [][]*repository.Filter{
|
|
{
|
|
repository.NewFilter(repository.FieldAggregateID, "wrong", repository.Operation(-1)),
|
|
},
|
|
},
|
|
},
|
|
useV1: true,
|
|
},
|
|
res: res{
|
|
clause: "",
|
|
values: nil,
|
|
},
|
|
},
|
|
{
|
|
name: "invalid condition v2",
|
|
args: args{
|
|
query: &repository.SearchQuery{
|
|
SubQueries: [][]*repository.Filter{
|
|
{
|
|
repository.NewFilter(repository.FieldAggregateID, "wrong", repository.Operation(-1)),
|
|
},
|
|
},
|
|
},
|
|
},
|
|
res: res{
|
|
clause: "",
|
|
values: nil,
|
|
},
|
|
},
|
|
{
|
|
name: "array as condition value",
|
|
args: args{
|
|
query: &repository.SearchQuery{
|
|
AwaitOpenTransactions: true,
|
|
SubQueries: [][]*repository.Filter{
|
|
{
|
|
repository.NewFilter(repository.FieldAggregateType, []eventstore.AggregateType{"user", "org"}, repository.OperationIn),
|
|
},
|
|
},
|
|
},
|
|
useV1: true,
|
|
},
|
|
res: res{
|
|
clause: " WHERE aggregate_type = ANY(?) AND creation_date::TIMESTAMP < (SELECT COALESCE(MIN(start), NOW())::TIMESTAMP FROM crdb_internal.cluster_transactions where application_name = ANY(?))",
|
|
values: []interface{}{[]eventstore.AggregateType{"user", "org"}, database.TextArray[string]{}},
|
|
},
|
|
},
|
|
{
|
|
name: "array as condition value v2",
|
|
args: args{
|
|
query: &repository.SearchQuery{
|
|
AwaitOpenTransactions: true,
|
|
SubQueries: [][]*repository.Filter{
|
|
{
|
|
repository.NewFilter(repository.FieldAggregateType, []eventstore.AggregateType{"user", "org"}, repository.OperationIn),
|
|
},
|
|
},
|
|
},
|
|
},
|
|
res: res{
|
|
clause: ` WHERE aggregate_type = ANY(?) AND hlc_to_timestamp("position") < (SELECT COALESCE(MIN(start), NOW())::TIMESTAMP FROM crdb_internal.cluster_transactions where application_name = ANY(?))`,
|
|
values: []interface{}{[]eventstore.AggregateType{"user", "org"}, database.TextArray[string]{}},
|
|
},
|
|
},
|
|
{
|
|
name: "multiple filters",
|
|
args: args{
|
|
query: &repository.SearchQuery{
|
|
AwaitOpenTransactions: true,
|
|
SubQueries: [][]*repository.Filter{
|
|
{
|
|
repository.NewFilter(repository.FieldAggregateType, []eventstore.AggregateType{"user", "org"}, repository.OperationIn),
|
|
repository.NewFilter(repository.FieldAggregateID, "1234", repository.OperationEquals),
|
|
repository.NewFilter(repository.FieldEventType, []eventstore.EventType{"user.created", "org.created"}, repository.OperationIn),
|
|
},
|
|
},
|
|
},
|
|
useV1: true,
|
|
},
|
|
res: res{
|
|
clause: " WHERE aggregate_type = ANY(?) AND aggregate_id = ? AND event_type = ANY(?) AND creation_date::TIMESTAMP < (SELECT COALESCE(MIN(start), NOW())::TIMESTAMP FROM crdb_internal.cluster_transactions where application_name = ANY(?))",
|
|
values: []interface{}{[]eventstore.AggregateType{"user", "org"}, "1234", []eventstore.EventType{"user.created", "org.created"}, database.TextArray[string]{}},
|
|
},
|
|
},
|
|
{
|
|
name: "multiple filters v2",
|
|
args: args{
|
|
query: &repository.SearchQuery{
|
|
AwaitOpenTransactions: true,
|
|
SubQueries: [][]*repository.Filter{
|
|
{
|
|
repository.NewFilter(repository.FieldAggregateType, []eventstore.AggregateType{"user", "org"}, repository.OperationIn),
|
|
repository.NewFilter(repository.FieldAggregateID, "1234", repository.OperationEquals),
|
|
repository.NewFilter(repository.FieldEventType, []eventstore.EventType{"user.created", "org.created"}, repository.OperationIn),
|
|
},
|
|
},
|
|
},
|
|
},
|
|
res: res{
|
|
clause: ` WHERE aggregate_type = ANY(?) AND aggregate_id = ? AND event_type = ANY(?) AND hlc_to_timestamp("position") < (SELECT COALESCE(MIN(start), NOW())::TIMESTAMP FROM crdb_internal.cluster_transactions where application_name = ANY(?))`,
|
|
values: []interface{}{[]eventstore.AggregateType{"user", "org"}, "1234", []eventstore.EventType{"user.created", "org.created"}, database.TextArray[string]{}},
|
|
},
|
|
},
|
|
}
|
|
crdb := NewCRDB(&database.DB{Database: new(cockroach.Config)})
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
gotClause, gotValues := prepareConditions(crdb, tt.args.query, tt.args.useV1)
|
|
if gotClause != tt.res.clause {
|
|
t.Errorf("prepareCondition() gotClause = %v, want %v", gotClause, tt.res.clause)
|
|
}
|
|
if len(gotValues) != len(tt.res.values) {
|
|
t.Errorf("wrong length of gotten values got = %d, want %d", len(gotValues), len(tt.res.values))
|
|
return
|
|
}
|
|
for i, value := range gotValues {
|
|
if !reflect.DeepEqual(value, tt.res.values[i]) {
|
|
t.Errorf("prepareCondition() gotValues = %v, want %v", gotValues, tt.res.values)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func Test_query_events_with_crdb(t *testing.T) {
|
|
type args struct {
|
|
searchQuery *eventstore.SearchQueryBuilder
|
|
}
|
|
type fields struct {
|
|
existingEvents []eventstore.Command
|
|
client *sql.DB
|
|
}
|
|
type res struct {
|
|
eventCount int
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
fields fields
|
|
args args
|
|
res res
|
|
wantErr bool
|
|
}{
|
|
{
|
|
name: "aggregate type filter no events",
|
|
args: args{
|
|
searchQuery: eventstore.NewSearchQueryBuilder(eventstore.ColumnsEvent).
|
|
AddQuery().
|
|
AggregateTypes("not found").
|
|
Builder(),
|
|
},
|
|
fields: fields{
|
|
client: testCRDBClient,
|
|
existingEvents: []eventstore.Command{
|
|
generateEvent(t, "300"),
|
|
generateEvent(t, "300"),
|
|
generateEvent(t, "300"),
|
|
},
|
|
},
|
|
res: res{
|
|
eventCount: 0,
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "aggregate type filter events found",
|
|
args: args{
|
|
searchQuery: eventstore.NewSearchQueryBuilder(eventstore.ColumnsEvent).
|
|
AddQuery().
|
|
AggregateTypes(eventstore.AggregateType(t.Name())).
|
|
Builder(),
|
|
},
|
|
fields: fields{
|
|
client: testCRDBClient,
|
|
existingEvents: []eventstore.Command{
|
|
generateEvent(t, "301"),
|
|
generateEvent(t, "302"),
|
|
generateEvent(t, "302"),
|
|
generateEvent(t, "303", func(e *repository.Event) { e.AggregateType = "not in list" }),
|
|
},
|
|
},
|
|
res: res{
|
|
eventCount: 3,
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "aggregate type and id filter events found",
|
|
args: args{
|
|
searchQuery: eventstore.NewSearchQueryBuilder(eventstore.ColumnsEvent).
|
|
AddQuery().
|
|
AggregateTypes(eventstore.AggregateType(t.Name())).
|
|
AggregateIDs("303").
|
|
Builder(),
|
|
},
|
|
fields: fields{
|
|
client: testCRDBClient,
|
|
existingEvents: []eventstore.Command{
|
|
generateEvent(t, "303"),
|
|
generateEvent(t, "303"),
|
|
generateEvent(t, "303"),
|
|
generateEvent(t, "304", func(e *repository.Event) { e.AggregateType = "not in list" }),
|
|
generateEvent(t, "305"),
|
|
},
|
|
},
|
|
res: res{
|
|
eventCount: 3,
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "resource owner filter events found",
|
|
args: args{
|
|
searchQuery: eventstore.NewSearchQueryBuilder(eventstore.ColumnsEvent).
|
|
ResourceOwner("caos"),
|
|
},
|
|
fields: fields{
|
|
client: testCRDBClient,
|
|
existingEvents: []eventstore.Command{
|
|
generateEvent(t, "306", func(e *repository.Event) { e.ResourceOwner = sql.NullString{String: "caos", Valid: true} }),
|
|
generateEvent(t, "307", func(e *repository.Event) { e.ResourceOwner = sql.NullString{String: "caos", Valid: true} }),
|
|
generateEvent(t, "308", func(e *repository.Event) { e.ResourceOwner = sql.NullString{String: "caos", Valid: true} }),
|
|
generateEvent(t, "309", func(e *repository.Event) { e.ResourceOwner = sql.NullString{String: "orgID", Valid: true} }),
|
|
generateEvent(t, "309", func(e *repository.Event) { e.ResourceOwner = sql.NullString{String: "orgID", Valid: true} }),
|
|
},
|
|
},
|
|
res: res{
|
|
eventCount: 3,
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "event type filter events found",
|
|
args: args{
|
|
searchQuery: eventstore.NewSearchQueryBuilder(eventstore.ColumnsEvent).
|
|
AddQuery().
|
|
EventTypes("user.created", "user.updated").
|
|
Builder(),
|
|
},
|
|
fields: fields{
|
|
client: testCRDBClient,
|
|
existingEvents: []eventstore.Command{
|
|
generateEvent(t, "311", func(e *repository.Event) { e.Typ = "user.created" }),
|
|
generateEvent(t, "311", func(e *repository.Event) { e.Typ = "user.updated" }),
|
|
generateEvent(t, "311", func(e *repository.Event) { e.Typ = "user.deactivated" }),
|
|
generateEvent(t, "311", func(e *repository.Event) { e.Typ = "user.locked" }),
|
|
generateEvent(t, "312", func(e *repository.Event) { e.Typ = "user.created" }),
|
|
generateEvent(t, "312", func(e *repository.Event) { e.Typ = "user.updated" }),
|
|
generateEvent(t, "312", func(e *repository.Event) { e.Typ = "user.deactivated" }),
|
|
generateEvent(t, "312", func(e *repository.Event) { e.Typ = "user.reactivated" }),
|
|
generateEvent(t, "313", func(e *repository.Event) { e.Typ = "user.locked" }),
|
|
},
|
|
},
|
|
res: res{
|
|
eventCount: 7,
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "fail because no filter",
|
|
args: args{
|
|
searchQuery: eventstore.NewSearchQueryBuilder(eventstore.Columns(-1)),
|
|
},
|
|
fields: fields{
|
|
client: testCRDBClient,
|
|
existingEvents: []eventstore.Command{},
|
|
},
|
|
res: res{
|
|
eventCount: 0,
|
|
},
|
|
wantErr: true,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
db := &CRDB{
|
|
DB: &database.DB{
|
|
DB: tt.fields.client,
|
|
Database: new(testDB),
|
|
},
|
|
}
|
|
|
|
// setup initial data for query
|
|
if _, err := db.Push(context.Background(), tt.fields.existingEvents...); err != nil {
|
|
t.Errorf("error in setup = %v", err)
|
|
return
|
|
}
|
|
|
|
events := []eventstore.Event{}
|
|
if err := query(context.Background(), db, tt.args.searchQuery, eventstore.Reducer(func(event eventstore.Event) error {
|
|
events = append(events, event)
|
|
return nil
|
|
}), true); (err != nil) != tt.wantErr {
|
|
t.Errorf("CRDB.query() error = %v, wantErr %v", err, tt.wantErr)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
/* Cockroach test DB doesn't seem to lock
|
|
func Test_query_events_with_crdb_locking(t *testing.T) {
|
|
type args struct {
|
|
searchQuery *eventstore.SearchQueryBuilder
|
|
}
|
|
type fields struct {
|
|
existingEvents []eventstore.Command
|
|
client *sql.DB
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
fields fields
|
|
args args
|
|
lockOption eventstore.LockOption
|
|
wantErr bool
|
|
}{
|
|
{
|
|
name: "skip locked",
|
|
fields: fields{
|
|
client: testCRDBClient,
|
|
existingEvents: []eventstore.Command{
|
|
generateEvent(t, "306", func(e *repository.Event) { e.ResourceOwner = sql.NullString{String: "caos", Valid: true} }),
|
|
generateEvent(t, "307", func(e *repository.Event) { e.ResourceOwner = sql.NullString{String: "caos", Valid: true} }),
|
|
generateEvent(t, "308", func(e *repository.Event) { e.ResourceOwner = sql.NullString{String: "caos", Valid: true} }),
|
|
},
|
|
},
|
|
args: args{
|
|
searchQuery: eventstore.NewSearchQueryBuilder(eventstore.ColumnsEvent).
|
|
ResourceOwner("caos"),
|
|
},
|
|
lockOption: eventstore.LockOptionNoWait,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
db := &CRDB{
|
|
DB: &database.DB{
|
|
DB: tt.fields.client,
|
|
Database: new(testDB),
|
|
},
|
|
}
|
|
// setup initial data for query
|
|
if _, err := db.Push(context.Background(), tt.fields.existingEvents...); err != nil {
|
|
t.Errorf("error in setup = %v", err)
|
|
return
|
|
}
|
|
// first TX should lock and return all events
|
|
tx1, err := db.DB.Begin()
|
|
require.NoError(t, err)
|
|
defer func() {
|
|
require.NoError(t, tx1.Rollback())
|
|
}()
|
|
searchQuery1 := tt.args.searchQuery.LockRowsDuringTx(tx1, tt.lockOption)
|
|
gotEvents1 := []eventstore.Event{}
|
|
err = query(context.Background(), db, searchQuery1, eventstore.Reducer(func(event eventstore.Event) error {
|
|
gotEvents1 = append(gotEvents1, event)
|
|
return nil
|
|
}), true)
|
|
require.NoError(t, err)
|
|
assert.Len(t, gotEvents1, len(tt.fields.existingEvents))
|
|
|
|
// second TX should not return the events, and might return an error
|
|
tx2, err := db.DB.Begin()
|
|
require.NoError(t, err)
|
|
defer func() {
|
|
require.NoError(t, tx2.Rollback())
|
|
}()
|
|
searchQuery2 := tt.args.searchQuery.LockRowsDuringTx(tx1, tt.lockOption)
|
|
gotEvents2 := []eventstore.Event{}
|
|
err = query(context.Background(), db, searchQuery2, eventstore.Reducer(func(event eventstore.Event) error {
|
|
gotEvents2 = append(gotEvents2, event)
|
|
return nil
|
|
}), true)
|
|
if tt.wantErr {
|
|
require.Error(t, err)
|
|
}
|
|
require.NoError(t, err)
|
|
assert.Len(t, gotEvents2, 0)
|
|
})
|
|
}
|
|
}
|
|
*/
|
|
|
|
func Test_query_events_mocked(t *testing.T) {
|
|
type args struct {
|
|
query *eventstore.SearchQueryBuilder
|
|
dest interface{}
|
|
useV1 bool
|
|
}
|
|
type res struct {
|
|
wantErr bool
|
|
}
|
|
type fields struct {
|
|
mock *dbMock
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
args args
|
|
fields fields
|
|
res res
|
|
}{
|
|
{
|
|
name: "with order by desc",
|
|
args: args{
|
|
dest: &[]*repository.Event{},
|
|
query: eventstore.NewSearchQueryBuilder(eventstore.ColumnsEvent).
|
|
OrderDesc().
|
|
AwaitOpenTransactions().
|
|
AddQuery().
|
|
AggregateTypes("user").
|
|
Builder(),
|
|
useV1: true,
|
|
},
|
|
fields: fields{
|
|
mock: newMockClient(t).expectQuery(t,
|
|
`SELECT creation_date, event_type, event_sequence, event_data, editor_user, resource_owner, instance_id, aggregate_type, aggregate_id, aggregate_version FROM eventstore.events WHERE aggregate_type = \$1 AND creation_date::TIMESTAMP < \(SELECT COALESCE\(MIN\(start\), NOW\(\)\)::TIMESTAMP FROM crdb_internal\.cluster_transactions where application_name = ANY\(\$2\)\) ORDER BY event_sequence DESC`,
|
|
[]driver.Value{eventstore.AggregateType("user"), database.TextArray[string]{}},
|
|
),
|
|
},
|
|
res: res{
|
|
wantErr: false,
|
|
},
|
|
},
|
|
{
|
|
name: "with limit",
|
|
args: args{
|
|
dest: &[]*repository.Event{},
|
|
query: eventstore.NewSearchQueryBuilder(eventstore.ColumnsEvent).
|
|
OrderAsc().
|
|
AwaitOpenTransactions().
|
|
Limit(5).
|
|
AddQuery().
|
|
AggregateTypes("user").
|
|
Builder(),
|
|
useV1: true,
|
|
},
|
|
fields: fields{
|
|
mock: newMockClient(t).expectQuery(t,
|
|
`SELECT creation_date, event_type, event_sequence, event_data, editor_user, resource_owner, instance_id, aggregate_type, aggregate_id, aggregate_version FROM eventstore.events WHERE aggregate_type = \$1 AND creation_date::TIMESTAMP < \(SELECT COALESCE\(MIN\(start\), NOW\(\)\)::TIMESTAMP FROM crdb_internal\.cluster_transactions where application_name = ANY\(\$2\)\) ORDER BY event_sequence LIMIT \$3`,
|
|
[]driver.Value{eventstore.AggregateType("user"), database.TextArray[string]{}, uint64(5)},
|
|
),
|
|
},
|
|
res: res{
|
|
wantErr: false,
|
|
},
|
|
},
|
|
{
|
|
name: "with limit and order by desc",
|
|
args: args{
|
|
dest: &[]*repository.Event{},
|
|
query: eventstore.NewSearchQueryBuilder(eventstore.ColumnsEvent).
|
|
OrderDesc().
|
|
AwaitOpenTransactions().
|
|
Limit(5).
|
|
AddQuery().
|
|
AggregateTypes("user").
|
|
Builder(),
|
|
useV1: true,
|
|
},
|
|
fields: fields{
|
|
mock: newMockClient(t).expectQuery(t,
|
|
`SELECT creation_date, event_type, event_sequence, event_data, editor_user, resource_owner, instance_id, aggregate_type, aggregate_id, aggregate_version FROM eventstore.events WHERE aggregate_type = \$1 AND creation_date::TIMESTAMP < \(SELECT COALESCE\(MIN\(start\), NOW\(\)\)::TIMESTAMP FROM crdb_internal\.cluster_transactions where application_name = ANY\(\$2\)\) ORDER BY event_sequence DESC LIMIT \$3`,
|
|
[]driver.Value{eventstore.AggregateType("user"), database.TextArray[string]{}, uint64(5)},
|
|
),
|
|
},
|
|
res: res{
|
|
wantErr: false,
|
|
},
|
|
},
|
|
{
|
|
name: "with limit and order by desc as of system time",
|
|
args: args{
|
|
dest: &[]*repository.Event{},
|
|
query: eventstore.NewSearchQueryBuilder(eventstore.ColumnsEvent).
|
|
OrderDesc().
|
|
AwaitOpenTransactions().
|
|
Limit(5).
|
|
AllowTimeTravel().
|
|
AddQuery().
|
|
AggregateTypes("user").
|
|
Builder(),
|
|
useV1: true,
|
|
},
|
|
fields: fields{
|
|
mock: newMockClient(t).expectQuery(t,
|
|
`SELECT creation_date, event_type, event_sequence, event_data, editor_user, resource_owner, instance_id, aggregate_type, aggregate_id, aggregate_version FROM eventstore.events AS OF SYSTEM TIME '-1 ms' WHERE aggregate_type = \$1 AND creation_date::TIMESTAMP < \(SELECT COALESCE\(MIN\(start\), NOW\(\)\)::TIMESTAMP FROM crdb_internal\.cluster_transactions where application_name = ANY\(\$2\)\) ORDER BY event_sequence DESC LIMIT \$3`,
|
|
[]driver.Value{eventstore.AggregateType("user"), database.TextArray[string]{}, uint64(5)},
|
|
),
|
|
},
|
|
res: res{
|
|
wantErr: false,
|
|
},
|
|
},
|
|
{
|
|
name: "lock, wait",
|
|
args: args{
|
|
dest: &[]*repository.Event{},
|
|
query: eventstore.NewSearchQueryBuilder(eventstore.ColumnsEvent).
|
|
OrderDesc().
|
|
Limit(5).
|
|
AddQuery().
|
|
AggregateTypes("user").
|
|
Builder().LockRowsDuringTx(nil, eventstore.LockOptionWait),
|
|
useV1: true,
|
|
},
|
|
fields: fields{
|
|
mock: newMockClient(t).expectQuery(t,
|
|
`SELECT creation_date, event_type, event_sequence, event_data, editor_user, resource_owner, instance_id, aggregate_type, aggregate_id, aggregate_version FROM eventstore.events WHERE aggregate_type = \$1 ORDER BY event_sequence DESC LIMIT \$2 FOR UPDATE`,
|
|
[]driver.Value{eventstore.AggregateType("user"), uint64(5)},
|
|
),
|
|
},
|
|
res: res{
|
|
wantErr: false,
|
|
},
|
|
},
|
|
{
|
|
name: "lock, no wait",
|
|
args: args{
|
|
dest: &[]*repository.Event{},
|
|
query: eventstore.NewSearchQueryBuilder(eventstore.ColumnsEvent).
|
|
OrderDesc().
|
|
Limit(5).
|
|
AddQuery().
|
|
AggregateTypes("user").
|
|
Builder().LockRowsDuringTx(nil, eventstore.LockOptionNoWait),
|
|
useV1: true,
|
|
},
|
|
fields: fields{
|
|
mock: newMockClient(t).expectQuery(t,
|
|
`SELECT creation_date, event_type, event_sequence, event_data, editor_user, resource_owner, instance_id, aggregate_type, aggregate_id, aggregate_version FROM eventstore.events WHERE aggregate_type = \$1 ORDER BY event_sequence DESC LIMIT \$2 FOR UPDATE NOWAIT`,
|
|
[]driver.Value{eventstore.AggregateType("user"), uint64(5)},
|
|
),
|
|
},
|
|
res: res{
|
|
wantErr: false,
|
|
},
|
|
},
|
|
{
|
|
name: "lock, skip locked",
|
|
args: args{
|
|
dest: &[]*repository.Event{},
|
|
query: eventstore.NewSearchQueryBuilder(eventstore.ColumnsEvent).
|
|
OrderDesc().
|
|
Limit(5).
|
|
AddQuery().
|
|
AggregateTypes("user").
|
|
Builder().LockRowsDuringTx(nil, eventstore.LockOptionSkipLocked),
|
|
useV1: true,
|
|
},
|
|
fields: fields{
|
|
mock: newMockClient(t).expectQuery(t,
|
|
`SELECT creation_date, event_type, event_sequence, event_data, editor_user, resource_owner, instance_id, aggregate_type, aggregate_id, aggregate_version FROM eventstore.events WHERE aggregate_type = \$1 ORDER BY event_sequence DESC LIMIT \$2 FOR UPDATE SKIP LOCKED`,
|
|
[]driver.Value{eventstore.AggregateType("user"), uint64(5)},
|
|
),
|
|
},
|
|
res: res{
|
|
wantErr: false,
|
|
},
|
|
},
|
|
{
|
|
name: "error sql conn closed",
|
|
args: args{
|
|
dest: &[]*repository.Event{},
|
|
query: eventstore.NewSearchQueryBuilder(eventstore.ColumnsEvent).
|
|
OrderDesc().
|
|
AwaitOpenTransactions().
|
|
Limit(0).
|
|
AddQuery().
|
|
AggregateTypes("user").
|
|
Builder(),
|
|
useV1: true,
|
|
},
|
|
fields: fields{
|
|
mock: newMockClient(t).expectQueryErr(t,
|
|
`SELECT creation_date, event_type, event_sequence, event_data, editor_user, resource_owner, instance_id, aggregate_type, aggregate_id, aggregate_version FROM eventstore.events WHERE aggregate_type = \$1 AND creation_date::TIMESTAMP < \(SELECT COALESCE\(MIN\(start\), NOW\(\)\)::TIMESTAMP FROM crdb_internal\.cluster_transactions where application_name = ANY\(\$2\)\) ORDER BY event_sequence DESC`,
|
|
[]driver.Value{eventstore.AggregateType("user"), database.TextArray[string]{}},
|
|
sql.ErrConnDone),
|
|
},
|
|
res: res{
|
|
wantErr: true,
|
|
},
|
|
},
|
|
{
|
|
name: "error unexpected dest",
|
|
args: args{
|
|
dest: nil,
|
|
query: eventstore.NewSearchQueryBuilder(eventstore.ColumnsEvent).
|
|
OrderDesc().
|
|
AwaitOpenTransactions().
|
|
Limit(0).
|
|
AddQuery().
|
|
AggregateTypes("user").
|
|
Builder(),
|
|
useV1: true,
|
|
},
|
|
fields: fields{
|
|
mock: newMockClient(t).expectQueryScanErr(t,
|
|
`SELECT creation_date, event_type, event_sequence, event_data, editor_user, resource_owner, instance_id, aggregate_type, aggregate_id, aggregate_version FROM eventstore.events WHERE aggregate_type = \$1 AND creation_date::TIMESTAMP < \(SELECT COALESCE\(MIN\(start\), NOW\(\)\)::TIMESTAMP FROM crdb_internal\.cluster_transactions where application_name = ANY\(\$2\)\) ORDER BY event_sequence DESC`,
|
|
[]driver.Value{eventstore.AggregateType("user"), database.TextArray[string]{}},
|
|
&repository.Event{Seq: 100}),
|
|
},
|
|
res: res{
|
|
wantErr: true,
|
|
},
|
|
},
|
|
{
|
|
name: "error no columns",
|
|
args: args{
|
|
query: eventstore.NewSearchQueryBuilder(eventstore.Columns(-1)),
|
|
},
|
|
res: res{
|
|
wantErr: true,
|
|
},
|
|
},
|
|
{
|
|
name: "with subqueries",
|
|
args: args{
|
|
dest: &[]*repository.Event{},
|
|
query: eventstore.NewSearchQueryBuilder(eventstore.ColumnsEvent).
|
|
OrderDesc().
|
|
AwaitOpenTransactions().
|
|
Limit(5).
|
|
AddQuery().
|
|
AggregateTypes("user").
|
|
Or().
|
|
AggregateTypes("org").
|
|
AggregateIDs("asdf42").
|
|
Builder(),
|
|
useV1: true,
|
|
},
|
|
fields: fields{
|
|
mock: newMockClient(t).expectQuery(t,
|
|
`SELECT creation_date, event_type, event_sequence, event_data, editor_user, resource_owner, instance_id, aggregate_type, aggregate_id, aggregate_version FROM eventstore.events WHERE \(aggregate_type = \$1 OR \(aggregate_type = \$2 AND aggregate_id = \$3\)\) AND creation_date::TIMESTAMP < \(SELECT COALESCE\(MIN\(start\), NOW\(\)\)::TIMESTAMP FROM crdb_internal\.cluster_transactions where application_name = ANY\(\$4\)\) ORDER BY event_sequence DESC LIMIT \$5`,
|
|
[]driver.Value{eventstore.AggregateType("user"), eventstore.AggregateType("org"), "asdf42", database.TextArray[string]{}, uint64(5)},
|
|
),
|
|
},
|
|
res: res{
|
|
wantErr: false,
|
|
},
|
|
},
|
|
{
|
|
name: "aggregate / event type, position and exclusion, v1",
|
|
args: args{
|
|
dest: &[]*repository.Event{},
|
|
query: eventstore.NewSearchQueryBuilder(eventstore.ColumnsEvent).
|
|
InstanceID("instanceID").
|
|
OrderDesc().
|
|
Limit(5).
|
|
PositionAfter(123.456).
|
|
AddQuery().
|
|
AggregateTypes("notify").
|
|
EventTypes("notify.foo.bar").
|
|
Builder().
|
|
ExcludeAggregateIDs().
|
|
AggregateTypes("notify").
|
|
EventTypes("notification.failed", "notification.success").
|
|
Builder(),
|
|
useV1: true,
|
|
},
|
|
fields: fields{
|
|
mock: newMockClient(t).expectQuery(t,
|
|
regexp.QuoteMeta(
|
|
`SELECT creation_date, event_type, event_sequence, event_data, editor_user, resource_owner, instance_id, aggregate_type, aggregate_id, aggregate_version FROM eventstore.events WHERE instance_id = $1 AND aggregate_type = $2 AND event_type = $3 AND "position" > $4 AND aggregate_id NOT IN (SELECT aggregate_id FROM eventstore.events WHERE aggregate_type = $5 AND event_type = ANY($6) AND instance_id = $7 AND "position" > $8) ORDER BY event_sequence DESC LIMIT $9`,
|
|
),
|
|
[]driver.Value{"instanceID", eventstore.AggregateType("notify"), eventstore.EventType("notify.foo.bar"), 123.456, eventstore.AggregateType("notify"), []eventstore.EventType{"notification.failed", "notification.success"}, "instanceID", 123.456, uint64(5)},
|
|
),
|
|
},
|
|
res: res{
|
|
wantErr: false,
|
|
},
|
|
},
|
|
{
|
|
name: "aggregate / event type, position and exclusion, v2",
|
|
args: args{
|
|
dest: &[]*repository.Event{},
|
|
query: eventstore.NewSearchQueryBuilder(eventstore.ColumnsEvent).
|
|
InstanceID("instanceID").
|
|
OrderDesc().
|
|
Limit(5).
|
|
PositionAfter(123.456).
|
|
AddQuery().
|
|
AggregateTypes("notify").
|
|
EventTypes("notify.foo.bar").
|
|
Builder().
|
|
ExcludeAggregateIDs().
|
|
AggregateTypes("notify").
|
|
EventTypes("notification.failed", "notification.success").
|
|
Builder(),
|
|
useV1: false,
|
|
},
|
|
fields: fields{
|
|
mock: newMockClient(t).expectQuery(t,
|
|
regexp.QuoteMeta(
|
|
`SELECT created_at, event_type, "sequence", "position", payload, creator, "owner", instance_id, aggregate_type, aggregate_id, revision FROM eventstore.events2 WHERE instance_id = $1 AND aggregate_type = $2 AND event_type = $3 AND "position" > $4 AND aggregate_id NOT IN (SELECT aggregate_id FROM eventstore.events2 WHERE aggregate_type = $5 AND event_type = ANY($6) AND instance_id = $7 AND "position" > $8) ORDER BY "position" DESC, in_tx_order DESC LIMIT $9`,
|
|
),
|
|
[]driver.Value{"instanceID", eventstore.AggregateType("notify"), eventstore.EventType("notify.foo.bar"), 123.456, eventstore.AggregateType("notify"), []eventstore.EventType{"notification.failed", "notification.success"}, "instanceID", 123.456, uint64(5)},
|
|
),
|
|
},
|
|
res: res{
|
|
wantErr: false,
|
|
},
|
|
},
|
|
{
|
|
name: "aggregate / event type, created after and exclusion, v2",
|
|
args: args{
|
|
dest: &[]*repository.Event{},
|
|
query: eventstore.NewSearchQueryBuilder(eventstore.ColumnsEvent).
|
|
InstanceID("instanceID").
|
|
OrderDesc().
|
|
Limit(5).
|
|
CreationDateAfter(time.Unix(123, 456)).
|
|
AddQuery().
|
|
AggregateTypes("notify").
|
|
EventTypes("notify.foo.bar").
|
|
Builder().
|
|
ExcludeAggregateIDs().
|
|
AggregateTypes("notify").
|
|
EventTypes("notification.failed", "notification.success").
|
|
Builder(),
|
|
useV1: false,
|
|
},
|
|
fields: fields{
|
|
mock: newMockClient(t).expectQuery(t,
|
|
regexp.QuoteMeta(
|
|
`SELECT created_at, event_type, "sequence", "position", payload, creator, "owner", instance_id, aggregate_type, aggregate_id, revision FROM eventstore.events2 WHERE instance_id = $1 AND aggregate_type = $2 AND event_type = $3 AND created_at > $4 AND aggregate_id NOT IN (SELECT aggregate_id FROM eventstore.events2 WHERE aggregate_type = $5 AND event_type = ANY($6) AND instance_id = $7 AND created_at > $8) ORDER BY "position" DESC, in_tx_order DESC LIMIT $9`,
|
|
),
|
|
[]driver.Value{"instanceID", eventstore.AggregateType("notify"), eventstore.EventType("notify.foo.bar"), time.Unix(123, 456), eventstore.AggregateType("notify"), []eventstore.EventType{"notification.failed", "notification.success"}, "instanceID", time.Unix(123, 456), uint64(5)},
|
|
),
|
|
},
|
|
res: res{
|
|
wantErr: false,
|
|
},
|
|
},
|
|
}
|
|
crdb := NewCRDB(&database.DB{Database: new(testDB)})
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
if tt.fields.mock != nil {
|
|
crdb.DB.DB = tt.fields.mock.client
|
|
}
|
|
|
|
err := query(context.Background(), crdb, tt.args.query, tt.args.dest, tt.args.useV1)
|
|
if (err != nil) != tt.res.wantErr {
|
|
t.Errorf("query() error = %v, wantErr %v", err, tt.res.wantErr)
|
|
}
|
|
|
|
if tt.fields.mock == nil {
|
|
return
|
|
}
|
|
|
|
if err := tt.fields.mock.mock.ExpectationsWereMet(); err != nil {
|
|
t.Errorf("not all expectaions met: %v", err)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
type dbMock struct {
|
|
mock sqlmock.Sqlmock
|
|
client *sql.DB
|
|
}
|
|
|
|
func (m *dbMock) expectQuery(t *testing.T, expectedQuery string, args []driver.Value, events ...*repository.Event) *dbMock {
|
|
query := m.mock.ExpectQuery(expectedQuery).WithArgs(args...)
|
|
rows := m.mock.NewRows([]string{"sequence"})
|
|
for _, event := range events {
|
|
rows = rows.AddRow(event.Seq)
|
|
}
|
|
query.WillReturnRows(rows).RowsWillBeClosed()
|
|
return m
|
|
}
|
|
|
|
func (m *dbMock) expectQueryScanErr(t *testing.T, expectedQuery string, args []driver.Value, events ...*repository.Event) *dbMock {
|
|
query := m.mock.ExpectQuery(expectedQuery).WithArgs(args...)
|
|
rows := m.mock.NewRows([]string{"sequence"})
|
|
for _, event := range events {
|
|
rows = rows.AddRow(event.Seq)
|
|
}
|
|
query.WillReturnRows(rows).RowsWillBeClosed()
|
|
return m
|
|
}
|
|
|
|
func (m *dbMock) expectQueryErr(t *testing.T, expectedQuery string, args []driver.Value, err error) *dbMock {
|
|
m.mock.ExpectQuery(expectedQuery).WithArgs(args...).WillReturnError(err)
|
|
return m
|
|
}
|
|
|
|
func newMockClient(t *testing.T) *dbMock {
|
|
t.Helper()
|
|
db, mock, err := sqlmock.New(sqlmock.ValueConverterOption(new(db_mock.TypeConverter)))
|
|
if err != nil {
|
|
t.Errorf("unable to create mock client: %v", err)
|
|
t.FailNow()
|
|
return nil
|
|
}
|
|
|
|
return &dbMock{
|
|
mock: mock,
|
|
client: db,
|
|
}
|
|
}
|