zitadel/internal/command/instance_debug_notification_log_test.go
Silvan 1ee7a1ab7c
feat(eventstore): accept transaction in push (#8945)
# Which Problems Are Solved

Push is not capable of external transactions.

# How the Problems Are Solved

A new function `PushWithClient` is added to the eventstore framework
which allows to pass a client which can either be a `*sql.Client` or
`*sql.Tx` and is used during push.

# Additional Changes

Added interfaces to database package.

# Additional Context

- part of https://github.com/zitadel/zitadel/issues/8931

---------

Co-authored-by: Livio Spring <livio.a@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2024-11-22 17:25:28 +01:00

376 lines
7.8 KiB
Go

package command
import (
"context"
"testing"
"github.com/stretchr/testify/assert"
"github.com/zitadel/zitadel/internal/api/authz"
"github.com/zitadel/zitadel/internal/domain"
"github.com/zitadel/zitadel/internal/eventstore"
"github.com/zitadel/zitadel/internal/notification/channels/fs"
"github.com/zitadel/zitadel/internal/repository/instance"
"github.com/zitadel/zitadel/internal/repository/settings"
"github.com/zitadel/zitadel/internal/zerrors"
)
func TestCommandSide_AddDefaultDebugNotificationProviderLog(t *testing.T) {
type fields struct {
eventstore *eventstore.Eventstore
}
type args struct {
ctx context.Context
provider *fs.Config
}
type res struct {
want *domain.ObjectDetails
err func(error) bool
}
ctx := authz.WithInstanceID(context.Background(), "INSTANCE")
tests := []struct {
name string
fields fields
args args
res res
}{
{
name: "provider already existing, already exists error",
fields: fields{
eventstore: eventstoreExpect(
t,
expectFilter(
eventFromEventPusherWithInstanceID(
"INSTANCE",
instance.NewDebugNotificationProviderLogAddedEvent(ctx,
&instance.NewAggregate("INSTANCE").Aggregate,
true,
),
),
),
),
},
args: args{
ctx: authz.WithInstanceID(ctx, "INSTANCE"),
provider: &fs.Config{
Compact: true,
Enabled: true,
},
},
res: res{
err: zerrors.IsErrorAlreadyExists,
},
},
{
name: "add disabled provider,ok",
fields: fields{
eventstore: eventstoreExpect(
t,
expectFilter(),
expectPush(
instance.NewDebugNotificationProviderLogAddedEvent(ctx,
&instance.NewAggregate("INSTANCE").Aggregate,
true,
),
),
),
},
args: args{
ctx: authz.WithInstanceID(ctx, "INSTANCE"),
provider: &fs.Config{
Compact: true,
},
},
res: res{
want: &domain.ObjectDetails{
ResourceOwner: "INSTANCE",
},
},
},
{
name: "add provider,ok",
fields: fields{
eventstore: eventstoreExpect(
t,
expectFilter(),
expectPush(
instance.NewDebugNotificationProviderLogAddedEvent(ctx,
&instance.NewAggregate("INSTANCE").Aggregate,
true,
),
),
),
},
args: args{
ctx: authz.WithInstanceID(ctx, "INSTANCE"),
provider: &fs.Config{
Compact: true,
Enabled: true,
},
},
res: res{
want: &domain.ObjectDetails{
ResourceOwner: "INSTANCE",
},
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
r := &Commands{
eventstore: tt.fields.eventstore,
}
got, err := r.AddDebugNotificationProviderLog(tt.args.ctx, tt.args.provider)
if tt.res.err == nil {
assert.NoError(t, err)
}
if tt.res.err != nil && !tt.res.err(err) {
t.Errorf("got wrong err: %v ", err)
}
if tt.res.err == nil {
assertObjectDetails(t, tt.res.want, got)
}
})
}
}
func TestCommandSide_ChangeDebugNotificationProviderLog(t *testing.T) {
type fields struct {
eventstore *eventstore.Eventstore
}
type args struct {
ctx context.Context
provider *fs.Config
}
type res struct {
want *domain.ObjectDetails
err func(error) bool
}
ctx := authz.WithInstanceID(context.Background(), "INSTANCE")
tests := []struct {
name string
fields fields
args args
res res
}{
{
name: "provider not existing, not found error",
fields: fields{
eventstore: eventstoreExpect(
t,
expectFilter(),
),
},
args: args{
ctx: ctx,
provider: &fs.Config{
Compact: true,
Enabled: true,
},
},
res: res{
err: zerrors.IsNotFound,
},
},
{
name: "no changes, precondition error",
fields: fields{
eventstore: eventstoreExpect(
t,
expectFilter(
eventFromEventPusher(
instance.NewDebugNotificationProviderLogAddedEvent(ctx,
&instance.NewAggregate("INSTANCE").Aggregate,
true,
),
),
),
),
},
args: args{
ctx: ctx,
provider: &fs.Config{
Compact: true,
Enabled: false,
},
},
res: res{
err: zerrors.IsPreconditionFailed,
},
},
{
name: "change, ok 1",
fields: fields{
eventstore: eventstoreExpect(
t,
expectFilter(
eventFromEventPusherWithInstanceID(
"INSTANCE",
instance.NewDebugNotificationProviderLogAddedEvent(ctx,
&instance.NewAggregate("INSTANCE").Aggregate,
true,
),
),
),
expectPush(
newDefaultDebugNotificationLogChangedEvent(ctx,
false),
),
),
},
args: args{
ctx: authz.WithInstanceID(ctx, "INSTANCE"),
provider: &fs.Config{
Compact: false,
Enabled: false,
},
},
res: res{
want: &domain.ObjectDetails{
ResourceOwner: "INSTANCE",
},
},
},
{
name: "change, ok 2",
fields: fields{
eventstore: eventstoreExpect(
t,
expectFilter(
eventFromEventPusher(
instance.NewDebugNotificationProviderLogAddedEvent(ctx,
&instance.NewAggregate("INSTANCE").Aggregate,
true,
),
),
),
expectPush(
newDefaultDebugNotificationLogChangedEvent(ctx,
false),
),
),
},
args: args{
ctx: authz.WithInstanceID(ctx, "INSTANCE"),
provider: &fs.Config{
Compact: false,
Enabled: true,
},
},
res: res{
want: &domain.ObjectDetails{
ResourceOwner: "INSTANCE",
},
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
r := &Commands{
eventstore: tt.fields.eventstore,
}
got, err := r.ChangeDefaultNotificationLog(tt.args.ctx, tt.args.provider)
if tt.res.err == nil {
assert.NoError(t, err)
}
if tt.res.err != nil && !tt.res.err(err) {
t.Errorf("got wrong err: %v ", err)
}
if tt.res.err == nil {
assertObjectDetails(t, tt.res.want, got)
}
})
}
}
func TestCommandSide_RemoveDebugNotificationProviderLog(t *testing.T) {
type fields struct {
eventstore *eventstore.Eventstore
}
type args struct {
ctx context.Context
}
type res struct {
want *domain.ObjectDetails
err func(error) bool
}
ctx := authz.WithInstanceID(context.Background(), "INSTANCE")
tests := []struct {
name string
fields fields
args args
res res
}{
{
name: "provider not existing, not found error",
fields: fields{
eventstore: eventstoreExpect(
t,
expectFilter(),
),
},
args: args{
ctx: ctx,
},
res: res{
err: zerrors.IsNotFound,
},
},
{
name: "remove, ok",
fields: fields{
eventstore: eventstoreExpect(
t,
expectFilter(
eventFromEventPusherWithInstanceID(
"INSTANCE",
instance.NewDebugNotificationProviderLogAddedEvent(ctx,
&instance.NewAggregate("INSTANCE").Aggregate,
true,
),
),
),
expectPush(
instance.NewDebugNotificationProviderLogRemovedEvent(ctx,
&instance.NewAggregate("INSTANCE").Aggregate),
),
),
},
args: args{
ctx: authz.WithInstanceID(ctx, "INSTANCE"),
},
res: res{
want: &domain.ObjectDetails{
ResourceOwner: "INSTANCE",
},
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
r := &Commands{
eventstore: tt.fields.eventstore,
}
got, err := r.RemoveDefaultNotificationLog(tt.args.ctx)
if tt.res.err == nil {
assert.NoError(t, err)
}
if tt.res.err != nil && !tt.res.err(err) {
t.Errorf("got wrong err: %v ", err)
}
if tt.res.err == nil {
assertObjectDetails(t, tt.res.want, got)
}
})
}
}
func newDefaultDebugNotificationLogChangedEvent(ctx context.Context, compact bool) *instance.DebugNotificationProviderLogChangedEvent {
event, _ := instance.NewDebugNotificationProviderLogChangedEvent(ctx,
&instance.NewAggregate("INSTANCE").Aggregate,
[]settings.DebugNotificationProviderChanges{
settings.ChangeCompact(compact),
},
)
return event
}