mirror of
https://github.com/zitadel/zitadel.git
synced 2024-12-15 04:18:01 +00:00
2bd255106a
* fix: org tests * fix: org tests * fix: user grant test * fix: user grant test * fix: project and project role test * fix: project grant test * fix: project grant test * fix: project member, grant member, app changed tests * fix: application tests * fix: application tests * fix: add oidc app test * fix: add oidc app test * fix: add api keys test * fix: iam policies * fix: iam and org member tests * fix: clock skew validation * revert crypto changes * fix: tests * fix project grant member commands Co-authored-by: Livio Amstutz <livio.a@gmail.com>
319 lines
7.1 KiB
Go
319 lines
7.1 KiB
Go
package command
|
|
|
|
import (
|
|
"context"
|
|
"github.com/caos/zitadel/internal/domain"
|
|
caos_errs "github.com/caos/zitadel/internal/errors"
|
|
"github.com/caos/zitadel/internal/eventstore"
|
|
"github.com/caos/zitadel/internal/eventstore/repository"
|
|
"github.com/caos/zitadel/internal/eventstore/v1/models"
|
|
"github.com/caos/zitadel/internal/repository/iam"
|
|
"github.com/caos/zitadel/internal/repository/policy"
|
|
"github.com/stretchr/testify/assert"
|
|
"testing"
|
|
)
|
|
|
|
func TestCommandSide_AddDefaultPasswordComplexityPolicy(t *testing.T) {
|
|
type fields struct {
|
|
eventstore *eventstore.Eventstore
|
|
}
|
|
type args struct {
|
|
ctx context.Context
|
|
policy *domain.PasswordComplexityPolicy
|
|
}
|
|
type res struct {
|
|
want *domain.PasswordComplexityPolicy
|
|
err func(error) bool
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
fields fields
|
|
args args
|
|
res res
|
|
}{
|
|
{
|
|
name: "invalid policy, invalid argument error",
|
|
fields: fields{
|
|
eventstore: eventstoreExpect(
|
|
t,
|
|
),
|
|
},
|
|
args: args{
|
|
ctx: context.Background(),
|
|
policy: &domain.PasswordComplexityPolicy{
|
|
MinLength: 0,
|
|
HasUppercase: true,
|
|
HasLowercase: true,
|
|
HasNumber: true,
|
|
HasSymbol: true,
|
|
},
|
|
},
|
|
res: res{
|
|
err: caos_errs.IsErrorInvalidArgument,
|
|
},
|
|
},
|
|
{
|
|
name: "password complexity policy already existing, already exists error",
|
|
fields: fields{
|
|
eventstore: eventstoreExpect(
|
|
t,
|
|
expectFilter(
|
|
eventFromEventPusher(
|
|
iam.NewPasswordComplexityPolicyAddedEvent(context.Background(),
|
|
&iam.NewAggregate().Aggregate,
|
|
8,
|
|
true, true, true, true,
|
|
),
|
|
),
|
|
),
|
|
),
|
|
},
|
|
args: args{
|
|
ctx: context.Background(),
|
|
policy: &domain.PasswordComplexityPolicy{
|
|
MinLength: 8,
|
|
HasUppercase: true,
|
|
HasLowercase: true,
|
|
HasNumber: true,
|
|
HasSymbol: true,
|
|
},
|
|
},
|
|
res: res{
|
|
err: caos_errs.IsErrorAlreadyExists,
|
|
},
|
|
},
|
|
{
|
|
name: "add policy,ok",
|
|
fields: fields{
|
|
eventstore: eventstoreExpect(
|
|
t,
|
|
expectFilter(),
|
|
expectPush(
|
|
[]*repository.Event{
|
|
eventFromEventPusher(
|
|
iam.NewPasswordComplexityPolicyAddedEvent(context.Background(),
|
|
&iam.NewAggregate().Aggregate,
|
|
8,
|
|
true, true, true, true,
|
|
),
|
|
),
|
|
},
|
|
),
|
|
),
|
|
},
|
|
args: args{
|
|
ctx: context.Background(),
|
|
policy: &domain.PasswordComplexityPolicy{
|
|
MinLength: 8,
|
|
HasUppercase: true,
|
|
HasLowercase: true,
|
|
HasNumber: true,
|
|
HasSymbol: true,
|
|
},
|
|
},
|
|
res: res{
|
|
want: &domain.PasswordComplexityPolicy{
|
|
ObjectRoot: models.ObjectRoot{
|
|
AggregateID: "IAM",
|
|
ResourceOwner: "IAM",
|
|
},
|
|
MinLength: 8,
|
|
HasUppercase: true,
|
|
HasLowercase: true,
|
|
HasNumber: true,
|
|
HasSymbol: true,
|
|
},
|
|
},
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
r := &Commands{
|
|
eventstore: tt.fields.eventstore,
|
|
}
|
|
got, err := r.AddDefaultPasswordComplexityPolicy(tt.args.ctx, tt.args.policy)
|
|
if tt.res.err == nil {
|
|
assert.NoError(t, err)
|
|
}
|
|
if tt.res.err != nil && !tt.res.err(err) {
|
|
t.Errorf("got wrong err: %v ", err)
|
|
}
|
|
if tt.res.err == nil {
|
|
assert.Equal(t, tt.res.want, got)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestCommandSide_ChangeDefaultPasswordComplexityPolicy(t *testing.T) {
|
|
type fields struct {
|
|
eventstore *eventstore.Eventstore
|
|
}
|
|
type args struct {
|
|
ctx context.Context
|
|
policy *domain.PasswordComplexityPolicy
|
|
}
|
|
type res struct {
|
|
want *domain.PasswordComplexityPolicy
|
|
err func(error) bool
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
fields fields
|
|
args args
|
|
res res
|
|
}{
|
|
{
|
|
name: "invalid policy, invalid argument error",
|
|
fields: fields{
|
|
eventstore: eventstoreExpect(
|
|
t,
|
|
),
|
|
},
|
|
args: args{
|
|
ctx: context.Background(),
|
|
policy: &domain.PasswordComplexityPolicy{
|
|
MinLength: 0,
|
|
HasUppercase: true,
|
|
HasLowercase: true,
|
|
HasNumber: true,
|
|
HasSymbol: true,
|
|
},
|
|
},
|
|
res: res{
|
|
err: caos_errs.IsErrorInvalidArgument,
|
|
},
|
|
},
|
|
{
|
|
name: "password complexity policy not existing, not found error",
|
|
fields: fields{
|
|
eventstore: eventstoreExpect(
|
|
t,
|
|
expectFilter(),
|
|
),
|
|
},
|
|
args: args{
|
|
ctx: context.Background(),
|
|
policy: &domain.PasswordComplexityPolicy{
|
|
MinLength: 8,
|
|
HasUppercase: true,
|
|
HasLowercase: true,
|
|
HasNumber: true,
|
|
HasSymbol: true,
|
|
},
|
|
},
|
|
res: res{
|
|
err: caos_errs.IsNotFound,
|
|
},
|
|
},
|
|
{
|
|
name: "no changes, precondition error",
|
|
fields: fields{
|
|
eventstore: eventstoreExpect(
|
|
t,
|
|
expectFilter(
|
|
eventFromEventPusher(
|
|
iam.NewPasswordComplexityPolicyAddedEvent(context.Background(),
|
|
&iam.NewAggregate().Aggregate,
|
|
8,
|
|
true, true, true, true,
|
|
),
|
|
),
|
|
),
|
|
),
|
|
},
|
|
args: args{
|
|
ctx: context.Background(),
|
|
policy: &domain.PasswordComplexityPolicy{
|
|
MinLength: 8,
|
|
HasUppercase: true,
|
|
HasLowercase: true,
|
|
HasNumber: true,
|
|
HasSymbol: true,
|
|
},
|
|
},
|
|
res: res{
|
|
err: caos_errs.IsPreconditionFailed,
|
|
},
|
|
},
|
|
{
|
|
name: "change, ok",
|
|
fields: fields{
|
|
eventstore: eventstoreExpect(
|
|
t,
|
|
expectFilter(
|
|
eventFromEventPusher(
|
|
iam.NewPasswordComplexityPolicyAddedEvent(context.Background(),
|
|
&iam.NewAggregate().Aggregate,
|
|
8,
|
|
true, true, true, true,
|
|
),
|
|
),
|
|
),
|
|
expectPush(
|
|
[]*repository.Event{
|
|
eventFromEventPusher(
|
|
newDefaultPasswordComplexityPolicyChangedEvent(context.Background(), 10, false, false, false, false),
|
|
),
|
|
},
|
|
),
|
|
),
|
|
},
|
|
args: args{
|
|
ctx: context.Background(),
|
|
policy: &domain.PasswordComplexityPolicy{
|
|
MinLength: 10,
|
|
HasUppercase: false,
|
|
HasLowercase: false,
|
|
HasNumber: false,
|
|
HasSymbol: false,
|
|
},
|
|
},
|
|
res: res{
|
|
want: &domain.PasswordComplexityPolicy{
|
|
ObjectRoot: models.ObjectRoot{
|
|
AggregateID: "IAM",
|
|
ResourceOwner: "IAM",
|
|
},
|
|
MinLength: 10,
|
|
HasUppercase: false,
|
|
HasLowercase: false,
|
|
HasNumber: false,
|
|
HasSymbol: false,
|
|
},
|
|
},
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
r := &Commands{
|
|
eventstore: tt.fields.eventstore,
|
|
}
|
|
got, err := r.ChangeDefaultPasswordComplexityPolicy(tt.args.ctx, tt.args.policy)
|
|
if tt.res.err == nil {
|
|
assert.NoError(t, err)
|
|
}
|
|
if tt.res.err != nil && !tt.res.err(err) {
|
|
t.Errorf("got wrong err: %v ", err)
|
|
}
|
|
if tt.res.err == nil {
|
|
assert.Equal(t, tt.res.want, got)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func newDefaultPasswordComplexityPolicyChangedEvent(ctx context.Context, minLength uint64, hasUpper, hasLower, hasNumber, hasSymbol bool) *iam.PasswordComplexityPolicyChangedEvent {
|
|
event, _ := iam.NewPasswordComplexityPolicyChangedEvent(ctx,
|
|
&iam.NewAggregate().Aggregate,
|
|
[]policy.PasswordComplexityPolicyChanges{
|
|
policy.ChangeMinLength(minLength),
|
|
policy.ChangeHasUppercase(hasUpper),
|
|
policy.ChangeHasLowercase(hasLower),
|
|
policy.ChangeHasSymbol(hasNumber),
|
|
policy.ChangeHasNumber(hasSymbol),
|
|
},
|
|
)
|
|
return event
|
|
}
|