mirror of
https://github.com/zitadel/zitadel.git
synced 2025-12-06 10:42:16 +00:00
# Which Problems Are Solved
The event execution system currently uses a projection handler that
subscribes to and processes all events for all instances. This creates a
high static cost because the system over-fetches event data, handling
many events that are not needed by most instances. This inefficiency is
also reflected in high "rows returned" metrics in the database.
# How the Problems Are Solved
Eliminate the use of a project handler. Instead, events for which
"execution targets" are defined, are directly pushed to the queue by the
eventstore. A Router is populated in the Instance object in the authz
middleware.
- By joining the execution targets to the instance, no additional
queries are needed anymore.
- As part of the instance object, execution targets are now cached as
well.
- Events are queued within the same transaction, giving transactional
guarantees on delivery.
- Uses the "insert many fast` variant of River. Multiple jobs are queued
in a single round-trip to the database.
- Fix compatibility with PostgreSQL 15
# Additional Changes
- The signing key was stored as plain-text in the river job payload in
the DB. This violated our [Secrets
Storage](https://zitadel.com/docs/concepts/architecture/secrets#secrets-storage)
principle. This change removed the field and only uses the encrypted
version of the signing key.
- Fixed the target ordering from descending to ascending.
- Some minor linter warnings on the use of `io.WriteString()`.
# Additional Context
- Introduced in https://github.com/zitadel/zitadel/pull/9249
- Closes https://github.com/zitadel/zitadel/issues/10553
- Closes https://github.com/zitadel/zitadel/issues/9832
- Closes https://github.com/zitadel/zitadel/issues/10372
- Closes https://github.com/zitadel/zitadel/issues/10492
---------
Co-authored-by: Stefan Benz <46600784+stebenz@users.noreply.github.com>
(cherry picked from commit a9ebc06c77)
337 lines
7.1 KiB
Go
337 lines
7.1 KiB
Go
package command
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
"github.com/zitadel/zitadel/internal/crypto"
|
|
"github.com/zitadel/zitadel/internal/eventstore"
|
|
target_domain "github.com/zitadel/zitadel/internal/execution/target"
|
|
"github.com/zitadel/zitadel/internal/repository/target"
|
|
)
|
|
|
|
func targetAddEvent(aggID, resourceOwner string) *target.AddedEvent {
|
|
return target.NewAddedEvent(context.Background(),
|
|
target.NewAggregate(aggID, resourceOwner),
|
|
"name",
|
|
target_domain.TargetTypeWebhook,
|
|
"https://example.com",
|
|
time.Second,
|
|
false,
|
|
&crypto.CryptoValue{
|
|
CryptoType: crypto.TypeEncryption,
|
|
Algorithm: "enc",
|
|
KeyID: "id",
|
|
Crypted: []byte("12345678"),
|
|
},
|
|
)
|
|
}
|
|
|
|
func targetRemoveEvent(aggID, resourceOwner string) *target.RemovedEvent {
|
|
return target.NewRemovedEvent(context.Background(),
|
|
target.NewAggregate(aggID, resourceOwner),
|
|
"name",
|
|
)
|
|
}
|
|
|
|
func TestCommandSide_targetsExistsWriteModel(t *testing.T) {
|
|
type fields struct {
|
|
eventstore func(t *testing.T) *eventstore.Eventstore
|
|
}
|
|
type args struct {
|
|
ctx context.Context
|
|
ids []string
|
|
resourceOwner string
|
|
}
|
|
|
|
tests := []struct {
|
|
name string
|
|
fields fields
|
|
args args
|
|
res bool
|
|
}{
|
|
{
|
|
name: "target, single",
|
|
fields: fields{
|
|
eventstore: expectEventstore(
|
|
expectFilter(
|
|
eventFromEventPusher(
|
|
targetAddEvent("target", "org1"),
|
|
),
|
|
),
|
|
),
|
|
},
|
|
args: args{
|
|
ctx: context.Background(),
|
|
ids: []string{"target"},
|
|
},
|
|
res: true,
|
|
},
|
|
{
|
|
name: "target, single reset",
|
|
fields: fields{
|
|
eventstore: expectEventstore(
|
|
expectFilter(
|
|
eventFromEventPusher(
|
|
targetAddEvent("target", "org1"),
|
|
),
|
|
eventFromEventPusher(
|
|
targetRemoveEvent("target", "org1"),
|
|
),
|
|
eventFromEventPusher(
|
|
|
|
targetAddEvent("target", "org1"),
|
|
),
|
|
),
|
|
),
|
|
},
|
|
args: args{
|
|
ctx: context.Background(),
|
|
ids: []string{"target"},
|
|
},
|
|
res: true,
|
|
},
|
|
{
|
|
name: "target, single before removed",
|
|
fields: fields{
|
|
eventstore: expectEventstore(
|
|
expectFilter(
|
|
eventFromEventPusher(
|
|
targetRemoveEvent("target", "org1"),
|
|
),
|
|
eventFromEventPusher(
|
|
targetAddEvent("target", "org1"),
|
|
),
|
|
),
|
|
),
|
|
},
|
|
args: args{
|
|
ctx: context.Background(),
|
|
ids: []string{"target"},
|
|
},
|
|
res: true,
|
|
},
|
|
{
|
|
name: "target, single removed",
|
|
fields: fields{
|
|
eventstore: expectEventstore(
|
|
expectFilter(
|
|
eventFromEventPusher(
|
|
targetAddEvent("target", "org1"),
|
|
),
|
|
eventFromEventPusher(
|
|
targetRemoveEvent("target", "org1"),
|
|
),
|
|
),
|
|
),
|
|
},
|
|
args: args{
|
|
ctx: context.Background(),
|
|
ids: []string{"target"},
|
|
},
|
|
res: false,
|
|
},
|
|
{
|
|
name: "target, multiple",
|
|
fields: fields{
|
|
eventstore: expectEventstore(
|
|
expectFilter(
|
|
eventFromEventPusher(
|
|
targetAddEvent("target1", "org1"),
|
|
),
|
|
eventFromEventPusher(
|
|
targetAddEvent("target2", "org1"),
|
|
),
|
|
eventFromEventPusher(
|
|
targetAddEvent("target3", "org1"),
|
|
),
|
|
),
|
|
),
|
|
},
|
|
args: args{
|
|
ctx: context.Background(),
|
|
ids: []string{"target1", "target2", "target3"},
|
|
},
|
|
res: true,
|
|
},
|
|
{
|
|
name: "target, multiple, first removed",
|
|
fields: fields{
|
|
eventstore: expectEventstore(
|
|
expectFilter(
|
|
eventFromEventPusher(
|
|
targetAddEvent("target1", "org1"),
|
|
),
|
|
eventFromEventPusher(
|
|
targetRemoveEvent("target1", "org1"),
|
|
),
|
|
eventFromEventPusher(
|
|
targetAddEvent("target2", "org1"),
|
|
),
|
|
eventFromEventPusher(
|
|
targetAddEvent("target3", "org1"),
|
|
),
|
|
),
|
|
),
|
|
},
|
|
args: args{
|
|
ctx: context.Background(),
|
|
ids: []string{"target1", "target2", "target3"},
|
|
},
|
|
res: false,
|
|
},
|
|
{
|
|
name: "target, multiple, second removed",
|
|
fields: fields{
|
|
eventstore: expectEventstore(
|
|
expectFilter(
|
|
eventFromEventPusher(
|
|
targetAddEvent("target1", "org1"),
|
|
),
|
|
eventFromEventPusher(
|
|
targetAddEvent("target2", "org1"),
|
|
),
|
|
eventFromEventPusher(
|
|
targetRemoveEvent("target2", "org1"),
|
|
),
|
|
eventFromEventPusher(
|
|
targetAddEvent("target3", "org1"),
|
|
),
|
|
),
|
|
),
|
|
},
|
|
args: args{
|
|
ctx: context.Background(),
|
|
ids: []string{"target1", "target2", "target3"},
|
|
},
|
|
res: false,
|
|
},
|
|
{
|
|
name: "target, multiple, third removed",
|
|
fields: fields{
|
|
eventstore: expectEventstore(
|
|
expectFilter(
|
|
eventFromEventPusher(
|
|
targetAddEvent("target1", "org1"),
|
|
),
|
|
eventFromEventPusher(
|
|
targetAddEvent("target2", "org1"),
|
|
),
|
|
eventFromEventPusher(
|
|
targetAddEvent("target3", "org1"),
|
|
),
|
|
eventFromEventPusher(
|
|
targetRemoveEvent("target3", "org1"),
|
|
),
|
|
),
|
|
),
|
|
},
|
|
args: args{
|
|
ctx: context.Background(),
|
|
ids: []string{"target1", "target2", "target3"},
|
|
},
|
|
res: false,
|
|
},
|
|
{
|
|
name: "target, multiple, before removed",
|
|
fields: fields{
|
|
eventstore: expectEventstore(
|
|
expectFilter(
|
|
eventFromEventPusher(
|
|
targetRemoveEvent("target1", "org1"),
|
|
),
|
|
eventFromEventPusher(
|
|
targetAddEvent("target1", "org1"),
|
|
),
|
|
eventFromEventPusher(
|
|
targetAddEvent("target2", "org1"),
|
|
),
|
|
eventFromEventPusher(
|
|
targetAddEvent("target3", "org1"),
|
|
),
|
|
),
|
|
),
|
|
},
|
|
args: args{
|
|
ctx: context.Background(),
|
|
ids: []string{"target1", "target2", "target3"},
|
|
},
|
|
res: true,
|
|
},
|
|
{
|
|
name: "target, multiple, all removed",
|
|
fields: fields{
|
|
eventstore: expectEventstore(
|
|
expectFilter(
|
|
eventFromEventPusher(
|
|
targetAddEvent("target1", "org1"),
|
|
),
|
|
eventFromEventPusher(
|
|
targetRemoveEvent("target1", "org1"),
|
|
),
|
|
eventFromEventPusher(
|
|
targetAddEvent("target2", "org1"),
|
|
),
|
|
eventFromEventPusher(
|
|
targetAddEvent("target3", "org1"),
|
|
),
|
|
eventFromEventPusher(
|
|
targetRemoveEvent("target2", "org1"),
|
|
),
|
|
eventFromEventPusher(
|
|
targetRemoveEvent("target3", "org1"),
|
|
),
|
|
),
|
|
),
|
|
},
|
|
args: args{
|
|
ctx: context.Background(),
|
|
ids: []string{"target1", "target2", "target3"},
|
|
},
|
|
res: false,
|
|
},
|
|
|
|
{
|
|
name: "target, multiple, two removed",
|
|
fields: fields{
|
|
eventstore: expectEventstore(
|
|
expectFilter(
|
|
eventFromEventPusher(
|
|
targetAddEvent("target1", "org1"),
|
|
),
|
|
eventFromEventPusher(
|
|
targetRemoveEvent("target1", "org1"),
|
|
),
|
|
eventFromEventPusher(
|
|
targetAddEvent("target2", "org1"),
|
|
),
|
|
eventFromEventPusher(
|
|
targetAddEvent("target3", "org1"),
|
|
),
|
|
eventFromEventPusher(
|
|
targetRemoveEvent("target2", "org1"),
|
|
),
|
|
),
|
|
),
|
|
},
|
|
args: args{
|
|
ctx: context.Background(),
|
|
ids: []string{"target1", "target2", "target3"},
|
|
},
|
|
res: false,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
c := &Commands{
|
|
eventstore: tt.fields.eventstore(t),
|
|
}
|
|
assert.Equal(t, tt.res, c.existsTargetsByIDs(tt.args.ctx, tt.args.ids, tt.args.resourceOwner))
|
|
|
|
})
|
|
}
|
|
}
|