mirror of
https://github.com/zitadel/zitadel.git
synced 2024-12-13 03:24:26 +00:00
f3e6f3b23b
* feat(command): remove org * refactor: imports, unused code, error handling * reduce org removed in action * add org deletion to projections * add org removal to projections * add org removal to projections * org removed projection * lint import * projections * fix: table names in tests * fix: table names in tests * logging * add org state * fix(domain): add Owner removed to object details * feat(ListQuery): add with owner removed * fix(org-delete): add bool to functions to select with owner removed * fix(org-delete): add bools to user grants with events to determine if dependencies lost owner * fix(org-delete): add unit tests for owner removed and org removed events * fix(org-delete): add handling of org remove for grants and members * fix(org-delete): correction of unit tests for owner removed * fix(org-delete): update projections, unit tests and get functions * fix(org-delete): add change date to authnkeys and owner removed to org metadata * fix(org-delete): include owner removed for login names * fix(org-delete): some column fixes in projections and build for queries with owner removed * indexes * fix(org-delete): include review changes * fix(org-delete): change user projection name after merge * fix(org-delete): include review changes for project grant where no project owner is necessary * fix(org-delete): include auth and adminapi tables with owner removed information * fix(org-delete): cleanup username and orgdomain uniqueconstraints when org is removed * fix(org-delete): add permissions for org.remove * remove unnecessary unique constraints * fix column order in primary keys * fix(org-delete): include review changes * fix(org-delete): add owner removed indexes and chang setup step to create tables * fix(org-delete): move PK order of instance_id and change added user_grant from review * fix(org-delete): no params for prepareUserQuery * change to step 6 * merge main * fix(org-delete): OldUserName rename to private * fix linting * cleanup * fix: remove org test * create prerelease * chore: delete org-delete as prerelease Co-authored-by: Stefan Benz <stefan@caos.ch> Co-authored-by: Livio Spring <livio.a@gmail.com> Co-authored-by: Fabi <38692350+hifabienne@users.noreply.github.com> Co-authored-by: Stefan Benz <46600784+stebenz@users.noreply.github.com>
569 lines
12 KiB
Go
569 lines
12 KiB
Go
package repository
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/jinzhu/gorm"
|
|
|
|
"github.com/zitadel/zitadel/internal/domain"
|
|
caos_errs "github.com/zitadel/zitadel/internal/errors"
|
|
)
|
|
|
|
func TestPrepareGetByKey(t *testing.T) {
|
|
type args struct {
|
|
table string
|
|
key ColumnKey
|
|
value string
|
|
}
|
|
type res struct {
|
|
result Test
|
|
wantErr bool
|
|
errFunc func(err error) bool
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
db *dbMock
|
|
args args
|
|
res res
|
|
}{
|
|
{
|
|
"ok",
|
|
mockDB(t).
|
|
expectGetByID("TESTTABLE", "test", "VALUE"),
|
|
args{
|
|
table: "TESTTABLE",
|
|
key: TestSearchKey_TEST,
|
|
value: "VALUE",
|
|
},
|
|
res{
|
|
result: Test{ID: "VALUE"},
|
|
wantErr: false,
|
|
},
|
|
},
|
|
{
|
|
"not found",
|
|
mockDB(t).
|
|
expectGetByIDErr("TESTTABLE", "test", "VALUE", gorm.ErrRecordNotFound),
|
|
args{
|
|
table: "TESTTABLE",
|
|
key: TestSearchKey_TEST,
|
|
value: "VALUE",
|
|
},
|
|
res{
|
|
result: Test{ID: "VALUE"},
|
|
wantErr: true,
|
|
errFunc: caos_errs.IsNotFound,
|
|
},
|
|
},
|
|
{
|
|
"db err",
|
|
mockDB(t).
|
|
expectGetByIDErr("TESTTABLE", "test", "VALUE", gorm.ErrUnaddressable),
|
|
args{
|
|
table: "TESTTABLE",
|
|
key: TestSearchKey_TEST,
|
|
value: "VALUE",
|
|
},
|
|
res{
|
|
result: Test{ID: "VALUE"},
|
|
wantErr: true,
|
|
errFunc: caos_errs.IsInternal,
|
|
},
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
res := &Test{}
|
|
getByID := PrepareGetByKey(tt.args.table, tt.args.key, tt.args.value)
|
|
err := getByID(tt.db.db, res)
|
|
|
|
if !tt.res.wantErr && err != nil {
|
|
t.Errorf("got wrong err should be nil: %v ", err)
|
|
}
|
|
|
|
if tt.res.wantErr && !tt.res.errFunc(err) {
|
|
t.Errorf("got wrong err: %v ", err)
|
|
}
|
|
if err := tt.db.mock.ExpectationsWereMet(); err != nil {
|
|
t.Errorf("there were unfulfilled expectations: %s", err)
|
|
}
|
|
|
|
tt.db.close()
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestPrepareGetByQuery(t *testing.T) {
|
|
type args struct {
|
|
table string
|
|
searchQuery SearchQuery
|
|
}
|
|
type res struct {
|
|
result Test
|
|
wantErr bool
|
|
errFunc func(err error) bool
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
db *dbMock
|
|
args args
|
|
res res
|
|
}{
|
|
{
|
|
"search with equals case insensitive",
|
|
mockDB(t).
|
|
expectGetByQuery("TESTTABLE", "test", "=", "VALUE"),
|
|
args{
|
|
table: "TESTTABLE",
|
|
searchQuery: TestSearchQuery{key: TestSearchKey_TEST, method: domain.SearchMethodEqualsIgnoreCase, value: "VALUE"},
|
|
},
|
|
res{
|
|
result: Test{ID: "VALUE"},
|
|
wantErr: false,
|
|
},
|
|
},
|
|
{
|
|
"search with equals case sensitive",
|
|
mockDB(t).
|
|
expectGetByQueryCaseSensitive("TESTTABLE", "test", "=", "VALUE"),
|
|
args{
|
|
table: "TESTTABLE",
|
|
searchQuery: TestSearchQuery{key: TestSearchKey_TEST, method: domain.SearchMethodEquals, value: "VALUE"},
|
|
},
|
|
res{
|
|
result: Test{ID: "VALUE"},
|
|
wantErr: false,
|
|
},
|
|
},
|
|
{
|
|
"search with startswith, case insensitive",
|
|
mockDB(t).
|
|
expectGetByQuery("TESTTABLE", "test", "LIKE", "VALUE%"),
|
|
args{
|
|
table: "TESTTABLE",
|
|
searchQuery: TestSearchQuery{key: TestSearchKey_TEST, method: domain.SearchMethodStartsWithIgnoreCase, value: "VALUE"},
|
|
},
|
|
res{
|
|
result: Test{ID: "VALUE"},
|
|
wantErr: false,
|
|
},
|
|
},
|
|
{
|
|
"search with startswith case sensitive",
|
|
mockDB(t).
|
|
expectGetByQueryCaseSensitive("TESTTABLE", "test", "LIKE", "VALUE%"),
|
|
args{
|
|
table: "TESTTABLE",
|
|
searchQuery: TestSearchQuery{key: TestSearchKey_TEST, method: domain.SearchMethodStartsWith, value: "VALUE"},
|
|
},
|
|
res{
|
|
result: Test{ID: "VALUE"},
|
|
wantErr: false,
|
|
},
|
|
},
|
|
{
|
|
"search with contains case insensitive",
|
|
mockDB(t).
|
|
expectGetByQuery("TESTTABLE", "test", "LIKE", "%VALUE%"),
|
|
args{
|
|
table: "TESTTABLE",
|
|
searchQuery: TestSearchQuery{key: TestSearchKey_TEST, method: domain.SearchMethodContainsIgnoreCase, value: "VALUE"},
|
|
},
|
|
res{
|
|
result: Test{ID: "VALUE"},
|
|
wantErr: false,
|
|
},
|
|
},
|
|
{
|
|
"search with contains case sensitive",
|
|
mockDB(t).
|
|
expectGetByQueryCaseSensitive("TESTTABLE", "test", "LIKE", "%VALUE%"),
|
|
args{
|
|
table: "TESTTABLE",
|
|
searchQuery: TestSearchQuery{key: TestSearchKey_TEST, method: domain.SearchMethodContains, value: "VALUE"},
|
|
},
|
|
res{
|
|
result: Test{ID: "VALUE"},
|
|
wantErr: false,
|
|
},
|
|
},
|
|
{
|
|
"search expect not found err",
|
|
mockDB(t).
|
|
expectGetByQueryErr("TESTTABLE", "test", "LIKE", "%VALUE%", gorm.ErrRecordNotFound),
|
|
args{
|
|
table: "TESTTABLE",
|
|
searchQuery: TestSearchQuery{key: TestSearchKey_TEST, method: domain.SearchMethodContainsIgnoreCase, value: "VALUE"},
|
|
},
|
|
res{
|
|
result: Test{ID: "VALUE"},
|
|
wantErr: true,
|
|
errFunc: caos_errs.IsNotFound,
|
|
},
|
|
},
|
|
{
|
|
"search expect internal err",
|
|
mockDB(t).
|
|
expectGetByQueryErr("TESTTABLE", "test", "LIKE", "%VALUE%", gorm.ErrUnaddressable),
|
|
args{
|
|
table: "TESTTABLE",
|
|
searchQuery: TestSearchQuery{key: TestSearchKey_TEST, method: domain.SearchMethodContainsIgnoreCase, value: "VALUE"},
|
|
},
|
|
res{
|
|
result: Test{ID: "VALUE"},
|
|
wantErr: true,
|
|
errFunc: caos_errs.IsInternal,
|
|
},
|
|
},
|
|
{
|
|
"search with invalid column",
|
|
mockDB(t).
|
|
expectGetByQuery("TESTTABLE", "", "=", "VALUE"),
|
|
args{
|
|
table: "TESTTABLE",
|
|
searchQuery: TestSearchQuery{key: TestSearchKey_UNDEFINED, method: domain.SearchMethodEqualsIgnoreCase, value: "VALUE"},
|
|
},
|
|
res{
|
|
result: Test{ID: "VALUE"},
|
|
wantErr: true,
|
|
errFunc: caos_errs.IsErrorInvalidArgument,
|
|
},
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
res := &Test{}
|
|
getByQuery := PrepareGetByQuery(tt.args.table, tt.args.searchQuery)
|
|
err := getByQuery(tt.db.db, res)
|
|
|
|
if !tt.res.wantErr && err != nil {
|
|
t.Errorf("got wrong err should be nil: %v ", err)
|
|
}
|
|
|
|
if tt.res.wantErr && !tt.res.errFunc(err) {
|
|
t.Errorf("got wrong err: %v ", err)
|
|
}
|
|
if err := tt.db.mock.ExpectationsWereMet(); !tt.res.wantErr && err != nil {
|
|
t.Errorf("there were unfulfilled expectations: %s", err)
|
|
}
|
|
|
|
tt.db.close()
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestPreparePut(t *testing.T) {
|
|
type args struct {
|
|
table string
|
|
object *Test
|
|
}
|
|
type res struct {
|
|
result Test
|
|
wantErr bool
|
|
errFunc func(err error) bool
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
db *dbMock
|
|
args args
|
|
res res
|
|
}{
|
|
{
|
|
"ok",
|
|
mockDB(t).
|
|
expectBegin(nil).
|
|
expectSave("TESTTABLE", Test{ID: "AggregateID", Test: "VALUE"}).
|
|
expectCommit(nil),
|
|
args{
|
|
table: "TESTTABLE",
|
|
object: &Test{ID: "AggregateID", Test: "VALUE"},
|
|
},
|
|
res{
|
|
result: Test{ID: "VALUE"},
|
|
wantErr: false,
|
|
},
|
|
},
|
|
{
|
|
"db error",
|
|
mockDB(t).
|
|
expectBegin(nil).
|
|
expectSaveErr("TESTTABLE", Test{ID: "AggregateID", Test: "VALUE"}, gorm.ErrUnaddressable).
|
|
expectCommit(nil),
|
|
args{
|
|
table: "TESTTABLE",
|
|
object: &Test{ID: "AggregateID", Test: "VALUE"},
|
|
},
|
|
res{
|
|
result: Test{ID: "VALUE"},
|
|
wantErr: true,
|
|
errFunc: caos_errs.IsInternal,
|
|
},
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
getPut := PrepareSave(tt.args.table)
|
|
err := getPut(tt.db.db, tt.args.object)
|
|
|
|
if !tt.res.wantErr && err != nil {
|
|
t.Errorf("got wrong err should be nil: %v ", err)
|
|
}
|
|
|
|
if tt.res.wantErr && !tt.res.errFunc(err) {
|
|
t.Errorf("got wrong err: %v ", err)
|
|
}
|
|
if err := tt.db.mock.ExpectationsWereMet(); !tt.res.wantErr && err != nil {
|
|
t.Errorf("there were unfulfilled expectations: %s", err)
|
|
}
|
|
|
|
tt.db.close()
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestPrepareDelete(t *testing.T) {
|
|
type args struct {
|
|
table string
|
|
key ColumnKey
|
|
value string
|
|
}
|
|
type res struct {
|
|
result Test
|
|
wantErr bool
|
|
errFunc func(err error) bool
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
db *dbMock
|
|
args args
|
|
res res
|
|
}{
|
|
{
|
|
"delete",
|
|
mockDB(t).
|
|
expectBegin(nil).
|
|
expectRemove("TESTTABLE", "id", "VALUE").
|
|
expectCommit(nil),
|
|
args{
|
|
table: "TESTTABLE",
|
|
key: TestSearchKey_ID,
|
|
value: "VALUE",
|
|
},
|
|
res{
|
|
result: Test{ID: "VALUE"},
|
|
wantErr: false,
|
|
},
|
|
},
|
|
{
|
|
"db error",
|
|
mockDB(t).
|
|
expectBegin(nil).
|
|
expectRemoveErr("TESTTABLE", "id", "VALUE", gorm.ErrUnaddressable).
|
|
expectCommit(nil),
|
|
args{
|
|
table: "TESTTABLE",
|
|
key: TestSearchKey_ID,
|
|
value: "VALUE",
|
|
},
|
|
res{
|
|
result: Test{ID: "VALUE"},
|
|
wantErr: true,
|
|
errFunc: caos_errs.IsInternal,
|
|
},
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
getDelete := PrepareDeleteByKey(tt.args.table, tt.args.key, tt.args.value)
|
|
err := getDelete(tt.db.db)
|
|
|
|
if !tt.res.wantErr && err != nil {
|
|
t.Errorf("got wrong err should be nil: %v ", err)
|
|
}
|
|
|
|
if tt.res.wantErr && !tt.res.errFunc(err) {
|
|
t.Errorf("got wrong err: %v ", err)
|
|
}
|
|
if err := tt.db.mock.ExpectationsWereMet(); !tt.res.wantErr && err != nil {
|
|
t.Errorf("there were unfulfilled expectations: %s", err)
|
|
}
|
|
|
|
tt.db.close()
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestPrepareDeleteByKeys(t *testing.T) {
|
|
type args struct {
|
|
table string
|
|
keys []Key
|
|
}
|
|
type res struct {
|
|
result Test
|
|
wantErr bool
|
|
errFunc func(err error) bool
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
db *dbMock
|
|
args args
|
|
res res
|
|
}{
|
|
{
|
|
"delete single key",
|
|
mockDB(t).
|
|
expectBegin(nil).
|
|
expectRemoveKeys("TESTTABLE", Key{Key: TestSearchKey_ID, Value: "VALUE"}).
|
|
expectCommit(nil),
|
|
args{
|
|
table: "TESTTABLE",
|
|
keys: []Key{
|
|
{Key: TestSearchKey_ID, Value: "VALUE"},
|
|
},
|
|
},
|
|
res{
|
|
result: Test{ID: "VALUE"},
|
|
wantErr: false,
|
|
},
|
|
},
|
|
{
|
|
"delete multiple keys",
|
|
mockDB(t).
|
|
expectBegin(nil).
|
|
expectRemoveKeys("TESTTABLE", Key{Key: TestSearchKey_ID, Value: "VALUE"}, Key{Key: TestSearchKey_TEST, Value: "VALUE2"}).
|
|
expectCommit(nil),
|
|
args{
|
|
table: "TESTTABLE",
|
|
keys: []Key{
|
|
{Key: TestSearchKey_ID, Value: "VALUE"},
|
|
{Key: TestSearchKey_TEST, Value: "VALUE2"},
|
|
},
|
|
},
|
|
res{
|
|
result: Test{ID: "VALUE"},
|
|
wantErr: false,
|
|
},
|
|
},
|
|
{
|
|
"db error",
|
|
mockDB(t).
|
|
expectBegin(nil).
|
|
expectRemoveErr("TESTTABLE", "id", "VALUE", gorm.ErrUnaddressable).
|
|
expectCommit(nil),
|
|
args{
|
|
table: "TESTTABLE",
|
|
keys: []Key{
|
|
{Key: TestSearchKey_ID, Value: "VALUE"},
|
|
},
|
|
},
|
|
res{
|
|
result: Test{ID: "VALUE"},
|
|
wantErr: true,
|
|
errFunc: caos_errs.IsInternal,
|
|
},
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
getDelete := PrepareDeleteByKeys(tt.args.table, tt.args.keys...)
|
|
err := getDelete(tt.db.db)
|
|
|
|
if !tt.res.wantErr && err != nil {
|
|
t.Errorf("got wrong err should be nil: %v ", err)
|
|
}
|
|
|
|
if tt.res.wantErr && !tt.res.errFunc(err) {
|
|
t.Errorf("got wrong err: %v ", err)
|
|
}
|
|
if err := tt.db.mock.ExpectationsWereMet(); !tt.res.wantErr && err != nil {
|
|
t.Errorf("there were unfulfilled expectations: %s", err)
|
|
}
|
|
|
|
tt.db.close()
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestPrepareDeleteByObject(t *testing.T) {
|
|
type args struct {
|
|
table string
|
|
object interface{}
|
|
}
|
|
type res struct {
|
|
result Test
|
|
wantErr bool
|
|
errFunc func(err error) bool
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
db *dbMock
|
|
args args
|
|
res res
|
|
}{
|
|
{
|
|
"delete",
|
|
mockDB(t).
|
|
expectBegin(nil).
|
|
expectRemoveByObject("TESTTABLE", Test{ID: "VALUE", Test: "TEST"}).
|
|
expectCommit(nil),
|
|
args{
|
|
table: "TESTTABLE",
|
|
object: &Test{ID: "VALUE", Test: "TEST"},
|
|
},
|
|
res{
|
|
result: Test{ID: "VALUE"},
|
|
wantErr: false,
|
|
},
|
|
},
|
|
{
|
|
"delete multiple PK",
|
|
mockDB(t).
|
|
expectBegin(nil).
|
|
expectRemoveByObjectMultiplePKs("TESTTABLE", TestMultiplePK{TestID: "TESTID", HodorID: "HODORID", Test: "TEST"}).
|
|
expectCommit(nil),
|
|
args{
|
|
table: "TESTTABLE",
|
|
object: &TestMultiplePK{TestID: "TESTID", HodorID: "HODORID", Test: "TEST"},
|
|
},
|
|
res{
|
|
wantErr: false,
|
|
},
|
|
},
|
|
{
|
|
"db error",
|
|
mockDB(t).
|
|
expectBegin(nil).
|
|
expectRemoveErr("TESTTABLE", "id", "VALUE", gorm.ErrUnaddressable).
|
|
expectCommit(nil),
|
|
args{
|
|
table: "TESTTABLE",
|
|
object: &Test{ID: "VALUE", Test: "TEST"},
|
|
},
|
|
res{
|
|
result: Test{ID: "VALUE"},
|
|
wantErr: true,
|
|
errFunc: caos_errs.IsInternal,
|
|
},
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
getDelete := PrepareDeleteByObject(tt.args.table, tt.args.object)
|
|
err := getDelete(tt.db.db)
|
|
|
|
if !tt.res.wantErr && err != nil {
|
|
t.Errorf("got wrong err should be nil: %v ", err)
|
|
}
|
|
|
|
if tt.res.wantErr && !tt.res.errFunc(err) {
|
|
t.Errorf("got wrong err: %v ", err)
|
|
}
|
|
if err := tt.db.mock.ExpectationsWereMet(); !tt.res.wantErr && err != nil {
|
|
t.Errorf("there were unfulfilled expectations: %s", err)
|
|
}
|
|
|
|
tt.db.close()
|
|
})
|
|
}
|
|
}
|