mirror of
https://github.com/zitadel/zitadel.git
synced 2024-12-13 19:44:21 +00:00
f5e9d4f57f
# Which Problems Are Solved After https://github.com/zitadel/zitadel/pull/7822 was merged we discovered that v2 tokens that where obtained through an IDP using the v1 login, can't be used for zitadel API calls. - Because we used to store the AMR claim on the auth request, but internally use the domain.UserAuthMethod type. AMR has no notion of an IDP login, so that "factor" was lost during conversion. Rendering those v2 tokens invalid on the zitadel API. - A wrong check on machine user tokens falsly allowed some tokens to be valid - The client ID was set to tokens from client credentials and JWT profile, which made client queries fail in the validation middleware. The middleware expects client ID unset for machine users. # How the Problems Are Solved Store the domain.AuthMethods directly in the auth requests and session, instead of using AMR claims with lossy conversion. - IDPs have seperate auth method, which is not an AMR claim - Machine users are treated specialy, eg auth methods are not required. - Do not set the client ID for client credentials and JWT profile # Additional Changes Cleaned up mostly unused `oidc.getInfoFromRequest()`. # Additional Context - Bugs were introduced in https://github.com/zitadel/zitadel/pull/7822 and not yet part of a release. - Reported internally. |
||
|---|---|---|
| .. | ||
| access_token.go | ||
| amr_test.go | ||
| amr.go | ||
| auth_request_converter_v2.go | ||
| auth_request_converter.go | ||
| auth_request_integration_test.go | ||
| auth_request.go | ||
| client_converter.go | ||
| client_credentials.go | ||
| client_integration_test.go | ||
| client.go | ||
| device_auth.go | ||
| error_test.go | ||
| error.go | ||
| introspect.go | ||
| jwt-profile.go | ||
| key_test.go | ||
| key.go | ||
| oidc_integration_test.go | ||
| op.go | ||
| server_integration_test.go | ||
| server_test.go | ||
| server.go | ||
| token_client_credentials_integration_test.go | ||
| token_client_credentials.go | ||
| token_code.go | ||
| token_device.go | ||
| token_exchange_converter.go | ||
| token_exchange_integration_test.go | ||
| token_exchange.go | ||
| token_jwt_profile_integration_test.go | ||
| token_jwt_profile.go | ||
| token_refresh.go | ||
| token.go | ||
| userinfo_integration_test.go | ||
| userinfo_test.go | ||
| userinfo.go | ||