zitadel/internal/eventstore/search_query_test.go
Silvan b522588d98
fix(eventstore): precise decimal (#8527)
# Which Problems Are Solved

Float64 which was used for the event.Position field is [not precise in
go and gets rounded](https://github.com/golang/go/issues/47300). This
can lead to unprecies position tracking of events and therefore
projections especially on cockcoachdb as the position used there is a
big number.

example of a unprecies position:
exact: 1725257931223002628
float64: 1725257931223002624.000000

# How the Problems Are Solved

The float64 was replaced by
[github.com/jackc/pgx-shopspring-decimal](https://github.com/jackc/pgx-shopspring-decimal).

# Additional Changes

Correct behaviour of makefile for load tests.
Rename `latestSequence`-queries to `latestPosition`
2024-09-06 12:19:19 +03:00

718 lines
15 KiB
Go

package eventstore
import (
"reflect"
"testing"
)
func testSetQuery(queryFuncs ...func(*SearchQueryBuilder) *SearchQueryBuilder) func(*SearchQueryBuilder) *SearchQueryBuilder {
return func(builder *SearchQueryBuilder) *SearchQueryBuilder {
for _, queryFunc := range queryFuncs {
queryFunc(builder)
}
return builder
}
}
func testSetSequenceGreater(sequence uint64) func(*SearchQueryBuilder) *SearchQueryBuilder {
return func(builder *SearchQueryBuilder) *SearchQueryBuilder {
builder = builder.SequenceGreater(sequence)
return builder
}
}
func testAddSubQuery(queryFuncs ...func(*SearchQuery) *SearchQuery) func(*SearchQueryBuilder) *SearchQueryBuilder {
return func(builder *SearchQueryBuilder) *SearchQueryBuilder {
query := builder.AddQuery()
for _, queryFunc := range queryFuncs {
queryFunc(query)
}
return query.Builder()
}
}
func testSetColumns(columns Columns) func(factory *SearchQueryBuilder) *SearchQueryBuilder {
return func(factory *SearchQueryBuilder) *SearchQueryBuilder {
factory = factory.Columns(columns)
return factory
}
}
func testSetLimit(limit uint64) func(builder *SearchQueryBuilder) *SearchQueryBuilder {
return func(builder *SearchQueryBuilder) *SearchQueryBuilder {
builder = builder.Limit(limit)
return builder
}
}
func testOr(queryFuncs ...func(*SearchQuery) *SearchQuery) func(*SearchQuery) *SearchQuery {
return func(query *SearchQuery) *SearchQuery {
subQuery := query.Or()
for _, queryFunc := range queryFuncs {
queryFunc(subQuery)
}
return subQuery
}
}
func testSetAggregateTypes(types ...AggregateType) func(*SearchQuery) *SearchQuery {
return func(query *SearchQuery) *SearchQuery {
query = query.AggregateTypes(types...)
return query
}
}
func testSetAggregateIDs(aggregateIDs ...string) func(*SearchQuery) *SearchQuery {
return func(query *SearchQuery) *SearchQuery {
query = query.AggregateIDs(aggregateIDs...)
return query
}
}
func testSetEventTypes(eventTypes ...EventType) func(*SearchQuery) *SearchQuery {
return func(query *SearchQuery) *SearchQuery {
query = query.EventTypes(eventTypes...)
return query
}
}
func testSetResourceOwner(resourceOwner string) func(*SearchQueryBuilder) *SearchQueryBuilder {
return func(builder *SearchQueryBuilder) *SearchQueryBuilder {
builder = builder.ResourceOwner(resourceOwner)
return builder
}
}
func testSetSortOrder(asc bool) func(*SearchQueryBuilder) *SearchQueryBuilder {
return func(query *SearchQueryBuilder) *SearchQueryBuilder {
if asc {
query = query.OrderAsc()
} else {
query = query.OrderDesc()
}
return query
}
}
func TestSearchQuerybuilderSetters(t *testing.T) {
type args struct {
columns Columns
setters []func(*SearchQueryBuilder) *SearchQueryBuilder
}
tests := []struct {
name string
args args
res *SearchQueryBuilder
}{
{
name: "New builder",
args: args{
columns: ColumnsEvent,
},
res: &SearchQueryBuilder{
columns: Columns(ColumnsEvent),
},
},
{
name: "set columns",
args: args{
setters: []func(*SearchQueryBuilder) *SearchQueryBuilder{testSetColumns(ColumnsMaxPosition)},
},
res: &SearchQueryBuilder{
columns: ColumnsMaxPosition,
},
},
{
name: "set limit",
args: args{
setters: []func(*SearchQueryBuilder) *SearchQueryBuilder{testSetLimit(100)},
},
res: &SearchQueryBuilder{
limit: 100,
},
},
{
name: "set sequence greater",
args: args{
setters: []func(b *SearchQueryBuilder) *SearchQueryBuilder{
testSetQuery(testSetSequenceGreater(90)),
},
},
res: &SearchQueryBuilder{
eventSequenceGreater: 90,
},
},
{
name: "set aggregateIDs",
args: args{
setters: []func(*SearchQueryBuilder) *SearchQueryBuilder{testAddSubQuery(testSetAggregateIDs("1235", "09824"))},
},
res: &SearchQueryBuilder{
queries: []*SearchQuery{
{
aggregateIDs: []string{"1235", "09824"},
},
},
},
},
{
name: "set eventTypes",
args: args{
setters: []func(*SearchQueryBuilder) *SearchQueryBuilder{testAddSubQuery(testSetEventTypes("user.created", "user.updated"))},
},
res: &SearchQueryBuilder{
queries: []*SearchQuery{
{
eventTypes: []EventType{"user.created", "user.updated"},
},
},
},
},
{
name: "set resource owner",
args: args{
setters: []func(*SearchQueryBuilder) *SearchQueryBuilder{testSetResourceOwner("hodor")},
},
res: &SearchQueryBuilder{
resourceOwner: "hodor",
},
},
{
name: "default search query",
args: args{
setters: []func(*SearchQueryBuilder) *SearchQueryBuilder{testAddSubQuery(testSetAggregateTypes("user"), testSetAggregateIDs("1235", "024")), testSetSortOrder(false)},
},
res: &SearchQueryBuilder{
desc: true,
queries: []*SearchQuery{
{
aggregateTypes: []AggregateType{"user"},
aggregateIDs: []string{"1235", "024"},
},
},
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
builder := NewSearchQueryBuilder(tt.args.columns)
for _, setter := range tt.args.setters {
builder = setter(builder)
}
assertBuilder(t, tt.res, builder)
})
}
}
func assertBuilder(t *testing.T, want, got *SearchQueryBuilder) {
t.Helper()
if got.columns != want.columns {
t.Errorf("wrong column: got: %v want: %v", got.columns, want.columns)
}
if got.desc != want.desc {
t.Errorf("wrong desc: got: %v want: %v", got.desc, want.desc)
}
if got.limit != want.limit {
t.Errorf("wrong limit: got: %v want: %v", got.limit, want.limit)
}
if got.resourceOwner != want.resourceOwner {
t.Errorf("wrong : got: %v want: %v", got.resourceOwner, want.resourceOwner)
}
if len(got.queries) != len(want.queries) {
t.Errorf("wrong length of queries: got: %v want: %v", len(got.queries), len(want.queries))
}
for i, query := range got.queries {
assertQuery(t, i, want.queries[i], query)
}
}
func assertQuery(t *testing.T, i int, want, got *SearchQuery) {
t.Helper()
if !reflect.DeepEqual(got.aggregateIDs, want.aggregateIDs) {
t.Errorf("wrong aggregateIDs in query %d : got: %v want: %v", i, got.aggregateIDs, want.aggregateIDs)
}
if !reflect.DeepEqual(got.aggregateTypes, want.aggregateTypes) {
t.Errorf("wrong aggregateTypes in query %d : got: %v want: %v", i, got.aggregateTypes, want.aggregateTypes)
}
if !reflect.DeepEqual(got.eventData, want.eventData) {
t.Errorf("wrong eventData in query %d : got: %v want: %v", i, got.eventData, want.eventData)
}
// if got.eventSequenceGreater != want.eventSequenceGreater {
// t.Errorf("wrong eventSequenceGreater in query %d : got: %v want: %v", i, got.eventSequenceGreater, want.eventSequenceGreater)
// }
if !reflect.DeepEqual(got.eventTypes, want.eventTypes) {
t.Errorf("wrong eventTypes in query %d : got: %v want: %v", i, got.eventTypes, want.eventTypes)
}
}
func TestSearchQuery_matches(t *testing.T) {
type args struct {
event Command
}
tests := []struct {
name string
query *SearchQuery
event Command
want bool
}{
{
name: "wrong aggregate type",
query: NewSearchQueryBuilder(ColumnsEvent).AddQuery().AggregateTypes("searched"),
event: &matcherCommand{
BaseEvent{
Agg: &Aggregate{
Type: "found",
},
},
},
want: false,
},
{
name: "wrong aggregate id",
query: NewSearchQueryBuilder(ColumnsEvent).AddQuery().AggregateIDs("1", "10", "100"),
event: &matcherCommand{
BaseEvent{
Agg: &Aggregate{
ID: "2",
},
},
},
want: false,
},
{
name: "wrong event type",
query: NewSearchQueryBuilder(ColumnsEvent).AddQuery().EventTypes("event.searched.type"),
event: &matcherCommand{
BaseEvent{
EventType: "event.actual.type",
Agg: &Aggregate{},
},
},
want: false,
},
{
name: "matching",
query: NewSearchQueryBuilder(ColumnsEvent).
AddQuery().
AggregateIDs("2").
AggregateTypes("actual").
EventTypes("event.actual.type"),
event: &matcherCommand{
BaseEvent{
Seq: 55,
Agg: &Aggregate{
ID: "2",
Type: "actual",
},
EventType: "event.actual.type",
},
},
want: true,
},
{
name: "matching empty query",
query: NewSearchQueryBuilder(ColumnsEvent).AddQuery(),
event: &matcherCommand{
BaseEvent{
Seq: 55,
Agg: &Aggregate{
ID: "2",
Type: "actual",
},
EventType: "event.actual.type",
},
},
want: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
query := &SearchQuery{
aggregateTypes: tt.query.aggregateTypes,
aggregateIDs: tt.query.aggregateIDs,
eventTypes: tt.query.eventTypes,
eventData: tt.query.eventData,
}
if got := query.matches(tt.event); got != tt.want {
t.Errorf("SearchQuery.matches() = %v, want %v", got, tt.want)
}
})
}
}
type matcherCommand struct {
BaseEvent
}
func (matcherCommand) Payload() any { return nil }
func (matcherCommand) UniqueConstraints() []*UniqueConstraint { return nil }
func TestSearchQueryBuilder_Matches(t *testing.T) {
type args struct {
commands []Command
}
tests := []struct {
name string
builder *SearchQueryBuilder
args args
wantedLen int
}{
{
name: "sequence too high",
builder: NewSearchQueryBuilder(ColumnsEvent).
SequenceGreater(60),
args: args{
commands: []Command{
&matcherCommand{
BaseEvent{
Agg: &Aggregate{
InstanceID: "instance",
},
Seq: 60,
},
},
},
},
wantedLen: 0,
},
{
name: "limit exeeded",
builder: NewSearchQueryBuilder(ColumnsEvent).
Limit(2),
args: args{
commands: []Command{
&matcherCommand{
BaseEvent{
Agg: &Aggregate{
ResourceOwner: "ro",
InstanceID: "instance",
},
Seq: 1001,
},
},
&matcherCommand{
BaseEvent{
Agg: &Aggregate{
ResourceOwner: "ro",
InstanceID: "instance",
},
Seq: 1001,
},
},
&matcherCommand{
BaseEvent{
Agg: &Aggregate{
ResourceOwner: "ro",
InstanceID: "instance",
},
Seq: 1001,
},
},
},
},
wantedLen: 2,
},
{
name: "wrong resource owner",
builder: NewSearchQueryBuilder(ColumnsEvent).
ResourceOwner("query"),
args: args{
commands: []Command{
&matcherCommand{
BaseEvent{
Agg: &Aggregate{
ResourceOwner: "ro",
},
},
},
},
},
wantedLen: 0,
},
{
name: "wrong instance",
builder: NewSearchQueryBuilder(ColumnsEvent).
InstanceID("instance"),
args: args{
commands: []Command{
&matcherCommand{
BaseEvent{
Agg: &Aggregate{
InstanceID: "different instance",
},
},
},
},
},
wantedLen: 0,
},
{
name: "query failed",
builder: NewSearchQueryBuilder(ColumnsEvent).
SequenceGreater(1000),
args: args{
commands: []Command{
&matcherCommand{
BaseEvent{
Seq: 999,
Agg: &Aggregate{},
},
},
},
},
wantedLen: 0,
},
{
name: "matching",
builder: NewSearchQueryBuilder(ColumnsEvent).
Limit(1000).
ResourceOwner("ro").
InstanceID("instance").
SequenceGreater(1000),
args: args{
commands: []Command{
&matcherCommand{
BaseEvent{
Agg: &Aggregate{
ResourceOwner: "ro",
InstanceID: "instance",
},
Seq: 1001,
},
},
},
},
wantedLen: 1,
},
{
name: "matching builder resourceOwner and Instance",
builder: NewSearchQueryBuilder(ColumnsEvent).
ResourceOwner("ro").
InstanceID("instance"),
args: args{
commands: []Command{
&matcherCommand{
BaseEvent{
Agg: &Aggregate{
ResourceOwner: "ro",
InstanceID: "instance",
},
Seq: 1001,
},
},
&matcherCommand{
BaseEvent{
Agg: &Aggregate{
ResourceOwner: "ro2",
InstanceID: "instance2",
},
Seq: 1002,
},
},
&matcherCommand{
BaseEvent{
Agg: &Aggregate{
ResourceOwner: "ro2",
InstanceID: "instance",
},
Seq: 1003,
},
},
&matcherCommand{
BaseEvent{
Agg: &Aggregate{
ResourceOwner: "ro",
InstanceID: "instance2",
},
Seq: 1004,
},
},
},
},
wantedLen: 1,
},
{
name: "matching builder resourceOwner only",
builder: NewSearchQueryBuilder(ColumnsEvent).
ResourceOwner("ro"),
args: args{
commands: []Command{
&matcherCommand{
BaseEvent{
Agg: &Aggregate{
ResourceOwner: "ro",
},
Seq: 1001,
},
},
&matcherCommand{
BaseEvent{
Agg: &Aggregate{
ResourceOwner: "ro2",
},
Seq: 1001,
},
},
},
},
wantedLen: 1,
},
{
name: "matching builder instanceID only",
builder: NewSearchQueryBuilder(ColumnsEvent).
InstanceID("instance"),
args: args{
commands: []Command{
&matcherCommand{
BaseEvent{
Agg: &Aggregate{
InstanceID: "instance",
},
Seq: 1001,
},
},
&matcherCommand{
BaseEvent{
Agg: &Aggregate{
InstanceID: "instance2",
},
Seq: 1001,
},
},
},
},
wantedLen: 1,
},
{
name: "offset too high",
builder: NewSearchQueryBuilder(ColumnsEvent).
Offset(2),
args: args{
commands: []Command{
&matcherCommand{
BaseEvent{
Agg: &Aggregate{
InstanceID: "instance",
},
Seq: 1001,
},
},
},
},
wantedLen: 0,
},
{
name: "offset",
builder: NewSearchQueryBuilder(ColumnsEvent).
Offset(1),
args: args{
commands: []Command{
&matcherCommand{
BaseEvent{
Agg: &Aggregate{
InstanceID: "instance",
},
Seq: 1001,
},
},
&matcherCommand{
BaseEvent{
Agg: &Aggregate{
InstanceID: "instance",
},
Seq: 1002,
},
},
},
},
wantedLen: 1,
},
{
name: "offset and limit",
builder: NewSearchQueryBuilder(ColumnsEvent).
Offset(1).
Limit(1),
args: args{
commands: []Command{
&matcherCommand{
BaseEvent{
Agg: &Aggregate{
InstanceID: "instance",
},
Seq: 1001,
},
},
&matcherCommand{
BaseEvent{
Agg: &Aggregate{
InstanceID: "instance",
},
Seq: 1002,
},
},
&matcherCommand{
BaseEvent{
Agg: &Aggregate{
InstanceID: "instance",
},
Seq: 1002,
},
},
},
},
wantedLen: 1,
},
{
name: "sub query",
builder: NewSearchQueryBuilder(ColumnsEvent).
AddQuery().
AggregateTypes("test").
Builder(),
args: args{
commands: []Command{
&matcherCommand{
BaseEvent{
Agg: &Aggregate{
InstanceID: "instance",
Type: "test",
},
Seq: 1001,
},
},
&matcherCommand{
BaseEvent{
Agg: &Aggregate{
InstanceID: "instance",
Type: "test",
},
Seq: 1002,
},
},
&matcherCommand{
BaseEvent{
Agg: &Aggregate{
InstanceID: "instance",
Type: "test2",
},
Seq: 1003,
},
},
},
},
wantedLen: 2,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
if got := tt.builder.Matches(tt.args.commands...); len(got) != tt.wantedLen {
t.Errorf("SearchQueryBuilder.Matches() = %v, wantted len %v", got, tt.wantedLen)
}
})
}
}