mirror of
https://github.com/zitadel/zitadel.git
synced 2025-12-06 14:02:20 +00:00
# Which Problems Are Solved
The event execution system currently uses a projection handler that
subscribes to and processes all events for all instances. This creates a
high static cost because the system over-fetches event data, handling
many events that are not needed by most instances. This inefficiency is
also reflected in high "rows returned" metrics in the database.
# How the Problems Are Solved
Eliminate the use of a project handler. Instead, events for which
"execution targets" are defined, are directly pushed to the queue by the
eventstore. A Router is populated in the Instance object in the authz
middleware.
- By joining the execution targets to the instance, no additional
queries are needed anymore.
- As part of the instance object, execution targets are now cached as
well.
- Events are queued within the same transaction, giving transactional
guarantees on delivery.
- Uses the "insert many fast` variant of River. Multiple jobs are queued
in a single round-trip to the database.
- Fix compatibility with PostgreSQL 15
# Additional Changes
- The signing key was stored as plain-text in the river job payload in
the DB. This violated our [Secrets
Storage](https://zitadel.com/docs/concepts/architecture/secrets#secrets-storage)
principle. This change removed the field and only uses the encrypted
version of the signing key.
- Fixed the target ordering from descending to ascending.
- Some minor linter warnings on the use of `io.WriteString()`.
# Additional Context
- Introduced in https://github.com/zitadel/zitadel/pull/9249
- Closes https://github.com/zitadel/zitadel/issues/10553
- Closes https://github.com/zitadel/zitadel/issues/9832
- Closes https://github.com/zitadel/zitadel/issues/10372
- Closes https://github.com/zitadel/zitadel/issues/10492
---------
Co-authored-by: Stefan Benz <46600784+stebenz@users.noreply.github.com>
(cherry picked from commit a9ebc06c77)
230 lines
6.1 KiB
Go
230 lines
6.1 KiB
Go
package action
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/muhlemmer/gu"
|
|
"github.com/stretchr/testify/assert"
|
|
"google.golang.org/protobuf/types/known/durationpb"
|
|
|
|
"github.com/zitadel/zitadel/internal/command"
|
|
target_domain "github.com/zitadel/zitadel/internal/execution/target"
|
|
"github.com/zitadel/zitadel/pkg/grpc/action/v2"
|
|
)
|
|
|
|
func Test_createTargetToCommand(t *testing.T) {
|
|
type args struct {
|
|
req *action.CreateTargetRequest
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
args args
|
|
want *command.AddTarget
|
|
}{
|
|
{
|
|
name: "nil",
|
|
args: args{nil},
|
|
want: &command.AddTarget{
|
|
Name: "",
|
|
Endpoint: "",
|
|
Timeout: 0,
|
|
InterruptOnError: false,
|
|
},
|
|
},
|
|
{
|
|
name: "all fields (webhook)",
|
|
args: args{&action.CreateTargetRequest{
|
|
Name: "target 1",
|
|
Endpoint: "https://example.com/hooks/1",
|
|
TargetType: &action.CreateTargetRequest_RestWebhook{
|
|
RestWebhook: &action.RESTWebhook{},
|
|
},
|
|
Timeout: durationpb.New(10 * time.Second),
|
|
}},
|
|
want: &command.AddTarget{
|
|
Name: "target 1",
|
|
TargetType: target_domain.TargetTypeWebhook,
|
|
Endpoint: "https://example.com/hooks/1",
|
|
Timeout: 10 * time.Second,
|
|
InterruptOnError: false,
|
|
},
|
|
},
|
|
{
|
|
name: "all fields (async)",
|
|
args: args{&action.CreateTargetRequest{
|
|
Name: "target 1",
|
|
Endpoint: "https://example.com/hooks/1",
|
|
TargetType: &action.CreateTargetRequest_RestAsync{
|
|
RestAsync: &action.RESTAsync{},
|
|
},
|
|
Timeout: durationpb.New(10 * time.Second),
|
|
}},
|
|
want: &command.AddTarget{
|
|
Name: "target 1",
|
|
TargetType: target_domain.TargetTypeAsync,
|
|
Endpoint: "https://example.com/hooks/1",
|
|
Timeout: 10 * time.Second,
|
|
InterruptOnError: false,
|
|
},
|
|
},
|
|
{
|
|
name: "all fields (interrupting response)",
|
|
args: args{&action.CreateTargetRequest{
|
|
Name: "target 1",
|
|
Endpoint: "https://example.com/hooks/1",
|
|
TargetType: &action.CreateTargetRequest_RestCall{
|
|
RestCall: &action.RESTCall{
|
|
InterruptOnError: true,
|
|
},
|
|
},
|
|
Timeout: durationpb.New(10 * time.Second),
|
|
}},
|
|
want: &command.AddTarget{
|
|
Name: "target 1",
|
|
TargetType: target_domain.TargetTypeCall,
|
|
Endpoint: "https://example.com/hooks/1",
|
|
Timeout: 10 * time.Second,
|
|
InterruptOnError: true,
|
|
},
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
got := createTargetToCommand(tt.args.req)
|
|
assert.Equal(t, tt.want, got)
|
|
})
|
|
}
|
|
}
|
|
|
|
func Test_updateTargetToCommand(t *testing.T) {
|
|
type args struct {
|
|
req *action.UpdateTargetRequest
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
args args
|
|
want *command.ChangeTarget
|
|
}{
|
|
{
|
|
name: "nil",
|
|
args: args{nil},
|
|
want: nil,
|
|
},
|
|
{
|
|
name: "all fields nil",
|
|
args: args{&action.UpdateTargetRequest{
|
|
Name: nil,
|
|
TargetType: nil,
|
|
Timeout: nil,
|
|
}},
|
|
want: &command.ChangeTarget{
|
|
Name: nil,
|
|
TargetType: nil,
|
|
Endpoint: nil,
|
|
Timeout: nil,
|
|
InterruptOnError: nil,
|
|
},
|
|
},
|
|
{
|
|
name: "all fields empty",
|
|
args: args{&action.UpdateTargetRequest{
|
|
Name: gu.Ptr(""),
|
|
TargetType: nil,
|
|
Timeout: durationpb.New(0),
|
|
}},
|
|
want: &command.ChangeTarget{
|
|
Name: gu.Ptr(""),
|
|
TargetType: nil,
|
|
Endpoint: nil,
|
|
Timeout: gu.Ptr(0 * time.Second),
|
|
InterruptOnError: nil,
|
|
},
|
|
},
|
|
{
|
|
name: "all fields (webhook)",
|
|
args: args{&action.UpdateTargetRequest{
|
|
Name: gu.Ptr("target 1"),
|
|
Endpoint: gu.Ptr("https://example.com/hooks/1"),
|
|
TargetType: &action.UpdateTargetRequest_RestWebhook{
|
|
RestWebhook: &action.RESTWebhook{
|
|
InterruptOnError: false,
|
|
},
|
|
},
|
|
Timeout: durationpb.New(10 * time.Second),
|
|
}},
|
|
want: &command.ChangeTarget{
|
|
Name: gu.Ptr("target 1"),
|
|
TargetType: gu.Ptr(target_domain.TargetTypeWebhook),
|
|
Endpoint: gu.Ptr("https://example.com/hooks/1"),
|
|
Timeout: gu.Ptr(10 * time.Second),
|
|
InterruptOnError: gu.Ptr(false),
|
|
},
|
|
},
|
|
{
|
|
name: "all fields (webhook interrupt)",
|
|
args: args{&action.UpdateTargetRequest{
|
|
Name: gu.Ptr("target 1"),
|
|
Endpoint: gu.Ptr("https://example.com/hooks/1"),
|
|
TargetType: &action.UpdateTargetRequest_RestWebhook{
|
|
RestWebhook: &action.RESTWebhook{
|
|
InterruptOnError: true,
|
|
},
|
|
},
|
|
Timeout: durationpb.New(10 * time.Second),
|
|
}},
|
|
want: &command.ChangeTarget{
|
|
Name: gu.Ptr("target 1"),
|
|
TargetType: gu.Ptr(target_domain.TargetTypeWebhook),
|
|
Endpoint: gu.Ptr("https://example.com/hooks/1"),
|
|
Timeout: gu.Ptr(10 * time.Second),
|
|
InterruptOnError: gu.Ptr(true),
|
|
},
|
|
},
|
|
{
|
|
name: "all fields (async)",
|
|
args: args{&action.UpdateTargetRequest{
|
|
Name: gu.Ptr("target 1"),
|
|
Endpoint: gu.Ptr("https://example.com/hooks/1"),
|
|
TargetType: &action.UpdateTargetRequest_RestAsync{
|
|
RestAsync: &action.RESTAsync{},
|
|
},
|
|
Timeout: durationpb.New(10 * time.Second),
|
|
}},
|
|
want: &command.ChangeTarget{
|
|
Name: gu.Ptr("target 1"),
|
|
TargetType: gu.Ptr(target_domain.TargetTypeAsync),
|
|
Endpoint: gu.Ptr("https://example.com/hooks/1"),
|
|
Timeout: gu.Ptr(10 * time.Second),
|
|
InterruptOnError: gu.Ptr(false),
|
|
},
|
|
},
|
|
{
|
|
name: "all fields (interrupting response)",
|
|
args: args{&action.UpdateTargetRequest{
|
|
Name: gu.Ptr("target 1"),
|
|
Endpoint: gu.Ptr("https://example.com/hooks/1"),
|
|
TargetType: &action.UpdateTargetRequest_RestCall{
|
|
RestCall: &action.RESTCall{
|
|
InterruptOnError: true,
|
|
},
|
|
},
|
|
Timeout: durationpb.New(10 * time.Second),
|
|
}},
|
|
want: &command.ChangeTarget{
|
|
Name: gu.Ptr("target 1"),
|
|
TargetType: gu.Ptr(target_domain.TargetTypeCall),
|
|
Endpoint: gu.Ptr("https://example.com/hooks/1"),
|
|
Timeout: gu.Ptr(10 * time.Second),
|
|
InterruptOnError: gu.Ptr(true),
|
|
},
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
got := updateTargetToCommand(tt.args.req)
|
|
assert.Equal(t, tt.want, got)
|
|
})
|
|
}
|
|
}
|