mirror of
https://github.com/zitadel/zitadel.git
synced 2025-07-13 00:38:31 +00:00

# Which Problems Are Solved Remove the feature flag that allowed triggers in introspection. This option was a fallback in case introspection would not function properly without triggers. The API documentation asked for anyone using this flag to raise an issue. No such issue was received, hence we concluded it is safe to remove it. # How the Problems Are Solved - Remove flags from the system and instance level feature APIs. - Remove trigger functions that are no longer used - Adjust tests that used the flag. # Additional Changes - none # Additional Context - Closes #10026 - Flag was introduced in #7356 --------- Co-authored-by: Silvan <27845747+adlerhurst@users.noreply.github.com>
148 lines
3.6 KiB
Go
148 lines
3.6 KiB
Go
package query
|
|
|
|
import (
|
|
"context"
|
|
"io"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/zitadel/zitadel/internal/domain"
|
|
"github.com/zitadel/zitadel/internal/eventstore"
|
|
"github.com/zitadel/zitadel/internal/feature"
|
|
"github.com/zitadel/zitadel/internal/repository/feature/feature_v2"
|
|
)
|
|
|
|
func TestQueries_GetSystemFeatures(t *testing.T) {
|
|
aggregate := feature_v2.NewAggregate("SYSTEM", "SYSTEM")
|
|
|
|
tests := []struct {
|
|
name string
|
|
eventstore func(*testing.T) *eventstore.Eventstore
|
|
want *SystemFeatures
|
|
wantErr error
|
|
}{
|
|
{
|
|
name: "filter error",
|
|
eventstore: expectEventstore(
|
|
expectFilterError(io.ErrClosedPipe),
|
|
),
|
|
wantErr: io.ErrClosedPipe,
|
|
},
|
|
{
|
|
name: "no features set",
|
|
eventstore: expectEventstore(
|
|
expectFilter(),
|
|
),
|
|
want: &SystemFeatures{
|
|
Details: &domain.ObjectDetails{
|
|
ResourceOwner: "SYSTEM",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "all features set",
|
|
eventstore: expectEventstore(
|
|
expectFilter(
|
|
eventFromEventPusher(feature_v2.NewSetEvent(
|
|
context.Background(), aggregate,
|
|
feature_v2.SystemLoginDefaultOrgEventType, false,
|
|
)),
|
|
eventFromEventPusher(feature_v2.NewSetEvent(
|
|
context.Background(), aggregate,
|
|
feature_v2.SystemUserSchemaEventType, false,
|
|
)),
|
|
),
|
|
),
|
|
want: &SystemFeatures{
|
|
Details: &domain.ObjectDetails{
|
|
ResourceOwner: "SYSTEM",
|
|
},
|
|
LoginDefaultOrg: FeatureSource[bool]{
|
|
Level: feature.LevelSystem,
|
|
Value: false,
|
|
},
|
|
UserSchema: FeatureSource[bool]{
|
|
Level: feature.LevelSystem,
|
|
Value: false,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "all features set, reset, set some feature",
|
|
eventstore: expectEventstore(
|
|
expectFilter(
|
|
eventFromEventPusher(feature_v2.NewSetEvent(
|
|
context.Background(), aggregate,
|
|
feature_v2.SystemLoginDefaultOrgEventType, false,
|
|
)),
|
|
eventFromEventPusher(feature_v2.NewSetEvent(
|
|
context.Background(), aggregate,
|
|
feature_v2.SystemUserSchemaEventType, false,
|
|
)),
|
|
eventFromEventPusher(feature_v2.NewResetEvent(
|
|
context.Background(), aggregate,
|
|
feature_v2.SystemResetEventType,
|
|
)),
|
|
),
|
|
),
|
|
want: &SystemFeatures{
|
|
Details: &domain.ObjectDetails{
|
|
ResourceOwner: "SYSTEM",
|
|
},
|
|
LoginDefaultOrg: FeatureSource[bool]{
|
|
Level: feature.LevelUnspecified,
|
|
Value: false,
|
|
},
|
|
UserSchema: FeatureSource[bool]{
|
|
Level: feature.LevelUnspecified,
|
|
Value: false,
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "all features set, reset, set some feature, not cascaded",
|
|
eventstore: expectEventstore(
|
|
expectFilter(
|
|
eventFromEventPusher(feature_v2.NewSetEvent(
|
|
context.Background(), aggregate,
|
|
feature_v2.SystemLoginDefaultOrgEventType, false,
|
|
)),
|
|
eventFromEventPusher(feature_v2.NewSetEvent(
|
|
context.Background(), aggregate,
|
|
feature_v2.SystemUserSchemaEventType, false,
|
|
)),
|
|
eventFromEventPusher(feature_v2.NewResetEvent(
|
|
context.Background(), aggregate,
|
|
feature_v2.SystemResetEventType,
|
|
)),
|
|
),
|
|
),
|
|
want: &SystemFeatures{
|
|
Details: &domain.ObjectDetails{
|
|
ResourceOwner: "SYSTEM",
|
|
},
|
|
LoginDefaultOrg: FeatureSource[bool]{
|
|
Level: feature.LevelUnspecified,
|
|
Value: false,
|
|
},
|
|
UserSchema: FeatureSource[bool]{
|
|
Level: feature.LevelUnspecified,
|
|
Value: false,
|
|
},
|
|
},
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
q := &Queries{
|
|
eventstore: tt.eventstore(t),
|
|
}
|
|
got, err := q.GetSystemFeatures(context.Background())
|
|
require.ErrorIs(t, err, tt.wantErr)
|
|
assert.Equal(t, tt.want, got)
|
|
})
|
|
}
|
|
}
|