mirror of
https://github.com/zitadel/zitadel.git
synced 2024-12-15 12:27:59 +00:00
2847806531
# Which Problems Are Solved IDPLinks list and other list endpoints can provide you with empty results if the used user has no permission for the information. # How the Problems Are Solved List endpoints with subelements to users, and provided userIDQuery, will return a PermissionDenied error if no permission for the user exsists. # Additional Changes Function to check for permission is re-used from the GetUserByID. # Additional Context Closes #8451
359 lines
9.0 KiB
Go
359 lines
9.0 KiB
Go
//go:build integration
|
|
|
|
package user_test
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"google.golang.org/protobuf/types/known/timestamppb"
|
|
|
|
"github.com/zitadel/zitadel/internal/integration"
|
|
"github.com/zitadel/zitadel/pkg/grpc/object/v2"
|
|
"github.com/zitadel/zitadel/pkg/grpc/user/v2"
|
|
)
|
|
|
|
func TestServer_AddIDPLink(t *testing.T) {
|
|
idpID := Tester.AddGenericOAuthProvider(t, CTX)
|
|
type args struct {
|
|
ctx context.Context
|
|
req *user.AddIDPLinkRequest
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
args args
|
|
want *user.AddIDPLinkResponse
|
|
wantErr bool
|
|
}{
|
|
{
|
|
name: "user does not exist",
|
|
args: args{
|
|
CTX,
|
|
&user.AddIDPLinkRequest{
|
|
UserId: "userID",
|
|
IdpLink: &user.IDPLink{
|
|
IdpId: idpID,
|
|
UserId: "userID",
|
|
UserName: "username",
|
|
},
|
|
},
|
|
},
|
|
want: nil,
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "idp does not exist",
|
|
args: args{
|
|
CTX,
|
|
&user.AddIDPLinkRequest{
|
|
UserId: Tester.Users[integration.FirstInstanceUsersKey][integration.OrgOwner].ID,
|
|
IdpLink: &user.IDPLink{
|
|
IdpId: "idpID",
|
|
UserId: "userID",
|
|
UserName: "username",
|
|
},
|
|
},
|
|
},
|
|
want: nil,
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "add link",
|
|
args: args{
|
|
CTX,
|
|
&user.AddIDPLinkRequest{
|
|
UserId: Tester.Users[integration.FirstInstanceUsersKey][integration.OrgOwner].ID,
|
|
IdpLink: &user.IDPLink{
|
|
IdpId: idpID,
|
|
UserId: "userID",
|
|
UserName: "username",
|
|
},
|
|
},
|
|
},
|
|
want: &user.AddIDPLinkResponse{
|
|
Details: &object.Details{
|
|
ChangeDate: timestamppb.Now(),
|
|
ResourceOwner: Tester.Organisation.ID,
|
|
},
|
|
},
|
|
wantErr: false,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
got, err := Client.AddIDPLink(tt.args.ctx, tt.args.req)
|
|
if tt.wantErr {
|
|
require.Error(t, err)
|
|
} else {
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
integration.AssertDetails(t, tt.want, got)
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestServer_ListIDPLinks(t *testing.T) {
|
|
orgResp := Tester.CreateOrganization(IamCTX, fmt.Sprintf("ListIDPLinks%d", time.Now().UnixNano()), fmt.Sprintf("%d@mouse.com", time.Now().UnixNano()))
|
|
|
|
instanceIdpID := Tester.AddGenericOAuthProvider(t, IamCTX)
|
|
userInstanceResp := Tester.CreateHumanUserVerified(IamCTX, orgResp.OrganizationId, fmt.Sprintf("%d@listidplinks.com", time.Now().UnixNano()))
|
|
Tester.CreateUserIDPlink(IamCTX, userInstanceResp.GetUserId(), "external_instance", instanceIdpID, "externalUsername_instance")
|
|
|
|
orgIdpID := Tester.AddOrgGenericOAuthProvider(t, IamCTX, orgResp.OrganizationId)
|
|
userOrgResp := Tester.CreateHumanUserVerified(IamCTX, orgResp.OrganizationId, fmt.Sprintf("%d@listidplinks.com", time.Now().UnixNano()))
|
|
Tester.CreateUserIDPlink(IamCTX, userOrgResp.GetUserId(), "external_org", orgIdpID, "externalUsername_org")
|
|
|
|
userMultipleResp := Tester.CreateHumanUserVerified(IamCTX, orgResp.OrganizationId, fmt.Sprintf("%d@listidplinks.com", time.Now().UnixNano()))
|
|
Tester.CreateUserIDPlink(IamCTX, userMultipleResp.GetUserId(), "external_multi", instanceIdpID, "externalUsername_multi")
|
|
Tester.CreateUserIDPlink(IamCTX, userMultipleResp.GetUserId(), "external_multi", orgIdpID, "externalUsername_multi")
|
|
|
|
type args struct {
|
|
ctx context.Context
|
|
req *user.ListIDPLinksRequest
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
args args
|
|
want *user.ListIDPLinksResponse
|
|
wantErr bool
|
|
}{
|
|
{
|
|
name: "list links, missing userID",
|
|
args: args{
|
|
IamCTX,
|
|
&user.ListIDPLinksRequest{
|
|
UserId: "",
|
|
},
|
|
},
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "list links, no permission",
|
|
args: args{
|
|
UserCTX,
|
|
&user.ListIDPLinksRequest{
|
|
UserId: userOrgResp.GetUserId(),
|
|
},
|
|
},
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "list links, no permission, org",
|
|
args: args{
|
|
CTX,
|
|
&user.ListIDPLinksRequest{
|
|
UserId: userOrgResp.GetUserId(),
|
|
},
|
|
},
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "list idp links, org, ok",
|
|
args: args{
|
|
IamCTX,
|
|
&user.ListIDPLinksRequest{
|
|
UserId: userOrgResp.GetUserId(),
|
|
},
|
|
},
|
|
want: &user.ListIDPLinksResponse{
|
|
Details: &object.ListDetails{
|
|
TotalResult: 1,
|
|
Timestamp: timestamppb.Now(),
|
|
},
|
|
Result: []*user.IDPLink{
|
|
{
|
|
IdpId: orgIdpID,
|
|
UserId: "external_org",
|
|
UserName: "externalUsername_org",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "list idp links, instance, ok",
|
|
args: args{
|
|
IamCTX,
|
|
&user.ListIDPLinksRequest{
|
|
UserId: userInstanceResp.GetUserId(),
|
|
},
|
|
},
|
|
want: &user.ListIDPLinksResponse{
|
|
Details: &object.ListDetails{
|
|
TotalResult: 1,
|
|
Timestamp: timestamppb.Now(),
|
|
},
|
|
Result: []*user.IDPLink{
|
|
{
|
|
IdpId: instanceIdpID,
|
|
UserId: "external_instance",
|
|
UserName: "externalUsername_instance",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "list idp links, multi, ok",
|
|
args: args{
|
|
IamCTX,
|
|
&user.ListIDPLinksRequest{
|
|
UserId: userMultipleResp.GetUserId(),
|
|
},
|
|
},
|
|
want: &user.ListIDPLinksResponse{
|
|
Details: &object.ListDetails{
|
|
TotalResult: 2,
|
|
Timestamp: timestamppb.Now(),
|
|
},
|
|
Result: []*user.IDPLink{
|
|
{
|
|
IdpId: instanceIdpID,
|
|
UserId: "external_multi",
|
|
UserName: "externalUsername_multi",
|
|
},
|
|
{
|
|
IdpId: orgIdpID,
|
|
UserId: "external_multi",
|
|
UserName: "externalUsername_multi",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
retryDuration := time.Minute
|
|
if ctxDeadline, ok := CTX.Deadline(); ok {
|
|
retryDuration = time.Until(ctxDeadline)
|
|
}
|
|
require.EventuallyWithT(t, func(ttt *assert.CollectT) {
|
|
got, listErr := Client.ListIDPLinks(tt.args.ctx, tt.args.req)
|
|
assertErr := assert.NoError
|
|
if tt.wantErr {
|
|
assertErr = assert.Error
|
|
}
|
|
assertErr(ttt, listErr)
|
|
if listErr != nil {
|
|
return
|
|
}
|
|
// always first check length, otherwise its failed anyway
|
|
assert.Len(ttt, got.Result, len(tt.want.Result))
|
|
for i := range tt.want.Result {
|
|
assert.Contains(ttt, got.Result, tt.want.Result[i])
|
|
}
|
|
integration.AssertListDetails(t, tt.want, got)
|
|
}, retryDuration, time.Millisecond*100, "timeout waiting for expected idplinks result")
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestServer_RemoveIDPLink(t *testing.T) {
|
|
orgResp := Tester.CreateOrganization(IamCTX, fmt.Sprintf("ListIDPLinks%d", time.Now().UnixNano()), fmt.Sprintf("%d@mouse.com", time.Now().UnixNano()))
|
|
|
|
instanceIdpID := Tester.AddGenericOAuthProvider(t, IamCTX)
|
|
userInstanceResp := Tester.CreateHumanUserVerified(IamCTX, orgResp.OrganizationId, fmt.Sprintf("%d@listidplinks.com", time.Now().UnixNano()))
|
|
Tester.CreateUserIDPlink(IamCTX, userInstanceResp.GetUserId(), "external_instance", instanceIdpID, "externalUsername_instance")
|
|
|
|
orgIdpID := Tester.AddOrgGenericOAuthProvider(t, IamCTX, orgResp.OrganizationId)
|
|
userOrgResp := Tester.CreateHumanUserVerified(IamCTX, orgResp.OrganizationId, fmt.Sprintf("%d@listidplinks.com", time.Now().UnixNano()))
|
|
Tester.CreateUserIDPlink(IamCTX, userOrgResp.GetUserId(), "external_org", orgIdpID, "externalUsername_org")
|
|
|
|
userNoLinkResp := Tester.CreateHumanUserVerified(IamCTX, orgResp.OrganizationId, fmt.Sprintf("%d@listidplinks.com", time.Now().UnixNano()))
|
|
|
|
type args struct {
|
|
ctx context.Context
|
|
req *user.RemoveIDPLinkRequest
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
args args
|
|
want *user.RemoveIDPLinkResponse
|
|
wantErr bool
|
|
}{
|
|
{
|
|
name: "remove link, no permission",
|
|
args: args{
|
|
UserCTX,
|
|
&user.RemoveIDPLinkRequest{
|
|
UserId: userOrgResp.GetUserId(),
|
|
IdpId: orgIdpID,
|
|
LinkedUserId: "external_org",
|
|
},
|
|
},
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "remove link, no permission, org",
|
|
args: args{
|
|
CTX,
|
|
&user.RemoveIDPLinkRequest{
|
|
UserId: userOrgResp.GetUserId(),
|
|
IdpId: orgIdpID,
|
|
LinkedUserId: "external_org",
|
|
},
|
|
},
|
|
wantErr: true,
|
|
},
|
|
{
|
|
name: "remove link, org, ok",
|
|
args: args{
|
|
IamCTX,
|
|
&user.RemoveIDPLinkRequest{
|
|
UserId: userOrgResp.GetUserId(),
|
|
IdpId: orgIdpID,
|
|
LinkedUserId: "external_org",
|
|
},
|
|
},
|
|
want: &user.RemoveIDPLinkResponse{
|
|
Details: &object.Details{
|
|
ResourceOwner: orgResp.GetOrganizationId(),
|
|
ChangeDate: timestamppb.Now(),
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "remove link, instance, ok",
|
|
args: args{
|
|
IamCTX,
|
|
&user.RemoveIDPLinkRequest{
|
|
UserId: userInstanceResp.GetUserId(),
|
|
IdpId: instanceIdpID,
|
|
LinkedUserId: "external_instance",
|
|
},
|
|
},
|
|
want: &user.RemoveIDPLinkResponse{
|
|
Details: &object.Details{
|
|
ResourceOwner: orgResp.GetOrganizationId(),
|
|
ChangeDate: timestamppb.Now(),
|
|
},
|
|
},
|
|
},
|
|
{
|
|
name: "remove link, no link, error",
|
|
args: args{
|
|
IamCTX,
|
|
&user.RemoveIDPLinkRequest{
|
|
UserId: userNoLinkResp.GetUserId(),
|
|
},
|
|
},
|
|
wantErr: true,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
got, err := Client.RemoveIDPLink(tt.args.ctx, tt.args.req)
|
|
if tt.wantErr {
|
|
require.Error(t, err)
|
|
} else {
|
|
require.NoError(t, err)
|
|
}
|
|
|
|
integration.AssertDetails(t, tt.want, got)
|
|
})
|
|
}
|
|
}
|