mirror of
https://github.com/zitadel/zitadel.git
synced 2024-12-15 04:18:01 +00:00
64a3bb3149
# Which Problems Are Solved Implement a new API service that allows management of OIDC signing web keys. This allows users to manage rotation of the instance level keys. which are currently managed based on expiry. The API accepts the generation of the following key types and parameters: - RSA keys with 2048, 3072 or 4096 bit in size and: - Signing with SHA-256 (RS256) - Signing with SHA-384 (RS384) - Signing with SHA-512 (RS512) - ECDSA keys with - P256 curve - P384 curve - P512 curve - ED25519 keys # How the Problems Are Solved Keys are serialized for storage using the JSON web key format from the `jose` library. This is the format that will be used by OIDC for signing, verification and publication. Each instance can have a number of key pairs. All existing public keys are meant to be used for token verification and publication the keys endpoint. Keys can be activated and the active private key is meant to sign new tokens. There is always exactly 1 active signing key: 1. When the first key for an instance is generated, it is automatically activated. 2. Activation of the next key automatically deactivates the previously active key. 3. Keys cannot be manually deactivated from the API 4. Active keys cannot be deleted # Additional Changes - Query methods that later will be used by the OIDC package are already implemented. Preparation for #8031 - Fix indentation in french translation for instance event - Move user_schema translations to consistent positions in all translation files # Additional Context - Closes #8030 - Part of #7809 --------- Co-authored-by: Elio Bischof <elio@zitadel.com>
211 lines
5.6 KiB
Go
211 lines
5.6 KiB
Go
package saml
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"time"
|
|
|
|
"github.com/go-jose/go-jose/v4"
|
|
"github.com/zitadel/logging"
|
|
"github.com/zitadel/saml/pkg/provider/key"
|
|
|
|
"github.com/zitadel/zitadel/internal/api/authz"
|
|
"github.com/zitadel/zitadel/internal/crypto"
|
|
"github.com/zitadel/zitadel/internal/eventstore"
|
|
"github.com/zitadel/zitadel/internal/query"
|
|
"github.com/zitadel/zitadel/internal/repository/instance"
|
|
"github.com/zitadel/zitadel/internal/repository/keypair"
|
|
"github.com/zitadel/zitadel/internal/zerrors"
|
|
)
|
|
|
|
const (
|
|
locksTable = "projections.locks"
|
|
signingKey = "signing_key"
|
|
samlUser = "SAML"
|
|
|
|
retryBackoff = 500 * time.Millisecond
|
|
retryCount = 3
|
|
lockDuration = retryCount * retryBackoff * 5
|
|
gracefulPeriod = 10 * time.Minute
|
|
)
|
|
|
|
type CertificateAndKey struct {
|
|
algorithm jose.SignatureAlgorithm
|
|
id string
|
|
key interface{}
|
|
certificate interface{}
|
|
}
|
|
|
|
func (c *CertificateAndKey) SignatureAlgorithm() jose.SignatureAlgorithm {
|
|
return c.algorithm
|
|
}
|
|
|
|
func (c *CertificateAndKey) Key() interface{} {
|
|
return c.key
|
|
}
|
|
|
|
func (c *CertificateAndKey) Certificate() interface{} {
|
|
return c.certificate
|
|
}
|
|
|
|
func (c *CertificateAndKey) ID() string {
|
|
return c.id
|
|
}
|
|
|
|
func (p *Storage) GetCertificateAndKey(ctx context.Context, usage crypto.KeyUsage) (certAndKey *key.CertificateAndKey, err error) {
|
|
err = retry(func() error {
|
|
certAndKey, err = p.getCertificateAndKey(ctx, usage)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if certAndKey == nil {
|
|
return zerrors.ThrowInternal(err, "SAML-8u01nks", "no certificate found")
|
|
}
|
|
return nil
|
|
})
|
|
return certAndKey, err
|
|
}
|
|
|
|
func (p *Storage) getCertificateAndKey(ctx context.Context, usage crypto.KeyUsage) (*key.CertificateAndKey, error) {
|
|
certs, err := p.query.ActiveCertificates(ctx, time.Now().Add(gracefulPeriod), usage)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if len(certs.Certificates) > 0 {
|
|
return p.certificateToCertificateAndKey(selectCertificate(certs.Certificates))
|
|
}
|
|
|
|
var position float64
|
|
if certs.State != nil {
|
|
position = certs.State.Position
|
|
}
|
|
|
|
return nil, p.refreshCertificate(ctx, usage, position)
|
|
}
|
|
|
|
func (p *Storage) refreshCertificate(
|
|
ctx context.Context,
|
|
usage crypto.KeyUsage,
|
|
position float64,
|
|
) error {
|
|
ok, err := p.ensureIsLatestCertificate(ctx, position)
|
|
if err != nil {
|
|
logging.WithError(err).Error("could not ensure latest key")
|
|
return err
|
|
}
|
|
if !ok {
|
|
logging.Warn("view not up to date, retrying later")
|
|
return err
|
|
}
|
|
err = p.lockAndGenerateCertificateAndKey(ctx, usage)
|
|
logging.OnError(err).Warn("could not create signing key")
|
|
return nil
|
|
}
|
|
|
|
func (p *Storage) ensureIsLatestCertificate(ctx context.Context, position float64) (bool, error) {
|
|
maxSequence, err := p.getMaxKeySequence(ctx)
|
|
if err != nil {
|
|
return false, fmt.Errorf("error retrieving new events: %w", err)
|
|
}
|
|
return position >= maxSequence, nil
|
|
}
|
|
|
|
func (p *Storage) lockAndGenerateCertificateAndKey(ctx context.Context, usage crypto.KeyUsage) error {
|
|
ctx, cancel := context.WithCancel(ctx)
|
|
defer cancel()
|
|
ctx = setSAMLCtx(ctx)
|
|
|
|
errs := p.locker.Lock(ctx, lockDuration, authz.GetInstance(ctx).InstanceID())
|
|
err, ok := <-errs
|
|
if err != nil || !ok {
|
|
if zerrors.IsErrorAlreadyExists(err) {
|
|
return nil
|
|
}
|
|
logging.OnError(err).Debug("initial lock failed")
|
|
return err
|
|
}
|
|
|
|
switch usage {
|
|
case crypto.KeyUsageSAMLMetadataSigning, crypto.KeyUsageSAMLResponseSinging:
|
|
certAndKey, err := p.GetCertificateAndKey(ctx, crypto.KeyUsageSAMLCA)
|
|
if err != nil {
|
|
return fmt.Errorf("error while reading ca certificate: %w", err)
|
|
}
|
|
if certAndKey.Key == nil || certAndKey.Certificate == nil {
|
|
return fmt.Errorf("has no ca certificate")
|
|
}
|
|
|
|
switch usage {
|
|
case crypto.KeyUsageSAMLMetadataSigning:
|
|
return p.command.GenerateSAMLMetadataCertificate(setSAMLCtx(ctx), p.certificateAlgorithm, certAndKey.Key, certAndKey.Certificate)
|
|
case crypto.KeyUsageSAMLResponseSinging:
|
|
return p.command.GenerateSAMLResponseCertificate(setSAMLCtx(ctx), p.certificateAlgorithm, certAndKey.Key, certAndKey.Certificate)
|
|
default:
|
|
return fmt.Errorf("unknown usage")
|
|
}
|
|
case crypto.KeyUsageSAMLCA:
|
|
return p.command.GenerateSAMLCACertificate(setSAMLCtx(ctx), p.certificateAlgorithm)
|
|
default:
|
|
return fmt.Errorf("unknown certificate usage")
|
|
}
|
|
}
|
|
|
|
func (p *Storage) getMaxKeySequence(ctx context.Context) (float64, error) {
|
|
return p.eventstore.LatestSequence(ctx,
|
|
eventstore.NewSearchQueryBuilder(eventstore.ColumnsMaxSequence).
|
|
ResourceOwner(authz.GetInstance(ctx).InstanceID()).
|
|
AwaitOpenTransactions().
|
|
AddQuery().
|
|
AggregateTypes(keypair.AggregateType).
|
|
EventTypes(
|
|
keypair.AddedEventType,
|
|
keypair.AddedCertificateEventType,
|
|
).
|
|
Or().
|
|
AggregateTypes(instance.AggregateType).
|
|
EventTypes(instance.InstanceRemovedEventType).
|
|
Builder(),
|
|
)
|
|
}
|
|
|
|
func (p *Storage) certificateToCertificateAndKey(certificate query.Certificate) (_ *key.CertificateAndKey, err error) {
|
|
keyData, err := crypto.Decrypt(certificate.Key(), p.encAlg)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
privateKey, err := crypto.BytesToPrivateKey(keyData)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
cert, err := crypto.BytesToCertificate(certificate.Certificate())
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return &key.CertificateAndKey{
|
|
Key: privateKey,
|
|
Certificate: cert,
|
|
}, nil
|
|
}
|
|
|
|
func selectCertificate(certs []query.Certificate) query.Certificate {
|
|
return certs[len(certs)-1]
|
|
}
|
|
|
|
func setSAMLCtx(ctx context.Context) context.Context {
|
|
return authz.SetCtxData(ctx, authz.CtxData{UserID: samlUser, OrgID: authz.GetInstance(ctx).InstanceID()})
|
|
}
|
|
|
|
func retry(retryable func() error) (err error) {
|
|
for i := 0; i < retryCount; i++ {
|
|
err = retryable()
|
|
if err == nil {
|
|
return nil
|
|
}
|
|
time.Sleep(retryBackoff)
|
|
}
|
|
return err
|
|
}
|