Stefan Benz 85e3b7449c
fix: correct permissions for projects on v2 api (#9973)
# Which Problems Are Solved

Permission checks in project v2beta API did not cover projects and
granted projects correctly.

# How the Problems Are Solved

Add permission checks v1 correctly to the list queries, add correct
permission checks v2 for projects.

# Additional Changes

Correct Pre-Checks for project grants that the right resource owner is
used.

# Additional Context

Permission checks v2 for project grants is still outstanding under
#9972.
2025-06-04 11:46:10 +00:00

1079 lines
31 KiB
Go

//go:build integration
package project_test
import (
"context"
"testing"
"time"
"github.com/brianvoe/gofakeit/v6"
"github.com/muhlemmer/gu"
"github.com/stretchr/testify/assert"
"github.com/zitadel/zitadel/internal/integration"
project "github.com/zitadel/zitadel/pkg/grpc/project/v2beta"
)
func TestServer_CreateProject(t *testing.T) {
iamOwnerCtx := instance.WithAuthorization(CTX, integration.UserTypeIAMOwner)
orgResp := instance.CreateOrganization(iamOwnerCtx, gofakeit.AppName(), gofakeit.Email())
alreadyExistingProjectName := gofakeit.AppName()
instance.CreateProject(iamOwnerCtx, t, orgResp.GetOrganizationId(), alreadyExistingProjectName, false, false)
type want struct {
id bool
creationDate bool
}
tests := []struct {
name string
ctx context.Context
req *project.CreateProjectRequest
want
wantErr bool
}{
{
name: "empty name",
ctx: iamOwnerCtx,
req: &project.CreateProjectRequest{
Name: "",
},
wantErr: true,
},
{
name: "empty organization",
ctx: iamOwnerCtx,
req: &project.CreateProjectRequest{
Name: gofakeit.Name(),
OrganizationId: "",
},
wantErr: true,
},
{
name: "already existing, error",
ctx: iamOwnerCtx,
req: &project.CreateProjectRequest{
Name: alreadyExistingProjectName,
OrganizationId: orgResp.GetOrganizationId(),
},
wantErr: true,
},
{
name: "empty, ok",
ctx: iamOwnerCtx,
req: &project.CreateProjectRequest{
Name: gofakeit.Name(),
OrganizationId: orgResp.GetOrganizationId(),
},
want: want{
id: true,
creationDate: true,
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
creationDate := time.Now().UTC()
got, err := instance.Client.Projectv2Beta.CreateProject(tt.ctx, tt.req)
changeDate := time.Now().UTC()
if tt.wantErr {
assert.Error(t, err)
return
}
assert.NoError(t, err)
assertCreateProjectResponse(t, creationDate, changeDate, tt.want.creationDate, tt.want.id, got)
})
}
}
func TestServer_CreateProject_Permission(t *testing.T) {
iamOwnerCtx := instance.WithAuthorization(CTX, integration.UserTypeIAMOwner)
orgResp := instance.CreateOrganization(iamOwnerCtx, gofakeit.AppName(), gofakeit.Email())
type want struct {
id bool
creationDate bool
}
tests := []struct {
name string
ctx context.Context
req *project.CreateProjectRequest
want
wantErr bool
}{
{
name: "unauthenticated",
ctx: CTX,
req: &project.CreateProjectRequest{
Name: gofakeit.Name(),
OrganizationId: orgResp.GetOrganizationId(),
},
wantErr: true,
},
{
name: "missing permission",
ctx: instance.WithAuthorization(CTX, integration.UserTypeNoPermission),
req: &project.CreateProjectRequest{
Name: gofakeit.Name(),
OrganizationId: orgResp.GetOrganizationId(),
},
wantErr: true,
},
{
name: "missing permission, other organization",
ctx: instance.WithAuthorization(CTX, integration.UserTypeOrgOwner),
req: &project.CreateProjectRequest{
Name: gofakeit.Name(),
OrganizationId: orgResp.GetOrganizationId(),
},
wantErr: true,
},
{
name: "organization owner, ok",
ctx: instance.WithAuthorization(CTX, integration.UserTypeOrgOwner),
req: &project.CreateProjectRequest{
Name: gofakeit.Name(),
OrganizationId: instance.DefaultOrg.GetId(),
},
want: want{
id: true,
creationDate: true,
},
},
{
name: "instance owner, ok",
ctx: iamOwnerCtx,
req: &project.CreateProjectRequest{
Name: gofakeit.Name(),
OrganizationId: orgResp.GetOrganizationId(),
},
want: want{
id: true,
creationDate: true,
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
creationDate := time.Now().UTC()
got, err := instance.Client.Projectv2Beta.CreateProject(tt.ctx, tt.req)
changeDate := time.Now().UTC()
if tt.wantErr {
assert.Error(t, err)
return
}
assert.NoError(t, err)
assertCreateProjectResponse(t, creationDate, changeDate, tt.want.creationDate, tt.want.id, got)
})
}
}
func assertCreateProjectResponse(t *testing.T, creationDate, changeDate time.Time, expectedCreationDate, expectedID bool, actualResp *project.CreateProjectResponse) {
if expectedCreationDate {
if !changeDate.IsZero() {
assert.WithinRange(t, actualResp.GetCreationDate().AsTime(), creationDate, changeDate)
} else {
assert.WithinRange(t, actualResp.GetCreationDate().AsTime(), creationDate, time.Now().UTC())
}
} else {
assert.Nil(t, actualResp.CreationDate)
}
if expectedID {
assert.NotEmpty(t, actualResp.GetId())
} else {
assert.Nil(t, actualResp.Id)
}
}
func TestServer_UpdateProject(t *testing.T) {
iamOwnerCtx := instance.WithAuthorization(CTX, integration.UserTypeIAMOwner)
orgResp := instance.CreateOrganization(iamOwnerCtx, gofakeit.AppName(), gofakeit.Email())
type args struct {
ctx context.Context
req *project.UpdateProjectRequest
}
type want struct {
change bool
changeDate bool
}
tests := []struct {
name string
prepare func(request *project.UpdateProjectRequest)
args args
want want
wantErr bool
}{
{
name: "not existing",
prepare: func(request *project.UpdateProjectRequest) {
request.Id = "notexisting"
return
},
args: args{
ctx: iamOwnerCtx,
req: &project.UpdateProjectRequest{
Name: gu.Ptr(gofakeit.Name()),
},
},
wantErr: true,
},
{
name: "no change, ok",
prepare: func(request *project.UpdateProjectRequest) {
name := gofakeit.AppName()
projectID := instance.CreateProject(iamOwnerCtx, t, orgResp.GetOrganizationId(), name, false, false).GetId()
request.Id = projectID
request.Name = gu.Ptr(name)
},
args: args{
ctx: iamOwnerCtx,
req: &project.UpdateProjectRequest{},
},
want: want{
change: false,
changeDate: true,
},
},
{
name: "change name, ok",
prepare: func(request *project.UpdateProjectRequest) {
projectID := instance.CreateProject(iamOwnerCtx, t, orgResp.GetOrganizationId(), gofakeit.AppName(), false, false).GetId()
request.Id = projectID
},
args: args{
ctx: iamOwnerCtx,
req: &project.UpdateProjectRequest{
Name: gu.Ptr(gofakeit.AppName()),
},
},
want: want{
change: true,
changeDate: true,
},
},
{
name: "change full, ok",
prepare: func(request *project.UpdateProjectRequest) {
projectID := instance.CreateProject(iamOwnerCtx, t, orgResp.GetOrganizationId(), gofakeit.AppName(), false, false).GetId()
request.Id = projectID
},
args: args{
ctx: iamOwnerCtx,
req: &project.UpdateProjectRequest{
Name: gu.Ptr(gofakeit.AppName()),
ProjectRoleAssertion: gu.Ptr(true),
ProjectRoleCheck: gu.Ptr(true),
HasProjectCheck: gu.Ptr(true),
PrivateLabelingSetting: gu.Ptr(project.PrivateLabelingSetting_PRIVATE_LABELING_SETTING_ALLOW_LOGIN_USER_RESOURCE_OWNER_POLICY),
},
},
want: want{
change: true,
changeDate: true,
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
creationDate := time.Now().UTC()
tt.prepare(tt.args.req)
got, err := instance.Client.Projectv2Beta.UpdateProject(tt.args.ctx, tt.args.req)
if tt.wantErr {
assert.Error(t, err)
return
}
changeDate := time.Time{}
if tt.want.change {
changeDate = time.Now().UTC()
}
assert.NoError(t, err)
assertUpdateProjectResponse(t, creationDate, changeDate, tt.want.changeDate, got)
})
}
}
func TestServer_UpdateProject_Permission(t *testing.T) {
iamOwnerCtx := instance.WithAuthorization(CTX, integration.UserTypeIAMOwner)
orgResp := instance.CreateOrganization(iamOwnerCtx, gofakeit.AppName(), gofakeit.Email())
userResp := instance.CreateMachineUser(iamOwnerCtx)
patResp := instance.CreatePersonalAccessToken(iamOwnerCtx, userResp.GetUserId())
projectID := instance.CreateProject(iamOwnerCtx, t, orgResp.GetOrganizationId(), gofakeit.AppName(), false, false).GetId()
instance.CreateProjectMembership(t, iamOwnerCtx, projectID, userResp.GetUserId())
projectOwnerCtx := integration.WithAuthorizationToken(CTX, patResp.Token)
type args struct {
ctx context.Context
req *project.UpdateProjectRequest
}
type want struct {
change bool
changeDate bool
}
tests := []struct {
name string
prepare func(request *project.UpdateProjectRequest)
args args
want want
wantErr bool
}{
{
name: "unauthenticated",
prepare: func(request *project.UpdateProjectRequest) {
projectResp := instance.CreateProject(iamOwnerCtx, t, orgResp.GetOrganizationId(), gofakeit.AppName(), false, false)
request.Id = projectResp.GetId()
},
args: args{
ctx: CTX,
req: &project.UpdateProjectRequest{
Name: gu.Ptr(gofakeit.Name()),
},
},
wantErr: true,
},
{
name: "missing permission",
prepare: func(request *project.UpdateProjectRequest) {
projectResp := instance.CreateProject(iamOwnerCtx, t, orgResp.GetOrganizationId(), gofakeit.AppName(), false, false)
request.Id = projectResp.GetId()
},
args: args{
ctx: instance.WithAuthorization(CTX, integration.UserTypeNoPermission),
req: &project.UpdateProjectRequest{
Name: gu.Ptr(gofakeit.Name()),
},
},
wantErr: true,
},
{
name: "project owner, no permission",
prepare: func(request *project.UpdateProjectRequest) {
projectID := instance.CreateProject(iamOwnerCtx, t, orgResp.GetOrganizationId(), gofakeit.AppName(), false, false).GetId()
request.Id = projectID
},
args: args{
ctx: projectOwnerCtx,
req: &project.UpdateProjectRequest{
Name: gu.Ptr(gofakeit.AppName()),
},
},
wantErr: true,
},
{
name: " roject owner, ok",
prepare: func(request *project.UpdateProjectRequest) {
request.Id = projectID
},
args: args{
ctx: projectOwnerCtx,
req: &project.UpdateProjectRequest{
Name: gu.Ptr(gofakeit.AppName()),
},
},
want: want{
change: true,
changeDate: true,
},
},
{
name: "missing permission, other organization",
prepare: func(request *project.UpdateProjectRequest) {
projectResp := instance.CreateProject(iamOwnerCtx, t, orgResp.GetOrganizationId(), gofakeit.AppName(), false, false)
request.Id = projectResp.GetId()
},
args: args{
ctx: instance.WithAuthorization(CTX, integration.UserTypeOrgOwner),
req: &project.UpdateProjectRequest{
Name: gu.Ptr(gofakeit.Name()),
},
},
wantErr: true,
},
{
name: "organization owner, ok",
prepare: func(request *project.UpdateProjectRequest) {
projectID := instance.CreateProject(iamOwnerCtx, t, instance.DefaultOrg.GetId(), gofakeit.AppName(), false, false).GetId()
request.Id = projectID
},
args: args{
ctx: instance.WithAuthorization(CTX, integration.UserTypeOrgOwner),
req: &project.UpdateProjectRequest{
Name: gu.Ptr(gofakeit.AppName()),
},
},
want: want{
change: true,
changeDate: true,
},
},
{
name: "instance owner, ok",
prepare: func(request *project.UpdateProjectRequest) {
projectID := instance.CreateProject(iamOwnerCtx, t, instance.DefaultOrg.GetId(), gofakeit.AppName(), false, false).GetId()
request.Id = projectID
},
args: args{
ctx: iamOwnerCtx,
req: &project.UpdateProjectRequest{
Name: gu.Ptr(gofakeit.AppName()),
},
},
want: want{
change: true,
changeDate: true,
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
creationDate := time.Now().UTC()
tt.prepare(tt.args.req)
got, err := instance.Client.Projectv2Beta.UpdateProject(tt.args.ctx, tt.args.req)
if tt.wantErr {
assert.Error(t, err)
return
}
changeDate := time.Time{}
if tt.want.change {
changeDate = time.Now().UTC()
}
assert.NoError(t, err)
assertUpdateProjectResponse(t, creationDate, changeDate, tt.want.changeDate, got)
})
}
}
func assertUpdateProjectResponse(t *testing.T, creationDate, changeDate time.Time, expectedChangeDate bool, actualResp *project.UpdateProjectResponse) {
if expectedChangeDate {
if !changeDate.IsZero() {
assert.WithinRange(t, actualResp.GetChangeDate().AsTime(), creationDate, changeDate)
} else {
assert.WithinRange(t, actualResp.GetChangeDate().AsTime(), creationDate, time.Now().UTC())
}
} else {
assert.Nil(t, actualResp.ChangeDate)
}
}
func TestServer_DeleteProject(t *testing.T) {
iamOwnerCtx := instance.WithAuthorization(CTX, integration.UserTypeIAMOwner)
orgResp := instance.CreateOrganization(iamOwnerCtx, gofakeit.AppName(), gofakeit.Email())
tests := []struct {
name string
ctx context.Context
prepare func(request *project.DeleteProjectRequest) (time.Time, time.Time)
req *project.DeleteProjectRequest
wantDeletionDate bool
wantErr bool
}{
{
name: "empty id",
ctx: iamOwnerCtx,
req: &project.DeleteProjectRequest{
Id: "",
},
wantErr: true,
},
{
name: "delete, not existing",
ctx: iamOwnerCtx,
req: &project.DeleteProjectRequest{
Id: "notexisting",
},
wantDeletionDate: false,
},
{
name: "delete",
ctx: iamOwnerCtx,
prepare: func(request *project.DeleteProjectRequest) (time.Time, time.Time) {
creationDate := time.Now().UTC()
projectID := instance.CreateProject(iamOwnerCtx, t, orgResp.GetOrganizationId(), gofakeit.AppName(), false, false).GetId()
request.Id = projectID
return creationDate, time.Time{}
},
req: &project.DeleteProjectRequest{},
wantDeletionDate: true,
},
{
name: "delete, already removed",
ctx: iamOwnerCtx,
prepare: func(request *project.DeleteProjectRequest) (time.Time, time.Time) {
creationDate := time.Now().UTC()
projectID := instance.CreateProject(iamOwnerCtx, t, orgResp.GetOrganizationId(), gofakeit.AppName(), false, false).GetId()
request.Id = projectID
instance.DeleteProject(iamOwnerCtx, t, projectID)
return creationDate, time.Now().UTC()
},
req: &project.DeleteProjectRequest{},
wantDeletionDate: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
var creationDate, deletionDate time.Time
if tt.prepare != nil {
creationDate, deletionDate = tt.prepare(tt.req)
}
got, err := instance.Client.Projectv2Beta.DeleteProject(tt.ctx, tt.req)
if tt.wantErr {
assert.Error(t, err)
return
}
assert.NoError(t, err)
assertDeleteProjectResponse(t, creationDate, deletionDate, tt.wantDeletionDate, got)
})
}
}
func TestServer_DeleteProject_Permission(t *testing.T) {
iamOwnerCtx := instance.WithAuthorization(CTX, integration.UserTypeIAMOwner)
orgResp := instance.CreateOrganization(iamOwnerCtx, gofakeit.AppName(), gofakeit.Email())
userResp := instance.CreateMachineUser(iamOwnerCtx)
patResp := instance.CreatePersonalAccessToken(iamOwnerCtx, userResp.GetUserId())
projectID := instance.CreateProject(iamOwnerCtx, t, orgResp.GetOrganizationId(), gofakeit.AppName(), false, false).GetId()
instance.CreateProjectMembership(t, iamOwnerCtx, projectID, userResp.GetUserId())
projectOwnerCtx := integration.WithAuthorizationToken(CTX, patResp.Token)
tests := []struct {
name string
ctx context.Context
prepare func(request *project.DeleteProjectRequest) (time.Time, time.Time)
req *project.DeleteProjectRequest
wantDeletionDate bool
wantErr bool
}{
{
name: "unauthenticated",
ctx: CTX,
prepare: func(request *project.DeleteProjectRequest) (time.Time, time.Time) {
creationDate := time.Now().UTC()
projectID := instance.CreateProject(iamOwnerCtx, t, orgResp.GetOrganizationId(), gofakeit.AppName(), false, false).GetId()
request.Id = projectID
return creationDate, time.Time{}
},
req: &project.DeleteProjectRequest{},
wantErr: true,
},
{
name: "missing permission",
ctx: instance.WithAuthorization(CTX, integration.UserTypeNoPermission),
prepare: func(request *project.DeleteProjectRequest) (time.Time, time.Time) {
creationDate := time.Now().UTC()
projectID := instance.CreateProject(iamOwnerCtx, t, orgResp.GetOrganizationId(), gofakeit.AppName(), false, false).GetId()
request.Id = projectID
return creationDate, time.Time{}
},
req: &project.DeleteProjectRequest{},
wantErr: true,
},
{
name: "project owner, no permission",
ctx: projectOwnerCtx,
prepare: func(request *project.DeleteProjectRequest) (time.Time, time.Time) {
creationDate := time.Now().UTC()
projectID := instance.CreateProject(iamOwnerCtx, t, orgResp.GetOrganizationId(), gofakeit.AppName(), false, false).GetId()
request.Id = projectID
return creationDate, time.Time{}
},
req: &project.DeleteProjectRequest{},
wantErr: true,
},
{
name: "project owner, ok",
ctx: projectOwnerCtx,
prepare: func(request *project.DeleteProjectRequest) (time.Time, time.Time) {
creationDate := time.Now().UTC()
request.Id = projectID
return creationDate, time.Time{}
},
req: &project.DeleteProjectRequest{},
wantDeletionDate: true,
},
{
name: "organization owner, other org",
ctx: instance.WithAuthorization(CTX, integration.UserTypeOrgOwner),
prepare: func(request *project.DeleteProjectRequest) (time.Time, time.Time) {
creationDate := time.Now().UTC()
projectID := instance.CreateProject(iamOwnerCtx, t, orgResp.GetOrganizationId(), gofakeit.AppName(), false, false).GetId()
request.Id = projectID
return creationDate, time.Time{}
},
req: &project.DeleteProjectRequest{},
wantErr: true,
},
{
name: "organization owner",
ctx: instance.WithAuthorization(CTX, integration.UserTypeOrgOwner),
prepare: func(request *project.DeleteProjectRequest) (time.Time, time.Time) {
creationDate := time.Now().UTC()
projectID := instance.CreateProject(iamOwnerCtx, t, instance.DefaultOrg.GetId(), gofakeit.AppName(), false, false).GetId()
request.Id = projectID
return creationDate, time.Time{}
},
req: &project.DeleteProjectRequest{},
wantDeletionDate: true,
},
{
name: "instance owner",
ctx: iamOwnerCtx,
prepare: func(request *project.DeleteProjectRequest) (time.Time, time.Time) {
creationDate := time.Now().UTC()
projectID := instance.CreateProject(iamOwnerCtx, t, instance.DefaultOrg.GetId(), gofakeit.AppName(), false, false).GetId()
request.Id = projectID
return creationDate, time.Time{}
},
req: &project.DeleteProjectRequest{},
wantDeletionDate: true,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
var creationDate, deletionDate time.Time
if tt.prepare != nil {
creationDate, deletionDate = tt.prepare(tt.req)
}
got, err := instance.Client.Projectv2Beta.DeleteProject(tt.ctx, tt.req)
if tt.wantErr {
assert.Error(t, err)
return
}
assert.NoError(t, err)
assertDeleteProjectResponse(t, creationDate, deletionDate, tt.wantDeletionDate, got)
})
}
}
func assertDeleteProjectResponse(t *testing.T, creationDate, deletionDate time.Time, expectedDeletionDate bool, actualResp *project.DeleteProjectResponse) {
if expectedDeletionDate {
if !deletionDate.IsZero() {
assert.WithinRange(t, actualResp.GetDeletionDate().AsTime(), creationDate, deletionDate)
} else {
assert.WithinRange(t, actualResp.GetDeletionDate().AsTime(), creationDate, time.Now().UTC())
}
} else {
assert.Nil(t, actualResp.DeletionDate)
}
}
func TestServer_DeactivateProject(t *testing.T) {
iamOwnerCtx := instance.WithAuthorization(CTX, integration.UserTypeIAMOwner)
orgResp := instance.CreateOrganization(iamOwnerCtx, gofakeit.AppName(), gofakeit.Email())
type args struct {
ctx context.Context
req *project.DeactivateProjectRequest
}
type want struct {
change bool
changeDate bool
}
tests := []struct {
name string
prepare func(request *project.DeactivateProjectRequest)
args args
want want
wantErr bool
}{
{
name: "not existing",
prepare: func(request *project.DeactivateProjectRequest) {
request.Id = "notexisting"
return
},
args: args{
ctx: iamOwnerCtx,
req: &project.DeactivateProjectRequest{},
},
wantErr: true,
},
{
name: "no change, ok",
prepare: func(request *project.DeactivateProjectRequest) {
name := gofakeit.AppName()
projectID := instance.CreateProject(iamOwnerCtx, t, orgResp.GetOrganizationId(), name, false, false).GetId()
request.Id = projectID
instance.DeactivateProject(iamOwnerCtx, t, projectID)
},
args: args{
ctx: iamOwnerCtx,
req: &project.DeactivateProjectRequest{},
},
wantErr: true,
},
{
name: "change, ok",
prepare: func(request *project.DeactivateProjectRequest) {
projectID := instance.CreateProject(iamOwnerCtx, t, orgResp.GetOrganizationId(), gofakeit.AppName(), false, false).GetId()
request.Id = projectID
},
args: args{
ctx: iamOwnerCtx,
req: &project.DeactivateProjectRequest{},
},
want: want{
change: true,
changeDate: true,
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
creationDate := time.Now().UTC()
tt.prepare(tt.args.req)
got, err := instance.Client.Projectv2Beta.DeactivateProject(tt.args.ctx, tt.args.req)
if tt.wantErr {
assert.Error(t, err)
return
}
changeDate := time.Time{}
if tt.want.change {
changeDate = time.Now().UTC()
}
assert.NoError(t, err)
assertDeactivateProjectResponse(t, creationDate, changeDate, tt.want.changeDate, got)
})
}
}
func TestServer_DeactivateProject_Permission(t *testing.T) {
iamOwnerCtx := instance.WithAuthorization(CTX, integration.UserTypeIAMOwner)
orgResp := instance.CreateOrganization(iamOwnerCtx, gofakeit.AppName(), gofakeit.Email())
type args struct {
ctx context.Context
req *project.DeactivateProjectRequest
}
type want struct {
change bool
changeDate bool
}
tests := []struct {
name string
prepare func(request *project.DeactivateProjectRequest)
args args
want want
wantErr bool
}{
{
name: "unauthenticated",
prepare: func(request *project.DeactivateProjectRequest) {
projectResp := instance.CreateProject(iamOwnerCtx, t, orgResp.GetOrganizationId(), gofakeit.AppName(), false, false)
request.Id = projectResp.GetId()
},
args: args{
ctx: CTX,
req: &project.DeactivateProjectRequest{},
},
wantErr: true,
},
{
name: "missing permission",
prepare: func(request *project.DeactivateProjectRequest) {
projectResp := instance.CreateProject(iamOwnerCtx, t, orgResp.GetOrganizationId(), gofakeit.AppName(), false, false)
request.Id = projectResp.GetId()
},
args: args{
ctx: instance.WithAuthorization(CTX, integration.UserTypeNoPermission),
req: &project.DeactivateProjectRequest{},
},
wantErr: true,
},
{
name: "organization owner, other org",
prepare: func(request *project.DeactivateProjectRequest) {
projectResp := instance.CreateProject(iamOwnerCtx, t, orgResp.GetOrganizationId(), gofakeit.AppName(), false, false)
request.Id = projectResp.GetId()
},
args: args{
ctx: instance.WithAuthorization(CTX, integration.UserTypeOrgOwner),
req: &project.DeactivateProjectRequest{},
},
wantErr: true,
},
{
name: "organization owner",
prepare: func(request *project.DeactivateProjectRequest) {
projectResp := instance.CreateProject(iamOwnerCtx, t, instance.DefaultOrg.GetId(), gofakeit.AppName(), false, false)
request.Id = projectResp.GetId()
},
args: args{
ctx: instance.WithAuthorization(CTX, integration.UserTypeOrgOwner),
req: &project.DeactivateProjectRequest{},
},
want: want{
change: true,
changeDate: true,
},
},
{
name: "instance owner",
prepare: func(request *project.DeactivateProjectRequest) {
projectResp := instance.CreateProject(iamOwnerCtx, t, orgResp.GetOrganizationId(), gofakeit.AppName(), false, false)
request.Id = projectResp.GetId()
},
args: args{
ctx: iamOwnerCtx,
req: &project.DeactivateProjectRequest{},
},
want: want{
change: true,
changeDate: true,
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
creationDate := time.Now().UTC()
tt.prepare(tt.args.req)
got, err := instance.Client.Projectv2Beta.DeactivateProject(tt.args.ctx, tt.args.req)
if tt.wantErr {
assert.Error(t, err)
return
}
changeDate := time.Time{}
if tt.want.change {
changeDate = time.Now().UTC()
}
assert.NoError(t, err)
assertDeactivateProjectResponse(t, creationDate, changeDate, tt.want.changeDate, got)
})
}
}
func assertDeactivateProjectResponse(t *testing.T, creationDate, changeDate time.Time, expectedChangeDate bool, actualResp *project.DeactivateProjectResponse) {
if expectedChangeDate {
if !changeDate.IsZero() {
assert.WithinRange(t, actualResp.GetChangeDate().AsTime(), creationDate, changeDate)
} else {
assert.WithinRange(t, actualResp.GetChangeDate().AsTime(), creationDate, time.Now().UTC())
}
} else {
assert.Nil(t, actualResp.ChangeDate)
}
}
func TestServer_ActivateProject(t *testing.T) {
iamOwnerCtx := instance.WithAuthorization(CTX, integration.UserTypeIAMOwner)
orgResp := instance.CreateOrganization(iamOwnerCtx, gofakeit.AppName(), gofakeit.Email())
type args struct {
ctx context.Context
req *project.ActivateProjectRequest
}
type want struct {
change bool
changeDate bool
}
tests := []struct {
name string
prepare func(request *project.ActivateProjectRequest)
args args
want want
wantErr bool
}{
{
name: "missing permission",
prepare: func(request *project.ActivateProjectRequest) {
projectResp := instance.CreateProject(iamOwnerCtx, t, orgResp.GetOrganizationId(), gofakeit.AppName(), false, false)
request.Id = projectResp.GetId()
},
args: args{
ctx: instance.WithAuthorization(CTX, integration.UserTypeNoPermission),
req: &project.ActivateProjectRequest{},
},
wantErr: true,
},
{
name: "not existing",
prepare: func(request *project.ActivateProjectRequest) {
request.Id = "notexisting"
return
},
args: args{
ctx: iamOwnerCtx,
req: &project.ActivateProjectRequest{},
},
wantErr: true,
},
{
name: "no change, ok",
prepare: func(request *project.ActivateProjectRequest) {
name := gofakeit.AppName()
projectID := instance.CreateProject(iamOwnerCtx, t, orgResp.GetOrganizationId(), name, false, false).GetId()
request.Id = projectID
},
args: args{
ctx: iamOwnerCtx,
req: &project.ActivateProjectRequest{},
},
wantErr: true,
},
{
name: "change, ok",
prepare: func(request *project.ActivateProjectRequest) {
projectID := instance.CreateProject(iamOwnerCtx, t, orgResp.GetOrganizationId(), gofakeit.AppName(), false, false).GetId()
request.Id = projectID
instance.DeactivateProject(iamOwnerCtx, t, projectID)
},
args: args{
ctx: iamOwnerCtx,
req: &project.ActivateProjectRequest{},
},
want: want{
change: true,
changeDate: true,
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
creationDate := time.Now().UTC()
tt.prepare(tt.args.req)
got, err := instance.Client.Projectv2Beta.ActivateProject(tt.args.ctx, tt.args.req)
if tt.wantErr {
assert.Error(t, err)
return
}
changeDate := time.Time{}
if tt.want.change {
changeDate = time.Now().UTC()
}
assert.NoError(t, err)
assertActivateProjectResponse(t, creationDate, changeDate, tt.want.changeDate, got)
})
}
}
func TestServer_ActivateProject_Permission(t *testing.T) {
iamOwnerCtx := instance.WithAuthorization(CTX, integration.UserTypeIAMOwner)
orgResp := instance.CreateOrganization(iamOwnerCtx, gofakeit.AppName(), gofakeit.Email())
type args struct {
ctx context.Context
req *project.ActivateProjectRequest
}
type want struct {
change bool
changeDate bool
}
tests := []struct {
name string
prepare func(request *project.ActivateProjectRequest)
args args
want want
wantErr bool
}{
{
name: "unauthenticated",
prepare: func(request *project.ActivateProjectRequest) {
projectResp := instance.CreateProject(iamOwnerCtx, t, orgResp.GetOrganizationId(), gofakeit.AppName(), false, false)
request.Id = projectResp.GetId()
instance.DeactivateProject(iamOwnerCtx, t, projectResp.GetId())
},
args: args{
ctx: CTX,
req: &project.ActivateProjectRequest{},
},
wantErr: true,
},
{
name: "missing permission",
prepare: func(request *project.ActivateProjectRequest) {
projectResp := instance.CreateProject(iamOwnerCtx, t, orgResp.GetOrganizationId(), gofakeit.AppName(), false, false)
request.Id = projectResp.GetId()
instance.DeactivateProject(iamOwnerCtx, t, projectResp.GetId())
},
args: args{
ctx: instance.WithAuthorization(CTX, integration.UserTypeNoPermission),
req: &project.ActivateProjectRequest{},
},
wantErr: true,
},
{
name: "organization owner, other org",
prepare: func(request *project.ActivateProjectRequest) {
projectResp := instance.CreateProject(iamOwnerCtx, t, orgResp.GetOrganizationId(), gofakeit.AppName(), false, false)
request.Id = projectResp.GetId()
instance.DeactivateProject(iamOwnerCtx, t, projectResp.GetId())
},
args: args{
ctx: instance.WithAuthorization(CTX, integration.UserTypeOrgOwner),
req: &project.ActivateProjectRequest{},
},
wantErr: true,
},
{
name: "organization owner",
prepare: func(request *project.ActivateProjectRequest) {
projectResp := instance.CreateProject(iamOwnerCtx, t, instance.DefaultOrg.GetId(), gofakeit.AppName(), false, false)
request.Id = projectResp.GetId()
instance.DeactivateProject(iamOwnerCtx, t, projectResp.GetId())
},
args: args{
ctx: instance.WithAuthorization(CTX, integration.UserTypeOrgOwner),
req: &project.ActivateProjectRequest{},
},
want: want{
change: true,
changeDate: true,
},
},
{
name: "instance owner",
prepare: func(request *project.ActivateProjectRequest) {
projectResp := instance.CreateProject(iamOwnerCtx, t, orgResp.GetOrganizationId(), gofakeit.AppName(), false, false)
request.Id = projectResp.GetId()
instance.DeactivateProject(iamOwnerCtx, t, projectResp.GetId())
},
args: args{
ctx: iamOwnerCtx,
req: &project.ActivateProjectRequest{},
},
want: want{
change: true,
changeDate: true,
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
creationDate := time.Now().UTC()
tt.prepare(tt.args.req)
got, err := instance.Client.Projectv2Beta.ActivateProject(tt.args.ctx, tt.args.req)
if tt.wantErr {
assert.Error(t, err)
return
}
changeDate := time.Time{}
if tt.want.change {
changeDate = time.Now().UTC()
}
assert.NoError(t, err)
assertActivateProjectResponse(t, creationDate, changeDate, tt.want.changeDate, got)
})
}
}
func assertActivateProjectResponse(t *testing.T, creationDate, changeDate time.Time, expectedChangeDate bool, actualResp *project.ActivateProjectResponse) {
if expectedChangeDate {
if !changeDate.IsZero() {
assert.WithinRange(t, actualResp.GetChangeDate().AsTime(), creationDate, changeDate)
} else {
assert.WithinRange(t, actualResp.GetChangeDate().AsTime(), creationDate, time.Now().UTC())
}
} else {
assert.Nil(t, actualResp.ChangeDate)
}
}