mirror of
https://github.com/zitadel/zitadel.git
synced 2024-12-13 19:44:21 +00:00
ffe9570776
# Which Problems Are Solved
There are multiple issues with the metadata and error handling of SAML:
- When providing a SAML metadata for an IdP, which cannot be processed,
the error will only be noticed once a user tries to use the IdP.
- Parsing for metadata with any other encoding than UTF-8 fails.
- Metadata containing an enclosing EntitiesDescriptor around
EntityDescriptor cannot be parsed.
- Metadata's `validUntil` value is always set to 48 hours, which causes
issues on external providers, if processed from a manual down/upload.
- If a SAML response cannot be parsed, only a generic "Authentication
failed" error is returned, the cause is hidden to the user and also to
actions.
# How the Problems Are Solved
- Return parsing errors after create / update and retrieval of an IdP in
the API.
- Prevent the creation and update of an IdP in case of a parsing
failure.
- Added decoders for encodings other than UTF-8 (including ASCII,
windows and ISO, [currently
supported](
|
||
|---|---|---|
| .. | ||
| action | ||
| admin | ||
| auth | ||
| authn | ||
| change | ||
| client/middleware | ||
| event | ||
| feature | ||
| gerrors | ||
| idp | ||
| instance | ||
| management | ||
| member | ||
| metadata | ||
| object | ||
| oidc | ||
| org | ||
| policy | ||
| project | ||
| resources | ||
| server | ||
| session | ||
| settings | ||
| system | ||
| text | ||
| user | ||
| config.go | ||
| fields.go | ||
| header_test.go | ||
| header.go | ||
| probes_test.go | ||
| probes.go | ||