mirror of
https://github.com/oxen-io/session-android.git
synced 2024-12-28 02:37:46 +00:00
21 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Fanchao Liu
|
67bcc937ce |
Strings work
Squashed commit of the following:
commit 86cab0e11e4871ec2258c2099d8634a91a2f9bea
Author: ThomasSession <thomas.r@getsession.org>
Date: Fri Aug 30 10:17:04 2024 +1000
Bringing my xml dialog styling from my 'Standardise message deletion' branch
commit 706d1aadd833f6fa60de8ac308c62919adf45dc4
Author: ThomasSession <thomas.r@getsession.org>
Date: Fri Aug 30 09:49:48 2024 +1000
fixing up clear data dialog
Removing unused code
commit f90599451f9660e4a64964481eacdf65070dc092
Author: Al Lansley <al@oxen.io>
Date: Fri Aug 30 09:13:51 2024 +1000
Replaced 'now' with 12/24 hour time
commit 16b8ad46c09515de949f0f47a0ef16f799a7e878
Author: alansley <aclansley@gmail.com>
Date: Thu Aug 29 17:34:03 2024 +1000
Fix two one-liner issues
commit 4c6c450b3218a0c3663ede1773b6dc32989024fc
Merge: 052f910d69 beb89d5b74
Author: ThomasSession <thomas.r@getsession.org>
Date: Thu Aug 29 17:07:16 2024 +1000
Merge branch 'strings-squashed' of https://github.com/oxen-io/session-android into strings-squashed
commit 052f910d69c453f847e5dbad9132a40f3e00126b
Author: ThomasSession <thomas.r@getsession.org>
Date: Thu Aug 29 17:06:53 2024 +1000
More bold fixing
commit beb89d5b74b8a64ffcf9c7ce3d7507a9b83dac9e
Author: fanchao <git@fanchao.dev>
Date: Thu Aug 29 17:00:37 2024 +1000
Fix incorrect group member left message
commit 5773f05a5c461fba8c91bb804be17f0245e6ee79
Merge: d35482daba 1cec477020
Author: ThomasSession <thomas.r@getsession.org>
Date: Thu Aug 29 15:21:44 2024 +1000
Merge branch 'strings-squashed' of https://github.com/oxen-io/session-android into strings-squashed
commit d35482dabaac8ae2da97fb920903a984cec525ca
Author: ThomasSession <thomas.r@getsession.org>
Date: Thu Aug 29 15:20:13 2024 +1000
More bold fixes and UI tweaks
commit 78a9ab7159218005f5bca91b35583e4daa608e2d
Author: ThomasSession <thomas.r@getsession.org>
Date: Thu Aug 29 14:03:41 2024 +1000
Making sure we bold appropriately
commit 1cec4770203a61547356009e42bf80e65fe17410
Author: alansley <aclansley@gmail.com>
Date: Thu Aug 29 13:33:50 2024 +1000
Made call to 'getQuantityString' pass the count twice because otherwise it doesn't work correctly
commit 8e80ab08a926c772f620089aeb8c7710a203af2d
Author: ThomasSession <thomas.r@getsession.org>
Date: Thu Aug 29 13:28:54 2024 +1000
Using the existing implementation
commit cb9554ab386af1d01177940cac10283be2944ce2
Author: alansley <aclansley@gmail.com>
Date: Thu Aug 29 12:32:30 2024 +1000
Merge CrowdIn strings circa 2024-08-29
commit dd57da70f64eb622482eea4f3c4a78e233d96d28
Author: alansley <aclansley@gmail.com>
Date: Thu Aug 29 09:06:22 2024 +1000
Updated Phrase usage in ConversationAdapter
commit 34b15d78656a9c82d7952da9d003df686e231f81
Author: alansley <aclansley@gmail.com>
Date: Thu Aug 29 09:03:55 2024 +1000
Converted TransferControlView into Kotlin and updated Phrase usage
commit a35a7a6a96cf68f7b44749f1f3482adac5b1d17e
Author: alansley <aclansley@gmail.com>
Date: Thu Aug 29 08:55:16 2024 +1000
Converted MessageReceipientNotificationBuilder to Kotlin & updated Phrase usage
commit 6dd93b33f222c0818073ff3fff02c312b3b9d2e9
Author: alansley <aclansley@gmail.com>
Date: Thu Aug 29 08:25:24 2024 +1000
Update MuteDialog, LinkPreviewDialog, and PathActivity
commit e7dd1c582d1ceb4bdf132ca068264badc70bccb4
Author: alansley <aclansley@gmail.com>
Date: Thu Aug 29 08:16:09 2024 +1000
Updated DisappearingMessages.kt and HelpSettingsActivity.kt
commit 5bd55ea99320941b8f9b40f0680d6980f8e09dc4
Author: alansley <aclansley@gmail.com>
Date: Thu Aug 29 08:01:30 2024 +1000
Converted SwitchPreferenceCompat to Kotlin and fixed the BlockedDialog using the joinCommunity string for some bizarre reason
commit d3fb440d05b90b6eb30d28dc9cf0524be3275160
Author: alansley <aclansley@gmail.com>
Date: Thu Aug 29 07:15:03 2024 +1000
Removed R.string.gif and replaced with a string constant
commit ace58e3493ec3a5991274ec8d2554ff1eea6cf8e
Author: alansley <aclansley@gmail.com>
Date: Thu Aug 29 07:11:53 2024 +1000
getSubbedString correction
commit 2a8f010369424ff5a7138c9294283478e31c424e
Merge: ce8efd7def 116bef3c71
Author: alansley <aclansley@gmail.com>
Date: Wed Aug 28 16:31:43 2024 +1000
Merge branch 'compose-open-url-dialog' into strings-squashed
commit ce8efd7def0a25515a06fea3b1dabf90cc4909c2
Author: alansley <aclansley@gmail.com>
Date: Wed Aug 28 16:31:11 2024 +1000
WIP
commit 114066ad5f841dfc0e8e68adc29f61abfc804f21
Author: alansley <aclansley@gmail.com>
Date: Wed Aug 28 15:30:02 2024 +1000
Push before changing over all the Phrase.from to extension method calls
commit 116bef3c7110a38b9f8198dbdb85e8bc7eafffed
Author: ThomasSession <thomas.r@getsession.org>
Date: Wed Aug 28 15:25:03 2024 +1000
For safety
commit 0b1a71a5820901a010b633525f56988e8b5095cd
Author: ThomasSession <thomas.r@getsession.org>
Date: Wed Aug 28 15:23:02 2024 +1000
Cleaning other use of old url dialog
commit 20abbebf4ac8bc3a8fd46463f3be621b991c15d1
Author: ThomasSession <thomas.r@getsession.org>
Date: Wed Aug 28 15:19:46 2024 +1000
Forgot !!
commit 25132c6342f11613083b9cd3f7413b775faefc00
Author: ThomasSession <thomas.r@getsession.org>
Date: Wed Aug 28 15:13:58 2024 +1000
Proper set up for the Open URL dialog
commit 1f68791da92287e52c7b1e95256ccb771f77a31b
Author: alansley <aclansley@gmail.com>
Date: Wed Aug 28 14:35:05 2024 +1000
Replaced placeholder text with new string
commit 8d97f31b4d5bf79d7f69887ca871210e431c40e5
Author: alansley <aclansley@gmail.com>
Date: Wed Aug 28 14:31:52 2024 +1000
Adjusted comment
commit dfebe6f3f97c6ea96d2b143291ae5991d7242104
Author: alansley <aclansley@gmail.com>
Date: Wed Aug 28 14:25:23 2024 +1000
Moved block/unblock string selection logic into ViewModel and fixed a comment
commit 736b5313e634c17e1446c0f42f1962ba1fdb0664
Author: alansley <aclansley@gmail.com>
Date: Wed Aug 28 14:02:54 2024 +1000
Changed toast to warning - although condition to trigger should not be possible
commit 413bc0be4b1464efcbe9cda92e47a139a87f6610
Author: alansley <aclansley@gmail.com>
Date: Wed Aug 28 13:55:04 2024 +1000
Adjusted EditGroupMembers to match iOS and fixed up save attachment commentary / logic
commit ae7164ecbb78d2045cb4df9fafdf5ad07eba5365
Merge: 5df981bc7a d1c4283f42
Author: alansley <aclansley@gmail.com>
Date: Wed Aug 28 09:51:58 2024 +1000
Merge branch 'dev' into strings-squashed
commit 2aa58f4dd6c62ec712715a24cf86272c0990a7af
Author: alansley <aclansley@gmail.com>
Date: Wed Aug 28 08:27:03 2024 +1000
WIP compose openURL dialog
commit 5df981bc7ab4736e1a96ef4f585f063189f95740
Author: alansley <aclansley@gmail.com>
Date: Tue Aug 27 15:51:38 2024 +1000
Adjusted NotificationRadioButton that takes string IDs to act as a pass-through
commit 96453f1f1ee9af9b8ddf20c83d52070d65b3d184
Author: alansley <aclansley@gmail.com>
Date: Tue Aug 27 15:42:33 2024 +1000
Added some TODO markers for tomorrow
commit a402a1be79a5e6ddebb65cc5bca2e41310f4f94e
Author: alansley <aclansley@gmail.com>
Date: Tue Aug 27 15:33:55 2024 +1000
Adjusted Landing page string substitutions to cater for emojis
commit 4809b5444b7b3488e58e6b6e96e5d17f77d545b0
Author: alansley <aclansley@gmail.com>
Date: Tue Aug 27 15:12:39 2024 +1000
Removed unused 'isEmpty' utility methods
commit b52048a080ac5c9cf6217d5f519c79aa48c873b6
Author: alansley <aclansley@gmail.com>
Date: Tue Aug 27 14:42:57 2024 +1000
Addressed many aspects of PR feedback + misc. strings issues
commit 9cdbc4b80b80368d42635144bc37b3ee2689f06b
Author: alansley <aclansley@gmail.com>
Date: Tue Aug 27 09:50:51 2024 +1000
Adjusted strings as per Rebecca's 'String Changes' spreadsheet
commit 4d7e4b9e2c6a91e3c362ce5694b31a30ef4f00f8
Merge: 3c576053a3 1393335121
Author: alansley <aclansley@gmail.com>
Date: Tue Aug 27 08:19:53 2024 +1000
Merge branch 'dev' into strings-squashed
commit 3c576053a3e5717b7beeef2286837be4951e355f
Author: alansley <aclansley@gmail.com>
Date: Mon Aug 26 17:11:45 2024 +1000
Moved into libsession for ease of access to control message view creation
commit b908a54a44aa7713a8a51e34d2432b54d6590758
Merge: 404fb8001c bfbe4a8fd2
Author: alansley <aclansley@gmail.com>
Date: Mon Aug 26 11:54:09 2024 +1000
Merge branch 'dev' into strings-squashed
commit 404fb8001cfe84b44bd76decb43dd0fa93040c25
Author: alansley <aclansley@gmail.com>
Date: Mon Aug 26 11:52:41 2024 +1000
Performed a PR pass to fix up anything obvious - there's still a few things left TODO
commit 53978f818dedf9d8b3aea063b7803a3152f9cae7
Author: Al Lansley <al@oxen.io>
Date: Fri Aug 23 14:13:11 2024 +1000
Cleaned up HomeActivityTests.kt
commit 5f82571befba7ec830c60064fefe553aac307cd6
Merge: 69b8bd7396 8deb21c0c6
Author: Al Lansley <al@oxen.io>
Date: Fri Aug 23 08:59:21 2024 +1000
Merge branch 'dev' into strings-squashed
commit 69b8bd739690f51540490d943b06f92ccb0a323a
Author: alansley <aclansley@gmail.com>
Date: Thu Aug 22 16:20:17 2024 +1000
Added back app_name string so app names properly, fixed API 28 save issue, made some buttons display as red if they should
commit e3cab9c0d9aad3c98ead66d8df70b68a0afef56a
Author: alansley <aclansley@gmail.com>
Date: Thu Aug 22 14:26:48 2024 +1000
SS-75 Prevented ScrollView vertical scroll bar from fading out
commit b0b835092dffab3a112f61f203dd9138a9a1c9b1
Author: alansley <aclansley@gmail.com>
Date: Thu Aug 22 14:07:49 2024 +1000
SS-64 Removed all 'Unblocked {name}' toasts as per instructions
commit c3c35de4089ddb16203b69e6391f4a936092c701
Merge: efc2ee2824 8e10e1abf4
Author: alansley <aclansley@gmail.com>
Date: Thu Aug 22 13:43:00 2024 +1000
Merge branch 'dev' into strings-squashed
commit efc2ee2824494169e383978819501d2edaa061d4
Author: alansley <aclansley@gmail.com>
Date: Thu Aug 22 13:40:59 2024 +1000
Added some comments about the new CrowdIn strings
commit 7a03fb37ef34726d268e467d51bfc83905609483
Author: alansley <aclansley@gmail.com>
Date: Thu Aug 22 13:08:03 2024 +1000
Initial integration of CrowdIn strings (English only)
commit 9766c3fd0b9200323584f15fbc004d9bc1b0987f
Author: alansley <aclansley@gmail.com>
Date: Thu Aug 22 09:55:14 2024 +1000
SS-75 Added 'Copied' toast when the user copies a URL in the Open URL dialog
commit 59b4805b8b5420adc64e23c49e381598226022cb
Author: alansley <aclansley@gmail.com>
Date: Thu Aug 22 09:51:01 2024 +1000
SS-75 Prevent 'Are you sure you want to open this URL?' dialog from being excessively tall when given a very long URL
commit b7f627f03c5c41fbcb215a78e54a0450b10295b6
Author: alansley <aclansley@gmail.com>
Date: Wed Aug 21 14:54:17 2024 +1000
Made closed group deleting-someone-elses msgs use 'Delete message' or 'Delete Messages' appropriately
commit 69f6818f99608f4cb2fae8c7e7a132c66f049a33
Author: alansley <aclansley@gmail.com>
Date: Wed Aug 21 13:53:58 2024 +1000
Adjusted SS-64 so that all Block / Unblock buttons now use that text and are displayed in red
commit 2192c2c00757cc07306fdd22f000e8061ddc899a
Merge: 2338bb47ca eea54d1a17
Author: alansley <aclansley@gmail.com>
Date: Wed Aug 21 13:28:16 2024 +1000
Merge branch 'dev' into strings-squashed
commit 2338bb47ca1dea1deb232c86978157a9f01fe44c
Author: alansley <aclansley@gmail.com>
Date: Tue Aug 20 19:11:40 2024 +1000
Converted DefaultMessageNotifier to Kotlin because it needs adjustment & that Java is nasty
commit 6b29e4d8ceae7bd24c56a724e67bcd58f90c5b3b
Author: alansley <aclansley@gmail.com>
Date: Tue Aug 20 17:53:27 2024 +1000
Added a note about the plurals for search results
commit f7748a0c05eb1272a7b281d6910691df2130c3b0
Author: alansley <aclansley@gmail.com>
Date: Tue Aug 20 16:06:24 2024 +1000
Corrected text on storage permission dialog
commit f6b62565989fa78b493c48a8a8efe9b9284c29d9
Author: alansley <aclansley@gmail.com>
Date: Tue Aug 20 14:44:25 2024 +1000
Minor cleanup of BlockedContactsActivity
commit e3d4870d81bd54f2f2373cc5d969ad2c406ddf89
Author: alansley <aclansley@gmail.com>
Date: Tue Aug 20 14:41:14 2024 +1000
Addressed changes to fix SS-64 / QA-146 - unblocking contacts modal & toast adjustments
commit e81252735856fb7e4b0ddf36fd107b2f82f2f194
Merge: 5e02e1ef5c 9919f716a7
Author: alansley <aclansley@gmail.com>
Date: Tue Aug 20 13:27:35 2024 +1000
Merge branch 'dev' into strings-squashed
commit 5e02e1ef5c04056761409c97ba90efc5b447bb6c
Author: alansley <aclansley@gmail.com>
Date: Tue Aug 20 09:39:16 2024 +1000
Added 'NonTranslatableStringConstants' file
commit 816f21bb29e00633285cf084e314f4375eec31dc
Author: alansley <aclansley@gmail.com>
Date: Tue Aug 20 09:30:30 2024 +1000
Addressed commit feedback & removed desktop string 'attachmentsClickToDownload' as we use 'attachmentsTapToDownload'
commit acc8d47c6875893ef9e988440c55f8239fda47d1
Author: Al Lansley <al@oxen.io>
Date: Mon Aug 19 16:22:08 2024 +1000
SES-1571 Large messages show warning toast
commit 27ca77d5c48b097d8e6b397414a09383a4645fc2
Merge: 27bc90bf1f f379604c54
Author: Al Lansley <al@oxen.io>
Date: Mon Aug 19 11:19:27 2024 +1000
Merge branch 'dev' into strings-squashed
commit 27bc90bf1f21ad3cba8c11e6318c51a083736f01
Author: Al Lansley <al@oxen.io>
Date: Mon Aug 19 08:59:38 2024 +1000
Cleaned up some comments and content description
commit 558684a56d9e609030242d411424def9f21b510a
Merge: 90d7064c18 93a28906fb
Author: Al Lansley <al@oxen.io>
Date: Mon Aug 19 08:41:47 2024 +1000
Merge branch 'dev' into strings-squashed
commit 90d7064c18d0d95cbeb1f3fd04831fb8d36e2d0c
Author: Al Lansley <al@oxen.io>
Date: Thu Aug 15 12:13:30 2024 +1000
Fixed issue where new closed groups would display a timestamp instead of the 'groupNoMessages' text
commit 51ef0ec81c8810c42379c863d970754ebc0814b8
Author: Al Lansley <al@oxen.io>
Date: Thu Aug 15 09:45:28 2024 +1000
Replaced string 'CreateProfileActivity_profile_photo' with the string 'photo' which has the same text ('Photo')
commit eecce08c25e560f2d62064f064afabb474c50a16
Merge: 01009cf521 5a248da445
Author: Al Lansley <al@oxen.io>
Date: Thu Aug 15 09:38:10 2024 +1000
Merge branch 'dev' into strings-squashed
commit 01009cf521e4fe8cb94f25beed48cd6e550a5b4a
Author: Al Lansley <al@oxen.io>
Date: Thu Aug 15 08:37:19 2024 +1000
Changed allowed emoji reactions per minute from 5 (which I used for testing) to 20 (production)
commit 9441d1e08daa11d2dce4168e3a2816acb1180dcb
Author: Al Lansley <al@oxen.io>
Date: Thu Aug 15 08:34:16 2024 +1000
Refactored emoji rate limiter to use a timestamp mechanism rather than removing queue items after a delay
commit 6cd6cc3e26b8f30213bb0570434a49a51c08bd6c
Author: alansley <aclansley@gmail.com>
Date: Wed Aug 14 16:48:07 2024 +1000
Adjusted emoji rate limit to 20 reactions per minute to match acceptance criteria
commit edd154d8e1979fc572250601c3f044ba00a3efe0
Author: alansley <aclansley@gmail.com>
Date: Wed Aug 14 16:02:16 2024 +1000
SS-78 / SES-199 Mechanism required to limit emoji reaction rate
commit a8ee5c9f3b0b121ca597fee5fc11cc5acb768ba0
Author: alansley <aclansley@gmail.com>
Date: Wed Aug 14 14:51:40 2024 +1000
Replaced hard-coded 'Session' with '{app_name}' in 'callsSessionCall'
commit 621094ebe4cb8c51ca4595b041eb94e5d4d469aa
Author: alansley <aclansley@gmail.com>
Date: Wed Aug 14 13:40:01 2024 +1000
SS-72 Update save attachment models + add one-time warning that other apps can access saved attachments
commit 0c8360653928f94e3a391ed851a63b309fda7e3d
Author: alansley <aclansley@gmail.com>
Date: Tue Aug 13 15:50:35 2024 +1000
SS-75 Open URL modal change
commit 802cf19598e83709303199a1d361416a557daac2
Author: Al Lansley <al@oxen.io>
Date: Mon Aug 12 16:42:15 2024 +1000
Open or copy URL WIP
commit ea84aa1478081095df6a0e6c120bc7e29100dd4a
Author: Al Lansley <al@oxen.io>
Date: Mon Aug 12 14:17:04 2024 +1000
Tied in bandDeleteAll string
commit 93b8e74f2d1489ea7c9127cea940300f020b9a11
Author: Al Lansley <al@oxen.io>
Date: Mon Aug 12 11:34:03 2024 +1000
Job done! All Accessibility ID strings mapped and/or dealt with appropriately!
commit fc3b4ad36723ec10cd136569417e69f68a2e0800
Author: Al Lansley <al@oxen.io>
Date: Mon Aug 12 09:49:57 2024 +1000
Further AccessibilityId mapping & fixed group members counts to display correct details
commit 558d6741b159a21c4f1a12262a08101a391daab2
Author: alansley <aclansley@gmail.com>
Date: Fri Aug 9 17:24:44 2024 +1000
End of day push
commit 73fdb16214c8f6c76b3e06c9e804e50a8961c032
Author: alansley <aclansley@gmail.com>
Date: Fri Aug 9 15:57:06 2024 +1000
Localised time strings working - even if the unit tests aren't
commit 436175d146db7add793fc8ebce31503ce1d6c844
Author: alansley <aclansley@gmail.com>
Date: Fri Aug 9 13:54:09 2024 +1000
Relative time string WIP
commit f309263e39fe9d68b4665d3ebf60a5debc5bd81d
Merge: 45c4118d52 007e705cd9
Author: alansley <aclansley@gmail.com>
Date: Fri Aug 9 11:39:13 2024 +1000
Merge dev
commit 45c4118d526a54b2aa7b332adef04c49b7a77205
Author: Al Lansley <al@oxen.io>
Date: Thu Aug 8 16:43:02 2024 +1000
Further AccessibilityId mapping WIP
commit 31bac8e30e0cf37b917fb847d913cd40a0109d0e
Author: Al Lansley <al@oxen.io>
Date: Thu Aug 8 10:53:30 2024 +1000
Further accessibility ID changes & removed fragment_new_conversation_home.xml
commit 9c2111e66e2ac09e5e210876665886bc9acb7d27
Author: alansley <aclansley@gmail.com>
Date: Wed Aug 7 13:13:52 2024 +1000
AccessibilityId WIP
commit 1e9eeff86adff3af64b515de4682a147f3078a55
Author: alansley <aclansley@gmail.com>
Date: Wed Aug 7 11:06:39 2024 +1000
AccessibilityId adjustments & removed some unused XML layouts
commit e5fd2c8cc03535bfd02fe7cd28eba51530ec7985
Author: alansley <aclansley@gmail.com>
Date: Wed Aug 7 09:22:14 2024 +1000
AccessibilityId refactor WIP
commit 399796bac34ca9ebbeb7cd37c030cca05da70dda
Author: alansley <aclansley@gmail.com>
Date: Tue Aug 6 15:51:53 2024 +1000
AccessibilityId WIP - up to AccessibilityId_reveal_recovery_phrase_button
commit a8d72dfcc073530fab923f95d08dc10c15852e03
Author: alansley <aclansley@gmail.com>
Date: Tue Aug 6 14:12:10 2024 +1000
Cleaned up a few comments and fixed some plurals logic
commit be400d8f4f9289de26d70eafa001f16fc039e7e0
Author: alansley <aclansley@gmail.com>
Date: Tue Aug 6 11:32:08 2024 +1000
Removed commented out merge conflict marker
commit 5cbe289a8d562f7e187f6e6e494b26e88094c5e0
Merge: 5fe123e7b5 d6c5ab2b18
Author: alansley <aclansley@gmail.com>
Date: Tue Aug 6 11:30:50 2024 +1000
Merge dev and cleanup
commit 5fe123e7b54dfa4f5056af00e5440f01ec226a4e
Author: Al Lansley <al@oxen.io>
Date: Mon Aug 5 14:37:47 2024 +1000
Adjusted sending of mms messages to show 'Uploading' rather than 'Sending' as per SES-1721
commit d3f8e928b6799bccf8fd2e9e74dc1eedca80340b
Merge: 00552930e6 cd1a0643e3
Author: Al Lansley <al@oxen.io>
Date: Mon Aug 5 13:30:03 2024 +1000
Merge branch 'dev' into strings-squashed
commit 00552930e604176f2dd679e9c8e956030078d39c
Author: Al Lansley <al@oxen.io>
Date: Mon Aug 5 13:28:55 2024 +1000
Removed unused helpReportABugDesktop strings
commit 6c0450b487b17e99e87805ada59a8bb583b86fac
Author: Al Lansley <al@oxen.io>
Date: Mon Aug 5 12:59:15 2024 +1000
Renamed 'quitButton' string to just 'quit'
commit 284c4859038362b8ef065d08507c43ccd444d27c
Author: Al Lansley <al@oxen.io>
Date: Mon Aug 5 12:00:35 2024 +1000
Replaced 'screenSecurity' with 'screenshotNotifications' as the title of the notifications toggle
commit 6948d64fa88d75a5a8bf6de4c5b8ababfc1a8445
Author: Al Lansley <al@oxen.io>
Date: Mon Aug 5 10:45:05 2024 +1000
WIP
commit bc94cb78db54b39c7276014809e55378d38056a0
Author: alansley <aclansley@gmail.com>
Date: Fri Aug 2 16:21:16 2024 +1000
End of day push
commit 1a2df3798ae285c1f61061ecf2fc423065490f98
Merge: c7fdb6aed9 a56e1d0b91
Author: alansley <aclansley@gmail.com>
Date: Fri Aug 2 15:20:19 2024 +1000
Merged dev
commit c7fdb6aed94544dcbef278d26702f8d093bdd91c
Author: alansley <aclansley@gmail.com>
Date: Fri Aug 2 14:21:11 2024 +1000
Replaced string 'dialog_disappearing_messages_follow_setting_confirm' with 'confirm'
commit 2992d590d9c1a5007941e17a404d692b89aa8899
Author: alansley <aclansley@gmail.com>
Date: Fri Aug 2 14:01:00 2024 +1000
Removed string 'attachment_type_selector__gallery' and associated / un-used 'attachment_type_selector.xml' layout
commit 4218663c956d1de735c2764bc42c47dc7d93b207
Author: alansley <aclansley@gmail.com>
Date: Fri Aug 2 13:39:54 2024 +1000
Removed 'message_details_header__disappears' and the unused 'activity_message_detail.xml' which was the only reference to it
commit ba2d0275e448c59c6f60ec6a087eb5ad2f1eff46
Author: alansley <aclansley@gmail.com>
Date: Fri Aug 2 12:15:42 2024 +1000
Implemented task SS-79 to only provide a save attachment menu option when the attachment download is complete
commit 20662c82222e9f2b3da698129b569be5bfe0f511
Merge: 608c984a6b fbbef4898a
Author: alansley <aclansley@gmail.com>
Date: Wed Jul 31 13:08:04 2024 +1000
Merge branch 'dev' into strings-squashed
commit 608c984a6b550e18423d0159fa746af7fe5be426
Author: alansley <aclansley@gmail.com>
Date: Tue Jul 30 16:58:08 2024 +1000
Actually remove the 4 specific time period mute strings
commit 006a4e8bad85db54b25e3edfc5ed02c05ce834fe
Author: alansley <aclansley@gmail.com>
Date: Tue Jul 30 16:43:54 2024 +1000
Cleaned up MuteDialog.kt
commit d3177f9f1a85ca772873fd4ec4f14d0d84c58e73
Author: alansley <aclansley@gmail.com>
Date: Tue Jul 30 16:27:06 2024 +1000
Added a 1 second kludge to the mute for subtitle so that it initially shows 1 hour not 59 minutes etc.
commit d568a86649b1d880b373ca525074de7443fcd8d6
Author: alansley <aclansley@gmail.com>
Date: Tue Jul 30 16:20:20 2024 +1000
Removed 'Muted for' strings and fixed it up to use 'Mute for {large_time_unit}' across the board
commit 84f6f19cf4f66b0309e07f82e120d83abdea326e
Author: alansley <aclansley@gmail.com>
Date: Tue Jul 30 11:03:46 2024 +1000
Changed some hard-coded 'Session' text in strings and renamed another
commit bc90d18c91e2a2dbb15c090b5d9d7e2fd02a2acf
Author: alansley <aclansley@gmail.com>
Date: Tue Jul 30 10:27:55 2024 +1000
Cleaned up a leftover plural & changed 'app_name' to use 'sessionMessenger' string
commit 79cd87878c18aad828df6142777b944e1d9eb9f2
Merge: 3b62e474b3 dec02cef5a
Author: alansley <aclansley@gmail.com>
Date: Tue Jul 30 08:16:02 2024 +1000
Merge branch 'dev' into strings-squashed
commit 3b62e474b37bef9530ae7e74d28312c902653b1b
Author: Al Lansley <al@oxen.io>
Date: Mon Jul 29 16:33:21 2024 +1000
Down to just the final few straggler strings
commit 13e81f046b7a781d8e8491170f52951f93353fce
Author: Al Lansley <al@oxen.io>
Date: Mon Jul 29 13:13:54 2024 +1000
WIP
commit 2d9961d5c0e27332ab87a37e7e263645e490f51c
Author: Al Lansley <al@oxen.io>
Date: Mon Jul 29 08:58:01 2024 +1000
Further cleanup of stragglers
commit 08b8a84309a8c91fb71cad313d52be565d86d3fd
Author: Al Lansley <al@oxen.io>
Date: Mon Jul 29 08:29:12 2024 +1000
Cleaning up straggler strings
commit d0e87c64b594f34579f1dcd4884801374dc6dbd1
Author: alansley <aclansley@gmail.com>
Date: Fri Jul 26 17:07:46 2024 +1000
WIP
commit 4bc9d09be2ffd5eecfa0d0fad6a9bc53f019307c
Author: alansley <aclansley@gmail.com>
Date: Fri Jul 26 16:30:28 2024 +1000
WIP
commit 3cee4bc12f778a3b9a5560092430303ba3f12a0b
Merge: aa1db13e3a a495ec232a
Author: alansley <aclansley@gmail.com>
Date: Fri Jul 26 13:57:09 2024 +1000
Removed some legacy strings & substituted others
commit aa1db13e3a254c2b2972ba3040db087b16644033
Author: fanchao <git@fanchao.dev>
Date: Fri Jul 26 11:34:05 2024 +1000
Initial squash merge for strings
|
||
|
ThomasSession
|
80933938e1
|
Removing unsed UI tests (#1625)
We need to rethink the UI tests if we do indeed want to use them as they are not tied to the existing flow anymore |
||
|
Fanchao Liu
|
16d6efbb5b
|
SES-2524 - Rewrite media gallery in Compose (#1619) | ||
|
Fanchao Liu
|
631d93c20c
|
Replace kapt with ksp and update dependencies (#1560) | ||
|
bemusementpark
|
8245e4ffe5 | Rename remaining session id refs | ||
|
Andrew
|
287b5566c4 | Remove session id refs | ||
|
Andrew
|
79c35b0e3b | Fix keypress non-alphanumeric keys | ||
|
Andrew
|
92c2d574ae | Fix HomeActivityTests | ||
|
0x330a
|
acb1181db0
|
feat: add more testing functionality for the expected current / updated expiry configuration upon merging libsession updates | ||
|
0x330a
|
e06f9ee79a | refactor: change storage adding contacts to create one on ones with a non hidden thread priority and base for testing storage expiration merges from fake polling | ||
|
andrew
|
892e4b75ec | Merge branch 'dev' into disappear-2 | ||
|
0x330a
|
84bc1dcb6b
|
Update session libsodium (#1326)
* chore: update dependencies for the libsodium dependency and replace aar * fix: update gradle dependencies to work with integration tests * fix: test * refactor: make it use espresso wait * refactor: bring compose dependencies back to stable releases |
||
|
0x330a
|
8db92cc55c
|
feat: add user config integrated into config sync | ||
|
hjubb
|
e7608763a0 | fix: tests pass with forcing config | ||
|
0x330a
|
ac18f1cbfe
|
Integrate shared libsession-util library (#1096)
* feat: add some config db basics and DI for it, make the user profile optional, start looking at integrate building from initial dump * update: get latest util library submodule update * refactor: fix compile for refactored API * refactor: naming consistent with library * feat: add in config storage and injection to common places, managing lifecycle of native instances * refactor: config database changes, new protos, adding in support for config base namespace queries * refactor: config query and store use the same format as other platforms * feat: add batch snode calls and try to poll from all the config namespaces * fix: add optional namespace in signature and params * feat: add raw requests for modifying expiry and getting expiries * feat: add some base config migration logic, start implementing wrappers for conversation and expiry types * chore: update libsession base * feat: start integrating conversation wrapper functions * feat: add basic conversation info volatile types and implementations, start working on tests * feat: more common library wrapper implementation and test * fix: tests and compile issues * fix: fix tests, don't use iterables * feat: add all iterators and tests * feat: add in more config factory for volatile * feat: update request responses and their appropriate processing * feat: add storage with hashes and some basic profile update logic in config factory probably move that somewhere else * feat: adding config sync functionality, refactoring jobs to execute in suspend context to do some nice coroutine execution * refactor: moving some properties around so we have access in libsession * feat: expand on the config sync job, finish basic implementation to test against * feat: add forced config sync * feat: syncs the user profile stuff for now, and errors back to placeholder instead of unknown recipient * feat: add basic message read logic for synchronizing last reads, need to modify the query to use the last seen instead of the unread count in a subquery possibly for thread display record * feat: add broken unreads everywhere * fix: unreads work now for incoming messages, need to sync conv volatile properly still * feat: batching poll responses properly and handling groups properly * fix: replace the mark read receiver (from notifications) to use the new set last seen mark read logic * feat: update to the group list branch * fix: compile errors from updating library to use latest branch, now requires cmake 3.22.1 * fix: fix the contact tests * fix: getters weren't getters properly in the config factory, fixed new onboarding from configs * feat: add the last seen * feat: start adding user groups wrapper objects * refactor: add more else branches for unimplemented types * feat: buffer the last read when in conversation * feat: add basic contact logic for setting local contact state. Need to implement handling properly * refactor: trying to just include blocked status for now in updating contacts * fix: add some more contact syncing: nicknames, approved statuses, blocked statuses * feat: start implementing hashes in shared lib and refactoring * feat: start to implement group list info classes and wrappers and refactor to use library based hashes * feat: incorporate hashes from library, more wrapper for user groups and serialization from c++ * feat: adding more serialization changes for community base info and user groups LGC * feat: adding more serialize deserialize to legacy closed groups * feat: finish serial/deserial helper * feat: just implement deserialize community info * refactor: refactor tests and wrappers to use less pointers, finish implementing user groups API * feat: finish latest wrappers fix tests and continue building default generation functions. refactor defaults to be used if no stored data blob in DB * feat: more usergroup functionality, storage functionality for checking pinned status, adding pinned status for NTS/contacts, move community info parse full url to base community, add StorageProtocol logic for group info * feat: adding user groups to the list of user configs, refactorign some of the config factory to fetch the user configs easier. Add handling for polling user group namespace * feat: implement the default user config list * feat: add user group config handling * chore: extra missed existing group * refactor: use existing lookup for objects in wrappers so they don't overwrite missing values * feat: add contacts expiry serialization/deserialization, more LGC, timestamps to add closed group encryption info (for latest tracking) * refactor: change how expiration timer works for contacts, set the expiration timer for those conversations in handling contact configs * feat: add expiration updates via config for contacts as well * feat: add almost all group editing cases, need to hook into the thread deletion for groups in the user groups * feat: open group joining should work now * feat: add groups to configs for push * fix: handling user group updates bug fix for closed groups instead of all groups * fix: open group sync persistence * feat: add in activity finish if recipient no longer exists (deleted thread) from sync * feat: support avatar removal from shared library * feat: support thread deletion and refactoring a lot of getOrCreateThread references to go via storage or assume they are correctly set to hook into the contact and volatile creation during thread creation * fix: database update not deleting in certain circumstances, storage persisting and removing the volatile convo info for thread deletion / creation, NTS hidden getter values in shared library * refactor: make update listener visibility package * refactor: update kotlin * feat: update dependencies and support outdated config messages, refactor config factory to return null configs if new configs not supported * feat: update shared library to use priority only, fix compile errors, fix group member sync problem * fix: compile error * fix: profile avatar fixes for local user now that we aren't setting local user profile key * Revert "fix: profile avatar fixes for local user now that we aren't setting local user profile key" This reverts commit 3f569e34034713ee230581bc118e9127a8d0f434. * refactor: let the local number update recipient details in profile manager * fix: don't recreate thread after leaving * fix: fix up the duplicate thread creation in the message receive handler * fix: fix the placeholder rendering on new messages, add in extra context logging for adding contacts and preventing new thread creation on new messages of various types * feat: add test theme for xml layout previews * feat: add shortened hex for session IDs throughout, replace nullable getName with null in underlying contacts for individual contacts, build shared lib with release mode, remove todo, fix broken unit test * feat: setup android unit tests for verifying storage behaviours and state of shared configs * feat: adding dependencies to try and get android tests working, fixing bug with initial config not syncing properly * fix: remove hilt testing, add spy on app context storage field instead, update libsession-util to fixed sodium cmake branch * refactor: use PR version of libsession-util to test cmake build * fix: new build on normal repo * feat: new libsession util commit * refactor: remove the old custom build libsodium stuff from cmake * feat: update libsession module * fix: add legacy config subscription to the home activity to enable showing banner at any time * fix: pinned status for communities and groups, group last read time being set to snodeapi.now on finish joining * fix: some open group volatile convo fix for last read timer being set. Need to investigate further * fix: prevent blocking local number * fix: adding in more checks for open group inbox recipients before being saved to the shared configs. Prevent sending typing indicator for blocked users * fix: add blocked check for read receipt and updating expiring messages * fix: another contact recipient config library call removed for non-standard IDs * fix: another ID check * fix: don't process thread creation for user is sender && recipient (sync message) for message request responses * refactor: mark as read on open and use less buffer time * fix: finally fix the darn unread count issue by * fix: removing debug logs, adding failure error handling logs for expiry message updater, properly using the message thread ID created for the expiring messages. Process the non-thread messages properly with await in BatchMessageReceiveJob * fix: checking the last read open to message and make sure that scroll behaviour matches expected, fix the config sync job not deleting ALL old hashes only latest * refactor: try to add a retry logic to config sync job in case of snode failure * build: update submodule * fix: remove user notifications for leaving group to prevent synced device issues, don't create thread in messages for new closed groups, includei nactive groups in the deletion queries for merging group configs * feat: use blinded message count for banner also * refactor: remove some logging, don't use blinded conversations in the list * fix: don't set the read flag in update notifications, some roundabout logic for first loads and scrolling to last known positions * refactor: merge changes, re-add the group check in unapproved messages * fix: re-poll on fail in case that was breaking anything * fix: pinning groups and notifying list listeners in threadDb.setPinned * feat: add in TTL extension subrequest and builder, enable extending TTLs for all latest config messages in poll as subrequest * feat: add block to the delete all message requests, only if they're not open group inbox contacts * refactor: disable edit text for non contacts * refactor: let the user display name return "You" for local user * fix: prevent NTS self create thread on user view bind * refactor: remove populate public key cache if needed call which seems unnecessary at that point, maybe UserView refs have changed since 2020 * refactor: use just first visible instead of completely visible, merge message sender changes * fix: prevent block of users in delete all * fix: self sync sync message failures for default values * feat: update libsession-util, adjust docs, update mms and sms to use message sent timestamp instead of -1 for last read in the thread * fix: some compile issues in tests and some TODOs for things to do before merge * fix: handle recyclerview scrolled on scroll to first unread if it's the first load * fix: added more migration code for deleting unnecessary threads and groups, fixed a post-migration last seen issue on last item (current read is now), comment out actual network sync while testing migrations * feat: adding a force new configs flag and logic for timestamp handling / forced configs, fix issue with handling legacy messages * refactor: re-add the sending of configs * fix: don't add contacts if they don't exist in the profile manager * [wip] fix: trying to consolidate prof pic and key properly * feat: add logs and fix compile issue with a themes.xml entry, add removing profile picture into logic for profile manager * fix: force has sent for local user, only prevent setting last seen for open group recipients, allow empty user pics to trigger config sync in settings * fix: nts threads * fix: open group avatar loop for open groups we have left * feat: add a wrapper hash to track home diff util changes for wrapper contact recipient info, add test for dirty state in double set * feat: add a dump in there as well * refactor: more test code refactor * fix: update last seen if later than current * fix: open group threads and avatar downloads * fix: add max size and maybe fix the non-200 sub requests for batches (for 421s in particular) * fix: open group comparison issues potentially, have to update some more outgoing message open group flags for visibility of details etc * Updated to the latest libSession-util * Updated logic to delete legacy groups when kicked/left * Added the legacy group 'joined_at' value * Replaced incorrect character in JNI * Fixed an issue where the group keyPair was getting encoded incorrectly * Updated the code to ignore outdated legacy group control message changes * Updated the code to ignore messages invalidated by the config * [Review] Updated the poller to process config messages before standard * Cleaned up the outdated message logic * Fixed inverted config dropping flags * Fixed an issue where the joining a community would read all messages Stopped using a reversed RecyclerView in all cases (caused the unread issue) Updated the logic to jump to the newly sent message when sending a message (to be consistent with other platforms) Updated the logic to refresh the DB unread count when the cursor receives an update * Updated the conversation to highlight the first unread message on open * Fixed a couple of bugs with the highlighting * Fixed a bug where the user profile picture wasn't downloading correctly * feat: add all namespaces to delete all messages request and signature verification data * fix: merge namespace hashes for signature returned and * fix: import correct scroll to bottom * build: update version code and name * fix: initial contact generation fix for existing blinded contacts * fix: initial convo generation fix for existing blinded convos (?) * fix: conversation unread not doing a check for standard ID prefix * fix: thread ID not being created for legacy config messages * fix: don't treat 404 as bad snode * fix: don't add retrieve profile job if we have one for that address * build: update build code * fix: reduce attempts for downloading image, invert unreachable type check * fix: attempting to fix preventing message processing if group thread is not active for closed groups and initial contact dump only allows conversations with thread, may need further optimisations though * feat: Added an unread marker and search result focus highlighting * fix: empty set in appropriate places for current closed groups * build: update build version code * fix: fix the notifications and request at appropriate time * refactor: remove debug logging for thread create and delete * build: update build number * fix: new community doesn't break persisting config if the .add request fails * build: trying to track down broken retrieve avatar job * feat: update to latest libsession dev * fix: maybe fix avatar download for new messages * fix: 404s causing snode errors and trying to retrieve avatars that have already 404'd a lot * fix: closed group creation sets thread date to formation timestamp * build: update version code * build: update version code * build: remove debuggable release build * fix: use new permissions for external attachments * build: update version code * chore: remove debug logs * fix: tests and main thread blocking db fetch for path status view * wip: trying to track down failure to mark conversation as read in delayed group add * wip: add more logs for initial last Read sync of communities * wip: maybe the volatile is being updated with 0 on batch message receive? * fix: maybe syncing read statuses are working now * chore: remove debug logs * build: update build number * fix: trying to improve performance * fix: add close to banner * refactor: hide seed reminder in preview * build: update build number * fix: maybe requires update thread no matter what * fix: message request banner shows again * fix: android tests work again and permissions * fix: blocked contacts click handler being overridden by something * Revert "fix: blocked contacts click handler being overridden by something" This reverts commit 608572fc426def0850085727ed0c399623110c37. * build: update build number * refactor: remove unused dependencies and update minor for sqlcipher * fix: actually do insert contact, because otherwise name doesn't get set properly * fix: maybe fix scroll to bottom issue * build: update build number * fix: the message time and jump to message queries are more optimized * fix: maybe fix the last seen issues * build: update build number * fix: pfp broken closed groups why * fix: add admins and members as member list instead of just members * fix: exclude lgc without membership > 1 and inactive explicitly * fix: submodule update * fix: compiles with removal of iterator erase * fix: unread indicator updates properly in ConversationActivityV2 * fix: unread notifications clear and altered if any notifications exist (prevents clearing read notifications in conversation or on home screen) * refactor: profile pictures kinda broken * build: update build number * refactor: remove full hash from log * fix: isPinned threadDB call * refactor: use mutex in all libsession native calls, change timestamp * refactor: add basic support for blinded v2 prefixes --------- Co-authored-by: Morgan Pretty <morgan.t.pretty@gmail.com> |
||
|
ceokot
|
fbd1721eaf
|
Menu redesign (#958)
* feat: Menu redesign * Add bottomsheet * Handle default peek height * Smooth out setting peek height * Move contacts prep to util * Dialog layout tweaks * Contact grouping tweaks * Add new message dialog * Add public key input delegate * Add create group dialog * Add join community dialog * Handle dialog back navigation * Enter community url tab tweaks * Scan QR code tab refactor * Scan qr code refactor * Direct and community tabs refactor * Add session id copy context menu item * Set dialog background colours * Set full dialog background colour * Minor tweaks * Add closed group contact search * Cleanup * Add content descriptions * Resize community chips * Fix new conversation screen paddings * Fix fade in/out of join community screen * Prevent creating conversation with empty public key * Resize and position create group loader * Fix back nav after creating direct message conversation * Fix inter-screen transitions * Fix new conversation background colours * Fix background colours * Rename contact list header for clarity * Bug fixes * Enable scrolling of Enter Session ID tab of the new message dialog * Minor refactor * Switch to child fragment manager * Fix member search on create group screen Co-authored-by: charles <charles@oxen.io> |
||
|
ceokot
|
bee287bb7e
|
Add Session Id blinding (#862)
* feat: Add Session Id blinding Including modified version of lazysodium-android to expose missing libsodium functions, we could build from a fork which we still need to setup. * Add v4 onion request handling * Update SOGS signature construction * Fix SOGS signature construction * Update onion request * Update signature data * Keep path prefixes for v4 endpoints * Update SOGS signature message * Rename to remove api version suffix * Update onion response parsing * Refactor file download paths * Implement request batching * Refactor batch response handling * Handle batch endpoint responses * Update batch endpoint responses * Update attachment download handling * Handle file downloads * Handle inbox messages * Fix issue with file downloads * Preserve image bytearray encoding * Refactor * Open group message requests * Check id blinding in user detail bottom sheet rather * Message validation refactor * Cache last inbox/outbox server ids * Update message encryption/decryption * Refactor * Refactor * Bypass user details bottom sheet in open groups for blinded session ids * Fix capabilities call auth * Refactor * Revert default server details * Update sodium dependency to forked repo * Fix attachment upload * Revert "Update sodium dependency to forked repo" This reverts commit c7db9529f900d09585ab94e440f6645faa88544e. * Add signed sodium lib * Update contact id truncation and mention logic * Open group inbox messaging fix * Refactor * Update blinded id check * Fix open group message sends * Fix crash on open group direct message send * Direct message refactor * Direct message encrypt/decrypt fixes * Use updated curve25519 version * Updated lazysodium dependency * Update encryption/decryption calls * Handle direct message parse errors * Minor refactor * Existing chat refactor * Update encryption & decryption parameters * Fix authenticated ciphertext size * Set direct message sync target * Update direct message thread lookup * Add blinded id mapping table * Add blinded id mapping table * Update threads after sends * Update open group message timestamp handling * Filter unblinded contacts * Format blinded id mentions * Add message deleted field * Hide open group inbox id * Update message request response handling * Update message request response sender handling * Fix mentions of blinded ids * Handle open group poll failure * fix: add log for failed open group onion request, add decoding body for blinding required error at destination * fix: change the error check * Persist group members * Reschedule polling after capabilities update * Retry on other exceptions * Minor refactor * Open group profile fix * Group member db schema update * Fix ban request key * Update ban response type * Ban endpoint updates * Ban endpoint updates * Delete messages Co-authored-by: charles <charles@oxen.io> Co-authored-by: jubb <hjubb@users.noreply.github.com> |
||
|
Harris
|
b01075cef6
|
fix: add UI test for URL modal dialog and fix mention infinite layout inflation bugs (#841) | ||
|
Harris
|
dd1da6b1a4
|
Add a global search (#834)
* feat: modifying search functionalities to include contacts * feat: add global search UI input layouts and color attributes * feat: add global search repository and model content * feat: adding diff callbacks and wiring up global search vm to views * feat: adding scroll to message, figuring out new query for recipient thread search * feat: messing with the search and highlighting functionality after wiring up bindings * fix: compile error from merge * fix: gradlew build errors * feat: filtering contacts by existing un-archived threads * refactor: prevent note to self breaking, update queries and logic in search repo to include member->group reverse searches * feat: adding home screen new redesigns for search * feat: replacing designs and adding new group subtitle text * feat: small design improvements and incrementing gradle build number to install on device * feat: add scrollbars for search * feat: replace isVisible for cancel button now that GlobalSearchInputLayout.kt replaces header * refactor: all queries are debounced not just all but 2 char * refactor: remove visibility modifiers for cancel icon * refactor: use simplified non-db and context related models in display, remove db get group members call from binding data * fix: use threadId instead of group's address * refactor: better close on cancel, removing only yourself from group member list in open groups * refactor: seed view back to inflated on create and visibility for empty placeholder and seed view text * refactor: fixing build issues and new designs for message list * refactor: use dynamic limit * refactor: include raw session ID string search for non-empty threads * fix: build lint errors * fix: build issues * feat: add in path to the settings activity * refactor: remove wildcard imports |
||
|
Harris
|
7c3dc7e7bc | refactor: instrumentation for clipboard test was failing on smaller screen devices running the tests | ||
|
Harris
|
bf6c2d29f1 | fix: Home activity crash handling from the seed view optimisations. added tests for that plus rendering URL crash |