TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-05-15 15:08:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

tstest/deptest: verify that tailscale.com BadDeps actually exist

Browse Source 
This protects against rearranging packages and not catching that a BadDeps
package got moved. That would then effectively remove a test.

Updates #12614

Change-Id: I257f1eeda9e3569c867b7628d5bfb252d3354ba6
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
This commit is contained in:
Brad Fitzpatrick 2025-01-26 18:12:46 +00:00 committed by Brad Fitzpatrick
parent e701fde6b3
commit 04029b857f
1 changed files with 25 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
tstest/deptest/deptest.go
View File

@ -15,6 +15,7 @@ import (
"runtime"
"slices"
"strings"
"sync"
"testing"
"tailscale.com/util/set"
@ -54,11 +55,35 @@ func (c DepChecker) Check(t *testing.T) {
t.Fatal(err)
}
tsRoot := sync.OnceValue(func() string {
out, err := exec.Command("go", "list", "-f", "{{.Dir}}", "tailscale.com").Output()
if err != nil {
t.Fatalf("failed to find tailscale.com root: %v", err)
}
return strings.TrimSpace(string(out))
})
for _, dep := range res.Deps {
if why, ok := c.BadDeps[dep]; ok {
t.Errorf("package %q is not allowed as a dependency (env: %q); reason: %s", dep, extraEnv, why)
}
}
// Make sure the BadDeps packages actually exists. If they got renamed or
// moved around, we should update the test referencing the old name.
// Doing this in the general case requires network access at runtime
// (resolving a package path to its module, possibly doing the ?go-get=1
// meta tag dance), so we just check the common case of
// "tailscale.com/*" packages for now, with the assumption that all
// "tailscale.com/*" packages are in the same module, which isn't
// necessarily true in the general case.
for dep := range c.BadDeps {
if suf, ok := strings.CutPrefix(dep, "tailscale.com/"); ok {
pkgDir := filepath.Join(tsRoot(), suf)
if _, err := os.Stat(pkgDir); err != nil {
t.Errorf("listed BadDep %q doesn't seem to exist anymore: %v", dep, err)
}
}
}
for dep := range c.WantDeps {
if !slices.Contains(res.Deps, dep) {
t.Errorf("expected package %q to be a dependency (env: %q)", dep, extraEnv)