TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-01-05 14:57:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

all: add (*testing.B).ReportAllocs() to every benchmark

Browse Source 
This ensures that we can properly track and catch allocation
slippages that could otherwise have been missed.

Fixes #2748
This commit is contained in:
Emmanuel T Odeke 2021-08-30 20:43:18 -07:00 committed by Brad Fitzpatrick
parent 44d71d1e42
commit 0daa32943e
7 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
net/dns/resolver/tsdns_test.go
View File

@ -1015,6 +1015,7 @@ func BenchmarkFull(b *testing.B) {
for _, tt := range tests {
b.Run(tt.name, func(b *testing.B) {
b.ReportAllocs()
for i := 0; i < b.N; i++ {
syncRespond(r, tt.request)
}

1
net/tsaddr/tsaddr_test.go
View File

@ -75,6 +75,7 @@ func TestNewContainsIPFunc(t *testing.T) {
var sinkIP netaddr.IP
func BenchmarkTailscaleServiceAddr(b *testing.B) {
b.ReportAllocs()
for i := 0; i < b.N; i++ {
sinkIP = TailscaleServiceIP()
}

1
net/tstun/wrap_test.go
View File

@ -397,6 +397,7 @@ func TestClose(t *testing.T) {
}
func BenchmarkWrite(b *testing.B) {
b.ReportAllocs()
ftun, tun := newFakeTUN(b.Logf, true)
defer tun.Close()

2
tstime/mono/mono_test.go
View File

@ -35,12 +35,14 @@ func TestUnmarshalZero(t *testing.T) {
}
func BenchmarkMonoNow(b *testing.B) {
b.ReportAllocs()
for i := 0; i < b.N; i++ {
Now()
}
}
func BenchmarkTimeNow(b *testing.B) {
b.ReportAllocs()
for i := 0; i < b.N; i++ {
time.Now()
}

2
tstime/tstime_test.go
View File

@ -152,7 +152,6 @@ func BenchmarkParse3339(b *testing.B) {
run := func(in string) func(*testing.B) {
return func(b *testing.B) {
b.ReportAllocs()
t, err := time.Parse(time.RFC3339Nano, in)
if err != nil {
b.Fatal(err)
@ -182,6 +181,7 @@ func BenchmarkParse3339(b *testing.B) {
}
func BenchmarkParseInt(b *testing.B) {
b.ReportAllocs()
var out int
for i := 0; i < b.N; i++ {
parseInt(mem.S("148487491"), &out)

5
wgengine/magicsock/magicsock_test.go
View File

@ -1194,6 +1194,10 @@ func addTestEndpoint(tb testing.TB, conn *Conn, sendConn net.PacketConn) (tailcf
}
func setUpReceiveFrom(tb testing.TB) (roundTrip func()) {
if b, ok := tb.(*testing.B); ok {
b.ReportAllocs()
}
conn := newTestConn(tb)
tb.Cleanup(func() { conn.Close() })
conn.logf = logger.Discard
@ -1295,6 +1299,7 @@ func BenchmarkReceiveFrom(b *testing.B) {
}
func BenchmarkReceiveFrom_Native(b *testing.B) {
b.ReportAllocs()
recvConn, err := net.ListenPacket("udp4", "127.0.0.1:0")
if err != nil {
b.Fatal(err)

8
wgengine/userspace_test.go
View File

@ -214,6 +214,8 @@ func BenchmarkGenLocalAddrFunc(b *testing.B) {
lanot := netaddr.MustParseIP("5.5.5.5")
var x bool
b.Run("map1", func(b *testing.B) {
b.ReportAllocs()
b.ResetTimer()
m := map[netaddr.IP]bool{
la1: true,
}
@ -223,6 +225,8 @@ func BenchmarkGenLocalAddrFunc(b *testing.B) {
}
})
b.Run("map2", func(b *testing.B) {
b.ReportAllocs()
b.ResetTimer()
m := map[netaddr.IP]bool{
la1: true,
la2: true,
@ -233,6 +237,8 @@ func BenchmarkGenLocalAddrFunc(b *testing.B) {
}
})
b.Run("or1", func(b *testing.B) {
b.ReportAllocs()
b.ResetTimer()
f := func(t netaddr.IP) bool {
return t == la1
}
@ -242,6 +248,8 @@ func BenchmarkGenLocalAddrFunc(b *testing.B) {
}
})
b.Run("or2", func(b *testing.B) {
b.ReportAllocs()
b.ResetTimer()
f := func(t netaddr.IP) bool {
return t == la1 || t == la2
}