TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-02-19 19:38:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

wgengine/magicsock: clear endpoint state in noteConnectivityChange

Browse Source 
There are latency values stored in bestAddr and endpointState that are
no longer applicable after a connectivity change and should be cleared
out, following the documented behavior of the function.

Updates #8999

Signed-off-by: James Tucker <james@tailscale.com>
This commit is contained in:
James Tucker 2023-08-21 15:48:17 -07:00 committed by James Tucker
parent 7364c6beec
commit 3a652d7761
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
wgengine/magicsock/endpoint.go
View File

@ -127,6 +127,14 @@ type endpointState struct {
index int16 // index in nodecfg.Node.Endpoints; meaningless if lastGotPing non-zero
}
// clear removes all derived / probed state from an endpointState.
func (s *endpointState) clear() {
*s = endpointState{
index: s.index,
lastGotPing: s.lastGotPing,
}
}
// pongHistoryCount is how many pongReply values we keep per endpointState
const pongHistoryCount = 64
@ -865,7 +873,12 @@ func (de *endpoint) noteConnectivityChange() {
de.mu.Lock()
defer de.mu.Unlock()
de.bestAddr = addrLatency{}
de.trustBestAddrUntil = 0
for k := range de.endpointState {
de.endpointState[k].clear()
}
}
// handlePongConnLocked handles a Pong message (a reply to an earlier ping).