stun, stunner: clarify an error log message more

But two earlier changes mean this doesn't show up anymore anyway.
But if it does, it'll be a nice message.
This commit is contained in:
Brad Fitzpatrick 2020-03-15 22:19:45 -07:00
parent 1b2be3f1c8
commit d348b94505
2 changed files with 2 additions and 2 deletions

View File

@ -124,7 +124,7 @@ func ParseBindingRequest(b []byte) (TxID, error) {
var (
ErrNotSTUN = errors.New("response is not a STUN packet")
ErrNotSuccessResponse = errors.New("STUN response error")
ErrNotSuccessResponse = errors.New("STUN packet is not a response")
ErrMalformedAttrs = errors.New("STUN response has malformed attributes")
ErrNotBindingRequest = errors.New("STUN request not a binding request")
ErrWrongSoftware = errors.New("STUN request came from non-Tailscale software")

View File

@ -110,7 +110,7 @@ func (s *Stunner) Receive(p []byte, fromAddr *net.UDPAddr) {
// check probe coming in late. Ignore.
return
}
s.logf("stunner: received bad STUN response: %v", err)
s.logf("stunner: received unexpected STUN message response from %v: %v", fromAddr, err)
return
}
r, ok := s.removeTX(tx)