TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-03-03 12:40:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

net/tshttpproxy: use correct size for Windows BOOL argument

Browse Source 
The Windows BOOL type is an int32. We were using a bool,
which is a one byte wide. This could be responsible for the
ERROR_INVALID_PARAMETER errors we were seeing for calls to
WinHttpGetProxyForUrl.

We manually checked all other existing Windows syscalls
for similar mistakes and did not find any.

Updates #879

Co-authored-by: Aaron Klotz <aaron@tailscale.com>
Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>
(cherry picked from commit ca1b3fe235ca617c4128fcc00d924e85535b4b8e)
This commit is contained in:
Josh Bleecher Snyder 2021-11-22 11:49:12 -08:00 committed by Brad Fitzpatrick
parent 71be839f03
commit d4fd80c5d7
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
net/tshttpproxy/tshttpproxy_windows.go
View File

@ -190,7 +190,7 @@ type autoProxyOptions struct {
AutoConfigUrl *uint16
_ uintptr
_ uint32
FAutoLogonIfChallenged bool
FAutoLogonIfChallenged int32 // BOOL
}
// WINHTTP_PROXY_INFO