TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-02-19 19:38:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

cmd/tailscale/cli: add test to catch ipn.Pref additions

Browse Source
This commit is contained in:
Brad Fitzpatrick 2021-04-30 13:29:06 -07:00
parent 6caa02428e
commit f6e3240dee
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
cmd/tailscale/cli/cli_test.go
View File

@ -9,6 +9,7 @@ import (
"encoding/json"
"flag"
"fmt"
"reflect"
"strings"
"testing"
@ -553,3 +554,26 @@ func TestPrefsFromUpArgs(t *testing.T) {
}
}
func TestPrefFlagMapping(t *testing.T) {
prefType := reflect.TypeOf(ipn.Prefs{})
for i := 0; i < prefType.NumField(); i++ {
prefName := prefType.Field(i).Name
if _, ok := flagForPref[prefName]; ok {
continue
}
switch prefName {
case "WantRunning", "Persist", "LoggedOut":
// All explicitly handled (ignored) by checkForAccidentalSettingReverts.
continue
case "OSVersion", "DeviceModel":
// Only used by Android, which doesn't have a CLI mode anyway, so
// fine to not map.
continue
case "NotepadURLs":
// TODO(bradfitz): https://github.com/tailscale/tailscale/issues/1830
continue
}
t.Errorf("unexpected new ipn.Pref field %q is not handled by up.go (see addPrefFlagMapping and checkForAccidentalSettingReverts)", prefName)
}
}