David Anderson a9da6b73a8 net/dnscache: don't cancel the TLS context before writing to the result channel. ...

Cancelling the context makes the timeout goroutine race with the write that
reports a successful TLS handshake, so you can end up with a successful TLS
handshake that mysteriously reports that it timed out after ~0s in flight.

The context is always canceled and cleaned up as the function exits, which
happens mere microseconds later, so just let function exit clean up and
thereby avoid races.

Signed-off-by: David Anderson <danderson@tailscale.com>

2022-01-13 23:01:29 +00:00

..

dnscache_test.go

net/{dnscache,interfaces}: use netaddr.IP.IsPrivate, delete copied code

2021-07-26 20:30:28 -07:00

dnscache.go

net/dnscache: don't cancel the TLS context before writing to the result channel.

2022-01-13 23:01:29 +00:00

messagecache_test.go

net/dnscache, net/tsdial: add DNS caching to tsdial UserDial

2021-12-09 11:34:21 -08:00

messagecache.go

net/dnscache, net/tsdial: add DNS caching to tsdial UserDial

2021-12-09 11:34:21 -08:00