docs: standardize multi-factor spelling and related string updates (#8752)

- **docs: s/Secondfactor/Second factor/**
- **docs: s/IDP/IdP/**
- **docs: s/Hardwaretokens/Hardware tokens/**
- **docs: standardize multi-factor vs multi factor vs multifactor**

# Which Problems Are Solved

 - English strings are improved

# How the Problems Are Solved

 - With better strings

---------

Co-authored-by: Fabi <fabienne@zitadel.com>

internal/api/oidc/server.go

@@ -46,7 +46,7 @@ type Server struct {
 }
 
 func endpoints(endpointConfig *EndpointConfig) op.Endpoints {
-	// some defaults. The new Server will disable enpoints that are nil.
+	// some defaults. The new Server will disable endpoints that are nil.
 	endpoints := op.Endpoints{
 		Authorization:       op.NewEndpoint("/oauth/v2/authorize"),
 		Token:               op.NewEndpoint("/oauth/v2/token"),

internal/authz/repository/eventsourcing/eventstore/token_verifier.go

@@ -173,7 +173,7 @@ func (repo *TokenVerifierRepo) verifySessionToken(ctx context.Context, sessionID
 }
 
 // checkAuthentication ensures the session or token was authenticated (at least a single [domain.UserAuthMethodType]).
-// It will also check if there was a multi factor authentication, if either MFA is forced by the login policy or if the user has set up any second factor
+// It will also check if there was a multi-factor authentication, if either MFA is forced by the login policy or if the user has set up any second factor
 func (repo *TokenVerifierRepo) checkAuthentication(ctx context.Context, authMethods []domain.UserAuthMethodType, userID string) error {
 	if len(authMethods) == 0 {
 		return zerrors.ThrowPermissionDenied(nil, "AUTHZ-Kl3p0", "authentication required")

internal/notification/handlers/user_notifier_test.go

@@ -1469,7 +1469,7 @@ func Test_userNotifier_reduceOTPSMSChallenged(t *testing.T) {
 			givenTemplate := "{{.LogoURL}}"
 			testCode := ""
 			expiry := 0 * time.Hour
-			expectContent := fmt.Sprintf(`%[1]s is your one-time-password for %[2]s. Use it within the next %[3]s.
+			expectContent := fmt.Sprintf(`%[1]s is your one-time password for %[2]s. Use it within the next %[3]s.
 @%[2]s #%[1]s`, testCode, eventOriginDomain, expiry)
 			w.messageSMS = &messages.SMS{
 				SenderPhoneNumber:    "senderNumber",
@@ -1506,7 +1506,7 @@ func Test_userNotifier_reduceOTPSMSChallenged(t *testing.T) {
 			givenTemplate := "{{.LogoURL}}"
 			testCode := ""
 			expiry := 0 * time.Hour
-			expectContent := fmt.Sprintf(`%[1]s is your one-time-password for %[2]s. Use it within the next %[3]s.
+			expectContent := fmt.Sprintf(`%[1]s is your one-time password for %[2]s. Use it within the next %[3]s.
 @%[2]s #%[1]s`, testCode, instancePrimaryDomain, expiry)
 			w.messageSMS = &messages.SMS{
 				SenderPhoneNumber:    "senderNumber",

internal/notification/static/i18n/en.yaml

@@ -35,7 +35,7 @@ VerifyEmailOTP:
   ButtonText: Authenticate
 VerifySMSOTP:
   Text: >-
-    {{.OTP}} is your one-time-password for {{ .Domain }}. Use it within the next {{.Expiry}}.
+    {{.OTP}} is your one-time password for {{ .Domain }}. Use it within the next {{.Expiry}}.
     
     @{{.Domain}} #{{.OTP}}
 DomainClaimed:

internal/static/i18n/en.yaml

@@ -938,8 +938,8 @@ EventTypes:
           added: Second factor added to Login Policy
           removed: Second factor removed from Login Policy
         multifactor:
-          added: Multi factor added to Login Policy
-          removed: Multi factor removed from Login Policy
+          added: Multi-factor added to Login Policy
+          removed: Multi-factor removed from Login Policy
       password:
         complexity:
           added: Password complexity policy added

internal/static/i18n/es.yaml

@@ -937,8 +937,8 @@ EventTypes:
           added: Doble factor añadido a la política de inicio de sesión
           removed: Doble factor eliminado de la política de inicio de sesión
         multifactor:
-          added: Multi factor añadido a la política de inicio de sesión
-          removed: Multi factor eliminado de la política de inicio de sesión
+          added: Multi-factor añadido a la política de inicio de sesión
+          removed: Multi-factor eliminado de la política de inicio de sesión
       password:
         complexity:
           added: Política de complejidad de la contraseña añadida