fix(console): rm mfa link, policy issues, consistency for table spacing (#585)

* rm console.logs

* fix application table

* fix project table padding

* rm user mfa link

* disable policy saving without desc

* lint
This commit is contained in:
Max Peintner 2020-08-17 09:44:21 +02:00 committed by GitHub
parent f61b30420a
commit b0af932dfb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
13 changed files with 15 additions and 29 deletions

View File

@ -2,7 +2,7 @@
<ng-container *ngIf="((['iam.read','iam.write'] | hasRole)) as iamuser$">
<mat-toolbar class="root-header">
<button aria-label="Toggle sidenav" mat-icon-button (click)="drawer.toggle()">
<mat-icon aria-label="Side nav toggle icon">menu</mat-icon>
<i class="icon las la-bars"></i>
</button>
<a *ngIf="(isHandset$ | async) == false" class="title" [routerLink]="['/']">
<img class="logo" alt="zitadel logo" *ngIf="componentCssClass == 'dark-theme'; else lighttheme"

View File

@ -63,7 +63,6 @@ export class IamMembersComponent implements AfterViewInit {
}
updateRoles(member: IamMemberView.AsObject, selectionChange: MatSelectChange): void {
console.log(member.userId, selectionChange.value);
this.adminService.ChangeIamMember(member.userId, selectionChange.value)
.then((newmember: IamMember) => {
this.toast.showInfo('ORG.TOAST.MEMBERCHANGED', true);

View File

@ -176,8 +176,6 @@ export class OrgCreateComponent {
}
public changeSelf(change: MatSlideToggleChange): void {
console.log(change.checked);
if (change.checked) {
this.createSteps = 1;
@ -195,7 +193,6 @@ export class OrgCreateComponent {
}
public createOrgForSelf(): void {
console.log('create for self');
if (this.name && this.name.value) {
this.orgService.CreateOrg(this.name.value).then((org) => {
this.router.navigate(['orgs', org.toObject().id]);

View File

@ -185,16 +185,10 @@ export class OrgDetailComponent implements OnInit, OnDestroy {
}
public verifyDomain(domain: OrgDomainView.AsObject): void {
const dialogRef = this.dialog.open(DomainVerificationComponent, {
this.dialog.open(DomainVerificationComponent, {
data: {
domain: domain,
},
});
dialogRef.afterClosed().subscribe(resp => {
if (resp) {
console.log(resp);
}
});
}
}

View File

@ -62,7 +62,6 @@ export class OrgMembersComponent implements AfterViewInit {
}
updateRoles(member: OrgMemberView.AsObject, selectionChange: MatSelectChange): void {
console.log(member.userId, selectionChange.value);
this.orgService.ChangeMyOrgMember(member.userId, selectionChange.value)
.then((newmember: OrgMember) => {
this.toast.showInfo('ORG.TOAST.MEMBERCHANGED', true);

View File

@ -130,6 +130,7 @@
<div class="btn-container">
<button (click)="savePolicy()" color="primary" type="submit"
[disabled]="(policyType === PolicyComponentType?.COMPLEXITY && !complexityData?.description) || (policyType === PolicyComponentType?.IAM_POLICY && !iamData?.description)"
mat-raised-button>{{ 'ACTIONS.SAVE' | translate }}</button>
</div>
</app-detail-layout>

View File

@ -58,9 +58,12 @@
td,
th {
padding-left: .5rem;
padding-right: .5rem;
&:first-child {
padding-left: 0;
padding-right: 1rem;
padding-right: .5rem;
}
&:last-child {

View File

@ -3,7 +3,7 @@ import { AfterViewInit, Component, Input, OnInit, ViewChild } from '@angular/cor
import { MatPaginator } from '@angular/material/paginator';
import { MatSort } from '@angular/material/sort';
import { MatTable } from '@angular/material/table';
import { merge } from 'rxjs';
import { merge, of } from 'rxjs';
import { tap } from 'rxjs/operators';
import { Application } from 'src/app/proto/generated/management_pb';
import { ProjectService } from 'src/app/services/project.service';
@ -26,7 +26,6 @@ export class ApplicationsComponent implements AfterViewInit, OnInit {
public dataSource!: ProjectApplicationsDataSource;
public selection: SelectionModel<Application.AsObject> = new SelectionModel<Application.AsObject>(true, []);
/** Columns displayed in the table. Columns IDs can be added, removed, or reordered. */
public displayedColumns: string[] = ['select', 'name'];
constructor(private projectService: ProjectService, private toast: ToastService) { }
@ -37,13 +36,11 @@ export class ApplicationsComponent implements AfterViewInit, OnInit {
}
public ngAfterViewInit(): void {
this.sort.sortChange.subscribe(() => this.paginator.pageIndex = 0);
merge(this.sort.sortChange, this.paginator.page)
merge(this.sort ? this.sort?.sortChange : of(null), this.paginator.page)
.pipe(
tap(() => this.loadRolesPage()),
)
.subscribe();
}
private loadRolesPage(): void {

View File

@ -70,9 +70,12 @@ h1 {
td,
th {
padding-left: .5rem;
padding-right: .5rem;
&:first-child {
padding-left: 0;
padding-right: 1rem;
padding-right: .5rem;
}
&:last-child {

View File

@ -27,9 +27,7 @@
</ng-container>
<tr mat-header-row *matHeaderRowDef="displayedColumns"></tr>
<tr class="data-row" mat-row *matRowDef="let row; columns: displayedColumns;"
[routerLink]="['/users', row.id]">
</tr>
<tr class="data-row" mat-row *matRowDef="let row; columns: displayedColumns;"></tr>
</table>
</app-refresh-table>
<div class="add-row">

View File

@ -18,8 +18,7 @@
</ng-container>
<tr mat-header-row *matHeaderRowDef="displayedColumns"></tr>
<tr class="data-row" mat-row *matRowDef="let row; columns: displayedColumns;"
[routerLink]="['/users', row.id]">
<tr class="data-row" mat-row *matRowDef="let row; columns: displayedColumns;">
</tr>
</table>
</app-refresh-table>

View File

@ -65,7 +65,6 @@ export class AuthService {
switchMap(() => from(this.userService.GetMyzitadelPermissions())),
map(rolesResp => rolesResp.toObject().permissionsList),
).subscribe(roles => {
console.log(roles);
this.zitadelPermissions.next(roles);
});
}

View File

@ -28,10 +28,7 @@ export class GrpcService {
public async loadAppEnvironment(): Promise<any> {
return this.http.get('./assets/environment.json')
.toPromise().then((data: any) => {
console.log('init grpc');
if (data && data.authServiceUrl && data.mgmtServiceUrl && data.issuer) {
console.log('init grpc promiseclients');
this.auth = new AuthServicePromiseClient(data.authServiceUrl);
this.mgmt = new ManagementServicePromiseClient(data.mgmtServiceUrl);
this.admin = new AdminServicePromiseClient(data.adminServiceUrl);