Commit Graph

4015 Commits

Author SHA1 Message Date
Elio Bischof
278006370a update main 2025-08-05 21:20:53 +02:00
Saurabh Thapliyal
5747109f14 fix(console): fix shrinking hover background on clear flow button (#10269)
## Problem
The mat-icon-button in the actions flow-type section had a shrinking
hover background. The hover effect was not displaying properly and
appeared constrained.

## Root Cause
The margin rules were being applied to all `span` elements, including
the Material button's internal elements (like `.mat-mdc-button-label`),
which interfered with the button's hover background positioning.

## Solution
- Changed the span selector from `span` to `> span` to target only
direct children
- Added specific margin reset for the button (`margin-right: 0`)
- Added margin reset for the icon inside the button
- This allows the Material button to use its default hover behavior

## Testing
- [x] No visual regressions in text spacing or layout
- [x] Button hover background now displays as a proper circle
- [x] Other buttons on the page remain unaffected
- [x] Matches the behavior of working buttons in trigger sections

## Type of Change
- [x] Bug fix (non-breaking change which fixes an UI issue)


Before :
<img width="427" height="411" alt="Screenshot 2025-07-15 at 6 08 35 PM"
src="https://github.com/user-attachments/assets/f728e1fa-6711-4e8b-ba24-2a84329f50d7"
/>

After fix :
<img width="406" height="404" alt="Screenshot 2025-07-15 at 6 09 36 PM"
src="https://github.com/user-attachments/assets/27d7b08d-684d-4094-8334-844a4e459025"
/>

Fixes hover background issue in actions flow-type section.

---------

Co-authored-by: Saurabh Thapliyal <saurabh@southguild.tech>
Co-authored-by: Marco A. <marco@zitadel.com>
2025-08-05 20:47:55 +02:00
Elio Bischof
b1b4fd3427 pipeline 2025-08-05 20:27:12 +02:00
Elio Bischof
10477b0c46 timeout$ 2025-08-05 20:18:54 +02:00
Elio Bischof
579f921374 update main 2025-08-05 18:25:29 +02:00
Elio Bischof
e210d0a16a chore: fix login integration (#10318)
# Which Problems Are Solved

Login integration tests are not executed in the pipeline

# How the Problems Are Solved

The login integration tests are fixed and added as a pipeline workflow.
It  tests against the built login docker image.
On pipeline failures, developers are guided on how to fix them using a
dev container configured for this purpose.

# Additional Changes

- email domains are replaced by example.com. In case the tests were
accidentally run against a cloud instance, it wouldn't cause bounces.
- pnpm is upgraded, because the --filter argument doesn't work for the
install command on the old version.
- The login Dockerfile is optimized for docker image builds

# Additional Changes From Review for
https://github.com/zitadel/zitadel/pull/10305

These changes were requested from @peintnermax 

- The base dev container starts without any services besides the
database and the dev container itself
- CONTRIBUTING.md is restructured
- To reproduce pipeline checks, only the devcontainer CLI and Docker are
needed. This is described in the CONTRIBUTING.md
- The convenience npm script "generate" is added

# Additional Context

- Follow-up for PR https://github.com/zitadel/zitadel/pull/10305
- Base for https://github.com/zitadel/zitadel/issues/10277
2025-08-05 15:59:30 +00:00
Elio Bischof
41ca21491c pipelin 2025-08-05 17:28:47 +02:00
Niko
30175041c1 docs: Typo in environment variable reference for OIDC:DeviceAuth:UserCode:CharAmount config (#10287)
# Which Problems Are Solved

Typo in environment variable reference for
OIDC:DeviceAuth:UserCode:CharAmount config
`ZITADEL_OIDC_DEVICEAUTH_USERCODE_CHARARMOUNT` - _CHARA_**~~R~~**_MOUNT_

# How the Problems Are Solved

Fixed the typo  `ZITADEL_OIDC_DEVICEAUTH_USERCODE_CHARAMOUNT`

Co-authored-by: Stefan Benz <46600784+stebenz@users.noreply.github.com>
2025-08-05 15:12:07 +00:00
Elio Bischof
3b81f1bd75 remove setup 2025-08-05 16:58:10 +02:00
Elio Bischof
df2ac9b189 fix acceptance tests 2025-08-05 16:36:28 +02:00
Elio Bischof
3ae58de738 chore: fix login acceptance tests 2025-08-05 11:45:15 +02:00
Zach Hirschtritt
d4222d6fd6 fix: don't trigger session projection on notification handling (#10298)
# Which Problems Are Solved

There is an outstanding bug wherein a session projection can fail to
complete and an session OTP challenge is blocked because the projection
doesn't exist. Not sure why the session projection can fail to persist -
I can't find any error logs or failed events to crosscheck. However, I
can clearly see the session events persisted with user/password checks
and the OTP challenged added on the session - but no session projection
on sessions8 table.

This only seems to come up under somewhat higher loads - about 5
logins/s and only for about 1% of cases. (where a "login" is:
authRequest, createSession, getAuthCodeWithSession, tokenExchange, and
finally, otpSmsChallenge...💥).

# How the Problems Are Solved

This is only half a fix, but an important one as it can block login for
affected users. Instead of triggering and checking the session
projection on notification enqueuing, build a write model directly from
the ES.

# Additional Changes

# Additional Context

This doesn't touch the "legacy" notification handler as to limit the
blast radius of this change. But might be worth adding there too.

The test is difficult to update correctly so is somewhat incomplete. Any
suggestions for refactoring or test helpers I'm missing would be
welcome.

Co-authored-by: Silvan <27845747+adlerhurst@users.noreply.github.com>
2025-08-04 13:33:01 +00:00
Mahdi JafariRaviz
b93b6a8a1c fix: disable client id in oidc configuration (#10177)
# Which Problems Are Solved

This pr disables the client id in oidc configuration in console, as
mentioned in #10149.

# How the Problems Are Solved

I re-disabled the field from inside the form.

# Additional Context

- Closes #10149.
- Closes #8530
2025-08-04 12:16:18 +00:00
Markus Heinemann
1728297d3c docs(oidc-playground): update scopes and default instance domain (#9995)
# Which Problems Are Solved

This PR resolves #4845 by enhancing the OIDC Playground:
* set default instance domain to `http://localhost:8080`
* openid checkbox is now disabled
* add explanation texts for custom zitadel scopes

# How the Problems Are Solved

* The checkbox for the `openid` scope is set to `disabled`
* The default value for the instance domain is update by using
`setInstance`
* A new map with explanation texts for the custom scopes is introduced.
During the rendering process of the scope checkboxes the value from this
map is displayed, if the scope exists as key.

# Additional Changes

During the local setup of the documentation webapp I got some react
errors on the authrequest page. This issue has ben solved by refactoring
the usage of an `useEffect` block.

# Additional Context

- Closes #4845

PS. 
I did not found any scripts for linting/formatting (e.g. eslint,
prettier) for the docs project. This is a bit annoying because when I
use my local configurations of eslint/prettier the whole file get's
refactored with unnecessary changes (change of import order, indention
etc.). It would be great to add some custom configurations to to make
the development process easier and enforce a consistent coding style :)

Co-authored-by: Markus Heinemann <markus@trustify.ch>
Co-authored-by: Tim Möhlmann <tim+github@zitadel.com>
2025-08-04 11:24:54 +00:00
Elio Bischof
f5d98202c6 pull 2025-08-02 07:26:22 +02:00
Elio Bischof
ca2ecf3c23 pull 2025-08-02 07:22:51 +02:00
Elio Bischof
abb969617f pull 2025-08-02 07:16:15 +02:00
Elio Bischof
2c72a63473 pull 2025-08-02 07:00:02 +02:00
Elio Bischof
df6bda8941 update checks 2025-08-02 06:54:32 +02:00
Elio Bischof
2d02c5c4bc update main 2025-08-02 06:54:20 +02:00
Elio Bischof
b37eddb7e6 cache cypress binary 2025-08-02 06:37:25 +02:00
Elio Bischof
c066e7cd0d simplify 2025-08-02 05:35:33 +02:00
Maximilian
f73b2fefd6 docs(inconsistent naming): Organization ID (#10370)
# Which Problems Are Solved

partially #9342

# How the Problems Are Solved

Suggested changes.
"Resource Owner" will remain in a couple of places, since these are
terms that are used in console / APIs.

# Additional Changes


# Additional Context

---------

Co-authored-by: Stefan Benz <46600784+stebenz@users.noreply.github.com>
2025-08-01 11:09:47 +00:00
Marco A.
c6392e175f docs: update roadmap (#10369)
# Which Problems Are Solved

The roadmap page is not up to date with the latest changes that have
been released with Zitadel v4.

# How the Problems Are Solved

Update the doc according to #10309

# Dependencies

- https://github.com/zitadel/zitadel/pull/10249 -> Update the API docs
with deprecated endpoints
- https://github.com/zitadel/zitadel/pull/10364 -> Actions v2 beta to v2

# Additional Context

- Closes #10309
2025-08-01 10:27:26 +00:00
Gayathri Vijayan
00b0af4368 fix(saml): use transient mapping attribute when nameID is missing in saml response (#10353)
# Which Problems Are Solved

In the SAML responses from some IDPs (e.g. ADFS and Shibboleth), the
`<NameID>` part could be missing in `<Subject>`, and in some cases, the
`<Subject>` part might be missing as well. This causes Zitadel to fail
the SAML login with the following error message:

```
ID=SAML-EFG32 Message=Errors.Intent.ResponseInvalid
```

# How the Problems Are Solved

This is solved by adding a workaround to accept a transient mapping
attribute when the `NameID` or the `Subject` is missing in the SAML
response. This requires setting the custom transient mapping attribute
in the SAML IDP config in Zitadel, and it should be present in the SAML
response as well.

<img width="639" height="173" alt="image"
src="https://github.com/user-attachments/assets/cbb792f1-aa6c-4b16-ad31-bd126d164eae"
/>


# Additional Changes
N/A

# Additional Context
- Closes #10251
2025-07-31 15:12:26 +00:00
Stefan Benz
4046dd31b4 feat: actions v2 api GA (#10364)
# Which Problems Are Solved

The Actions v2beta API is not yet promoted to GA.

# How the Problems Are Solved

Promote Actions v2Beta API to Actions v2 API.

# Additional Changes

None

# Additional Context

None
2025-07-31 13:09:09 +00:00
Livio Spring
28d70db6ae docs: document service ping configuration and data sent (#10167)
# Which Problems Are Solved

With the introduction of the service ping, we'll send data from all
systems back to a central endpoint for analytics and getting insights
about usage. To make it visible what data is sent and provide the users
an easy way to opt-out, we need a small documentation to tell them what
and how.

# How the Problems Are Solved

Document the service ping including what data is sent and how to opt-out
or configure most important settings.

# Additional Changes

None

# Additional Context

relates to #9869
2025-07-31 10:23:19 +00:00
Elio Bischof
b06e4e2f9c docs(self-hosting): simplify lb example and replace compose example (#9844)
# Which Problems Are Solved

The load balancing compose example uses a dedicated service
`use-new-login` that gives the set up machine user the login role and
requires the v2 login using an instance feature. This is cumbersome and
unnecessary.

# How the Problems Are Solved

- A login client machine user is set up and the token is passed to the
login by using the environment variable ZITADEL_SERVICE_USER_TOKEN_FILE.
- The unnecessary service is removed

# Additional Changes

- Uses the static `MasterkeyNeedsToHave32Characters` master key.
- The load balancing example replaces the previous Docker Compose
example.
- The login uses `network_mode: service:zitadel` so it can access the
zitadel service in the docker network via localhost.
- Uses the docker provider for Traefik.

# Additional Context

- Complements https://github.com/zitadel/zitadel/pull/9496
- Partially closes https://github.com/zitadel/zitadel/issues/10016
- When we release, we should update the image tags to latest, for
example with [this PR](https://github.com/zitadel/zitadel/pull/10249).

---------

Co-authored-by: Tim Möhlmann <tim+github@zitadel.com>
2025-07-31 12:51:38 +03:00
Gayathri Vijayan
6a93950b64 docs: fix the example docs related to set execution api (actions) (#10359)
# Which Problems Are Solved

Fix docs related to Actions V2 SetExecution API
[endpoint](https://zitadel.com/docs/apis/resources/action_service_v2/action-service-set-execution)

# How the Problems Are Solved

The examples are updated

# Additional Changes
N/A

# Additional Context
- Closes #10320
2025-07-31 10:50:17 +02:00
Elio Bischof
dcdea5a4fe fix: fix login image (#10355)
# Which Problems Are Solved

The broken login image is fixed.

# How the Problems Are Solved

The most important learnings from
https://github.com/zitadel/zitadel/pull/10318 are applied:
- Path in entrypoint is fixed: `exec node /runtime/apps/login/server.js`
- .dockerignore is updated so CSS styles are built into the image
- `source: .` is passed to the docker-bake action. Without this,
docker-bake builds from a remote context, which seems to be slow and not
updated on new PR commits. Looks like the bake action uploads an
artifact that [conflicts with the compile
workflow](https://github.com/zitadel/zitadel/actions/runs/16620417216/job/47023478437).
Therefore, a pattern is added to the compile workflow so only relevant
artifacts are selected.
2025-07-31 07:51:26 +00:00
Elio Bischof
90dc64a2bb devx 2025-07-31 05:57:52 +02:00
Elio Bischof
b400b1b42c network_mode=service:mock-zitadel 2025-07-31 03:40:00 +02:00
Elio Bischof
8678aefd03 remove depot 2025-07-31 03:30:34 +02:00
Elio Bischof
7ab1e4043c depot builder 2025-07-31 03:19:39 +02:00
Elio Bischof
c1685f2724 depot builder 2025-07-31 03:17:34 +02:00
Elio Bischof
e0a0ae9e1c depot runner 2025-07-31 02:51:30 +02:00
Elio Bischof
ce69eb00c3 depot runner 2025-07-31 02:48:50 +02:00
Elio Bischof
43accc4cf8 optimize 2025-07-31 02:26:56 +02:00
Elio Bischof
37c13bbc77 bake 2025-07-31 02:00:10 +02:00
Elio Bischof
9c83436128 cache login build 2025-07-31 00:55:36 +02:00
Elio Bischof
3c78abca93 chore: exclude npm packages from go linting (#10345)
# Which Problems Are Solved

Not all NPM packages are excluded from go linting.

# How the Problems Are Solved

Missing exclusions are added.

# Additional Context

Follows-up on #10331

Co-authored-by: Silvan <27845747+adlerhurst@users.noreply.github.com>
2025-07-30 22:47:40 +00:00
Elio Bischof
048d152650 cache login build 2025-07-31 00:17:07 +02:00
Elio Bischof
5d5787ca3e cache login build 2025-07-31 00:09:47 +02:00
Elio Bischof
2dc275b84b builder 2025-07-30 23:41:23 +02:00
Elio Bischof
fddadfe4a0 update base 2025-07-30 23:33:46 +02:00
Elio Bischof
fd064fc974 Merge branch 'fix-firefox-e2e' into fix-login-image-minimal 2025-07-30 23:23:32 +02:00
Elio Bischof
51431529d1 update cypress 2025-07-30 22:42:19 +02:00
Elio Bischof
e6bb3246e8 no cache 2025-07-30 22:31:58 +02:00
Elio Bischof
3c30720002 cypress install 2025-07-30 19:32:51 +02:00
Elio Bischof
2504e30411 file name 2025-07-30 19:14:13 +02:00