Update v7.3.4 changelogs

Close #1607

.gitattributes

@@ -11,7 +11,7 @@
 *.bat text eol=crlf
 
 # Denote all files that are truly binary and should not be modified.
-chromeos/** binary
+tools/** binary
 *.jar binary
 *.exe binary
 *.apk binary

.gitmodules

@@ -19,3 +19,9 @@
 [submodule "nanopb"]
 	path = native/jni/external/nanopb
 	url = https://github.com/nanopb/nanopb.git
+[submodule "mincrypt"]
+	path = native/jni/external/mincrypt
+	url = https://github.com/topjohnwu/mincrypt.git
+[submodule "termux-elf-cleaner"]
+	path = tools/termux-elf-cleaner
+	url = https://github.com/termux/termux-elf-cleaner.git

README.MD

@@ -10,7 +10,7 @@ Furthermore, Magisk provides a **Systemless Interface** to alter the system (or
 
 ## Bug Reports
 
-**Make sure to install the latest [Canary Build](https://forum.xda-developers.com/apps/magisk/dev-magisk-canary-channel-bleeding-edge-t3839337) before reporting any bugs!** **DO NOT** report bugs that is already fixed upstream. Follow the instructions in the [Canary Channel XDA Thread](https://forum.xda-developers.com/apps/magisk/dev-magisk-canary-channel-bleeding-edge-t3839337), and report a bug either by opening an issue on GitHub or directly in the thread.
+**Make sure to install the latest [Canary Build](https://forum.xda-developers.com/apps/magisk/dev-magisk-canary-channel-bleeding-edge-t3839337) before reporting any bugs!** **DO NOT** report bugs that are already fixed upstream. Follow the instructions in the [Canary Channel XDA Thread](https://forum.xda-developers.com/apps/magisk/dev-magisk-canary-channel-bleeding-edge-t3839337), and report a bug either by [opening an issue on GitHub](https://github.com/topjohnwu/Magisk/issues) or directly in the thread.
 
 ## Building Environment Requirements
 

app/build.gradle

@@ -17,8 +17,8 @@ android {
         applicationId 'com.topjohnwu.magisk'
         vectorDrawables.useSupportLibrary = true
         multiDexEnabled true
-        versionName configProps['appVersion']
-        versionCode configProps['appVersionCode'] as Integer
+        versionName props['appVersion']
+        versionCode props['appVersionCode'] as Integer
     }
 
     buildTypes {
@@ -39,7 +39,7 @@ android {
         exclude '/META-INF/*.kotlin_module'
         exclude '/META-INF/rxkotlin.properties'
         exclude '/androidsupportmultidexversion.txt'
-        exclude '/org/**'
+        exclude '/org/bouncycastle/**'
         exclude '/kotlin/**'
         exclude '/kotlinx/**'
     }
@@ -55,7 +55,6 @@ androidExtensions {
 
 dependencies {
     implementation fileTree(include: ['*.jar'], dir: 'libs')
-    implementation project(':net')
     implementation project(':shared')
     implementation project(':signing')
 
@@ -63,13 +62,14 @@ dependencies {
     implementation 'com.jakewharton.timber:timber:4.7.1'
     implementation 'com.github.skoumalcz:teanity:0.3.3'
     implementation 'com.ncapdevi:frag-nav:3.2.0'
+    implementation 'com.github.pwittchen:reactivenetwork-rx2:3.0.6'
 
-    def vMarkwon = '3.0.1'
+    def vMarkwon = '3.1.0'
     implementation "ru.noties.markwon:core:${vMarkwon}"
     implementation "ru.noties.markwon:html:${vMarkwon}"
     implementation "ru.noties.markwon:image-svg:${vMarkwon}"
 
-    def vLibsu = '2.5.0'
+    def vLibsu = '2.5.1'
     implementation "com.github.topjohnwu.libsu:core:${vLibsu}"
     implementation "com.github.topjohnwu.libsu:io:${vLibsu}"
 
@@ -78,12 +78,13 @@ dependencies {
     implementation "org.koin:koin-android:${vKoin}"
     implementation "org.koin:koin-androidx-viewmodel:${vKoin}"
 
-    def vRetrofit = "2.6.0"
+    def vRetrofit = '2.6.1'
     implementation "com.squareup.retrofit2:retrofit:${vRetrofit}"
     implementation "com.squareup.retrofit2:converter-moshi:${vRetrofit}"
+    implementation "com.squareup.retrofit2:converter-scalars:${vRetrofit}"
     implementation "com.squareup.retrofit2:adapter-rxjava2:${vRetrofit}"
 
-    def vOkHttp = "3.12.3"
+    def vOkHttp = '3.12.2'
     implementation "com.squareup.okhttp3:okhttp:${vOkHttp}"
     implementation "com.squareup.okhttp3:logging-interceptor:${vOkHttp}"
 
@@ -101,14 +102,18 @@ dependencies {
     }
     def vRoom = "2.1.0"
     implementation "com.github.topjohnwu:room-runtime:${vRoom}"
+    kapt "androidx.room:room-compiler:${vRoom}"
+
+    implementation "org.jetbrains.kotlin:kotlin-stdlib:${kotlinVer}"
+    implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:${kotlinVer}"
 
     implementation 'androidx.constraintlayout:constraintlayout:1.1.3'
     implementation 'androidx.browser:browser:1.0.0'
-    implementation 'androidx.preference:preference:1.0.0'
-    implementation 'androidx.recyclerview:recyclerview:1.1.0-alpha06'
+    implementation 'androidx.preference:preference:1.1.0'
+    implementation 'androidx.recyclerview:recyclerview:1.1.0-beta04'
     implementation 'androidx.cardview:cardview:1.0.0'
-    implementation 'androidx.work:work-runtime:2.0.1'
-    implementation 'androidx.transition:transition:1.2.0-alpha01'
+    implementation 'androidx.work:work-runtime:2.2.0'
+    implementation 'androidx.transition:transition:1.2.0-rc01'
     implementation 'androidx.multidex:multidex:2.0.1'
-    implementation 'com.google.android.material:material:1.1.0-alpha07'
+    implementation 'com.google.android.material:material:1.1.0-alpha10'
 }

app/proguard-rules.pro

@@ -17,9 +17,9 @@
 #}
 
 # Snet
--keepclassmembers class com.topjohnwu.magisk.utils.ISafetyNetHelper { *; }
--keep,allowobfuscation interface com.topjohnwu.magisk.utils.ISafetyNetHelper$Callback
--keepclassmembers class * implements com.topjohnwu.magisk.utils.ISafetyNetHelper$Callback {
+-keepclassmembers class com.topjohnwu.magisk.utils.SafetyNetHelper { *; }
+-keep,allowobfuscation interface com.topjohnwu.magisk.utils.SafetyNetHelper$Callback
+-keepclassmembers class * implements com.topjohnwu.magisk.utils.SafetyNetHelper$Callback {
   void onResponse(int);
 }
 
@@ -36,9 +36,6 @@
 
 # Strip logging
 -assumenosideeffects class timber.log.Timber.Tree { *; }
--assumenosideeffects class com.topjohnwu.magisk.utils.Logger {
-  public *** debug(...);
-}
 
 # Excessive obfuscation
 -repackageclasses 'a'

app/src/main/AndroidManifest.xml

@@ -3,14 +3,15 @@
     xmlns:tools="http://schemas.android.com/tools"
     package="com.topjohnwu.magisk">
 
+    <uses-permission android:name="android.permission.INTERNET"/>
     <uses-permission android:name="android.permission.VIBRATE" />
     <uses-permission android:name="android.permission.RECEIVE_BOOT_COMPLETED" />
     <uses-permission android:name="android.permission.FOREGROUND_SERVICE" />
     <uses-permission android:name="android.permission.USE_FINGERPRINT" />
 
     <application
-        android:allowBackup="true"
         android:name="a.e"
+        android:allowBackup="true"
         android:theme="@style/MagiskTheme"
         android:usesCleartextTraffic="true"
         tools:ignore="UnusedAttribute,GoogleAppIndexingWarning">
@@ -41,9 +42,9 @@
 
         <activity
             android:name="a.m"
-            android:exported="false"
             android:directBootAware="true"
             android:excludeFromRecents="true"
+            android:exported="false"
             android:theme="@style/MagiskTheme.SU" />
 
         <!-- Receiver -->
@@ -65,7 +66,8 @@
 
         <!-- Service -->
 
-        <service android:name="a.j" />
+        <service android:name="a.j"
+            android:exported="false" />
 
         <!-- Hardcode GMS version -->
         <meta-data

app/src/main/java/a/j.java

@@ -1,7 +1,7 @@
 package a;
 
-import com.topjohnwu.magisk.model.download.DownloadModuleService;
+import com.topjohnwu.magisk.model.download.DownloadService;
 
-public class j extends DownloadModuleService {
+public class j extends DownloadService {
     /* stub */
 }

app/src/main/java/a/w.java

@@ -2,14 +2,14 @@ package a;
 
 import android.content.Context;
 
-import com.topjohnwu.magisk.model.worker.DelegateWorker;
-
-import java.lang.reflect.ParameterizedType;
-
 import androidx.annotation.NonNull;
 import androidx.work.Worker;
 import androidx.work.WorkerParameters;
 
+import com.topjohnwu.magisk.model.worker.DelegateWorker;
+
+import java.lang.reflect.ParameterizedType;
+
 public abstract class w<T extends DelegateWorker> extends Worker {
 
     /* Wrapper class to workaround Proguard -keep class * extends Worker */
@@ -22,7 +22,7 @@ public abstract class w<T extends DelegateWorker> extends Worker {
         try {
             base = ((Class<T>) ((ParameterizedType) getClass().getGenericSuperclass())
                     .getActualTypeArguments()[0]).newInstance();
-            base.setActualWorker(this);
+            base.attachWorker(this);
         } catch (Exception ignored) {}
     }
 

app/src/main/java/com/topjohnwu/magisk/App.kt

@@ -1,35 +1,42 @@
 package com.topjohnwu.magisk
 
-import android.annotation.SuppressLint
-import android.app.Activity
 import android.app.Application
 import android.content.Context
 import android.content.res.Configuration
-import android.os.AsyncTask
-import android.os.Build
-import android.os.Bundle
 import androidx.appcompat.app.AppCompatDelegate
 import androidx.multidex.MultiDex
 import androidx.room.Room
 import androidx.work.impl.WorkDatabase
 import androidx.work.impl.WorkDatabase_Impl
+import com.topjohnwu.magisk.data.database.RepoDatabase
+import com.topjohnwu.magisk.data.database.RepoDatabase_Impl
+import com.topjohnwu.magisk.di.ActivityTracker
 import com.topjohnwu.magisk.di.koinModules
+import com.topjohnwu.magisk.extensions.get
+import com.topjohnwu.magisk.net.Networking
 import com.topjohnwu.magisk.utils.LocaleManager
 import com.topjohnwu.magisk.utils.RootUtils
-import com.topjohnwu.magisk.utils.inject
-import com.topjohnwu.net.Networking
 import com.topjohnwu.superuser.Shell
 import org.koin.android.ext.koin.androidContext
 import org.koin.core.context.startKoin
 import timber.log.Timber
-import java.util.concurrent.ThreadPoolExecutor
 
-open class App : Application(), Application.ActivityLifecycleCallbacks {
+open class App : Application() {
 
-    lateinit var protectedContext: Context
-
-    @Volatile
-    private var foreground: Activity? = null
+    init {
+        AppCompatDelegate.setCompatVectorFromResourcesEnabled(true)
+        Shell.Config.setFlags(Shell.FLAG_MOUNT_MASTER or Shell.FLAG_USE_MAGISK_BUSYBOX)
+        Shell.Config.verboseLogging(BuildConfig.DEBUG)
+        Shell.Config.addInitializers(RootUtils::class.java)
+        Shell.Config.setTimeout(2)
+        Room.setFactory {
+            when (it) {
+                WorkDatabase::class.java -> WorkDatabase_Impl()
+                RepoDatabase::class.java -> RepoDatabase_Impl()
+                else -> null
+            }
+        }
+    }
 
     override fun attachBaseContext(base: Context) {
         super.attachBaseContext(base)
@@ -42,17 +49,7 @@ open class App : Application(), Application.ActivityLifecycleCallbacks {
             modules(koinModules)
         }
 
-        protectedContext = baseContext
-        self = this
-        deContext = base
-
-        if (Build.VERSION.SDK_INT >= 24) {
-            protectedContext = base.createDeviceProtectedStorageContext()
-            deContext = protectedContext
-            deContext.moveSharedPreferencesFrom(base, base.defaultPrefsName)
-        }
-
-        registerActivityLifecycleCallbacks(this)
+        registerActivityLifecycleCallbacks(get<ActivityTracker>())
 
         Networking.init(base)
         LocaleManager.setLocale(this)
@@ -62,67 +59,4 @@ open class App : Application(), Application.ActivityLifecycleCallbacks {
         super.onConfigurationChanged(newConfig)
         LocaleManager.setLocale(this)
     }
-
-    //region ActivityLifecycleCallbacks
-    override fun onActivityCreated(activity: Activity, bundle: Bundle?) {}
-
-    override fun onActivityStarted(activity: Activity) {}
-
-    @Synchronized
-    override fun onActivityResumed(activity: Activity) {
-        foreground = activity
-    }
-
-    @Synchronized
-    override fun onActivityPaused(activity: Activity) {
-        foreground = null
-    }
-
-    override fun onActivityStopped(activity: Activity) {}
-
-    override fun onActivitySaveInstanceState(activity: Activity, bundle: Bundle) {}
-
-    override fun onActivityDestroyed(activity: Activity) {}
-    //endregion
-
-    private val Context.defaultPrefsName get() = "${packageName}_preferences"
-
-    companion object {
-
-        @SuppressLint("StaticFieldLeak")
-        @Deprecated("Use dependency injection")
-        @JvmStatic
-        lateinit var self: App
-
-        @SuppressLint("StaticFieldLeak")
-        @Deprecated("Use dependency injection; replace with protectedContext")
-        @JvmStatic
-        lateinit var deContext: Context
-
-        @Deprecated("Use Rx or similar")
-        @JvmField
-        var THREAD_POOL: ThreadPoolExecutor
-
-        init {
-            AppCompatDelegate.setCompatVectorFromResourcesEnabled(true)
-            Shell.Config.setFlags(Shell.FLAG_MOUNT_MASTER or Shell.FLAG_USE_MAGISK_BUSYBOX)
-            Shell.Config.verboseLogging(BuildConfig.DEBUG)
-            Shell.Config.addInitializers(RootUtils::class.java)
-            Shell.Config.setTimeout(2)
-            THREAD_POOL = AsyncTask.THREAD_POOL_EXECUTOR as ThreadPoolExecutor
-            Room.setFactory {
-                when (it) {
-                    WorkDatabase::class.java -> WorkDatabase_Impl()
-                    else -> null
-                }
-            }
-        }
-
-        @Deprecated("")
-        @JvmStatic
-        fun foreground(): Activity? {
-            val app: App by inject()
-            return app.foreground
-        }
-    }
 }

app/src/main/java/com/topjohnwu/magisk/ClassMap.kt

@@ -1,6 +1,6 @@
 package com.topjohnwu.magisk
 
-import com.topjohnwu.magisk.model.download.DownloadModuleService
+import com.topjohnwu.magisk.model.download.DownloadService
 import com.topjohnwu.magisk.model.receiver.GeneralReceiver
 import com.topjohnwu.magisk.model.update.UpdateCheckService
 import com.topjohnwu.magisk.ui.MainActivity
@@ -16,11 +16,10 @@ object ClassMap {
         FlashActivity::class.java to a.f::class.java,
         UpdateCheckService::class.java to a.g::class.java,
         GeneralReceiver::class.java to a.h::class.java,
-        DownloadModuleService::class.java to a.j::class.java,
+        DownloadService::class.java to a.j::class.java,
         SuRequestActivity::class.java to a.m::class.java
     )
 
-    @JvmStatic
     operator fun <T : Class<*>>get(c: Class<*>): T {
         return map.getOrElse(c) { throw IllegalArgumentException() } as T
     }

app/src/main/java/com/topjohnwu/magisk/Config.kt

@@ -1,14 +1,20 @@
 package com.topjohnwu.magisk
 
 import android.content.Context
+import android.content.SharedPreferences
+import android.os.Environment
 import android.util.Xml
 import androidx.core.content.edit
 import com.topjohnwu.magisk.data.database.SettingsDao
 import com.topjohnwu.magisk.data.database.StringDao
 import com.topjohnwu.magisk.data.repository.DBConfig
 import com.topjohnwu.magisk.di.Protected
+import com.topjohnwu.magisk.extensions.get
+import com.topjohnwu.magisk.extensions.inject
+import com.topjohnwu.magisk.extensions.packageName
 import com.topjohnwu.magisk.model.preference.PreferenceModel
-import com.topjohnwu.magisk.utils.*
+import com.topjohnwu.magisk.utils.FingerprintHelper
+import com.topjohnwu.magisk.utils.Utils
 import com.topjohnwu.superuser.Shell
 import com.topjohnwu.superuser.io.SuFile
 import com.topjohnwu.superuser.io.SuFileInputStream
@@ -39,9 +45,9 @@ object Config : PreferenceModel, DBConfig {
         const val CUSTOM_CHANNEL = "custom_channel"
         const val LOCALE = "locale"
         const val DARK_THEME = "dark_theme"
-        const val ETAG_KEY = "ETag"
         const val REPO_ORDER = "repo_order"
         const val SHOW_SYSTEM_APP = "show_system"
+        const val DOWNLOAD_PATH = "download_path"
 
         // system state
         const val MAGISKHIDE = "magiskhide"
@@ -91,9 +97,10 @@ object Config : PreferenceModel, DBConfig {
     }
 
     private val defaultChannel =
-            if (Utils.isCanary) Value.CANARY_DEBUG_CHANNEL
-            else Value.DEFAULT_CHANNEL
+        if (Utils.isCanary) Value.CANARY_DEBUG_CHANNEL
+        else Value.DEFAULT_CHANNEL
 
+    var downloadPath by preference(Key.DOWNLOAD_PATH, Environment.DIRECTORY_DOWNLOADS)
     var repoOrder by preference(Key.REPO_ORDER, Value.ORDER_DATE)
 
     var suDefaultTimeout by preferenceStrInt(Key.SU_REQUEST_TIMEOUT, 10)
@@ -104,73 +111,26 @@ object Config : PreferenceModel, DBConfig {
     var darkTheme by preference(Key.DARK_THEME, true)
     var suReAuth by preference(Key.SU_REAUTH, false)
     var checkUpdate by preference(Key.CHECK_UPDATES, true)
-    @JvmStatic
     var magiskHide by preference(Key.MAGISKHIDE, true)
     var coreOnly by preference(Key.COREONLY, false)
     var showSystemApp by preference(Key.SHOW_SYSTEM_APP, false)
 
     var customChannelUrl by preference(Key.CUSTOM_CHANNEL, "")
     var locale by preference(Key.LOCALE, "")
-    @JvmStatic
-    var etagKey by preference(Key.ETAG_KEY, "")
 
     var rootMode by dbSettings(Key.ROOT_ACCESS, Value.ROOT_ACCESS_APPS_AND_ADB)
     var suMntNamespaceMode by dbSettings(Key.SU_MNT_NS, Value.NAMESPACE_MODE_REQUESTER)
     var suMultiuserMode by dbSettings(Key.SU_MULTIUSER_MODE, Value.MULTIUSER_MODE_OWNER_ONLY)
     var suFingerprint by dbSettings(Key.SU_FINGERPRINT, false)
-    @JvmStatic
-    var suManager by dbStrings(Key.SU_MANAGER, "")
+    var suManager by dbStrings(Key.SU_MANAGER, "", true)
+
+    // Always return a path in external storage where we can write
+    val downloadDirectory get() =
+        Utils.ensureDownloadPath(downloadPath) ?: get<Context>().getExternalFilesDir(null)!!
 
     fun initialize() = prefs.edit {
-        val config = SuFile.open("/data/adb", Const.MANAGER_CONFIGS)
-        if (config.exists()) runCatching {
-            val input = SuFileInputStream(config).buffered()
-            val parser = Xml.newPullParser()
-            parser.setFeature(XmlPullParser.FEATURE_PROCESS_NAMESPACES, false)
-            parser.setInput(input, "UTF-8")
-            parser.nextTag()
-            parser.require(XmlPullParser.START_TAG, null, "map")
-            while (parser.next() != XmlPullParser.END_TAG) {
-                if (parser.eventType != XmlPullParser.START_TAG)
-                    continue
-                val key: String = parser.getAttributeValue(null, "name")
-                val value: String = parser.getAttributeValue(null, "value")
-                when (parser.name) {
-                    "string" -> {
-                        parser.require(XmlPullParser.START_TAG, null, "string")
-                        putString(key, parser.nextText())
-                        parser.require(XmlPullParser.END_TAG, null, "string")
-                    }
-                    "boolean" -> {
-                        parser.require(XmlPullParser.START_TAG, null, "boolean")
-                        putBoolean(key, value.toBoolean())
-                        parser.nextTag()
-                        parser.require(XmlPullParser.END_TAG, null, "boolean")
-                    }
-                    "int" -> {
-                        parser.require(XmlPullParser.START_TAG, null, "int")
-                        putInt(key, value.toInt())
-                        parser.nextTag()
-                        parser.require(XmlPullParser.END_TAG, null, "int")
-                    }
-                    "long" -> {
-                        parser.require(XmlPullParser.START_TAG, null, "long")
-                        putLong(key, value.toLong())
-                        parser.nextTag()
-                        parser.require(XmlPullParser.END_TAG, null, "long")
-                    }
-                    "float" -> {
-                        parser.require(XmlPullParser.START_TAG, null, "int")
-                        putFloat(key, value.toFloat())
-                        parser.nextTag()
-                        parser.require(XmlPullParser.END_TAG, null, "int")
-                    }
-                    else -> parser.next()
-                }
-            }
-            config.delete()
-        }
-        remove(Key.ETAG_KEY)
+        parsePrefs(this)
+
         if (!prefs.contains(Key.UPDATE_CHANNEL))
             putString(Key.UPDATE_CHANNEL, defaultChannel.toString())
 
@@ -184,12 +144,64 @@ object Config : PreferenceModel, DBConfig {
         putBoolean(Key.SU_FINGERPRINT, FingerprintHelper.useFingerprint())
     }
 
-    @JvmStatic
+    private fun parsePrefs(editor: SharedPreferences.Editor) = editor.apply {
+        val config = SuFile.open("/data/adb", Const.MANAGER_CONFIGS)
+        if (config.exists()) runCatching {
+            val input = SuFileInputStream(config).buffered()
+            val parser = Xml.newPullParser()
+            parser.setFeature(XmlPullParser.FEATURE_PROCESS_NAMESPACES, false)
+            parser.setInput(input, "UTF-8")
+            parser.nextTag()
+            parser.require(XmlPullParser.START_TAG, null, "map")
+            while (parser.next() != XmlPullParser.END_TAG) {
+                if (parser.eventType != XmlPullParser.START_TAG)
+                    continue
+                val key: String = parser.getAttributeValue(null, "name")
+                fun value() = parser.getAttributeValue(null, "value")!!
+                when (parser.name) {
+                    "string" -> {
+                        parser.require(XmlPullParser.START_TAG, null, "string")
+                        putString(key, parser.nextText())
+                        parser.require(XmlPullParser.END_TAG, null, "string")
+                    }
+                    "boolean" -> {
+                        parser.require(XmlPullParser.START_TAG, null, "boolean")
+                        putBoolean(key, value().toBoolean())
+                        parser.nextTag()
+                        parser.require(XmlPullParser.END_TAG, null, "boolean")
+                    }
+                    "int" -> {
+                        parser.require(XmlPullParser.START_TAG, null, "int")
+                        putInt(key, value().toInt())
+                        parser.nextTag()
+                        parser.require(XmlPullParser.END_TAG, null, "int")
+                    }
+                    "long" -> {
+                        parser.require(XmlPullParser.START_TAG, null, "long")
+                        putLong(key, value().toLong())
+                        parser.nextTag()
+                        parser.require(XmlPullParser.END_TAG, null, "long")
+                    }
+                    "float" -> {
+                        parser.require(XmlPullParser.START_TAG, null, "int")
+                        putFloat(key, value().toFloat())
+                        parser.nextTag()
+                        parser.require(XmlPullParser.END_TAG, null, "int")
+                    }
+                    else -> parser.next()
+                }
+            }
+            config.delete()
+        }
+    }
+
     fun export() {
         // Flush prefs to disk
-        prefs.edit().apply()
-        val xml = File("${get<Context>(Protected).filesDir.parent}/shared_prefs",
-                "${packageName}_preferences.xml")
+        prefs.edit().commit()
+        val xml = File(
+            "${get<Context>(Protected).filesDir.parent}/shared_prefs",
+            "${packageName}_preferences.xml"
+        )
         Shell.su("cat $xml > /data/adb/${Const.MANAGER_CONFIGS}").exec()
     }
 

app/src/main/java/com/topjohnwu/magisk/Const.kt

@@ -1,39 +1,27 @@
 package com.topjohnwu.magisk
 
-import android.os.Environment
 import android.os.Process
-
 import java.io.File
 
 object Const {
 
-    const val DEBUG_TAG = "MagiskManager"
-
     // Paths
     const val MAGISK_PATH = "/sbin/.magisk/img"
-    @JvmField
-    val EXTERNAL_PATH = Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_DOWNLOADS)!!
-    @JvmField
     var MAGISK_DISABLE_FILE = File("xxx")
     const val TMP_FOLDER_PATH = "/dev/tmp"
     const val MAGISK_LOG = "/cache/magisk.log"
 
     // Versions
-    const val SNET_EXT_VER = 12
-    const val SNET_REVISION = "b66b1a914978e5f4c4bbfd74a59f4ad371bac107"
+    const val SNET_EXT_VER = 13
+    const val SNET_REVISION = "5adbc435ce93ded953c30ebe587edfd50b5503bc"
     const val BOOTCTL_REVISION = "9c5dfc1b8245c0b5b524901ef0ff0f8335757b77"
 
     // Misc
     const val ANDROID_MANIFEST = "AndroidManifest.xml"
     const val MAGISK_INSTALL_LOG_FILENAME = "magisk_install_log_%s.log"
     const val MANAGER_CONFIGS = ".tmp.magisk.config"
-    @JvmField
     val USER_ID = Process.myUid() / 100000
 
-    init {
-        EXTERNAL_PATH.mkdirs()
-    }
-
     object MagiskVersion {
         const val MIN_SUPPORT = 18000
     }
@@ -53,35 +41,28 @@ object Const {
     }
 
     object Url {
-        @Deprecated("This shouldn't be used. There's literally no need for it")
-        const val REPO_URL =
-            "https://api.github.com/users/Magisk-Modules-Repo/repos?per_page=100&sort=pushed&page=%d"
-        const val FILE_URL = "https://raw.githubusercontent.com/Magisk-Modules-Repo/%s/master/%s"
         const val ZIP_URL = "https://github.com/Magisk-Modules-Repo/%s/archive/master.zip"
-        const val MODULE_INSTALLER =
-            "https://raw.githubusercontent.com/topjohnwu/Magisk/master/scripts/module_installer.sh"
         const val PAYPAL_URL = "https://www.paypal.me/topjohnwu"
         const val PATREON_URL = "https://www.patreon.com/topjohnwu"
         const val TWITTER_URL = "https://twitter.com/topjohnwu"
         const val XDA_THREAD = "http://forum.xda-developers.com/showthread.php?t=3432382"
         const val SOURCE_CODE_URL = "https://github.com/topjohnwu/Magisk"
-        @JvmField
-        val BOOTCTL_URL = getRaw("9c5dfc1b8245c0b5b524901ef0ff0f8335757b77", "bootctl")
-        const val GITHUB_RAW_API_URL = "https://raw.githubusercontent.com/"
 
-        private fun getRaw(where: String, name: String) =
-            "${GITHUB_RAW_API_URL}topjohnwu/magisk_files/$where/$name"
+        const val GITHUB_RAW_URL = "https://raw.githubusercontent.com/"
+        const val GITHUB_API_URL = "https://api.github.com/users/Magisk-Modules-Repo/"
     }
 
     object Key {
         // others
         const val LINK_KEY = "Link"
         const val IF_NONE_MATCH = "If-None-Match"
+        const val ETAG_KEY = "ETag"
         // intents
         const val OPEN_SECTION = "section"
-        const val INTENT_SET_NAME = "filename"
-        const val INTENT_SET_LINK = "link"
+        const val INTENT_SET_APP = "app_json"
         const val FLASH_ACTION = "action"
+        const val FLASH_DATA = "additional_data"
+        const val DISMISS_ID = "dismiss_id"
         const val BROADCAST_MANAGER_UPDATE = "manager_update"
         const val BROADCAST_REBOOT = "reboot"
     }
@@ -94,5 +75,4 @@ object Const {
         const val UNINSTALL = "uninstall"
     }
 
-
 }

app/src/main/java/com/topjohnwu/magisk/Info.java

@@ -1,36 +0,0 @@
-package com.topjohnwu.magisk;
-
-import com.topjohnwu.superuser.Shell;
-import com.topjohnwu.superuser.ShellUtils;
-
-public final class Info {
-
-    public static int magiskVersionCode = -1;
-    // Current status
-    public static String magiskVersionString = "";
-    // Update Info
-    public static String remoteMagiskVersionString = "";
-    public static int remoteMagiskVersionCode = -1;
-    public static String magiskLink = "";
-    public static String magiskNoteLink = "";
-    public static String magiskMD5 = "";
-    public static String remoteManagerVersionString = "";
-    public static int remoteManagerVersionCode = -1;
-    public static String managerLink = "";
-    public static String managerNoteLink = "";
-    public static String uninstallerLink = "";
-
-    // Install flags
-    public static boolean keepVerity = false;
-    public static boolean keepEnc = false;
-    public static boolean recovery = false;
-
-    public static void loadMagiskInfo() {
-        try {
-            magiskVersionString = ShellUtils.fastCmd("magisk -v").split(":")[0];
-            magiskVersionCode = Integer.parseInt(ShellUtils.fastCmd("magisk -V"));
-            Config.setMagiskHide(Shell.su("magiskhide --status").exec().isSuccess());
-        } catch (NumberFormatException ignored) {
-        }
-    }
-}

app/src/main/java/com/topjohnwu/magisk/Info.kt

@@ -0,0 +1,26 @@
+package com.topjohnwu.magisk
+
+import com.topjohnwu.magisk.model.entity.UpdateInfo
+import com.topjohnwu.superuser.Shell
+import com.topjohnwu.superuser.ShellUtils
+
+object Info {
+
+    var magiskVersionCode = -1
+
+    var magiskVersionString = ""
+
+    var remote = UpdateInfo()
+
+    var keepVerity = false
+    var keepEnc = false
+    var recovery = false
+
+    fun loadMagiskInfo() {
+        runCatching {
+            magiskVersionString = ShellUtils.fastCmd("magisk -v").split(":".toRegex())[0]
+            magiskVersionCode = ShellUtils.fastCmd("magisk -V").toInt()
+            Config.magiskHide = Shell.su("magiskhide --status").exec().isSuccess
+        }
+    }
+}

app/src/main/java/com/topjohnwu/magisk/data/database/PolicyDao.kt

@@ -4,10 +4,11 @@ import android.content.Context
 import android.content.pm.PackageManager
 import com.topjohnwu.magisk.Const
 import com.topjohnwu.magisk.data.database.base.*
+import com.topjohnwu.magisk.extensions.now
 import com.topjohnwu.magisk.model.entity.MagiskPolicy
 import com.topjohnwu.magisk.model.entity.toMap
 import com.topjohnwu.magisk.model.entity.toPolicy
-import com.topjohnwu.magisk.utils.now
+import timber.log.Timber
 import java.util.concurrent.TimeUnit
 
 
@@ -47,12 +48,7 @@ class PolicyDao(
         condition {
             equals("uid", uid)
         }
-    }.map { it.firstOrNull()?.toPolicy(context.packageManager) }
-        .doOnError {
-            if (it is PackageManager.NameNotFoundException) {
-                delete(uid).subscribe()
-            }
-        }
+    }.map { it.first().toPolicySafe() }
 
     fun update(policy: MagiskPolicy) = query<Replace> {
         values(policy.toMap())
@@ -62,8 +58,18 @@ class PolicyDao(
         condition {
             equals("uid/100000", Const.USER_ID)
         }
-    }.flattenAsFlowable { it }
-        .map { it.toPolicy(context.packageManager) }
-        .toList()
+    }.map { it.mapNotNull { it.toPolicySafe() } }
+
+
+    private fun Map<String, String>.toPolicySafe(): MagiskPolicy? {
+        return runCatching { toPolicy(context.packageManager) }.getOrElse {
+            Timber.e(it)
+            if (it is PackageManager.NameNotFoundException) {
+                val uid = getOrElse("uid") { null } ?: return null
+                delete(uid).subscribe()
+            }
+            null
+        }
+    }
 
 }

app/src/main/java/com/topjohnwu/magisk/data/database/RepoDao.kt

@@ -0,0 +1,72 @@
+package com.topjohnwu.magisk.data.database
+
+import androidx.room.*
+import com.topjohnwu.magisk.Config
+import com.topjohnwu.magisk.model.entity.module.Repo
+
+@Dao
+abstract class RepoDao {
+
+    val repoIDList get() = getRepoID().map { it.id }
+
+    val repos: List<Repo> get() = when (Config.repoOrder) {
+            Config.Value.ORDER_NAME -> getReposNameOrder()
+            else -> getReposDateOrder()
+        }
+
+    var etagKey: String
+        set(etag) = addEtagRaw(RepoEtag(0, etag))
+        get() = etagRaw()?.key.orEmpty()
+
+    fun clear() {
+        clearRepos()
+        clearEtag()
+    }
+
+    @Query("SELECT * FROM repos ORDER BY last_update DESC")
+    protected abstract fun getReposDateOrder(): List<Repo>
+
+    @Query("SELECT * FROM repos ORDER BY name COLLATE NOCASE")
+    protected abstract fun getReposNameOrder(): List<Repo>
+
+    @Insert(onConflict = OnConflictStrategy.REPLACE)
+    abstract fun addRepo(repo: Repo)
+
+    @Query("SELECT * FROM repos WHERE id = :id")
+    abstract fun getRepo(id: String): Repo?
+
+    @Query("SELECT id FROM repos")
+    protected abstract fun getRepoID(): List<RepoID>
+
+    @Delete
+    abstract fun removeRepo(repo: Repo)
+
+    @Query("DELETE FROM repos WHERE id = :id")
+    abstract fun removeRepo(id: String)
+
+    @Query("DELETE FROM repos WHERE id IN (:idList)")
+    abstract fun removeRepos(idList: Collection<String>)
+
+    @Query("SELECT * FROM etag")
+    protected abstract fun etagRaw(): RepoEtag?
+
+    @Insert(onConflict = OnConflictStrategy.REPLACE)
+    protected abstract fun addEtagRaw(etag: RepoEtag)
+
+    @Query("DELETE FROM repos")
+    protected abstract fun clearRepos()
+
+    @Query("DELETE FROM etag")
+    protected abstract fun clearEtag()
+}
+
+data class RepoID(
+    @PrimaryKey val id: String
+)
+
+@Entity(tableName = "etag")
+data class RepoEtag(
+    @PrimaryKey val id: Int,
+    val key: String
+)
+

app/src/main/java/com/topjohnwu/magisk/data/database/RepoDatabase.kt

@@ -0,0 +1,11 @@
+package com.topjohnwu.magisk.data.database
+
+import androidx.room.Database
+import androidx.room.RoomDatabase
+import com.topjohnwu.magisk.model.entity.module.Repo
+
+@Database(version = 6, entities = [Repo::class, RepoEtag::class])
+abstract class RepoDatabase : RoomDatabase() {
+
+    abstract fun repoDao() : RepoDao
+}

app/src/main/java/com/topjohnwu/magisk/data/database/RepoDatabaseHelper.kt

@@ -1,109 +0,0 @@
-package com.topjohnwu.magisk.data.database
-
-import android.content.Context
-import android.database.Cursor
-import android.database.sqlite.SQLiteDatabase
-import android.database.sqlite.SQLiteOpenHelper
-import androidx.core.content.edit
-import com.topjohnwu.magisk.Config
-import com.topjohnwu.magisk.model.entity.Repo
-import java.util.*
-
-@Deprecated("")
-class RepoDatabaseHelper
-constructor(context: Context) : SQLiteOpenHelper(context, "repo.db", null, DATABASE_VER) {
-
-    private val mDb: SQLiteDatabase = writableDatabase
-
-    val rawCursor: Cursor
-        @Deprecated("")
-        get() = mDb.query(TABLE_NAME, null, null, null, null, null, null)
-
-    val repoCursor: Cursor
-        @Deprecated("")
-        get() {
-            var orderBy: String? = null
-            when (Config.repoOrder) {
-                Config.Value.ORDER_NAME -> orderBy = "name COLLATE NOCASE"
-                Config.Value.ORDER_DATE -> orderBy = "last_update DESC"
-            }
-            return mDb.query(TABLE_NAME, null, null, null, null, null, orderBy)
-        }
-
-    val repoIDSet: Set<String>
-        @Deprecated("")
-        get() {
-            val set = HashSet<String>(300)
-            mDb.query(TABLE_NAME, null, null, null, null, null, null).use { c ->
-                while (c.moveToNext()) {
-                    set.add(c.getString(c.getColumnIndex("id")))
-                }
-            }
-            return set
-        }
-
-    override fun onCreate(db: SQLiteDatabase) {
-        onUpgrade(db, 0, DATABASE_VER)
-    }
-
-    override fun onUpgrade(db: SQLiteDatabase, oldVersion: Int, newVersion: Int) {
-        if (oldVersion != newVersion) {
-            // Nuke old DB and create new table
-            db.execSQL("DROP TABLE IF EXISTS $TABLE_NAME")
-            db.execSQL(
-                    "CREATE TABLE IF NOT EXISTS " + TABLE_NAME + " " +
-                            "(id TEXT, name TEXT, version TEXT, versionCode INT, " +
-                            "author TEXT, description TEXT, last_update INT, PRIMARY KEY(id))")
-            Config.prefs.edit {
-                remove(Config.Key.ETAG_KEY)
-            }
-        }
-    }
-
-    override fun onDowngrade(db: SQLiteDatabase, oldVersion: Int, newVersion: Int) {
-        onUpgrade(db, 0, DATABASE_VER)
-    }
-
-    @Deprecated("")
-    fun clearRepo() {
-        mDb.delete(TABLE_NAME, null, null)
-    }
-
-
-    @Deprecated("")
-    fun removeRepo(id: String) {
-        mDb.delete(TABLE_NAME, "id=?", arrayOf(id))
-    }
-
-    @Deprecated("")
-    fun removeRepo(repo: Repo) {
-        removeRepo(repo.id)
-    }
-
-    @Deprecated("")
-    fun removeRepo(list: Iterable<String>) {
-        list.forEach {
-            mDb.delete(TABLE_NAME, "id=?", arrayOf(it))
-        }
-    }
-
-    @Deprecated("")
-    fun addRepo(repo: Repo) {
-        mDb.replace(TABLE_NAME, null, repo.contentValues)
-    }
-
-    @Deprecated("")
-    fun getRepo(id: String): Repo? {
-        mDb.query(TABLE_NAME, null, "id=?", arrayOf(id), null, null, null).use { c ->
-            if (c.moveToNext()) {
-                return Repo(c)
-            }
-        }
-        return null
-    }
-
-    companion object {
-        private val DATABASE_VER = 5
-        private val TABLE_NAME = "repos"
-    }
-}

app/src/main/java/com/topjohnwu/magisk/data/network/GithubServices.kt

@@ -1,35 +1,34 @@
 package com.topjohnwu.magisk.data.network
 
 import com.topjohnwu.magisk.Const
-import com.topjohnwu.magisk.model.entity.MagiskConfig
+import com.topjohnwu.magisk.model.entity.UpdateInfo
+import com.topjohnwu.magisk.tasks.GithubRepoInfo
+import io.reactivex.Flowable
 import io.reactivex.Single
 import okhttp3.ResponseBody
-import retrofit2.http.GET
-import retrofit2.http.Path
-import retrofit2.http.Streaming
-import retrofit2.http.Url
+import retrofit2.adapter.rxjava2.Result
+import retrofit2.http.*
 
-
-interface GithubRawApiServices {
+interface GithubRawServices {
 
     //region topjohnwu/magisk_files
 
     @GET("$MAGISK_FILES/master/stable.json")
-    fun fetchStableUpdate(): Single<MagiskConfig>
+    fun fetchStableUpdate(): Single<UpdateInfo>
 
     @GET("$MAGISK_FILES/master/beta.json")
-    fun fetchBetaUpdate(): Single<MagiskConfig>
+    fun fetchBetaUpdate(): Single<UpdateInfo>
 
     @GET("$MAGISK_FILES/master/canary_builds/release.json")
-    fun fetchCanaryUpdate(): Single<MagiskConfig>
+    fun fetchCanaryUpdate(): Single<UpdateInfo>
 
     @GET("$MAGISK_FILES/master/canary_builds/canary.json")
-    fun fetchCanaryDebugUpdate(): Single<MagiskConfig>
+    fun fetchCanaryDebugUpdate(): Single<UpdateInfo>
 
     @GET
-    fun fetchCustomUpdate(@Url url: String): Single<MagiskConfig>
+    fun fetchCustomUpdate(@Url url: String): Single<UpdateInfo>
 
-    @GET("$MAGISK_FILES/{$REVISION}/snet.apk")
+    @GET("$MAGISK_FILES/{$REVISION}/snet.jar")
     @Streaming
     fun fetchSafetynet(@Path(REVISION) revision: String = Const.SNET_REVISION): Single<ResponseBody>
 
@@ -37,6 +36,13 @@ interface GithubRawApiServices {
     @Streaming
     fun fetchBootctl(@Path(REVISION) revision: String = Const.BOOTCTL_REVISION): Single<ResponseBody>
 
+    @GET("$MAGISK_MASTER/scripts/module_installer.sh")
+    @Streaming
+    fun fetchInstaller(): Single<ResponseBody>
+
+    @GET("$MAGISK_MODULES/{$MODULE}/master/{$FILE}")
+    fun fetchModuleInfo(@Path(MODULE) id: String, @Path(FILE) file: String): Single<String>
+
     //endregion
 
     /**
@@ -47,6 +53,9 @@ interface GithubRawApiServices {
     @Streaming
     fun fetchFile(@Url url: String): Single<ResponseBody>
 
+    @GET
+    fun fetchString(@Url url: String): Single<String>
+
 
     companion object {
         private const val REVISION = "revision"
@@ -59,4 +68,14 @@ interface GithubRawApiServices {
         private const val MAGISK_MODULES = "Magisk-Modules-Repo"
     }
 
+}
+
+interface GithubApiServices {
+
+    @GET("repos")
+    fun fetchRepos(@Query("page") page: Int,
+                   @Header(Const.Key.IF_NONE_MATCH) etag: String,
+                   @Query("sort") sort: String = "pushed",
+                   @Query("per_page") count: Int = 100): Flowable<Result<List<GithubRepoInfo>>>
+
 }

app/src/main/java/com/topjohnwu/magisk/data/repository/AppRepository.kt

@@ -1,15 +0,0 @@
-package com.topjohnwu.magisk.data.repository
-
-import com.topjohnwu.magisk.data.database.PolicyDao
-import com.topjohnwu.magisk.model.entity.MagiskPolicy
-
-class AppRepository(private val policyDao: PolicyDao) {
-
-    fun deleteOutdated() = policyDao.deleteOutdated()
-    fun delete(packageName: String) = policyDao.delete(packageName)
-    fun delete(uid: Int) = policyDao.delete(uid)
-    fun fetch(uid: Int) = policyDao.fetch(uid)
-    fun fetchAll() = policyDao.fetchAll()
-    fun update(policy: MagiskPolicy) = policyDao.update(policy)
-
-}

app/src/main/java/com/topjohnwu/magisk/data/repository/DBConfig.kt

@@ -2,7 +2,6 @@ package com.topjohnwu.magisk.data.repository
 
 import com.topjohnwu.magisk.data.database.SettingsDao
 import com.topjohnwu.magisk.data.database.StringDao
-import com.topjohnwu.magisk.utils.trimEmptyToNull
 import io.reactivex.schedulers.Schedulers
 import kotlin.properties.ReadWriteProperty
 import kotlin.reflect.KProperty
@@ -23,8 +22,9 @@ interface DBConfig {
 
     fun dbStrings(
         name: String,
-        default: String
-    ) = DBStringsValue(name, default)
+        default: String,
+        sync: Boolean = false
+    ) = DBStringsValue(name, default, sync)
 
 }
 
@@ -35,12 +35,10 @@ class DBSettingsValue(
 
     private var value: Int? = null
 
-    private fun getKey(property: KProperty<*>) = name.trimEmptyToNull() ?: property.name
-
     @Synchronized
     override fun getValue(thisRef: DBConfig, property: KProperty<*>): Int {
         if (value == null)
-            value = thisRef.settingsDao.fetch(getKey(property), default).blockingGet()
+            value = thisRef.settingsDao.fetch(name, default).blockingGet()
         return value!!
     }
 
@@ -48,7 +46,7 @@ class DBSettingsValue(
         synchronized(this) {
             this.value = value
         }
-        thisRef.settingsDao.put(getKey(property), value)
+        thisRef.settingsDao.put(name, value)
                 .subscribeOn(Schedulers.io())
                 .subscribe()
     }
@@ -70,17 +68,16 @@ class DBBoolSettings(
 
 class DBStringsValue(
         private val name: String,
-        private val default: String
+        private val default: String,
+        private val sync: Boolean
 ) : ReadWriteProperty<DBConfig, String> {
 
     private var value: String? = null
 
-    private fun getKey(property: KProperty<*>) = name.trimEmptyToNull() ?: property.name
-
     @Synchronized
     override fun getValue(thisRef: DBConfig, property: KProperty<*>): String {
         if (value == null)
-            value = thisRef.stringDao.fetch(getKey(property), default).blockingGet()
+            value = thisRef.stringDao.fetch(name, default).blockingGet()
         return value!!
     }
 
@@ -88,8 +85,22 @@ class DBStringsValue(
         synchronized(this) {
             this.value = value
         }
-        thisRef.stringDao.put(getKey(property), value)
-                .subscribeOn(Schedulers.io())
-                .subscribe()
+        if (value.isEmpty()) {
+            if (sync) {
+                thisRef.stringDao.delete(name).blockingAwait()
+            } else {
+                thisRef.stringDao.delete(name)
+                        .subscribeOn(Schedulers.io())
+                        .subscribe()
+            }
+        } else {
+            if (sync) {
+                thisRef.stringDao.put(name, value).blockingAwait()
+            } else {
+                thisRef.stringDao.put(name, value)
+                        .subscribeOn(Schedulers.io())
+                        .subscribe()
+            }
+        }
     }
 }

app/src/main/java/com/topjohnwu/magisk/data/repository/LogRepository.kt

@@ -3,11 +3,10 @@ package com.topjohnwu.magisk.data.repository
 import com.topjohnwu.magisk.Const
 import com.topjohnwu.magisk.data.database.LogDao
 import com.topjohnwu.magisk.data.database.base.suRaw
+import com.topjohnwu.magisk.extensions.toSingle
 import com.topjohnwu.magisk.model.entity.MagiskLog
 import com.topjohnwu.magisk.model.entity.WrappedMagiskLog
-import com.topjohnwu.magisk.utils.toSingle
 import com.topjohnwu.superuser.Shell
-import timber.log.Timber
 import java.util.concurrent.TimeUnit
 
 
@@ -21,7 +20,6 @@ class LogRepository(
 
     fun fetchMagiskLogs() = "tail -n 5000 ${Const.MAGISK_LOG}".suRaw()
         .filter { it.isNotEmpty() }
-        .map { Timber.i(it.toString()); it }
 
     fun clearLogs() = logDao.deleteAll()
     fun clearOutdated() = logDao.deleteOutdated()

app/src/main/java/com/topjohnwu/magisk/data/repository/MagiskRepository.kt

@@ -1,46 +1,25 @@
 package com.topjohnwu.magisk.data.repository
 
-import android.content.Context
 import android.content.pm.PackageManager
-import com.topjohnwu.magisk.App
 import com.topjohnwu.magisk.Config
 import com.topjohnwu.magisk.Info
 import com.topjohnwu.magisk.data.database.base.su
-import com.topjohnwu.magisk.data.network.GithubRawApiServices
+import com.topjohnwu.magisk.data.network.GithubRawServices
+import com.topjohnwu.magisk.extensions.getLabel
+import com.topjohnwu.magisk.extensions.packageName
+import com.topjohnwu.magisk.extensions.toSingle
 import com.topjohnwu.magisk.model.entity.HideAppInfo
 import com.topjohnwu.magisk.model.entity.HideTarget
-import com.topjohnwu.magisk.utils.Utils
-import com.topjohnwu.magisk.utils.inject
-import com.topjohnwu.magisk.utils.toSingle
-import com.topjohnwu.magisk.utils.writeToFile
 import com.topjohnwu.superuser.Shell
 import io.reactivex.Single
 
 class MagiskRepository(
-    private val context: Context,
-    private val apiRaw: GithubRawApiServices,
-    private val packageManager: PackageManager
+        private val apiRaw: GithubRawServices,
+        private val packageManager: PackageManager
 ) {
 
-    fun fetchMagisk() = fetchUpdate()
-        .flatMap { apiRaw.fetchFile(it.magisk.link) }
-        .map { it.writeToFile(context, FILE_MAGISK_ZIP) }
-
-    fun fetchManager() = fetchUpdate()
-        .flatMap { apiRaw.fetchFile(it.app.link) }
-        .map { it.writeToFile(context, FILE_MAGISK_APK) }
-
-    fun fetchUninstaller() = fetchUpdate()
-        .flatMap { apiRaw.fetchFile(it.uninstaller.link) }
-        .map { it.writeToFile(context, FILE_UNINSTALLER_ZIP) }
-
     fun fetchSafetynet() = apiRaw.fetchSafetynet()
 
-    fun fetchBootctl() = apiRaw
-        .fetchBootctl()
-        .map { it.writeToFile(context, FILE_BOOTCTL_SH) }
-
-
     fun fetchUpdate() = when (Config.updateChannel) {
         Config.Value.DEFAULT_CHANNEL, Config.Value.STABLE_CHANNEL -> apiRaw.fetchStableUpdate()
         Config.Value.BETA_CHANNEL -> apiRaw.fetchBetaUpdate()
@@ -50,34 +29,21 @@ class MagiskRepository(
         else -> throw IllegalArgumentException()
     }.flatMap {
         // If remote version is lower than current installed, try switching to beta
-        if (it.magisk.versionCode.toIntOrNull() ?: -1 < Info.magiskVersionCode
+        if (it.magisk.versionCode < Info.magiskVersionCode
                 && Config.updateChannel == Config.Value.DEFAULT_CHANNEL) {
             Config.updateChannel = Config.Value.BETA_CHANNEL
             apiRaw.fetchBetaUpdate()
         } else {
             Single.just(it)
         }
-    }.doOnSuccess {
-        Info.remoteMagiskVersionString = it.magisk.version
-        Info.remoteMagiskVersionCode = it.magisk.versionCode.toIntOrNull() ?: -1
-        Info.magiskLink = it.magisk.link
-        Info.magiskNoteLink = it.magisk.note
-        Info.magiskMD5 = it.magisk.hash
-
-        Info.remoteManagerVersionString = it.app.version
-        Info.remoteManagerVersionCode = it.app.versionCode.toIntOrNull() ?: -1
-        Info.managerLink = it.app.link
-        Info.managerNoteLink = it.app.note
-
-        Info.uninstallerLink = it.uninstaller.link
-    }
+    }.doOnSuccess { Info.remote = it }
 
     fun fetchApps() =
         Single.fromCallable { packageManager.getInstalledApplications(0) }
             .flattenAsFlowable { it }
             .filter { it.enabled && !blacklist.contains(it.packageName) }
             .map {
-                val label = Utils.getAppLabel(it, packageManager)
+                val label = it.getLabel(packageManager)
                 val icon = it.loadIcon(packageManager)
                 HideAppInfo(it, label, icon)
             }
@@ -96,14 +62,8 @@ class MagiskRepository(
     private val Boolean.state get() = if (this) "add" else "rm"
 
     companion object {
-        const val FILE_MAGISK_ZIP = "magisk.zip"
-        const val FILE_MAGISK_APK = "magisk.apk"
-        const val FILE_UNINSTALLER_ZIP = "uninstaller.zip"
-        const val FILE_SAFETY_NET_APK = "safetynet.apk"
-        const val FILE_BOOTCTL_SH = "bootctl"
-
-        private val blacklist = listOf(
-            let { val app: App by inject(); app }.packageName,
+        private val blacklist by lazy { listOf(
+            packageName,
             "android",
             "com.android.chrome",
             "com.chrome.beta",
@@ -111,7 +71,7 @@ class MagiskRepository(
             "com.chrome.canary",
             "com.android.webview",
             "com.google.android.webview"
-        )
+        ) }
     }
 
 }

app/src/main/java/com/topjohnwu/magisk/data/repository/StringRepository.kt

@@ -0,0 +1,15 @@
+package com.topjohnwu.magisk.data.repository
+
+import com.topjohnwu.magisk.data.network.GithubRawServices
+import com.topjohnwu.magisk.model.entity.module.Repo
+
+class StringRepository(
+    private val api: GithubRawServices
+) {
+
+    fun getString(url: String) = api.fetchString(url)
+
+    fun getMetadata(repo: Repo) = api.fetchModuleInfo(repo.id, "module.prop")
+
+    fun getReadme(repo: Repo) = api.fetchModuleInfo(repo.id, "README.md")
+}

app/src/main/java/com/topjohnwu/magisk/di/ApplicationModule.kt

@@ -1,18 +1,61 @@
 package com.topjohnwu.magisk.di
 
+import android.annotation.SuppressLint
+import android.app.Activity
+import android.app.Application
 import android.content.Context
+import android.os.Build
+import android.os.Bundle
 import androidx.preference.PreferenceManager
 import com.skoumal.teanity.rxbus.RxBus
-import com.topjohnwu.magisk.App
+import org.koin.core.qualifier.named
 import org.koin.dsl.module
 
+val SUTimeout = named("su_timeout")
+val Protected = named("protected")
 
 val applicationModule = module {
     single { RxBus() }
     factory { get<Context>().resources }
-    factory { get<Context>() as App }
     factory { get<Context>().packageManager }
-    factory(Protected) { get<App>().protectedContext }
+    factory(Protected) { createDEContext(get()) }
     single(SUTimeout) { get<Context>(Protected).getSharedPreferences("su_timeout", 0) }
     single { PreferenceManager.getDefaultSharedPreferences(get<Context>(Protected)) }
-}
+    single { ActivityTracker() }
+    factory { get<ActivityTracker>().foreground ?: NullActivity }
+}
+
+private fun createDEContext(context: Context): Context {
+    return if (Build.VERSION.SDK_INT >= 24)
+        context.createDeviceProtectedStorageContext()
+    else context
+}
+
+class ActivityTracker : Application.ActivityLifecycleCallbacks {
+
+    @Volatile
+    var foreground: Activity? = null
+
+    override fun onActivityCreated(activity: Activity, bundle: Bundle?) {}
+
+    override fun onActivityStarted(activity: Activity) {}
+
+    @Synchronized
+    override fun onActivityResumed(activity: Activity) {
+        foreground = activity
+    }
+
+    @Synchronized
+    override fun onActivityPaused(activity: Activity) {
+        foreground = null
+    }
+
+    override fun onActivityStopped(activity: Activity) {}
+
+    override fun onActivitySaveInstanceState(activity: Activity, bundle: Bundle) {}
+
+    override fun onActivityDestroyed(activity: Activity) {}
+}
+
+@SuppressLint("Registered")
+object NullActivity : Activity()

app/src/main/java/com/topjohnwu/magisk/di/DatabaseModule.kt

@@ -1,7 +1,9 @@
 package com.topjohnwu.magisk.di
 
+import android.content.Context
+import androidx.room.Room
 import com.topjohnwu.magisk.data.database.*
-import com.topjohnwu.magisk.tasks.UpdateRepos
+import com.topjohnwu.magisk.tasks.RepoUpdater
 import org.koin.dsl.module
 
 
@@ -10,6 +12,12 @@ val databaseModule = module {
     single { PolicyDao(get()) }
     single { SettingsDao() }
     single { StringDao() }
-    single { RepoDatabaseHelper(get()) }
-    single { UpdateRepos(get()) }
+    single { createRepoDatabase(get()) }
+    single { get<RepoDatabase>().repoDao() }
+    single { RepoUpdater(get(), get()) }
 }
+
+fun createRepoDatabase(context: Context) =
+        Room.databaseBuilder(context, RepoDatabase::class.java, "repo.db")
+            .fallbackToDestructiveMigration()
+            .build()

app/src/main/java/com/topjohnwu/magisk/di/MiscModule.kt

@@ -1,10 +0,0 @@
-package com.topjohnwu.magisk.di
-
-import org.koin.dsl.module
-
-
-val miscModule = module {
-
-    // define miscs here
-
-}

app/src/main/java/com/topjohnwu/magisk/di/Modules.kt

@@ -5,6 +5,5 @@ val koinModules = listOf(
     networkingModule,
     databaseModule,
     repositoryModule,
-    viewModelModules,
-    miscModule
+    viewModelModules
 )

app/src/main/java/com/topjohnwu/magisk/di/NamedInjection.kt

@@ -1,6 +0,0 @@
-package com.topjohnwu.magisk.di
-
-import org.koin.core.qualifier.named
-
-val SUTimeout = named("su_timeout")
-val Protected = named("protected")

app/src/main/java/com/topjohnwu/magisk/di/NetworkingModule.kt

@@ -4,23 +4,23 @@ import com.squareup.moshi.JsonAdapter
 import com.squareup.moshi.Moshi
 import com.topjohnwu.magisk.BuildConfig
 import com.topjohnwu.magisk.Const
-import com.topjohnwu.magisk.data.network.GithubRawApiServices
+import com.topjohnwu.magisk.data.network.GithubApiServices
+import com.topjohnwu.magisk.data.network.GithubRawServices
 import okhttp3.OkHttpClient
 import okhttp3.logging.HttpLoggingInterceptor
 import org.koin.dsl.module
-import retrofit2.CallAdapter
-import retrofit2.Converter
 import retrofit2.Retrofit
 import retrofit2.adapter.rxjava2.RxJava2CallAdapterFactory
 import retrofit2.converter.moshi.MoshiConverterFactory
+import retrofit2.converter.scalars.ScalarsConverterFactory
 import se.ansman.kotshi.KotshiJsonAdapterFactory
 
 val networkingModule = module {
     single { createOkHttpClient() }
-    single { createConverterFactory() }
-    single { createCallAdapterFactory() }
-    single { createRetrofit(get(), get(), get()) }
-    single { createApiService<GithubRawApiServices>(get(), Const.Url.GITHUB_RAW_API_URL) }
+    single { createMoshiConverterFactory() }
+    single { createRetrofit(get(), get()) }
+    single { createApiService<GithubRawServices>(get(), Const.Url.GITHUB_RAW_URL) }
+    single { createApiService<GithubApiServices>(get(), Const.Url.GITHUB_API_URL) }
 }
 
 fun createOkHttpClient(): OkHttpClient {
@@ -28,7 +28,7 @@ fun createOkHttpClient(): OkHttpClient {
 
     if (BuildConfig.DEBUG) {
         val httpLoggingInterceptor = HttpLoggingInterceptor().apply {
-            level = HttpLoggingInterceptor.Level.BODY
+            level = HttpLoggingInterceptor.Level.HEADERS
         }
         builder.addInterceptor(httpLoggingInterceptor)
     }
@@ -36,34 +36,26 @@ fun createOkHttpClient(): OkHttpClient {
     return builder.build()
 }
 
-fun createConverterFactory(): Converter.Factory {
+fun createMoshiConverterFactory(): MoshiConverterFactory {
     val moshi = Moshi.Builder()
-            .add(JsonAdapterFactory.INSTANCE)
+            .add(KotshiJsonAdapterFactory)
             .build()
     return MoshiConverterFactory.create(moshi)
 }
 
-fun createCallAdapterFactory(): CallAdapter.Factory {
-    return RxJava2CallAdapterFactory.create()
-}
-
 fun createRetrofit(
     okHttpClient: OkHttpClient,
-    converterFactory: Converter.Factory,
-    callAdapterFactory: CallAdapter.Factory
+    converterFactory: MoshiConverterFactory
 ): Retrofit.Builder {
     return Retrofit.Builder()
+        .addConverterFactory(ScalarsConverterFactory.create())
         .addConverterFactory(converterFactory)
-        .addCallAdapterFactory(callAdapterFactory)
+        .addCallAdapterFactory(RxJava2CallAdapterFactory.create())
         .client(okHttpClient)
 }
 
 @KotshiJsonAdapterFactory
-abstract class JsonAdapterFactory : JsonAdapter.Factory {
-    companion object {
-        val INSTANCE: JsonAdapterFactory = KotshiJsonAdapterFactory
-    }
-}
+abstract class JsonAdapterFactory : JsonAdapter.Factory
 
 inline fun <reified T> createApiService(retrofitBuilder: Retrofit.Builder, baseUrl: String): T {
     return retrofitBuilder

app/src/main/java/com/topjohnwu/magisk/di/RepositoryModule.kt

@@ -1,13 +1,13 @@
 package com.topjohnwu.magisk.di
 
-import com.topjohnwu.magisk.data.repository.AppRepository
 import com.topjohnwu.magisk.data.repository.LogRepository
 import com.topjohnwu.magisk.data.repository.MagiskRepository
+import com.topjohnwu.magisk.data.repository.StringRepository
 import org.koin.dsl.module
 
 
 val repositoryModule = module {
-    single { MagiskRepository(get(), get(), get()) }
+    single { MagiskRepository(get(), get()) }
     single { LogRepository(get()) }
-    single { AppRepository(get()) }
+    single { StringRepository(get()) }
 }

app/src/main/java/com/topjohnwu/magisk/di/ViewModelsModule.kt

@@ -20,6 +20,8 @@ val viewModelModules = module {
     viewModel { HideViewModel(get(), get()) }
     viewModel { ModuleViewModel(get(), get(), get()) }
     viewModel { LogViewModel(get(), get()) }
-    viewModel { (action: String, uri: Uri?) -> FlashViewModel(action, uri, get()) }
+    viewModel { (action: String, file: Uri, additional: Uri) ->
+        FlashViewModel(action, file, additional, get())
+    }
     viewModel { SuRequestViewModel(get(), get(), get(SUTimeout), get()) }
 }

app/src/main/java/com/topjohnwu/magisk/extensions/XAndroid.kt

@@ -1,4 +1,4 @@
-package com.topjohnwu.magisk.utils
+package com.topjohnwu.magisk.extensions
 
 import android.content.Context
 import android.content.Intent
@@ -7,17 +7,16 @@ import android.content.pm.ComponentInfo
 import android.content.pm.PackageInfo
 import android.content.pm.PackageManager
 import android.content.pm.PackageManager.*
+import android.content.res.Configuration
+import android.database.Cursor
 import android.net.Uri
 import android.provider.OpenableColumns
-import com.topjohnwu.magisk.App
+import com.topjohnwu.magisk.utils.FileProvider
+import com.topjohnwu.magisk.utils.currentLocale
 import java.io.File
 import java.io.FileNotFoundException
 
-val packageName: String
-    get() {
-        val app: App by inject()
-        return app.packageName
-    }
+val packageName: String get() = get<Context>().packageName
 
 val PackageInfo.processes
     get() = activities?.processNames.orEmpty() +
@@ -50,21 +49,22 @@ val ApplicationInfo.packageInfo: PackageInfo?
         }
     }
 
-val Uri.fileName: String get() {
-    var name: String? = null
-    App.self.contentResolver.query(this, null, null, null, null)?.use { c ->
-        val nameIndex = c.getColumnIndex(OpenableColumns.DISPLAY_NAME)
-        if (nameIndex != -1) {
-            c.moveToFirst()
-            name = c.getString(nameIndex)
+val Uri.fileName: String
+    get() {
+        var name: String? = null
+        get<Context>().contentResolver.query(this, null, null, null, null)?.use { c ->
+            val nameIndex = c.getColumnIndex(OpenableColumns.DISPLAY_NAME)
+            if (nameIndex != -1) {
+                c.moveToFirst()
+                name = c.getString(nameIndex)
+            }
         }
+        if (name == null && path != null) {
+            val idx = path!!.lastIndexOf('/')
+            name = path!!.substring(idx + 1)
+        }
+        return name.orEmpty()
     }
-    if (name == null && path != null) {
-        val idx = path!!.lastIndexOf('/')
-        name = path!!.substring(idx + 1)
-    }
-    return name.orEmpty()
-}
 
 fun PackageManager.activities(packageName: String) =
     getPackageInfo(packageName, GET_ACTIVITIES)
@@ -80,24 +80,42 @@ fun PackageManager.providers(packageName: String) =
 
 fun Context.rawResource(id: Int) = resources.openRawResource(id)
 
-fun Context.readUri(uri: Uri) = contentResolver.openInputStream(uri) ?: throw FileNotFoundException()
-
-fun ApplicationInfo.findAppLabel(pm: PackageManager): String {
-    return pm.getApplicationLabel(this)?.toString().orEmpty()
-}
+fun Context.readUri(uri: Uri) =
+    contentResolver.openInputStream(uri) ?: throw FileNotFoundException()
 
 fun Intent.startActivity(context: Context) = context.startActivity(this)
 
-fun File.provide(): Uri {
-    val context: Context by inject()
-    return FileProvider.getUriForFile(context, "com.topjohnwu.magisk.fileprovider", this)
+fun File.provide(context: Context = get()): Uri {
+    return FileProvider.getUriForFile(context, context.packageName + ".provider", this)
 }
 
 fun File.mv(destination: File) {
-    inputStream().copyTo(destination)
+    inputStream().writeTo(destination)
     deleteRecursively()
 }
 
 fun String.toFile() = File(this)
 
-fun Intent.chooser(title: String = "Pick an app") = Intent.createChooser(this, title)
+fun Intent.chooser(title: String = "Pick an app") = Intent.createChooser(this, title)
+
+fun Context.cachedFile(name: String) = File(cacheDir, name)
+
+fun <Result> Cursor.toList(transformer: (Cursor) -> Result): List<Result> {
+    val out = mutableListOf<Result>()
+    while (moveToNext()) out.add(transformer(this))
+    return out
+}
+
+fun ApplicationInfo.getLabel(pm: PackageManager): String {
+    runCatching {
+        if (labelRes > 0) {
+            val res = pm.getResourcesForApplication(this)
+            val config = Configuration()
+            config.setLocale(currentLocale)
+            res.updateConfiguration(config, res.displayMetrics)
+            return res.getString(labelRes)
+        }
+    }
+
+    return loadLabel(pm).toString()
+}

app/src/main/java/com/topjohnwu/magisk/extensions/XBinding.kt

@@ -1,4 +1,4 @@
-package com.topjohnwu.magisk.utils
+package com.topjohnwu.magisk.extensions
 
 import com.skoumal.teanity.util.KObservableField
 

app/src/main/java/com/topjohnwu/magisk/extensions/XJava.kt

@@ -0,0 +1,103 @@
+package com.topjohnwu.magisk.extensions
+
+import android.net.Uri
+import android.os.Build
+import androidx.core.net.toFile
+import java.io.File
+import java.io.InputStream
+import java.io.OutputStream
+import java.util.*
+import java.util.zip.ZipEntry
+import java.util.zip.ZipInputStream
+import kotlin.NoSuchElementException
+
+fun ZipInputStream.forEach(callback: (ZipEntry) -> Unit) {
+    var entry: ZipEntry? = nextEntry
+    while (entry != null) {
+        callback(entry)
+        entry = nextEntry
+    }
+}
+
+fun Uri.writeTo(file: File) = toFile().copyTo(file)
+
+fun InputStream.writeTo(file: File) =
+        withStreams(this, file.outputStream()) { reader, writer -> reader.copyTo(writer) }
+
+inline fun <In : InputStream, Out : OutputStream> withStreams(
+    inStream: In,
+    outStream: Out,
+    withBoth: (In, Out) -> Unit
+) {
+    inStream.use { reader ->
+        outStream.use { writer ->
+            withBoth(reader, writer)
+        }
+    }
+}
+
+inline fun <T, R> List<T>.firstMap(mapper: (T) -> R?): R {
+    for (item: T in this) {
+        return mapper(item) ?: continue
+    }
+    throw NoSuchElementException("Collection contains no element matching the predicate.")
+}
+
+fun String.langTagToLocale(): Locale {
+    if (Build.VERSION.SDK_INT >= 21) {
+        return Locale.forLanguageTag(this)
+    } else {
+        val tok = split("-".toRegex()).dropLastWhile { it.isEmpty() }.toTypedArray()
+        if (tok.isEmpty()) {
+            return Locale("")
+        }
+        val language = when (tok[0]) {
+            "und" -> "" // Undefined
+            "fil" -> "tl" // Filipino
+            else -> tok[0]
+        }
+        if (language.length != 2 && language.length != 3)
+            return Locale("")
+        if (tok.size == 1)
+            return Locale(language)
+        val country = tok[1]
+
+        return if (country.length != 2 && country.length != 3) Locale(language)
+        else Locale(language, country)
+    }
+}
+
+fun Locale.toLangTag(): String {
+    if (Build.VERSION.SDK_INT >= 21) {
+        return toLanguageTag()
+    } else {
+        var language = language
+        var country = country
+        var variant = variant
+        when {
+            language.isEmpty() || !language.matches("\\p{Alpha}{2,8}".toRegex()) ->
+                language = "und"       // Follow the Locale#toLanguageTag() implementation
+            language == "iw" -> language = "he"        // correct deprecated "Hebrew"
+            language == "in" -> language = "id"        // correct deprecated "Indonesian"
+            language == "ji" -> language = "yi"        // correct deprecated "Yiddish"
+        }
+        // ensure valid country code, if not well formed, it's omitted
+
+        // variant subtags that begin with a letter must be at least 5 characters long
+        // ensure valid country code, if not well formed, it's omitted
+        if (!country.matches("\\p{Alpha}{2}|\\p{Digit}{3}".toRegex())) {
+            country = ""
+        }
+
+        // variant subtags that begin with a letter must be at least 5 characters long
+        if (!variant.matches("\\p{Alnum}{5,8}|\\p{Digit}\\p{Alnum}{3}".toRegex())) {
+            variant = ""
+        }
+        val tag = StringBuilder(language)
+        if (country.isNotEmpty())
+            tag.append('-').append(country)
+        if (variant.isNotEmpty())
+            tag.append('-').append(variant)
+        return tag.toString()
+    }
+}

app/src/main/java/com/topjohnwu/magisk/extensions/XKoin.kt

@@ -1,4 +1,4 @@
-package com.topjohnwu.magisk.utils
+package com.topjohnwu.magisk.extensions
 
 import org.koin.core.context.GlobalContext
 import org.koin.core.parameter.ParametersDefinition
@@ -6,12 +6,12 @@ import org.koin.core.qualifier.Qualifier
 
 fun getKoin() = GlobalContext.get().koin
 
-inline fun <reified T : Any> inject(
+inline fun <reified T> inject(
     qualifier: Qualifier? = null,
     noinline parameters: ParametersDefinition? = null
 ) = lazy { get<T>(qualifier, parameters) }
 
-inline fun <reified T : Any> get(
+inline fun <reified T> get(
     qualifier: Qualifier? = null,
     noinline parameters: ParametersDefinition? = null
 ): T = getKoin().get(qualifier, parameters)

app/src/main/java/com/topjohnwu/magisk/extensions/XList.kt

@@ -1,4 +1,4 @@
-package com.topjohnwu.magisk.utils
+package com.topjohnwu.magisk.extensions
 
 import androidx.collection.SparseArrayCompat
 import androidx.databinding.ObservableList

app/src/main/java/com/topjohnwu/magisk/extensions/XRx.kt

@@ -1,4 +1,4 @@
-package com.topjohnwu.magisk.utils
+package com.topjohnwu.magisk.extensions
 
 import io.reactivex.Single
 import io.reactivex.functions.BiFunction

app/src/main/java/com/topjohnwu/magisk/extensions/XSU.kt

@@ -1,4 +1,4 @@
-package com.topjohnwu.magisk.utils
+package com.topjohnwu.magisk.extensions
 
 import com.topjohnwu.magisk.Info
 import com.topjohnwu.superuser.Shell

app/src/main/java/com/topjohnwu/magisk/extensions/XString.kt

@@ -1,4 +1,4 @@
-package com.topjohnwu.magisk.utils
+package com.topjohnwu.magisk.extensions
 
 import android.content.res.Resources
 
@@ -20,4 +20,8 @@ fun Int.res(vararg args: Any): String {
     return resources.getString(this, *args)
 }
 
-fun String.trimEmptyToNull(): String? = if (isBlank()) null else this
+fun String.trimEmptyToNull(): String? = if (isBlank()) null else this
+
+fun String.legalFilename() = replace(" ", "_").replace("'", "").replace("\"", "")
+        .replace("$", "").replace("`", "").replace("*", "").replace("/", "_")
+        .replace("#", "").replace("@", "").replace("\\", "_")

app/src/main/java/com/topjohnwu/magisk/extensions/XTime.kt

@@ -1,5 +1,6 @@
-package com.topjohnwu.magisk.utils
+package com.topjohnwu.magisk.extensions
 
+import com.topjohnwu.magisk.utils.currentLocale
 import java.text.DateFormat
 import java.text.ParseException
 import java.text.SimpleDateFormat
@@ -13,8 +14,7 @@ fun String.toTime(format: DateFormat) = try {
     -1L
 }
 
-private val locale get() = LocaleManager.locale
-val timeFormatFull by lazy { SimpleDateFormat("yyyy/MM/dd_HH:mm:ss", locale) }
-val timeFormatStandard by lazy { SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss'Z'", locale) }
-val timeFormatMedium by lazy { DateFormat.getDateInstance(DateFormat.MEDIUM, LocaleManager.locale) }
-val timeFormatTime by lazy { SimpleDateFormat("h:mm a", LocaleManager.locale) }
+val timeFormatFull by lazy { SimpleDateFormat("yyyy/MM/dd_HH:mm:ss", currentLocale) }
+val timeFormatStandard by lazy { SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss'Z'", currentLocale) }
+val timeFormatMedium by lazy { DateFormat.getDateInstance(DateFormat.MEDIUM, currentLocale) }
+val timeFormatTime by lazy { SimpleDateFormat("h:mm a", currentLocale) }

app/src/main/java/com/topjohnwu/magisk/extensions/XView.kt

@@ -1,4 +1,4 @@
-package com.topjohnwu.magisk.utils
+package com.topjohnwu.magisk.extensions
 
 import android.view.View
 import android.view.ViewTreeObserver

app/src/main/java/com/topjohnwu/magisk/model/download/DownloadModuleService.java

@@ -1,156 +0,0 @@
-package com.topjohnwu.magisk.model.download;
-
-import android.app.PendingIntent;
-import android.app.Service;
-import android.content.Intent;
-import android.net.Uri;
-import android.os.IBinder;
-
-import androidx.annotation.Nullable;
-
-import com.topjohnwu.magisk.App;
-import com.topjohnwu.magisk.ClassMap;
-import com.topjohnwu.magisk.Const;
-import com.topjohnwu.magisk.model.entity.Repo;
-import com.topjohnwu.magisk.ui.flash.FlashActivity;
-import com.topjohnwu.magisk.view.Notifications;
-import com.topjohnwu.magisk.view.ProgressNotification;
-import com.topjohnwu.net.Networking;
-import com.topjohnwu.superuser.Shell;
-import com.topjohnwu.superuser.ShellUtils;
-
-import java.io.BufferedOutputStream;
-import java.io.File;
-import java.io.FileOutputStream;
-import java.io.IOException;
-import java.io.InputStream;
-import java.io.OutputStream;
-import java.util.ArrayList;
-import java.util.List;
-import java.util.zip.ZipEntry;
-import java.util.zip.ZipInputStream;
-import java.util.zip.ZipOutputStream;
-
-public class DownloadModuleService extends Service {
-
-    private List<ProgressNotification> notifications;
-
-    @Nullable
-    @Override
-    public IBinder onBind(Intent intent) {
-        return null;
-    }
-
-    @Override
-    public void onCreate() {
-        notifications = new ArrayList<>();
-    }
-
-    @Override
-    public int onStartCommand(Intent intent, int flags, int startId) {
-        Shell.EXECUTOR.execute(() -> {
-            Repo repo = intent.getParcelableExtra("repo");
-            boolean install = intent.getBooleanExtra("install", false);
-            dlProcessInstall(repo, install);
-        });
-        return START_REDELIVER_INTENT;
-    }
-
-    @Override
-    public synchronized void onTaskRemoved(Intent rootIntent) {
-        for (ProgressNotification n : notifications) {
-            Notifications.mgr.cancel(n.hashCode());
-        }
-        notifications.clear();
-    }
-
-    private synchronized void addNotification(ProgressNotification n) {
-        if (notifications.isEmpty()) {
-            // Start foreground
-            startForeground(n.hashCode(), n.getNotification());
-        }
-        notifications.add(n);
-    }
-
-    private synchronized void removeNotification(ProgressNotification n) {
-        notifications.remove(n);
-        if (notifications.isEmpty()) {
-            // No more tasks, stop service
-            stopForeground(true);
-            stopSelf();
-        } else {
-            // Pick another notification as our foreground notification
-            n = notifications.get(0);
-            startForeground(n.hashCode(), n.getNotification());
-        }
-    }
-
-    private void dlProcessInstall(Repo repo, boolean install) {
-        File output = new File(Const.EXTERNAL_PATH, repo.getDownloadFilename());
-        ProgressNotification progress = new ProgressNotification(output.getName());
-        addNotification(progress);
-        try {
-            InputStream in = Networking.get(repo.getZipUrl())
-                    .setDownloadProgressListener(progress)
-                    .execForInputStream().getResult();
-            OutputStream out = new BufferedOutputStream(new FileOutputStream(output));
-            processZip(in, out);
-            Intent intent = new Intent(this, ClassMap.get(FlashActivity.class));
-            intent.setData(Uri.fromFile(output))
-                    .addFlags(Intent.FLAG_ACTIVITY_NEW_TASK)
-                    .putExtra(Const.Key.FLASH_ACTION, Const.Value.FLASH_ZIP);
-            synchronized (getApplication()) {
-                if (install && App.foreground() != null &&
-                        !(App.foreground() instanceof FlashActivity)) {
-                    /* Only start flashing if there is a foreground activity and the
-                     * user is not also flashing another module at the same time */
-                    App.foreground().startActivity(intent);
-                } else {
-                    /* Or else we preset a notification notifying that we are done */
-                    PendingIntent pi = PendingIntent.getActivity(this, progress.hashCode(), intent,
-                            PendingIntent.FLAG_UPDATE_CURRENT);
-                    progress.dlDone(pi);
-                }
-            }
-        } catch (Exception e) {
-            e.printStackTrace();
-            progress.dlFail();
-        }
-        removeNotification(progress);
-    }
-
-    private void processZip(InputStream in, OutputStream out)
-            throws IOException {
-        try (ZipInputStream zin = new ZipInputStream(in);
-             ZipOutputStream zout = new ZipOutputStream(out)) {
-
-            // Inject latest module-installer.sh as update-binary
-            zout.putNextEntry(new ZipEntry("META-INF/"));
-            zout.putNextEntry(new ZipEntry("META-INF/com/"));
-            zout.putNextEntry(new ZipEntry("META-INF/com/google/"));
-            zout.putNextEntry(new ZipEntry("META-INF/com/google/android/"));
-            zout.putNextEntry(new ZipEntry("META-INF/com/google/android/update-binary"));
-            try (InputStream update_bin = Networking.get(Const.Url.MODULE_INSTALLER)
-                    .execForInputStream().getResult()) {
-                ShellUtils.pump(update_bin, zout);
-            }
-            zout.putNextEntry(new ZipEntry("META-INF/com/google/android/updater-script"));
-            zout.write("#MAGISK\n".getBytes("UTF-8"));
-
-            int off = -1;
-            ZipEntry entry;
-            while ((entry = zin.getNextEntry()) != null) {
-                if (off < 0)
-                    off = entry.getName().indexOf('/') + 1;
-                String path = entry.getName().substring(off);
-                if (path.isEmpty())
-                    continue;
-                if (path.startsWith("META-INF"))
-                    continue;
-                zout.putNextEntry(new ZipEntry(path));
-                if (!entry.isDirectory())
-                    ShellUtils.pump(zin, zout);
-            }
-        }
-    }
-}

app/src/main/java/com/topjohnwu/magisk/model/download/DownloadService.kt

@@ -0,0 +1,142 @@
+package com.topjohnwu.magisk.model.download
+
+import android.annotation.SuppressLint
+import android.app.PendingIntent
+import android.content.Context
+import android.content.Intent
+import android.os.Build
+import android.webkit.MimeTypeMap
+import androidx.core.app.NotificationCompat
+import com.topjohnwu.magisk.ClassMap
+import com.topjohnwu.magisk.R
+import com.topjohnwu.magisk.extensions.chooser
+import com.topjohnwu.magisk.extensions.provide
+import com.topjohnwu.magisk.model.entity.internal.Configuration.*
+import com.topjohnwu.magisk.model.entity.internal.Configuration.Flash.Secondary
+import com.topjohnwu.magisk.model.entity.internal.DownloadSubject
+import com.topjohnwu.magisk.model.entity.internal.DownloadSubject.*
+import com.topjohnwu.magisk.ui.flash.FlashActivity
+import com.topjohnwu.magisk.utils.APKInstall
+import java.io.File
+import kotlin.random.Random.Default.nextInt
+
+/* More of a facade for [RemoteFileService], but whatever... */
+@SuppressLint("Registered")
+open class DownloadService : RemoteFileService() {
+
+    private val context get() = this
+    private val File.type
+        get() = MimeTypeMap.getSingleton()
+            .getMimeTypeFromExtension(extension)
+            ?: "resource/folder"
+
+    override fun onFinished(subject: DownloadSubject, id: Int) = when (subject) {
+        is Magisk -> onFinishedInternal(subject, id)
+        is Module -> onFinishedInternal(subject, id)
+        is Manager -> onFinishedInternal(subject, id)
+    }
+
+    private fun onFinishedInternal(
+        subject: Magisk,
+        id: Int
+    ) = when (val conf = subject.configuration) {
+        Uninstall -> FlashActivity.uninstall(this, subject.file, id)
+        is Patch -> FlashActivity.patch(this, subject.file, conf.fileUri, id)
+        is Flash -> FlashActivity.flash(this, subject.file, conf is Secondary, id)
+        else -> Unit
+    }
+
+    private fun onFinishedInternal(
+        subject: Module,
+        id: Int
+    ) = when (subject.configuration) {
+        is Flash -> FlashActivity.install(this, subject.file, id)
+        else -> Unit
+    }
+
+    private fun onFinishedInternal(
+        subject: Manager,
+        id: Int
+    ) {
+        remove(id)
+        when (subject.configuration)  {
+            is APK.Upgrade -> APKInstall.install(this, subject.file)
+            else -> Unit
+        }
+    }
+
+    // ---
+
+    override fun NotificationCompat.Builder.addActions(subject: DownloadSubject)
+    = when (subject) {
+        is Magisk -> addActionsInternal(subject)
+        is Module -> addActionsInternal(subject)
+        is Manager -> addActionsInternal(subject)
+    }
+
+    private fun NotificationCompat.Builder.addActionsInternal(subject: Magisk)
+    = when (val conf = subject.configuration) {
+        Download -> addAction(0, R.string.download_open_parent, fileIntent(subject.file.parentFile!!))
+            .addAction(0, R.string.download_open_self, fileIntent(subject.file))
+        Uninstall -> setContentIntent(FlashActivity.uninstallIntent(context, subject.file))
+        is Flash -> setContentIntent(FlashActivity.flashIntent(context, subject.file, conf is Secondary))
+        is Patch -> setContentIntent(FlashActivity.patchIntent(context, subject.file, conf.fileUri))
+        else -> this
+    }
+
+    private fun NotificationCompat.Builder.addActionsInternal(subject: Module)
+    = when (subject.configuration) {
+        Download -> addAction(0, R.string.download_open_parent, fileIntent(subject.file.parentFile!!))
+            .addAction(0, R.string.download_open_self, fileIntent(subject.file))
+        is Flash -> setContentIntent(FlashActivity.installIntent(context, subject.file))
+        else -> this
+    }
+
+    private fun NotificationCompat.Builder.addActionsInternal(subject: Manager)
+    = when (subject.configuration) {
+        APK.Upgrade -> setContentIntent(APKInstall.installIntent(context, subject.file))
+        else -> this
+    }
+
+    @Suppress("ReplaceSingleLineLet")
+    private fun NotificationCompat.Builder.setContentIntent(intent: Intent) =
+        PendingIntent.getActivity(context, nextInt(), intent, PendingIntent.FLAG_ONE_SHOT)
+            .let { setContentIntent(it) }
+
+    @Suppress("ReplaceSingleLineLet")
+    private fun NotificationCompat.Builder.addAction(icon: Int, title: Int, intent: Intent) =
+        PendingIntent.getActivity(context, nextInt(), intent, PendingIntent.FLAG_ONE_SHOT)
+            .let { addAction(icon, getString(title), it) }
+
+    // ---
+
+    private fun fileIntent(file: File): Intent {
+        return Intent(Intent.ACTION_VIEW)
+            .setDataAndType(file.provide(this), file.type)
+            .addFlags(Intent.FLAG_ACTIVITY_NEW_TASK)
+            .addFlags(Intent.FLAG_GRANT_READ_URI_PERMISSION)
+            .chooser()
+    }
+
+    class Builder {
+        lateinit var subject: DownloadSubject
+    }
+
+    companion object {
+
+        inline operator fun invoke(context: Context, argBuilder: Builder.() -> Unit) {
+            val app = context.applicationContext
+            val builder = Builder().apply(argBuilder)
+            val intent = Intent(app, ClassMap[DownloadService::class.java])
+                .putExtra(ARG_URL, builder.subject)
+
+            if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
+                app.startForegroundService(intent)
+            } else {
+                app.startService(intent)
+            }
+        }
+
+    }
+
+}

app/src/main/java/com/topjohnwu/magisk/model/download/ManagerUpgrade.kt

@@ -0,0 +1,65 @@
+package com.topjohnwu.magisk.model.download
+
+import android.content.ComponentName
+import com.topjohnwu.magisk.BuildConfig
+import com.topjohnwu.magisk.ClassMap
+import com.topjohnwu.magisk.Config
+import com.topjohnwu.magisk.R
+import com.topjohnwu.magisk.model.entity.internal.Configuration.APK.Restore
+import com.topjohnwu.magisk.model.entity.internal.Configuration.APK.Upgrade
+import com.topjohnwu.magisk.model.entity.internal.DownloadSubject
+import com.topjohnwu.magisk.ui.SplashActivity
+import com.topjohnwu.magisk.utils.DynamicClassLoader
+import com.topjohnwu.magisk.utils.PatchAPK
+import com.topjohnwu.magisk.utils.RootUtils
+import com.topjohnwu.superuser.Shell
+import timber.log.Timber
+import java.io.File
+
+private fun RemoteFileService.patchPackage(apk: File, id: Int) {
+    if (packageName != BuildConfig.APPLICATION_ID) {
+        update(id) { notification ->
+            notification.setProgress(0, 0, true)
+                    .setProgress(0, 0, true)
+                    .setContentTitle(getString(R.string.hide_manager_title))
+                    .setContentText("")
+        }
+        val patched = File(apk.parent, "patched.apk")
+        try {
+            // Try using the new APK to patch itself
+            val loader = DynamicClassLoader(apk)
+            loader.loadClass("a.a")
+                    .getMethod("patchAPK", String::class.java, String::class.java, String::class.java)
+                    .invoke(null, apk.path, patched.path, packageName)
+        } catch (e: Exception) {
+            Timber.e(e)
+            // Fallback to use the current implementation
+            PatchAPK.patch(apk.path, patched.path, packageName)
+        }
+        apk.delete()
+        patched.renameTo(apk)
+    }
+}
+
+private fun RemoteFileService.restore(apk: File, id: Int) {
+    update(id) { notification ->
+        notification.setProgress(0, 0, true)
+                .setProgress(0, 0, true)
+                .setContentTitle(getString(R.string.restore_img_msg))
+                .setContentText("")
+    }
+    Config.export()
+    // Make it world readable
+    apk.setReadable(true, false)
+    if (Shell.su("pm install $apk").exec().isSuccess) {
+        val component = ComponentName(BuildConfig.APPLICATION_ID,
+                ClassMap.get<Class<*>>(SplashActivity::class.java).name)
+        RootUtils.rmAndLaunch(packageName, component)
+    }
+}
+
+fun RemoteFileService.handleAPK(subject: DownloadSubject.Manager)
+    = when (subject.configuration) {
+        is Upgrade -> patchPackage(subject.file, subject.hashCode())
+        is Restore -> restore(subject.file, subject.hashCode())
+    }

app/src/main/java/com/topjohnwu/magisk/model/download/ModuleProcessor.kt

@@ -0,0 +1,44 @@
+package com.topjohnwu.magisk.model.download
+
+import com.topjohnwu.magisk.extensions.withStreams
+import java.io.File
+import java.io.InputStream
+import java.util.zip.ZipEntry
+import java.util.zip.ZipInputStream
+import java.util.zip.ZipOutputStream
+
+fun InputStream.toModule(file: File, installer: InputStream) {
+
+    val input = ZipInputStream(buffered())
+    val output = ZipOutputStream(file.outputStream().buffered())
+
+    withStreams(input, output) { zin, zout ->
+        zout.putNextEntry(ZipEntry("META-INF/"))
+        zout.putNextEntry(ZipEntry("META-INF/com/"))
+        zout.putNextEntry(ZipEntry("META-INF/com/google/"))
+        zout.putNextEntry(ZipEntry("META-INF/com/google/android/"))
+        zout.putNextEntry(ZipEntry("META-INF/com/google/android/update-binary"))
+        installer.copyTo(zout)
+
+        zout.putNextEntry(ZipEntry("META-INF/com/google/android/updater-script"))
+        zout.write("#MAGISK\n".toByteArray(charset("UTF-8")))
+
+        var off = -1
+        var entry: ZipEntry? = zin.nextEntry
+        while (entry != null) {
+            if (off < 0) {
+                off = entry.name.indexOf('/') + 1
+            }
+
+            val path = entry.name.substring(off)
+            if (path.isNotEmpty() && !path.startsWith("META-INF")) {
+                zout.putNextEntry(ZipEntry(path))
+                if (!entry.isDirectory) {
+                    zin.copyTo(zout)
+                }
+            }
+
+            entry = zin.nextEntry
+        }
+    }
+}

app/src/main/java/com/topjohnwu/magisk/model/download/NotificationService.kt

@@ -0,0 +1,86 @@
+package com.topjohnwu.magisk.model.download
+
+import android.app.Notification
+import android.app.Service
+import android.content.Intent
+import android.os.IBinder
+import androidx.core.app.NotificationCompat
+import androidx.core.app.NotificationManagerCompat
+import java.util.*
+import kotlin.random.Random.Default.nextInt
+
+abstract class NotificationService : Service() {
+
+    abstract val defaultNotification: NotificationCompat.Builder
+
+    private val manager by lazy { NotificationManagerCompat.from(this) }
+    private val hasNotifications get() = notifications.isNotEmpty()
+
+    private val notifications =
+        Collections.synchronizedMap(mutableMapOf<Int, NotificationCompat.Builder>())
+
+    override fun onTaskRemoved(rootIntent: Intent?) {
+        super.onTaskRemoved(rootIntent)
+        notifications.forEach { cancel(it.key) }
+        notifications.clear()
+    }
+
+    // --
+
+    fun update(
+        id: Int,
+        body: (NotificationCompat.Builder) -> Unit = {}
+    ) {
+        val notification = notifications.getOrPut(id) { defaultNotification }
+
+        notify(id, notification.also(body).build())
+
+        if (notifications.size == 1) {
+            updateForeground()
+        }
+    }
+
+    protected fun finishNotify(
+        id: Int,
+        editBody: (NotificationCompat.Builder) -> NotificationCompat.Builder? = { null }
+    ) : Int {
+        val currentNotification = remove(id)?.run(editBody)
+
+        var newId = -1
+        currentNotification?.let {
+            newId = nextInt(Int.MAX_VALUE)
+            notify(newId, it.build())
+        }
+
+        if (!hasNotifications) {
+            stopSelf()
+        }
+        return newId
+    }
+
+    // ---
+
+    private fun notify(id: Int, notification: Notification) {
+        manager.notify(id, notification)
+    }
+
+    private fun cancel(id: Int) {
+        manager.cancel(id)
+    }
+
+    protected fun remove(id: Int) = notifications.remove(id).also {
+        cancel(id)
+        updateForeground()
+    }
+
+    private fun updateForeground() {
+        if (hasNotifications)
+            startForeground(notifications.keys.first(), notifications.values.first().build())
+        else
+            stopForeground(true)
+    }
+
+    // --
+
+    override fun onBind(p0: Intent?): IBinder? = null
+}

app/src/main/java/com/topjohnwu/magisk/model/download/RemoteFileService.kt

@@ -0,0 +1,118 @@
+package com.topjohnwu.magisk.model.download
+
+import android.app.Activity
+import android.content.Intent
+import androidx.core.app.NotificationCompat
+import com.skoumal.teanity.extensions.subscribeK
+import com.topjohnwu.magisk.R
+import com.topjohnwu.magisk.data.network.GithubRawServices
+import com.topjohnwu.magisk.di.NullActivity
+import com.topjohnwu.magisk.extensions.get
+import com.topjohnwu.magisk.extensions.writeTo
+import com.topjohnwu.magisk.model.entity.internal.DownloadSubject
+import com.topjohnwu.magisk.model.entity.internal.DownloadSubject.*
+import com.topjohnwu.magisk.utils.ProgressInputStream
+import com.topjohnwu.magisk.view.Notifications
+import com.topjohnwu.superuser.ShellUtils
+import io.reactivex.Completable
+import okhttp3.ResponseBody
+import org.koin.android.ext.android.inject
+import timber.log.Timber
+import java.io.InputStream
+
+abstract class RemoteFileService : NotificationService() {
+
+    private val service: GithubRawServices by inject()
+
+    override val defaultNotification: NotificationCompat.Builder
+        get() = Notifications.progress(this, "")
+
+    override fun onStartCommand(intent: Intent?, flags: Int, startId: Int): Int {
+        intent?.getParcelableExtra<DownloadSubject>(ARG_URL)?.let { start(it) }
+        return START_REDELIVER_INTENT
+    }
+
+    // ---
+
+    private fun start(subject: DownloadSubject) = checkExisting(subject)
+        .onErrorResumeNext { download(subject) }
+        .doOnSubscribe { update(subject.hashCode()) { it.setContentTitle(subject.title) } }
+        .subscribeK(onError = {
+            Timber.e(it)
+            finishNotify(subject.hashCode()) { notification ->
+                notification.setContentText(getString(R.string.download_file_error))
+                        .setSmallIcon(android.R.drawable.stat_notify_error)
+                        .setOngoing(false)
+            }
+        }) {
+            val newId = finishNotify(subject)
+            if (get<Activity>() !is NullActivity) {
+                onFinished(subject, newId)
+            }
+        }
+
+    private fun checkExisting(subject: DownloadSubject) = Completable.fromAction {
+        check(subject is Magisk) { "Download cache is disabled" }
+
+        subject.file.also {
+            check(it.exists() && ShellUtils.checkSum("MD5", it, subject.magisk.md5)) {
+                "The given file does not match checksum"
+            }
+        }
+    }
+
+    private fun download(subject: DownloadSubject) = service.fetchFile(subject.url)
+        .map { it.toStream(subject.hashCode()) }
+        .flatMapCompletable { stream ->
+            when (subject) {
+                is Module -> service.fetchInstaller()
+                        .doOnSuccess { stream.toModule(subject.file, it.byteStream()) }
+                        .ignoreElement()
+                else -> Completable.fromAction { stream.writeTo(subject.file) }
+            }
+        }.doOnComplete {
+            if (subject is Manager)
+                handleAPK(subject)
+        }
+
+    private fun ResponseBody.toStream(id: Int): InputStream {
+        val maxRaw = contentLength()
+        val max = maxRaw / 1_000_000f
+
+        return ProgressInputStream(byteStream()) {
+            val progress = it / 1_000_000f
+            update(id) { notification ->
+                if (maxRaw > 0) {
+                    notification
+                            .setProgress(maxRaw.toInt(), it.toInt(), false)
+                            .setContentText("%.2f / %.2f MB".format(progress, max))
+                } else {
+                    notification.setContentText("%.2f MB / ??".format(progress))
+                }
+            }
+        }
+    }
+
+    private fun finishNotify(subject: DownloadSubject) = finishNotify(subject.hashCode()) {
+        it.addActions(subject)
+            .setContentText(getString(R.string.download_complete))
+            .setSmallIcon(android.R.drawable.stat_sys_download_done)
+            .setProgress(0, 0, false)
+            .setOngoing(false)
+            .setAutoCancel(true)
+    }
+
+    // ---
+
+
+    @Throws(Throwable::class)
+    protected abstract fun onFinished(subject: DownloadSubject, id: Int)
+
+    protected abstract fun NotificationCompat.Builder.addActions(subject: DownloadSubject)
+            : NotificationCompat.Builder
+
+    companion object {
+        const val ARG_URL = "arg_url"
+    }
+
+}

app/src/main/java/com/topjohnwu/magisk/model/entity/BaseModule.java

@@ -1,155 +0,0 @@
-package com.topjohnwu.magisk.model.entity;
-
-import android.content.ContentValues;
-import android.database.Cursor;
-import android.os.Parcel;
-import android.os.Parcelable;
-
-import androidx.annotation.NonNull;
-
-import java.util.List;
-
-public abstract class BaseModule implements Comparable<BaseModule>, Parcelable {
-
-    private String mId, mName, mVersion, mAuthor, mDescription;
-    private int mVersionCode = -1;
-
-    protected BaseModule() {
-        mId = mName = mVersion = mAuthor = mDescription = "";
-    }
-
-    protected BaseModule(Cursor c) {
-        mId = nonNull(c.getString(c.getColumnIndex("id")));
-        mName = nonNull(c.getString(c.getColumnIndex("name")));
-        mVersion = nonNull(c.getString(c.getColumnIndex("version")));
-        mVersionCode = c.getInt(c.getColumnIndex("versionCode"));
-        mAuthor = nonNull(c.getString(c.getColumnIndex("author")));
-        mDescription = nonNull(c.getString(c.getColumnIndex("description")));
-    }
-
-    protected BaseModule(Parcel p) {
-        mId = p.readString();
-        mName = p.readString();
-        mVersion = p.readString();
-        mAuthor = p.readString();
-        mDescription = p.readString();
-        mVersionCode = p.readInt();
-    }
-
-    protected BaseModule(MagiskModule m) {
-        mId = m.getId();
-        mName = m.getName();
-        mVersion = m.getVersion();
-        mAuthor = m.getAuthor();
-        mDescription = m.getDescription();
-        mVersionCode = Integer.parseInt(m.getVersionCode());
-    }
-
-    @Override
-    public int compareTo(@NonNull BaseModule module) {
-        return getName().toLowerCase().compareTo(module.getName().toLowerCase());
-    }
-
-    @Override
-    public int describeContents() {
-        return 0;
-    }
-
-    @Override
-    public void writeToParcel(Parcel dest, int flags) {
-        dest.writeString(mId);
-        dest.writeString(mName);
-        dest.writeString(mVersion);
-        dest.writeString(mAuthor);
-        dest.writeString(mDescription);
-        dest.writeInt(mVersionCode);
-    }
-
-    private String nonNull(String s) {
-        return s == null ? "" : s;
-    }
-
-    public ContentValues getContentValues() {
-        ContentValues values = new ContentValues();
-        values.put("id", mId);
-        values.put("name", mName);
-        values.put("version", mVersion);
-        values.put("versionCode", mVersionCode);
-        values.put("author", mAuthor);
-        values.put("description", mDescription);
-        return values;
-    }
-
-    protected void parseProps(List<String> props) {
-        parseProps(props.toArray(new String[0]));
-    }
-
-    protected void parseProps(String[] props) throws NumberFormatException {
-        for (String line : props) {
-            String[] prop = line.split("=", 2);
-            if (prop.length != 2)
-                continue;
-
-            String key = prop[0].trim();
-            String value = prop[1].trim();
-            if (key.isEmpty() || key.charAt(0) == '#')
-                continue;
-
-            switch (key) {
-                case "id":
-                    mId = value;
-                    break;
-                case "name":
-                    mName = value;
-                    break;
-                case "version":
-                    mVersion = value;
-                    break;
-                case "versionCode":
-                    mVersionCode = Integer.parseInt(value);
-                    break;
-                case "author":
-                    mAuthor = value;
-                    break;
-                case "description":
-                    mDescription = value;
-                    break;
-                default:
-                    break;
-            }
-        }
-    }
-
-    public String getName() {
-        return mName;
-    }
-
-    public void setName(String name) {
-        mName = name;
-    }
-
-    public String getVersion() {
-        return mVersion;
-    }
-
-    public String getAuthor() {
-        return mAuthor;
-    }
-
-    public String getId() {
-        return mId;
-    }
-
-    public void setId(String id) {
-        mId = id;
-    }
-
-    public String getDescription() {
-        return mDescription;
-    }
-
-    public int getVersionCode() {
-        return mVersionCode;
-    }
-
-}

app/src/main/java/com/topjohnwu/magisk/model/entity/HideAppInfo.kt

@@ -2,8 +2,8 @@ package com.topjohnwu.magisk.model.entity
 
 import android.content.pm.ApplicationInfo
 import android.graphics.drawable.Drawable
-import com.topjohnwu.magisk.utils.packageInfo
-import com.topjohnwu.magisk.utils.processes
+import com.topjohnwu.magisk.extensions.packageInfo
+import com.topjohnwu.magisk.extensions.processes
 
 class HideAppInfo(
     val info: ApplicationInfo,

app/src/main/java/com/topjohnwu/magisk/model/entity/MagiskApp.kt

@@ -1,11 +0,0 @@
-package com.topjohnwu.magisk.model.entity
-
-import se.ansman.kotshi.JsonSerializable
-
-@JsonSerializable
-data class MagiskApp(
-    val version: String,
-    val versionCode: String,
-    val link: String,
-    val note: String
-)

app/src/main/java/com/topjohnwu/magisk/model/entity/MagiskConfig.kt

@@ -1,10 +0,0 @@
-package com.topjohnwu.magisk.model.entity
-
-import se.ansman.kotshi.JsonSerializable
-
-@JsonSerializable
-data class MagiskConfig(
-    val app: MagiskApp,
-    val uninstaller: MagiskLink,
-    val magisk: MagiskFlashable
-)

app/src/main/java/com/topjohnwu/magisk/model/entity/MagiskFlashable.kt

@@ -1,13 +0,0 @@
-package com.topjohnwu.magisk.model.entity
-
-import com.squareup.moshi.Json
-import se.ansman.kotshi.JsonSerializable
-
-@JsonSerializable
-data class MagiskFlashable(
-    val version: String,
-    val versionCode: String,
-    val link: String,
-    val note: String,
-    @Json(name = "md5") val hash: String
-)

app/src/main/java/com/topjohnwu/magisk/model/entity/MagiskLink.kt

@@ -1,8 +0,0 @@
-package com.topjohnwu.magisk.model.entity
-
-import se.ansman.kotshi.JsonSerializable
-
-@JsonSerializable
-data class MagiskLink(
-    val link: String
-)

app/src/main/java/com/topjohnwu/magisk/model/entity/MagiskLog.kt

@@ -1,8 +1,8 @@
 package com.topjohnwu.magisk.model.entity
 
+import com.topjohnwu.magisk.extensions.timeFormatTime
+import com.topjohnwu.magisk.extensions.toTime
 import com.topjohnwu.magisk.model.entity.MagiskPolicy.Companion.ALLOW
-import com.topjohnwu.magisk.utils.timeFormatTime
-import com.topjohnwu.magisk.utils.toTime
 import java.util.*
 
 data class MagiskLog(

app/src/main/java/com/topjohnwu/magisk/model/entity/MagiskModule.kt

@@ -1,86 +0,0 @@
-package com.topjohnwu.magisk.model.entity
-
-import android.os.Parcelable
-import androidx.annotation.AnyThread
-import androidx.annotation.NonNull
-import androidx.annotation.WorkerThread
-import androidx.room.Entity
-import androidx.room.PrimaryKey
-import com.topjohnwu.magisk.Const
-import com.topjohnwu.magisk.data.database.base.su
-import io.reactivex.Single
-import kotlinx.android.parcel.Parcelize
-import okhttp3.ResponseBody
-import java.io.File
-
-interface MagiskModule : Parcelable {
-    val id: String
-    val name: String
-    val author: String
-    val version: String
-    val versionCode: String
-    val description: String
-}
-
-@Entity(tableName = "repos")
-@Parcelize
-data class Repository(
-    @PrimaryKey @NonNull
-    override val id: String,
-    override val name: String,
-    override val author: String,
-    override val version: String,
-    override val versionCode: String,
-    override val description: String,
-    val lastUpdate: Long
-) : MagiskModule
-
-@Parcelize
-data class Module(
-    override val id: String,
-    override val name: String,
-    override val author: String,
-    override val version: String,
-    override val versionCode: String,
-    override val description: String,
-    val path: String
-) : MagiskModule
-
-@AnyThread
-fun File.toModule(): Single<Module> {
-    val path = "${Const.MAGISK_PATH}/$name"
-    return "dos2unix < $path/module.prop".su()
-        .map { it.first().toModule(path) }
-}
-
-fun Map<String, String>.toModule(path: String): Module {
-    return Module(
-        id = get("id").orEmpty(),
-        name = get("name").orEmpty(),
-        author = get("author").orEmpty(),
-        version = get("version").orEmpty(),
-        versionCode = get("versionCode").orEmpty(),
-        description = get("description").orEmpty(),
-        path = path
-    )
-}
-
-@WorkerThread
-fun ResponseBody.toRepository(lastUpdate: Long) = string()
-    .split(Regex("\\n"))
-    .map { it.split("=", limit = 2) }
-    .filter { it.size == 2 }
-    .map { Pair(it[0], it[1]) }
-    .toMap()
-    .toRepository(lastUpdate)
-
-@AnyThread
-fun Map<String, String>.toRepository(lastUpdate: Long) = Repository(
-    id = get("id").orEmpty(),
-    name = get("name").orEmpty(),
-    author = get("author").orEmpty(),
-    version = get("version").orEmpty(),
-    versionCode = get("versionCode").orEmpty(),
-    description = get("description").orEmpty(),
-    lastUpdate = lastUpdate
-)

app/src/main/java/com/topjohnwu/magisk/model/entity/MagiskPolicy.kt

@@ -2,6 +2,7 @@ package com.topjohnwu.magisk.model.entity
 
 import android.content.pm.ApplicationInfo
 import android.content.pm.PackageManager
+import com.topjohnwu.magisk.extensions.getLabel
 import com.topjohnwu.magisk.model.entity.MagiskPolicy.Companion.INTERACTIVE
 
 
@@ -50,7 +51,7 @@ fun Map<String, String>.toPolicy(pm: PackageManager): MagiskPolicy {
         logging = get("logging")?.toIntOrNull() != 0,
         notification = get("notification")?.toIntOrNull() != 0,
         applicationInfo = info,
-        appName = info.loadLabel(pm).toString()
+        appName = info.getLabel(pm)
     )
 }
 

app/src/main/java/com/topjohnwu/magisk/model/entity/OldModule.java

@@ -1,83 +0,0 @@
-package com.topjohnwu.magisk.model.entity;
-
-import android.os.Parcel;
-import android.os.Parcelable;
-
-import com.topjohnwu.superuser.Shell;
-import com.topjohnwu.superuser.io.SuFile;
-
-public class OldModule extends BaseModule {
-
-    public static final Parcelable.Creator<OldModule> CREATOR = new Creator<OldModule>() {
-        /* It won't be used at any place */
-        @Override
-        public OldModule createFromParcel(Parcel source) {
-            return null;
-        }
-
-        @Override
-        public OldModule[] newArray(int size) {
-            return null;
-        }
-    };
-    private final SuFile mRemoveFile;
-    private final SuFile mDisableFile;
-    private final SuFile mUpdateFile;
-    private final boolean mUpdated;
-    private boolean mEnable;
-    private boolean mRemove;
-
-    public OldModule(String path) {
-
-        try {
-            parseProps(Shell.su("dos2unix <  " + path + "/module.prop").exec().getOut());
-        } catch (NumberFormatException ignored) {
-        }
-
-        mRemoveFile = new SuFile(path, "remove");
-        mDisableFile = new SuFile(path, "disable");
-        mUpdateFile = new SuFile(path, "update");
-
-        if (getId().isEmpty()) {
-            int sep = path.lastIndexOf('/');
-            setId(path.substring(sep + 1));
-        }
-
-        if (getName().isEmpty()) {
-            setName(getId());
-        }
-
-        mEnable = !mDisableFile.exists();
-        mRemove = mRemoveFile.exists();
-        mUpdated = mUpdateFile.exists();
-    }
-
-    public void createDisableFile() {
-        mEnable = !mDisableFile.createNewFile();
-    }
-
-    public void removeDisableFile() {
-        mEnable = mDisableFile.delete();
-    }
-
-    public boolean isEnabled() {
-        return mEnable;
-    }
-
-    public void createRemoveFile() {
-        mRemove = mRemoveFile.createNewFile();
-    }
-
-    public void deleteRemoveFile() {
-        mRemove = !mRemoveFile.delete();
-    }
-
-    public boolean willBeRemoved() {
-        return mRemove;
-    }
-
-    public boolean isUpdated() {
-        return mUpdated;
-    }
-
-}

app/src/main/java/com/topjohnwu/magisk/model/entity/Policy.java

@@ -1,61 +0,0 @@
-package com.topjohnwu.magisk.model.entity;
-
-import android.content.ContentValues;
-import android.content.pm.ApplicationInfo;
-import android.content.pm.PackageManager;
-
-import androidx.annotation.NonNull;
-
-import com.topjohnwu.magisk.utils.Utils;
-
-
-public class Policy implements Comparable<Policy>{
-    public static final int INTERACTIVE = 0;
-    public static final int DENY = 1;
-    public static final int ALLOW = 2;
-
-    public int uid, policy = INTERACTIVE;
-    public long until;
-    public boolean logging = true, notification = true;
-    public String packageName, appName;
-    public ApplicationInfo info;
-
-    public Policy(int uid, PackageManager pm) throws PackageManager.NameNotFoundException {
-        String[] pkgs = pm.getPackagesForUid(uid);
-        if (pkgs == null || pkgs.length == 0)
-            throw new PackageManager.NameNotFoundException();
-        this.uid = uid;
-        packageName = pkgs[0];
-        info = pm.getApplicationInfo(packageName, 0);
-        appName = Utils.INSTANCE.getAppLabel(info, pm);
-    }
-
-    public Policy(ContentValues values, PackageManager pm) throws PackageManager.NameNotFoundException {
-        uid = values.getAsInteger("uid");
-        packageName = values.getAsString("package_name");
-        policy = values.getAsInteger("policy");
-        until = values.getAsInteger("until");
-        logging = values.getAsInteger("logging") != 0;
-        notification = values.getAsInteger("notification") != 0;
-        info = pm.getApplicationInfo(packageName, 0);
-        if (info.uid != uid)
-            throw new PackageManager.NameNotFoundException();
-        appName = info.loadLabel(pm).toString();
-    }
-
-    public ContentValues getContentValues() {
-        ContentValues values = new ContentValues();
-        values.put("uid", uid);
-        values.put("package_name", packageName);
-        values.put("policy", policy);
-        values.put("until", until);
-        values.put("logging", logging ? 1 : 0);
-        values.put("notification", notification ? 1 : 0);
-        return values;
-    }
-
-    @Override
-    public int compareTo(@NonNull Policy policy) {
-        return appName.toLowerCase().compareTo(policy.appName.toLowerCase());
-    }
-}

app/src/main/java/com/topjohnwu/magisk/model/entity/Repo.java

@@ -1,114 +0,0 @@
-package com.topjohnwu.magisk.model.entity;
-
-import android.content.ContentValues;
-import android.database.Cursor;
-import android.os.Parcel;
-import android.os.Parcelable;
-
-import com.topjohnwu.magisk.Const;
-import com.topjohnwu.magisk.utils.Utils;
-
-import java.text.DateFormat;
-import java.util.Date;
-
-public class Repo extends BaseModule {
-
-    private Date mLastUpdate;
-
-    public Repo(String id) {
-        setId(id);
-    }
-
-    public Repo(Cursor c) {
-        super(c);
-        mLastUpdate = new Date(c.getLong(c.getColumnIndex("last_update")));
-    }
-
-    public Repo(Parcel p) {
-        super(p);
-        mLastUpdate = new Date(p.readLong());
-    }
-
-    public Repo(Repository repo) {
-        super(repo);
-        mLastUpdate = new Date(repo.getLastUpdate());
-    }
-
-    public static final Parcelable.Creator<Repo> CREATOR = new Parcelable.Creator<Repo>() {
-
-        @Override
-        public Repo createFromParcel(Parcel source) {
-            return new Repo(source);
-        }
-
-        @Override
-        public Repo[] newArray(int size) {
-            return new Repo[size];
-        }
-    };
-
-    @Override
-    public void writeToParcel(Parcel dest, int flags) {
-        super.writeToParcel(dest, flags);
-        dest.writeLong(mLastUpdate.getTime());
-    }
-
-    public void update() throws IllegalRepoException {
-        String[] props = Utils.INSTANCE.dlString(getPropUrl()).split("\\n");
-        try {
-            parseProps(props);
-        } catch (NumberFormatException e) {
-            throw new IllegalRepoException("Repo [" + getId() + "] parse error: " + e.getMessage());
-        }
-
-        if (getVersionCode() < 0) {
-            throw new IllegalRepoException("Repo [" + getId() + "] does not contain versionCode");
-        }
-    }
-
-    public void update(Date lastUpdate) throws IllegalRepoException {
-        mLastUpdate = lastUpdate;
-        update();
-    }
-
-    @Override
-    public ContentValues getContentValues() {
-        ContentValues values = super.getContentValues();
-        values.put("last_update", mLastUpdate.getTime());
-        return values;
-    }
-
-    public String getZipUrl() {
-        return String.format(Const.Url.ZIP_URL, getId());
-    }
-
-    public String getPropUrl() {
-        return getFileUrl("module.prop");
-    }
-
-    public String getDetailUrl() {
-        return getFileUrl("README.md");
-    }
-
-    public String getFileUrl(String file) {
-        return String.format(Const.Url.FILE_URL, getId(), file);
-    }
-
-    public String getLastUpdateString() {
-        return DateFormat.getDateTimeInstance(DateFormat.MEDIUM, DateFormat.MEDIUM).format(mLastUpdate);
-    }
-
-    public Date getLastUpdate() {
-        return mLastUpdate;
-    }
-
-    public String getDownloadFilename() {
-        return Utils.INSTANCE.getLegalFilename(getName() + "-" + getVersion() + ".zip");
-    }
-
-    public class IllegalRepoException extends Exception {
-        IllegalRepoException(String message) {
-            super(message);
-        }
-    }
-}

app/src/main/java/com/topjohnwu/magisk/model/entity/SuLogEntry.java

@@ -1,56 +0,0 @@
-package com.topjohnwu.magisk.model.entity;
-
-import android.content.ContentValues;
-
-import com.topjohnwu.magisk.utils.LocaleManager;
-
-import java.text.DateFormat;
-import java.text.SimpleDateFormat;
-import java.util.Date;
-
-public class SuLogEntry {
-
-    public int fromUid, toUid, fromPid;
-    public String packageName, appName, command;
-    public boolean action;
-    public Date date;
-
-    public SuLogEntry(MagiskPolicy policy) {
-        fromUid = policy.getUid();
-        packageName = policy.getPackageName();
-        appName = policy.getAppName();
-        action = policy.getPolicy() == Policy.ALLOW;
-    }
-
-    public SuLogEntry(ContentValues values) {
-        fromUid = values.getAsInteger("from_uid");
-        packageName = values.getAsString("package_name");
-        appName = values.getAsString("app_name");
-        fromPid = values.getAsInteger("from_pid");
-        command = values.getAsString("command");
-        toUid = values.getAsInteger("to_uid");
-        action = values.getAsInteger("action") != 0;
-        date = new Date(values.getAsLong("time"));
-    }
-
-    public ContentValues getContentValues() {
-        ContentValues values = new ContentValues();
-        values.put("from_uid", fromUid);
-        values.put("package_name", packageName);
-        values.put("app_name", appName);
-        values.put("from_pid", fromPid);
-        values.put("command", command);
-        values.put("to_uid", toUid);
-        values.put("action", action ? 1 : 0);
-        values.put("time", date.getTime());
-        return values;
-    }
-
-    public String getDateString() {
-        return DateFormat.getDateInstance(DateFormat.MEDIUM, LocaleManager.getLocale()).format(date);
-    }
-
-    public String getTimeString() {
-        return new SimpleDateFormat("h:mm a", LocaleManager.getLocale()).format(date);
-    }
-}

app/src/main/java/com/topjohnwu/magisk/model/entity/UpdateInfo.kt

@@ -0,0 +1,35 @@
+package com.topjohnwu.magisk.model.entity
+
+import android.os.Parcelable
+import kotlinx.android.parcel.Parcelize
+import se.ansman.kotshi.JsonSerializable
+
+@JsonSerializable
+data class UpdateInfo(
+    val app: ManagerJson = ManagerJson(),
+    val uninstaller: UninstallerJson = UninstallerJson(),
+    val magisk: MagiskJson = MagiskJson()
+)
+
+@JsonSerializable
+data class UninstallerJson(
+    val link: String = ""
+)
+
+@JsonSerializable
+data class MagiskJson(
+    val version: String = "",
+    val versionCode: Int = -1,
+    val link: String = "",
+    val note: String = "",
+    val md5: String = ""
+)
+
+@Parcelize
+@JsonSerializable
+data class ManagerJson(
+    val version: String = "",
+    val versionCode: Int = -1,
+    val link: String = "",
+    val note: String = ""
+) : Parcelable

app/src/main/java/com/topjohnwu/magisk/model/entity/internal/Configuration.kt

@@ -0,0 +1,37 @@
+package com.topjohnwu.magisk.model.entity.internal
+
+import android.net.Uri
+import android.os.Parcelable
+import kotlinx.android.parcel.Parcelize
+
+sealed class Configuration : Parcelable {
+
+    sealed class Flash : Configuration() {
+
+        @Parcelize
+        object Primary : Flash()
+
+        @Parcelize
+        object Secondary : Flash()
+
+    }
+
+    sealed class APK : Configuration() {
+
+        @Parcelize
+        object Upgrade : APK()
+
+        @Parcelize
+        object Restore : APK()
+    }
+
+    @Parcelize
+    object Download : Configuration()
+
+    @Parcelize
+    object Uninstall : Configuration()
+
+    @Parcelize
+    data class Patch(val fileUri: Uri) : Configuration()
+
+}

app/src/main/java/com/topjohnwu/magisk/model/entity/internal/DownloadSubject.kt

@@ -0,0 +1,106 @@
+package com.topjohnwu.magisk.model.entity.internal
+
+import android.content.Context
+import android.os.Parcelable
+import com.topjohnwu.magisk.Config
+import com.topjohnwu.magisk.Info
+import com.topjohnwu.magisk.extensions.cachedFile
+import com.topjohnwu.magisk.extensions.get
+import com.topjohnwu.magisk.model.entity.MagiskJson
+import com.topjohnwu.magisk.model.entity.ManagerJson
+import com.topjohnwu.magisk.model.entity.module.Repo
+import kotlinx.android.parcel.IgnoredOnParcel
+import kotlinx.android.parcel.Parcelize
+import java.io.File
+
+sealed class DownloadSubject : Parcelable {
+
+    abstract val url: String
+    abstract val file: File
+    open val title: String get() = file.name
+
+    @Parcelize
+    data class Module(
+        val module: Repo,
+        val configuration: Configuration
+    ) : DownloadSubject() {
+        override val url: String get() = module.zipUrl
+
+        @IgnoredOnParcel
+        override val file by lazy {
+            File(Config.downloadDirectory, module.downloadFilename)
+        }
+    }
+
+    @Parcelize
+    data class Manager(
+        val configuration: Configuration.APK
+    ) : DownloadSubject() {
+
+        @IgnoredOnParcel
+        val manager: ManagerJson = Info.remote.app
+
+        override val title: String
+            get() = "MagiskManager-v${manager.version}(${manager.versionCode})"
+
+        override val url: String
+            get() = manager.link
+
+        @IgnoredOnParcel
+        override val file by lazy {
+            get<Context>().cachedFile("manager.apk")
+        }
+
+    }
+
+    sealed class Magisk : DownloadSubject() {
+
+        abstract val configuration: Configuration
+        val magisk: MagiskJson = Info.remote.magisk
+
+        @Parcelize
+        protected data class Flash(
+            override val configuration: Configuration
+        ) : Magisk() {
+            override val url: String get() = magisk.link
+            override val title: String get() = "Magisk-v${magisk.version}(${magisk.versionCode})"
+
+            @IgnoredOnParcel
+            override val file by lazy {
+                get<Context>().cachedFile("magisk.zip")
+            }
+        }
+
+        @Parcelize
+        protected class Uninstall : Magisk() {
+            override val configuration: Configuration get() = Configuration.Uninstall
+            override val url: String get() = Info.remote.uninstaller.link
+
+            @IgnoredOnParcel
+            override val file by lazy {
+                get<Context>().cachedFile("uninstall.zip")
+            }
+        }
+
+        @Parcelize
+        protected class Download : Magisk() {
+            override val configuration: Configuration get() = Configuration.Download
+            override val url: String get() = magisk.link
+
+            @IgnoredOnParcel
+            override val file by lazy {
+                File(Config.downloadDirectory, "Magisk-v${magisk.version}(${magisk.versionCode}).zip")
+            }
+        }
+
+        companion object {
+            operator fun invoke(configuration: Configuration) = when (configuration) {
+                Configuration.Download -> Download()
+                Configuration.Uninstall -> Uninstall()
+                else -> Flash(configuration)
+            }
+        }
+
+    }
+
+}

app/src/main/java/com/topjohnwu/magisk/model/entity/module/BaseModule.kt

@@ -0,0 +1,41 @@
+package com.topjohnwu.magisk.model.entity.module
+
+abstract class BaseModule : Comparable<BaseModule> {
+    abstract var id: String
+        protected set
+    abstract var name: String
+        protected set
+    abstract var author: String
+        protected set
+    abstract var version: String
+        protected set
+    abstract var versionCode: Int
+        protected set
+    abstract var description: String
+        protected set
+
+    @Throws(NumberFormatException::class)
+    protected fun parseProps(props: List<String>) {
+        for (line in props) {
+            val prop = line.split("=".toRegex(), 2).map { it.trim() }
+            if (prop.size != 2)
+                continue
+
+            val key = prop[0]
+            val value = prop[1]
+            if (key.isEmpty() || key[0] == '#')
+                continue
+
+            when (key) {
+                "id" -> id = value
+                "name" -> name = value
+                "version" -> version = value
+                "versionCode" -> versionCode = value.toInt()
+                "author" -> author = value
+                "description" -> description = value
+            }
+        }
+    }
+
+    override operator fun compareTo(other: BaseModule) = name.compareTo(other.name, true)
+}

app/src/main/java/com/topjohnwu/magisk/model/entity/module/Module.kt

@@ -0,0 +1,71 @@
+package com.topjohnwu.magisk.model.entity.module
+
+import androidx.annotation.WorkerThread
+import com.topjohnwu.magisk.Const
+import com.topjohnwu.superuser.Shell
+import com.topjohnwu.superuser.io.SuFile
+
+class Module(path: String) : BaseModule() {
+    override var id: String = ""
+    override var name: String = ""
+    override var author: String = ""
+    override var version: String = ""
+    override var versionCode: Int = -1
+    override var description: String = ""
+
+    private val removeFile: SuFile = SuFile(path, "remove")
+    private val disableFile: SuFile = SuFile(path, "disable")
+    private val updateFile: SuFile = SuFile(path, "update")
+
+    val updated: Boolean = updateFile.exists()
+
+    var enable: Boolean = !disableFile.exists()
+        set(enable) {
+            field = if (enable) {
+                disableFile.delete()
+            } else {
+                !disableFile.createNewFile()
+            }
+        }
+
+    var remove: Boolean = removeFile.exists()
+        set(remove) {
+            field = if (remove) {
+                removeFile.createNewFile()
+            } else {
+                !removeFile.delete()
+            }
+        }
+
+    init {
+        runCatching {
+            parseProps(Shell.su("dos2unix < $path/module.prop").exec().out)
+        }
+
+        if (id.isEmpty()) {
+            val sep = path.lastIndexOf('/')
+            id = path.substring(sep + 1)
+        }
+
+        if (name.isEmpty()) {
+            name = id;
+        }
+    }
+
+    companion object {
+
+        @WorkerThread
+        fun loadModules(): List<Module> {
+            val moduleList = mutableListOf<Module>()
+            val path = SuFile(Const.MAGISK_PATH)
+            val modules =
+                    path.listFiles { _, name -> name != "lost+found" && name != ".core" }.orEmpty()
+            for (file in modules) {
+                if (file.isFile) continue
+                val module = Module(Const.MAGISK_PATH + "/" + file.name)
+                moduleList.add(module)
+            }
+            return moduleList
+        }
+    }
+}

app/src/main/java/com/topjohnwu/magisk/model/entity/module/Repo.kt

@@ -0,0 +1,71 @@
+package com.topjohnwu.magisk.model.entity.module
+
+import android.os.Parcelable
+import androidx.room.Entity
+import androidx.room.PrimaryKey
+import com.topjohnwu.magisk.Const
+import com.topjohnwu.magisk.data.repository.StringRepository
+import com.topjohnwu.magisk.extensions.get
+import com.topjohnwu.magisk.extensions.legalFilename
+import kotlinx.android.parcel.Parcelize
+import java.text.DateFormat
+import java.util.*
+
+@Entity(tableName = "repos")
+@Parcelize
+data class Repo(
+    @PrimaryKey override var id: String,
+    override var name: String,
+    override var author: String,
+    override var version: String,
+    override var versionCode: Int,
+    override var description: String,
+    var last_update: Long
+) : BaseModule(), Parcelable {
+
+    private val stringRepo: StringRepository get() = get()
+
+    val lastUpdate get() = Date(last_update)
+
+    val lastUpdateString: String get() = dateFormat.format(lastUpdate)
+
+    val downloadFilename: String get() = "$name-$version($versionCode).zip".legalFilename()
+
+    val readme get() = stringRepo.getReadme(this)
+
+    val zipUrl: String get() = Const.Url.ZIP_URL.format(id)
+
+    constructor(id: String) : this(id, "", "", "", -1, "", 0)
+
+    @Throws(IllegalRepoException::class)
+    fun update() {
+        val props = runCatching {
+            stringRepo.getMetadata(this).blockingGet()
+                    .orEmpty().split("\\n".toRegex()).dropLastWhile { it.isEmpty() }
+        }.getOrElse {
+            throw IllegalRepoException("Repo [$id] module.prop download error: " + it.message)
+        }
+
+        props.runCatching {
+            parseProps(this)
+        }.onFailure {
+            throw IllegalRepoException("Repo [$id] parse error: " + it.message)
+        }
+
+        if (versionCode < 0) {
+            throw IllegalRepoException("Repo [$id] does not contain versionCode")
+        }
+    }
+
+    @Throws(IllegalRepoException::class)
+    fun update(lastUpdate: Date) {
+        last_update = lastUpdate.time
+        update()
+    }
+
+    class IllegalRepoException(message: String) : Exception(message)
+
+    companion object {
+        val dateFormat = DateFormat.getDateTimeInstance(DateFormat.MEDIUM, DateFormat.MEDIUM)!!
+    }
+}

app/src/main/java/com/topjohnwu/magisk/model/entity/recycler/HideRvItem.kt

@@ -6,12 +6,12 @@ import com.skoumal.teanity.rxbus.RxBus
 import com.skoumal.teanity.util.DiffObservableList
 import com.skoumal.teanity.util.KObservableField
 import com.topjohnwu.magisk.R
+import com.topjohnwu.magisk.extensions.inject
+import com.topjohnwu.magisk.extensions.toggle
 import com.topjohnwu.magisk.model.entity.HideAppInfo
 import com.topjohnwu.magisk.model.entity.HideTarget
 import com.topjohnwu.magisk.model.entity.state.IndeterminateState
 import com.topjohnwu.magisk.model.events.HideProcessEvent
-import com.topjohnwu.magisk.utils.inject
-import com.topjohnwu.magisk.utils.toggle
 
 class HideRvItem(val item: HideAppInfo, targets: List<HideTarget>) :
     ComparableRvItem<HideRvItem>() {

app/src/main/java/com/topjohnwu/magisk/model/entity/recycler/LogRvItem.kt

@@ -4,11 +4,11 @@ import com.skoumal.teanity.databinding.ComparableRvItem
 import com.skoumal.teanity.util.DiffObservableList
 import com.skoumal.teanity.util.KObservableField
 import com.topjohnwu.magisk.R
+import com.topjohnwu.magisk.extensions.timeFormatMedium
+import com.topjohnwu.magisk.extensions.toTime
+import com.topjohnwu.magisk.extensions.toggle
 import com.topjohnwu.magisk.model.entity.MagiskLog
 import com.topjohnwu.magisk.model.entity.WrappedMagiskLog
-import com.topjohnwu.magisk.utils.timeFormatMedium
-import com.topjohnwu.magisk.utils.toTime
-import com.topjohnwu.magisk.utils.toggle
 
 class LogRvItem : ComparableRvItem<LogRvItem>() {
     override val layoutRes: Int = R.layout.item_page_log

app/src/main/java/com/topjohnwu/magisk/model/entity/recycler/ModuleRvItem.kt

@@ -6,44 +6,54 @@ import com.skoumal.teanity.databinding.ComparableRvItem
 import com.skoumal.teanity.extensions.addOnPropertyChangedCallback
 import com.skoumal.teanity.util.KObservableField
 import com.topjohnwu.magisk.R
-import com.topjohnwu.magisk.model.entity.OldModule
-import com.topjohnwu.magisk.model.entity.Repo
-import com.topjohnwu.magisk.model.entity.Repository
-import com.topjohnwu.magisk.utils.get
-import com.topjohnwu.magisk.utils.toggle
+import com.topjohnwu.magisk.extensions.get
+import com.topjohnwu.magisk.extensions.toggle
+import com.topjohnwu.magisk.model.entity.module.Module
+import com.topjohnwu.magisk.model.entity.module.Repo
 
-class ModuleRvItem(val item: OldModule) : ComparableRvItem<ModuleRvItem>() {
+class ModuleRvItem(val item: Module) : ComparableRvItem<ModuleRvItem>() {
 
     override val layoutRes: Int = R.layout.item_module
 
     val lastActionNotice = KObservableField("")
-    val isChecked = KObservableField(item.isEnabled)
-    val isDeletable = KObservableField(item.willBeRemoved())
+    val isChecked = KObservableField(item.enable)
+    val isDeletable = KObservableField(item.remove)
 
     init {
         isChecked.addOnPropertyChangedCallback {
             when (it) {
-                true -> item.removeDisableFile().notice(R.string.disable_file_removed)
-                false -> item.createDisableFile().notice(R.string.disable_file_created)
+                true -> {
+                    item.enable = true
+                    notice(R.string.disable_file_removed)
+                }
+                false -> {
+                    item.enable = false
+                    notice(R.string.disable_file_created)
+                }
             }
         }
         isDeletable.addOnPropertyChangedCallback {
             when (it) {
-                true -> item.createRemoveFile().notice(R.string.remove_file_created)
-                false -> item.deleteRemoveFile().notice(R.string.remove_file_deleted)
+                true -> {
+                    item.remove = true
+                    notice(R.string.remove_file_created)
+                }
+                false -> {
+                    item.remove = false
+                    notice(R.string.remove_file_deleted)
+                }
             }
         }
         when {
-            item.isUpdated -> notice(R.string.update_file_created)
-            item.willBeRemoved() -> notice(R.string.remove_file_created)
+            item.updated -> notice(R.string.update_file_created)
+            item.remove -> notice(R.string.remove_file_created)
         }
     }
 
     fun toggle() = isChecked.toggle()
     fun toggleDelete() = isDeletable.toggle()
 
-    @Suppress("unused")
-    private fun Any.notice(@StringRes info: Int) {
+    private fun notice(@StringRes info: Int) {
         lastActionNotice.value = get<Resources>().getString(info)
     }
 
@@ -57,15 +67,9 @@ class ModuleRvItem(val item: OldModule) : ComparableRvItem<ModuleRvItem>() {
 
 class RepoRvItem(val item: Repo) : ComparableRvItem<RepoRvItem>() {
 
-    constructor(repo: Repository) : this(Repo(repo))
-
     override val layoutRes: Int = R.layout.item_repo
 
-    override fun contentSameAs(other: RepoRvItem): Boolean = item.version == other.item.version
-            && item.lastUpdate == other.item.lastUpdate
-            && item.versionCode == other.item.versionCode
-            && item.description == other.item.description
-            && item.detailUrl == other.item.detailUrl
+    override fun contentSameAs(other: RepoRvItem): Boolean = item == other.item
 
     override fun itemSameAs(other: RepoRvItem): Boolean = item.id == other.item.id
 }

app/src/main/java/com/topjohnwu/magisk/model/entity/recycler/PolicyRvItem.kt

@@ -6,19 +6,18 @@ import com.skoumal.teanity.extensions.addOnPropertyChangedCallback
 import com.skoumal.teanity.rxbus.RxBus
 import com.skoumal.teanity.util.KObservableField
 import com.topjohnwu.magisk.R
+import com.topjohnwu.magisk.extensions.inject
+import com.topjohnwu.magisk.extensions.toggle
 import com.topjohnwu.magisk.model.entity.MagiskPolicy
-import com.topjohnwu.magisk.model.entity.Policy
 import com.topjohnwu.magisk.model.events.PolicyEnableEvent
 import com.topjohnwu.magisk.model.events.PolicyUpdateEvent
-import com.topjohnwu.magisk.utils.inject
-import com.topjohnwu.magisk.utils.toggle
 
 class PolicyRvItem(val item: MagiskPolicy, val icon: Drawable) : ComparableRvItem<PolicyRvItem>() {
 
     override val layoutRes: Int = R.layout.item_policy
 
     val isExpanded = KObservableField(false)
-    val isEnabled = KObservableField(item.policy == Policy.ALLOW)
+    val isEnabled = KObservableField(item.policy == MagiskPolicy.ALLOW)
     val shouldNotify = KObservableField(item.notification)
     val shouldLog = KObservableField(item.logging)
 
@@ -28,7 +27,7 @@ class PolicyRvItem(val item: MagiskPolicy, val icon: Drawable) : ComparableRvIte
 
     private val currentStateItem
         get() = item.copy(
-            policy = if (isEnabled.value) Policy.ALLOW else Policy.DENY,
+            policy = if (isEnabled.value) MagiskPolicy.ALLOW else MagiskPolicy.DENY,
             notification = shouldNotify.value,
             logging = shouldLog.value
         )

app/src/main/java/com/topjohnwu/magisk/model/events/ViewEvents.kt

@@ -2,8 +2,7 @@ package com.topjohnwu.magisk.model.events
 
 import android.app.Activity
 import com.skoumal.teanity.viewevents.ViewEvent
-import com.topjohnwu.magisk.model.entity.Policy
-import com.topjohnwu.magisk.model.entity.Repo
+import com.topjohnwu.magisk.model.entity.module.Repo
 import io.reactivex.subjects.PublishSubject
 
 
@@ -36,5 +35,4 @@ class PermissionEvent(
 
 class BackPressEvent : ViewEvent()
 
-class SuDialogEvent(val policy: Policy) : ViewEvent()
 class DieEvent : ViewEvent()

app/src/main/java/com/topjohnwu/magisk/model/flash/Flashing.kt

@@ -3,8 +3,8 @@ package com.topjohnwu.magisk.model.flash
 import android.content.Context
 import android.net.Uri
 import androidx.core.os.postDelayed
+import com.topjohnwu.magisk.extensions.inject
 import com.topjohnwu.magisk.tasks.FlashZip
-import com.topjohnwu.magisk.utils.inject
 import com.topjohnwu.superuser.Shell
 import com.topjohnwu.superuser.internal.UiThreadHandler
 

app/src/main/java/com/topjohnwu/magisk/model/flash/Patching.kt

@@ -5,10 +5,11 @@ import com.topjohnwu.magisk.tasks.MagiskInstaller
 import com.topjohnwu.superuser.Shell
 
 sealed class Patching(
+    file: Uri,
     private val console: MutableList<String>,
     logs: MutableList<String>,
     private val resultListener: FlashResultListener
-) : MagiskInstaller(console, logs) {
+) : MagiskInstaller(file, console, logs) {
 
     override fun onResult(success: Boolean) {
         if (success) {
@@ -21,29 +22,32 @@ sealed class Patching(
     }
 
     class File(
+        file: Uri,
         private val uri: Uri,
         console: MutableList<String>,
         logs: MutableList<String>,
         resultListener: FlashResultListener
-    ) : Patching(console, logs, resultListener) {
+    ) : Patching(file, console, logs, resultListener) {
         override fun operations() =
             extractZip() && handleFile(uri) && patchBoot() && storeBoot()
     }
 
     class SecondSlot(
+        file: Uri,
         console: MutableList<String>,
         logs: MutableList<String>,
         resultListener: FlashResultListener
-    ) : Patching(console, logs, resultListener) {
+    ) : Patching(file, console, logs, resultListener) {
         override fun operations() =
             findSecondaryImage() && extractZip() && patchBoot() && flashBoot() && postOTA()
     }
 
     class Direct(
+        file: Uri,
         console: MutableList<String>,
         logs: MutableList<String>,
         resultListener: FlashResultListener
-    ) : Patching(console, logs, resultListener) {
+    ) : Patching(file, console, logs, resultListener) {
         override fun operations() =
             findImage() && extractZip() && patchBoot() && flashBoot()
     }

app/src/main/java/com/topjohnwu/magisk/model/preference/BooleanProperty.kt

@@ -1,7 +1,7 @@
 package com.topjohnwu.magisk.model.preference
 
 import androidx.core.content.edit
-import com.topjohnwu.magisk.utils.trimEmptyToNull
+import com.topjohnwu.magisk.extensions.trimEmptyToNull
 import kotlin.properties.ReadWriteProperty
 import kotlin.reflect.KProperty
 

app/src/main/java/com/topjohnwu/magisk/model/preference/FloatProperty.kt

@@ -1,7 +1,7 @@
 package com.topjohnwu.magisk.model.preference
 
 import androidx.core.content.edit
-import com.topjohnwu.magisk.utils.trimEmptyToNull
+import com.topjohnwu.magisk.extensions.trimEmptyToNull
 import kotlin.properties.ReadWriteProperty
 import kotlin.reflect.KProperty
 

app/src/main/java/com/topjohnwu/magisk/model/preference/IntProperty.kt

@@ -1,7 +1,7 @@
 package com.topjohnwu.magisk.model.preference
 
 import androidx.core.content.edit
-import com.topjohnwu.magisk.utils.trimEmptyToNull
+import com.topjohnwu.magisk.extensions.trimEmptyToNull
 import kotlin.properties.ReadWriteProperty
 import kotlin.reflect.KProperty
 

app/src/main/java/com/topjohnwu/magisk/model/preference/LongProperty.kt

@@ -1,7 +1,7 @@
 package com.topjohnwu.magisk.model.preference
 
 import androidx.core.content.edit
-import com.topjohnwu.magisk.utils.trimEmptyToNull
+import com.topjohnwu.magisk.extensions.trimEmptyToNull
 import kotlin.properties.ReadWriteProperty
 import kotlin.reflect.KProperty
 

app/src/main/java/com/topjohnwu/magisk/model/preference/StringProperty.kt

@@ -1,7 +1,7 @@
 package com.topjohnwu.magisk.model.preference
 
 import androidx.core.content.edit
-import com.topjohnwu.magisk.utils.trimEmptyToNull
+import com.topjohnwu.magisk.extensions.trimEmptyToNull
 import kotlin.properties.ReadWriteProperty
 import kotlin.reflect.KProperty
 

app/src/main/java/com/topjohnwu/magisk/model/preference/StringSetProperty.kt

@@ -1,7 +1,7 @@
 package com.topjohnwu.magisk.model.preference
 
 import androidx.core.content.edit
-import com.topjohnwu.magisk.utils.trimEmptyToNull
+import com.topjohnwu.magisk.extensions.trimEmptyToNull
 import kotlin.properties.ReadWriteProperty
 import kotlin.reflect.KProperty
 

app/src/main/java/com/topjohnwu/magisk/model/receiver/GeneralReceiver.kt

@@ -7,20 +7,23 @@ import com.topjohnwu.magisk.ClassMap
 import com.topjohnwu.magisk.Config
 import com.topjohnwu.magisk.Const
 import com.topjohnwu.magisk.Info
+import com.topjohnwu.magisk.data.database.PolicyDao
 import com.topjohnwu.magisk.data.database.base.su
-import com.topjohnwu.magisk.data.repository.AppRepository
+import com.topjohnwu.magisk.extensions.inject
+import com.topjohnwu.magisk.extensions.reboot
+import com.topjohnwu.magisk.model.download.DownloadService
+import com.topjohnwu.magisk.model.entity.ManagerJson
+import com.topjohnwu.magisk.model.entity.internal.Configuration
+import com.topjohnwu.magisk.model.entity.internal.DownloadSubject
 import com.topjohnwu.magisk.ui.surequest.SuRequestActivity
-import com.topjohnwu.magisk.utils.DownloadApp
 import com.topjohnwu.magisk.utils.SuLogger
-import com.topjohnwu.magisk.utils.inject
-import com.topjohnwu.magisk.utils.reboot
 import com.topjohnwu.magisk.view.Notifications
 import com.topjohnwu.magisk.view.Shortcuts
 import com.topjohnwu.superuser.Shell
 
 open class GeneralReceiver : BroadcastReceiver() {
 
-    private val appRepo: AppRepository by inject()
+    private val policyDB: PolicyDao by inject()
 
     companion object {
         const val REQUEST = "request"
@@ -30,21 +33,19 @@ open class GeneralReceiver : BroadcastReceiver() {
     }
 
     private fun getPkg(intent: Intent): String {
-        return intent.data?.encodedSchemeSpecificPart ?: ""
+        return intent.data?.encodedSchemeSpecificPart.orEmpty()
     }
 
     override fun onReceive(context: Context, intent: Intent?) {
-        if (intent == null)
-            return
-        var action: String? = intent.action ?: return
-        when (action) {
+        intent ?: return
+        when (intent.action ?: return) {
             Intent.ACTION_REBOOT, Intent.ACTION_BOOT_COMPLETED -> {
-                action = intent.getStringExtra("action")
+                val action = intent.getStringExtra("action")
                 if (action == null) {
                     // Actual boot completed event
-                    Shell.su("mm_patch_dtbo").submit { result ->
-                        if (result.isSuccess)
-                            Notifications.dtboPatched()
+                    Shell.su("mm_patch_dtbo").submit {
+                        if (it.isSuccess)
+                            Notifications.dtboPatched(context)
                     }
                     return
                 }
@@ -65,16 +66,20 @@ open class GeneralReceiver : BroadcastReceiver() {
             Intent.ACTION_PACKAGE_REPLACED ->
                 // This will only work pre-O
                 if (Config.suReAuth)
-                    appRepo.delete(getPkg(intent)).blockingGet()
+                    policyDB.delete(getPkg(intent)).blockingGet()
             Intent.ACTION_PACKAGE_FULLY_REMOVED -> {
                 val pkg = getPkg(intent)
-                appRepo.delete(pkg).blockingGet()
+                policyDB.delete(pkg).blockingGet()
                 "magiskhide --rm $pkg".su().blockingGet()
             }
             Intent.ACTION_LOCALE_CHANGED -> Shortcuts.setup(context)
             Const.Key.BROADCAST_MANAGER_UPDATE -> {
-                Info.managerLink = intent.getStringExtra(Const.Key.INTENT_SET_LINK)
-                DownloadApp.upgrade(intent.getStringExtra(Const.Key.INTENT_SET_NAME))
+                intent.getParcelableExtra<ManagerJson>(Const.Key.INTENT_SET_APP)?.let {
+                    Info.remote = Info.remote.copy(app = it)
+                }
+                DownloadService(context) {
+                    subject = DownloadSubject.Manager(Configuration.APK.Upgrade)
+                }
             }
             Const.Key.BROADCAST_REBOOT -> reboot()
         }

app/src/main/java/com/topjohnwu/magisk/model/update/UpdateCheckService.kt

@@ -4,8 +4,8 @@ import androidx.work.ListenableWorker
 import com.topjohnwu.magisk.BuildConfig
 import com.topjohnwu.magisk.Info
 import com.topjohnwu.magisk.data.repository.MagiskRepository
+import com.topjohnwu.magisk.extensions.inject
 import com.topjohnwu.magisk.model.worker.DelegateWorker
-import com.topjohnwu.magisk.utils.inject
 import com.topjohnwu.magisk.view.Notifications
 import com.topjohnwu.superuser.Shell
 
@@ -18,10 +18,10 @@ class UpdateCheckService : DelegateWorker() {
         Shell.getShell()
         return runCatching {
             magiskRepo.fetchUpdate().blockingGet()
-            if (BuildConfig.VERSION_CODE < Info.remoteManagerVersionCode)
-                Notifications.managerUpdate()
-            else if (Info.magiskVersionCode < Info.remoteMagiskVersionCode)
-                Notifications.magiskUpdate()
+            if (BuildConfig.VERSION_CODE < Info.remote.app.versionCode)
+                Notifications.managerUpdate(applicationContext)
+            else if (Info.magiskVersionCode < Info.remote.magisk.versionCode)
+                Notifications.magiskUpdate(applicationContext)
             ListenableWorker.Result.success()
         }.getOrElse {
             ListenableWorker.Result.failure()

app/src/main/java/com/topjohnwu/magisk/model/worker/DelegateWorker.java

@@ -1,84 +0,0 @@
-package com.topjohnwu.magisk.model.worker;
-
-import android.content.Context;
-import android.net.Network;
-import android.net.Uri;
-
-import androidx.annotation.MainThread;
-import androidx.annotation.NonNull;
-import androidx.annotation.Nullable;
-import androidx.annotation.RequiresApi;
-import androidx.work.Data;
-import androidx.work.ListenableWorker;
-
-import com.google.common.util.concurrent.ListenableFuture;
-
-import java.util.List;
-import java.util.Set;
-import java.util.UUID;
-
-public abstract class DelegateWorker {
-
-    private ListenableWorker worker;
-
-    @NonNull
-    public abstract ListenableWorker.Result doWork();
-
-    public void onStopped() {}
-
-    public void setActualWorker(ListenableWorker w) {
-        worker = w;
-    }
-
-    @NonNull
-    public Context getApplicationContext() {
-        return worker.getApplicationContext();
-    }
-
-    @NonNull
-    public UUID getId() {
-        return worker.getId();
-    }
-
-    @NonNull
-    public Data getInputData() {
-        return worker.getInputData();
-    }
-
-    @NonNull
-    public Set<String> getTags() {
-        return worker.getTags();
-    }
-
-    @NonNull
-    @RequiresApi(24)
-    public List<Uri> getTriggeredContentUris() {
-        return worker.getTriggeredContentUris();
-    }
-
-    @NonNull
-    @RequiresApi(24)
-    public List<String> getTriggeredContentAuthorities() {
-        return worker.getTriggeredContentAuthorities();
-    }
-
-    @Nullable
-    @RequiresApi(28)
-    public Network getNetwork() {
-        return worker.getNetwork();
-    }
-
-    public int getRunAttemptCount() {
-        return worker.getRunAttemptCount();
-    }
-
-    @NonNull
-    @MainThread
-    public ListenableFuture<ListenableWorker.Result> startWork() {
-        return worker.startWork();
-    }
-
-    public boolean isStopped() {
-        return worker.isStopped();
-    }
-}

app/src/main/java/com/topjohnwu/magisk/model/worker/DelegateWorker.kt

@@ -0,0 +1,59 @@
+package com.topjohnwu.magisk.model.worker
+
+import android.content.Context
+import android.net.Network
+import android.net.Uri
+import androidx.annotation.MainThread
+import androidx.annotation.RequiresApi
+import androidx.work.Data
+import androidx.work.ListenableWorker
+import com.google.common.util.concurrent.ListenableFuture
+import java.util.*
+
+abstract class DelegateWorker {
+
+    private lateinit var worker: ListenableWorker
+
+    val applicationContext: Context
+        get() = worker.applicationContext
+
+    val id: UUID
+        get() = worker.id
+
+    val inputData: Data
+        get() = worker.inputData
+
+    val tags: Set<String>
+        get() = worker.tags
+
+    val triggeredContentUris: List<Uri>
+        @RequiresApi(24)
+        get() = worker.triggeredContentUris
+
+    val triggeredContentAuthorities: List<String>
+        @RequiresApi(24)
+        get() = worker.triggeredContentAuthorities
+
+    val network: Network?
+        @RequiresApi(28)
+        get() = worker.network
+
+    val runAttemptCount: Int
+        get() = worker.runAttemptCount
+
+    val isStopped: Boolean
+        get() = worker.isStopped
+
+    abstract fun doWork(): ListenableWorker.Result
+
+    fun onStopped() {}
+
+    fun attachWorker(w: ListenableWorker) {
+        worker = w
+    }
+
+    @MainThread
+    fun startWork(): ListenableFuture<ListenableWorker.Result> {
+        return worker.startWork()
+    }
+}

app/src/main/java/com/topjohnwu/magisk/model/zip/Zip.kt

@@ -1,7 +1,7 @@
 package com.topjohnwu.magisk.model.zip
 
-import com.topjohnwu.magisk.utils.forEach
-import com.topjohnwu.magisk.utils.withStreams
+import com.topjohnwu.magisk.extensions.forEach
+import com.topjohnwu.magisk.extensions.withStreams
 import com.topjohnwu.superuser.io.SuFile
 import java.io.File
 import java.util.zip.ZipInputStream

app/src/main/java/com/topjohnwu/magisk/tasks/FlashZip.kt

@@ -1,12 +1,12 @@
 package com.topjohnwu.magisk.tasks
 
+import android.content.Context
 import android.net.Uri
 import com.skoumal.teanity.extensions.subscribeK
-import com.topjohnwu.magisk.App
 import com.topjohnwu.magisk.Const
-import com.topjohnwu.magisk.utils.fileName
-import com.topjohnwu.magisk.utils.inject
-import com.topjohnwu.magisk.utils.readUri
+import com.topjohnwu.magisk.extensions.fileName
+import com.topjohnwu.magisk.extensions.inject
+import com.topjohnwu.magisk.extensions.readUri
 import com.topjohnwu.magisk.utils.unzip
 import com.topjohnwu.superuser.Shell
 import io.reactivex.Single
@@ -20,8 +20,11 @@ abstract class FlashZip(
     private val logs: MutableList<String>
 ) {
 
-    private val app: App by inject()
-    private val tmpFile: File = File(app.cacheDir, "install.zip")
+    private val context: Context by inject()
+    private val installFolder = File(context.cacheDir, "flash").apply {
+        if (!exists()) mkdirs()
+    }
+    private val tmpFile: File = File(installFolder, "install.zip")
 
     @Throws(IOException::class)
     private fun unzipAndCheck(): Boolean {
@@ -40,7 +43,7 @@ abstract class FlashZip(
         console.add("- Copying zip to temp directory")
 
         runCatching {
-            app.readUri(mUri).use { input ->
+            context.readUri(mUri).use { input ->
                 tmpFile.outputStream().use { out -> input.copyTo(out) }
             }
         }.getOrElse {

app/src/main/java/com/topjohnwu/magisk/tasks/MagiskInstaller.java

@@ -1,380 +0,0 @@
-package com.topjohnwu.magisk.tasks;
-
-import android.net.Uri;
-import android.os.Build;
-import android.text.TextUtils;
-
-import androidx.annotation.MainThread;
-import androidx.annotation.WorkerThread;
-
-import com.topjohnwu.magisk.App;
-import com.topjohnwu.magisk.Const;
-import com.topjohnwu.magisk.Info;
-import com.topjohnwu.magisk.utils.Utils;
-import com.topjohnwu.net.DownloadProgressListener;
-import com.topjohnwu.net.Networking;
-import com.topjohnwu.signing.SignBoot;
-import com.topjohnwu.superuser.Shell;
-import com.topjohnwu.superuser.ShellUtils;
-import com.topjohnwu.superuser.internal.NOPList;
-import com.topjohnwu.superuser.internal.UiThreadHandler;
-import com.topjohnwu.superuser.io.SuFile;
-import com.topjohnwu.superuser.io.SuFileInputStream;
-import com.topjohnwu.superuser.io.SuFileOutputStream;
-
-import org.kamranzafar.jtar.TarEntry;
-import org.kamranzafar.jtar.TarHeader;
-import org.kamranzafar.jtar.TarInputStream;
-import org.kamranzafar.jtar.TarOutputStream;
-
-import java.io.BufferedInputStream;
-import java.io.BufferedOutputStream;
-import java.io.File;
-import java.io.FileInputStream;
-import java.io.FileOutputStream;
-import java.io.IOException;
-import java.io.InputStream;
-import java.io.OutputStream;
-import java.nio.ByteBuffer;
-import java.util.Arrays;
-import java.util.List;
-import java.util.zip.ZipEntry;
-import java.util.zip.ZipInputStream;
-
-public abstract class MagiskInstaller {
-
-    protected String srcBoot;
-    protected File destFile;
-    protected File installDir;
-
-    private List<String> console, logs;
-    private boolean isTar = false;
-
-    private class ProgressLog implements DownloadProgressListener {
-
-        private int prev = -1;
-        private int location;
-
-        @Override
-        public void onProgress(long bytesDownloaded, long totalBytes) {
-            if (prev < 0) {
-                location = console.size();
-                console.add("... 0%");
-            }
-            int curr = (int) (100 * bytesDownloaded / totalBytes);
-            if (prev != curr) {
-                prev = curr;
-                console.set(location, "... " + prev + "%");
-            }
-        }
-    }
-
-    protected MagiskInstaller() {
-        console = NOPList.getInstance();
-        logs = NOPList.getInstance();
-    }
-
-    public MagiskInstaller(List<String> out, List<String> err) {
-        console = out;
-        logs = err;
-        installDir = new File(App.deContext.getFilesDir().getParent(), "install");
-        Shell.sh("rm -rf " + installDir).exec();
-        installDir.mkdirs();
-    }
-
-    protected boolean findImage() {
-        srcBoot = ShellUtils.fastCmd("find_boot_image", "echo \"$BOOTIMAGE\"");
-        if (srcBoot.isEmpty()) {
-            console.add("! Unable to detect target image");
-            return false;
-        }
-        console.add("- Target image: " + srcBoot);
-        return true;
-    }
-
-    protected boolean findSecondaryImage() {
-        String slot = ShellUtils.fastCmd("echo $SLOT");
-        String target = (TextUtils.equals(slot, "_a") ? "_b" : "_a");
-        console.add("- Target slot: " + target);
-        srcBoot = ShellUtils.fastCmd(
-                "SLOT=" + target,
-                "find_boot_image",
-                "SLOT=" + slot,
-                "echo \"$BOOTIMAGE\""
-        );
-        if (srcBoot.isEmpty()) {
-            console.add("! Unable to detect target image");
-            return false;
-        }
-        console.add("- Target image: " + srcBoot);
-        return true;
-    }
-
-    protected boolean extractZip() {
-        String arch;
-        if (Build.VERSION.SDK_INT >= 21) {
-            List<String> abis = Arrays.asList(Build.SUPPORTED_ABIS);
-            arch = abis.contains("x86") ? "x86" : "arm";
-        } else {
-            arch = TextUtils.equals(Build.CPU_ABI, "x86") ? "x86" : "arm";
-        }
-
-        console.add("- Device platform: " + Build.CPU_ABI);
-
-        File zip = new File(App.self.getCacheDir(), "magisk.zip");
-
-        if (!ShellUtils.checkSum("MD5", zip, Info.magiskMD5)) {
-            console.add("- Downloading zip");
-            Networking.get(Info.magiskLink)
-                    .setDownloadProgressListener(new ProgressLog())
-                    .execForFile(zip);
-        } else {
-            console.add("- Existing zip found");
-        }
-
-        try {
-            ZipInputStream zi = new ZipInputStream(new BufferedInputStream(
-                    new FileInputStream(zip), (int) zip.length()));
-            ZipEntry ze;
-            while ((ze = zi.getNextEntry()) != null) {
-                if (ze.isDirectory())
-                    continue;
-                String name = null;
-                String[] names = { arch + "/", "common/", "META-INF/com/google/android/update-binary" };
-                for (String n : names) {
-                    if (ze.getName().startsWith(n)) {
-                        name = ze.getName().substring(ze.getName().lastIndexOf('/') + 1);
-                        break;
-                    }
-                }
-                if (name == null && ze.getName().startsWith("chromeos/"))
-                    name = ze.getName();
-                if (name == null)
-                    continue;
-                File dest = (installDir instanceof SuFile) ?
-                        new SuFile(installDir, name) :
-                        new File(installDir, name);
-                dest.getParentFile().mkdirs();
-                try (OutputStream out = new SuFileOutputStream(dest)) {
-                    ShellUtils.pump(zi, out);
-                }
-            }
-        } catch (IOException e) {
-            console.add("! Cannot unzip zip");
-            return false;
-        }
-
-        File init64 = SuFile.open(installDir, "magiskinit64");
-        if (Build.VERSION.SDK_INT >= 21 && Build.SUPPORTED_64_BIT_ABIS.length != 0) {
-            init64.renameTo(SuFile.open(installDir, "magiskinit"));
-        } else {
-            init64.delete();
-        }
-        Shell.sh("cd " + installDir, "chmod 755 *").exec();
-        return true;
-    }
-
-    private TarEntry newEntry(String name, long size) {
-        console.add("-- Writing: " + name);
-        return new TarEntry(TarHeader.createHeader(name, size, 0, false, 0644));
-    }
-
-    private void handleTar(InputStream in) throws IOException {
-        console.add("- Processing tar file");
-        boolean vbmeta = false;
-        try (TarInputStream tarIn = new TarInputStream(in);
-             TarOutputStream tarOut = new TarOutputStream(destFile)) {
-            TarEntry entry;
-            while ((entry = tarIn.getNextEntry()) != null) {
-                if (entry.getName().contains("boot.img")
-                        || entry.getName().contains("recovery.img")) {
-                    String name = entry.getName();
-                    console.add("-- Extracting: " + name);
-                    File extract = new File(installDir, name);
-                    try (FileOutputStream fout = new FileOutputStream(extract)) {
-                        ShellUtils.pump(tarIn, fout);
-                    }
-                    if (name.contains(".lz4")) {
-                        console.add("-- Decompressing: " + name);
-                        Shell.sh("./magiskboot --decompress " + extract).to(console).exec();
-                    }
-                } else if (entry.getName().contains("vbmeta.img")) {
-                    vbmeta = true;
-                    ByteBuffer buf = ByteBuffer.allocate(256);
-                    buf.put("AVB0".getBytes()); // magic
-                    buf.putInt(1);              // required_libavb_version_major
-                    buf.putInt(120, 2);         // flags
-                    buf.position(128);          // release_string
-                    buf.put("avbtool 1.1.0".getBytes());
-                    tarOut.putNextEntry(newEntry("vbmeta.img", 256));
-                    tarOut.write(buf.array());
-                } else {
-                    console.add("-- Writing: " + entry.getName());
-                    tarOut.putNextEntry(entry);
-                    ShellUtils.pump(tarIn, tarOut);
-                }
-            }
-            File boot = SuFile.open(installDir, "boot.img");
-            File recovery = SuFile.open(installDir, "recovery.img");
-            if (vbmeta && recovery.exists() && boot.exists()) {
-                // Install Magisk to recovery
-                srcBoot = recovery.getPath();
-                // Repack boot image to prevent restore
-                Shell.sh(
-                        "./magiskboot --unpack boot.img",
-                        "./magiskboot --repack boot.img",
-                        "./magiskboot --cleanup",
-                        "mv new-boot.img boot.img").exec();
-                try (InputStream sin = new SuFileInputStream(boot)) {
-                    tarOut.putNextEntry(newEntry("boot.img", boot.length()));
-                    ShellUtils.pump(sin, tarOut);
-                }
-                boot.delete();
-            } else {
-                if (!boot.exists()) {
-                    console.add("! No boot image found");
-                    throw new IOException();
-                }
-                srcBoot = boot.getPath();
-            }
-        }
-    }
-
-    protected boolean handleFile(Uri uri) {
-        try (InputStream in = new BufferedInputStream(App.self.getContentResolver().openInputStream(uri))) {
-            in.mark(500);
-            byte[] magic = new byte[5];
-            if (in.skip(257) != 257 || in.read(magic) != magic.length) {
-                console.add("! Invalid file");
-                return false;
-            }
-            in.reset();
-            if (Arrays.equals(magic, "ustar".getBytes())) {
-                isTar = true;
-                destFile = new File(Const.EXTERNAL_PATH, "magisk_patched.tar");
-                handleTar(in);
-            } else {
-                // Raw image
-                srcBoot = new File(installDir, "boot.img").getPath();
-                destFile = new File(Const.EXTERNAL_PATH, "magisk_patched.img");
-                console.add("- Copying image to cache");
-                try (OutputStream out = new FileOutputStream(srcBoot)) {
-                    ShellUtils.pump(in, out);
-                }
-            }
-        } catch (IOException e) {
-            console.add("! Process error");
-            e.printStackTrace();
-            return false;
-        }
-        return true;
-    }
-
-    protected boolean patchBoot() {
-        boolean isSigned;
-        try (InputStream in = new SuFileInputStream(srcBoot)) {
-            isSigned = SignBoot.verifySignature(in, null);
-            if (isSigned) {
-                console.add("- Boot image is signed with AVB 1.0");
-            }
-        } catch (IOException e) {
-            console.add("! Unable to check signature");
-            return false;
-        }
-
-        if (!Shell.sh(Utils.INSTANCE.fmt(
-                "KEEPFORCEENCRYPT=%b KEEPVERITY=%b RECOVERYMODE=%b " +
-                "sh update-binary sh boot_patch.sh %s",
-                Info.keepEnc, Info.keepVerity, Info.recovery, srcBoot))
-                .to(console, logs).exec().isSuccess())
-            return false;
-
-        Shell.Job job = Shell.sh("./magiskboot --cleanup",
-                "mv bin/busybox busybox",
-                "rm -rf magisk.apk bin boot.img update-binary",
-                "cd /");
-
-        File patched = new File(installDir, "new-boot.img");
-        if (isSigned) {
-            console.add("- Signing boot image with test keys");
-            File signed = new File(installDir, "signed.img");
-            try (InputStream in = new SuFileInputStream(patched);
-                 OutputStream out = new BufferedOutputStream(new FileOutputStream(signed))) {
-                SignBoot.doSignature("/boot", in, out, null, null);
-            } catch (IOException e) {
-                return false;
-            }
-            job.add("mv -f " + signed + " " + patched);
-        }
-        job.exec();
-        return true;
-    }
-
-    protected boolean flashBoot() {
-        if (!Shell.su(Utils.INSTANCE.fmt("direct_install %s %s", installDir, srcBoot))
-                .to(console, logs).exec().isSuccess())
-            return false;
-        if (!Info.keepVerity)
-            Shell.su("patch_dtbo_image").to(console, logs).exec();
-        return true;
-    }
-
-    protected boolean storeBoot() {
-        File patched = SuFile.open(installDir, "new-boot.img");
-        try {
-            OutputStream os;
-            if (isTar) {
-                os = new TarOutputStream(destFile, true);
-                ((TarOutputStream) os).putNextEntry(newEntry(
-                                srcBoot.contains("recovery") ? "recovery.img" : "boot.img",
-                                patched.length()));
-            } else {
-                os = new BufferedOutputStream(new FileOutputStream(destFile));
-            }
-            try (InputStream in = new SuFileInputStream(patched);
-                OutputStream out = os) {
-                ShellUtils.pump(in, out);
-            }
-        } catch (IOException e) {
-            console.add("! Failed to output to " + destFile);
-            e.printStackTrace();
-        }
-        patched.delete();
-        console.add("");
-        console.add("****************************");
-        console.add(" Output file is placed in ");
-        console.add(" " + destFile + " ");
-        console.add("****************************");
-        return true;
-    }
-
-    protected boolean postOTA() {
-        SuFile bootctl = new SuFile("/data/adb/bootctl");
-        try (InputStream in = Networking.get(Const.Url.BOOTCTL_URL).execForInputStream().getResult();
-             OutputStream out = new SuFileOutputStream(bootctl)) {
-            ShellUtils.pump(in, out);
-        } catch (IOException e) {
-            e.printStackTrace();
-            return false;
-        }
-        Shell.su("post_ota " + bootctl.getParent()).exec();
-        console.add("***************************************");
-        console.add(" Next reboot will boot to second slot!");
-        console.add("***************************************");
-        return true;
-    }
-
-    @WorkerThread
-    protected abstract boolean operations();
-
-    @MainThread
-    protected abstract void onResult(boolean success);
-
-    public void exec() {
-        App.THREAD_POOL.execute(() -> {
-            boolean b = operations();
-            UiThreadHandler.run(() -> onResult(b));
-        });
-    }
-
-}

app/src/main/java/com/topjohnwu/magisk/tasks/MagiskInstaller.kt

@@ -0,0 +1,356 @@
+package com.topjohnwu.magisk.tasks
+
+import android.content.Context
+import android.net.Uri
+import android.os.Build
+import android.text.TextUtils
+import androidx.annotation.MainThread
+import androidx.annotation.WorkerThread
+import com.skoumal.teanity.extensions.subscribeK
+import com.topjohnwu.magisk.Config
+import com.topjohnwu.magisk.Info
+import com.topjohnwu.magisk.data.network.GithubRawServices
+import com.topjohnwu.magisk.di.Protected
+import com.topjohnwu.magisk.extensions.*
+import com.topjohnwu.signing.SignBoot
+import com.topjohnwu.superuser.Shell
+import com.topjohnwu.superuser.ShellUtils
+import com.topjohnwu.superuser.internal.NOPList
+import com.topjohnwu.superuser.io.SuFile
+import com.topjohnwu.superuser.io.SuFileInputStream
+import com.topjohnwu.superuser.io.SuFileOutputStream
+import io.reactivex.Single
+import org.kamranzafar.jtar.TarEntry
+import org.kamranzafar.jtar.TarHeader
+import org.kamranzafar.jtar.TarInputStream
+import org.kamranzafar.jtar.TarOutputStream
+import timber.log.Timber
+import java.io.*
+import java.nio.ByteBuffer
+import java.util.*
+import java.util.zip.ZipEntry
+import java.util.zip.ZipInputStream
+
+abstract class MagiskInstaller {
+
+    protected lateinit var srcBoot: String
+    protected lateinit var destFile: File
+    protected lateinit var installDir: File
+    protected lateinit var zipUri: Uri
+
+    private val console: MutableList<String>
+    private val logs: MutableList<String>
+    private var isTar = false
+
+    private val service: GithubRawServices by inject()
+    private val context: Context by inject()
+
+    protected constructor() {
+        console = NOPList.getInstance()
+        logs = NOPList.getInstance()
+    }
+
+    constructor(zip: Uri, out: MutableList<String>, err: MutableList<String>) {
+        console = out
+        logs = err
+        zipUri = zip
+        installDir = File(get<Context>(Protected).filesDir.parent, "install")
+        "rm -rf $installDir".sh()
+        installDir.mkdirs()
+    }
+
+    protected fun findImage(): Boolean {
+        srcBoot = "find_boot_image; echo \"\$BOOTIMAGE\"".fsh()
+        if (srcBoot.isEmpty()) {
+            console.add("! Unable to detect target image")
+            return false
+        }
+        console.add("- Target image: $srcBoot")
+        return true
+    }
+
+    protected fun findSecondaryImage(): Boolean {
+        val slot = "echo \$SLOT".fsh()
+        val target = if (slot == "_a") "_b" else "_a"
+        console.add("- Target slot: $target")
+        srcBoot = arrayOf(
+                "SLOT=$target",
+                "find_boot_image",
+                "SLOT=$slot",
+                "echo \"\$BOOTIMAGE\"").fsh()
+        if (srcBoot.isEmpty()) {
+            console.add("! Unable to detect target image")
+            return false
+        }
+        console.add("- Target image: $srcBoot")
+        return true
+    }
+
+    protected fun extractZip(): Boolean {
+        val arch: String
+        arch = if (Build.VERSION.SDK_INT >= 21) {
+            val abis = listOf(*Build.SUPPORTED_ABIS)
+            if (abis.contains("x86")) "x86" else "arm"
+        } else {
+            if (TextUtils.equals(Build.CPU_ABI, "x86")) "x86" else "arm"
+        }
+
+        console.add("- Device platform: " + Build.CPU_ABI)
+
+        try {
+            ZipInputStream(context.readUri(zipUri).buffered()).use { zi ->
+                lateinit var ze: ZipEntry
+                while (zi.nextEntry?.let { ze = it } != null) {
+                    if (ze.isDirectory)
+                        continue
+                    var name: String? = null
+                    val names = arrayOf("$arch/", "common/", "META-INF/com/google/android/update-binary")
+                    for (n in names) {
+                        ze.name.run {
+                            if (startsWith(n)) {
+                                name = substring(lastIndexOf('/') + 1)
+                            }
+                        }
+                        name ?: continue
+                        break
+                    }
+                    if (name == null && ze.name.startsWith("chromeos/"))
+                        name = ze.name
+                    if (name == null)
+                        continue
+                    val dest = if (installDir is SuFile)
+                        SuFile(installDir, name)
+                    else
+                        File(installDir, name)
+                    dest.parentFile!!.mkdirs()
+                    SuFileOutputStream(dest).use { zi.copyTo(it) }
+                }
+            }
+        } catch (e: IOException) {
+            console.add("! Cannot unzip zip")
+            Timber.e(e)
+            return false
+        }
+
+        val init64 = SuFile.open(installDir, "magiskinit64")
+        if (Build.VERSION.SDK_INT >= 21 && Build.SUPPORTED_64_BIT_ABIS.isNotEmpty()) {
+            init64.renameTo(SuFile.open(installDir, "magiskinit"))
+        } else {
+            init64.delete()
+        }
+        "cd $installDir; chmod 755 *".sh()
+        return true
+    }
+
+    private fun newEntry(name: String, size: Long): TarEntry {
+        console.add("-- Writing: $name")
+        return TarEntry(TarHeader.createHeader(name, size, 0, false, 420 /* 0644 */))
+    }
+
+    @Throws(IOException::class)
+    private fun handleTar(input: InputStream) {
+        console.add("- Processing tar file")
+        var vbmeta = false
+        withStreams(TarInputStream(input), TarOutputStream(destFile)) { tarIn, tarOut ->
+            lateinit var entry: TarEntry
+            while (tarIn.nextEntry?.let { entry = it } != null) {
+                if (entry.name.contains("boot.img") || entry.name.contains("recovery.img")) {
+                    val name = entry.name
+                    console.add("-- Extracting: $name")
+                    val extract = File(installDir, name)
+                    FileOutputStream(extract).use { tarIn.copyTo(it) }
+                    if (name.contains(".lz4")) {
+                        console.add("-- Decompressing: $name")
+                        "./magiskboot --decompress $extract".sh()
+                    }
+                } else if (entry.name.contains("vbmeta.img")) {
+                    vbmeta = true
+                    val buf = ByteBuffer.allocate(256)
+                    buf.put("AVB0".toByteArray())   // magic
+                    buf.putInt(1)                   // required_libavb_version_major
+                    buf.putInt(120, 2)              // flags
+                    buf.position(128)               // release_string
+                    buf.put("avbtool 1.1.0".toByteArray())
+                    tarOut.putNextEntry(newEntry("vbmeta.img", 256))
+                    tarOut.write(buf.array())
+                } else {
+                    console.add("-- Writing: " + entry.name)
+                    tarOut.putNextEntry(entry)
+                    tarIn.copyTo(tarOut)
+                }
+            }
+            val boot = SuFile.open(installDir, "boot.img")
+            val recovery = SuFile.open(installDir, "recovery.img")
+            if (vbmeta && recovery.exists() && boot.exists()) {
+                // Install Magisk to recovery
+                srcBoot = recovery.path
+                // Repack boot image to prevent restore
+                arrayOf(
+                        "./magiskboot --unpack boot.img",
+                        "./magiskboot --repack boot.img",
+                        "./magiskboot --cleanup",
+                        "mv new-boot.img boot.img").sh()
+                SuFileInputStream(boot).use {
+                    tarOut.putNextEntry(newEntry("boot.img", boot.length()))
+                    it.copyTo(tarOut)
+                }
+                boot.delete()
+            } else {
+                if (!boot.exists()) {
+                    console.add("! No boot image found")
+                    throw IOException()
+                }
+                srcBoot = boot.path
+            }
+        }
+    }
+
+    protected fun handleFile(uri: Uri): Boolean {
+        try {
+            context.readUri(uri).buffered().use {
+                it.mark(500)
+                val magic = ByteArray(5)
+                if (it.skip(257) != 257L || it.read(magic) != magic.size) {
+                    console.add("! Invalid file")
+                    return false
+                }
+                it.reset()
+                if (Arrays.equals(magic, "ustar".toByteArray())) {
+                    isTar = true
+                    destFile = File(Config.downloadDirectory, "magisk_patched.tar")
+                    handleTar(it)
+                } else {
+                    // Raw image
+                    srcBoot = File(installDir, "boot.img").path
+                    destFile = File(Config.downloadDirectory, "magisk_patched.img")
+                    console.add("- Copying image to cache")
+                    FileOutputStream(srcBoot).use { out -> it.copyTo(out) }
+                }
+            }
+        } catch (e: IOException) {
+            console.add("! Process error")
+            Timber.e(e)
+            return false
+        }
+
+        return true
+    }
+
+    protected fun patchBoot(): Boolean {
+        var isSigned = false
+        try {
+            SuFileInputStream(srcBoot).use {
+                isSigned = SignBoot.verifySignature(it, null)
+                if (isSigned) {
+                    console.add("- Boot image is signed with AVB 1.0")
+                }
+            }
+        } catch (e: IOException) {
+            console.add("! Unable to check signature")
+            return false
+        }
+
+        if (!("KEEPFORCEENCRYPT=${Info.keepEnc} KEEPVERITY=${Info.keepVerity} " +
+                "RECOVERYMODE=${Info.recovery} sh update-binary " +
+                "sh boot_patch.sh $srcBoot").sh().isSuccess) {
+            return false
+        }
+
+        val job = Shell.sh(
+                "./magiskboot --cleanup",
+                "mv bin/busybox busybox",
+                "rm -rf magisk.apk bin boot.img update-binary",
+                "cd /")
+
+        val patched = File(installDir, "new-boot.img")
+        if (isSigned) {
+            console.add("- Signing boot image with test keys")
+            val signed = File(installDir, "signed.img")
+            try {
+                withStreams(SuFileInputStream(patched), signed.outputStream().buffered()) {
+                    input, out -> SignBoot.doSignature("/boot", input, out, null, null)
+                }
+            } catch (e: IOException) {
+                console.add("! Unable to sign image")
+                Timber.e(e)
+                return false
+            }
+
+            job.add("mv -f $signed $patched")
+        }
+        job.exec()
+        return true
+    }
+
+    protected fun flashBoot(): Boolean {
+        if (!"direct_install $installDir $srcBoot".sh().isSuccess)
+            return false
+        if (!Info.keepVerity)
+            "patch_dtbo_image".sh()
+        return true
+    }
+
+    protected fun storeBoot(): Boolean {
+        val patched = SuFile.open(installDir, "new-boot.img")
+        try {
+            val os: OutputStream
+            if (isTar) {
+                os = TarOutputStream(destFile, true)
+                os.putNextEntry(newEntry(
+                        if (srcBoot.contains("recovery")) "recovery.img" else "boot.img",
+                        patched.length()))
+            } else {
+                os = destFile.outputStream()
+            }
+            patched.suInputStream().use { it.copyTo(os); os.close() }
+        } catch (e: IOException) {
+            console.add("! Failed to output to $destFile")
+            Timber.e(e)
+            return false
+        }
+
+        patched.delete()
+        console.add("")
+        console.add("****************************")
+        console.add(" Output file is placed in ")
+        console.add(" $destFile ")
+        console.add("****************************")
+        return true
+    }
+
+    protected fun postOTA(): Boolean {
+        val bootctl = SuFile("/data/adb/bootctl")
+        try {
+            withStreams(service.fetchBootctl().blockingGet().byteStream(), bootctl.suOutputStream()) {
+                input, out -> input.copyTo(out)
+            }
+        } catch (e: IOException) {
+            console.add("! Unable to download bootctl")
+            Timber.e(e)
+            return false
+        }
+
+        "post_ota ${bootctl.parent}".sh()
+
+        console.add("***************************************")
+        console.add(" Next reboot will boot to second slot!")
+        console.add("***************************************")
+        return true
+    }
+
+    private fun String.sh() = Shell.sh(this).to(console, logs).exec()
+    private fun Array<String>.sh() = Shell.sh(*this).to(console, logs).exec()
+    private fun String.fsh() = ShellUtils.fastCmd(this)
+    private fun Array<String>.fsh() = ShellUtils.fastCmd(*this)
+
+    @WorkerThread
+    protected abstract fun operations(): Boolean
+
+    @MainThread
+    protected abstract fun onResult(success: Boolean)
+
+    fun exec() {
+        Single.fromCallable { operations() }.subscribeK { onResult(it) }
+    }
+
+}

app/src/main/java/com/topjohnwu/magisk/tasks/RepoUpdater.kt

@@ -0,0 +1,98 @@
+package com.topjohnwu.magisk.tasks
+
+import com.topjohnwu.magisk.Const
+import com.topjohnwu.magisk.data.database.RepoDao
+import com.topjohnwu.magisk.data.network.GithubApiServices
+import com.topjohnwu.magisk.model.entity.module.Repo
+import io.reactivex.Flowable
+import io.reactivex.Single
+import io.reactivex.rxkotlin.toFlowable
+import io.reactivex.schedulers.Schedulers
+import se.ansman.kotshi.JsonSerializable
+import timber.log.Timber
+import java.net.HttpURLConnection
+import java.text.SimpleDateFormat
+import java.util.*
+import kotlin.collections.HashSet
+
+class RepoUpdater(
+    private val api: GithubApiServices,
+    private val repoDB: RepoDao
+) {
+
+    private fun loadRepos(repos: List<GithubRepoInfo>, cached: MutableSet<String>) =
+            repos.toFlowable().parallel().runOn(Schedulers.io()).map {
+                // Skip submission
+                if (it.id == "submission")
+                    return@map
+                (repoDB.getRepo(it.id)?.apply { cached.remove(it.id) } ?:
+                Repo(it.id)).runCatching {
+                    update(it.pushDate)
+                    repoDB.addRepo(this)
+                }.getOrElse { Timber.e(it) }
+            }.sequential()
+
+    private fun loadPage(
+        cached: MutableSet<String>,
+        page: Int = 1,
+        etag: String = ""
+    ): Flowable<Unit> = api.fetchRepos(page, etag).flatMap {
+        it.error()?.also { throw it }
+        it.response()?.run {
+            if (code() == HttpURLConnection.HTTP_NOT_MODIFIED)
+                return@run Flowable.error<Unit>(CachedException)
+
+            if (page == 1)
+                repoDB.etagKey = headers()[Const.Key.ETAG_KEY].orEmpty().trimEtag()
+
+            val flow = loadRepos(body()!!, cached)
+            if (headers()[Const.Key.LINK_KEY].orEmpty().contains("next")) {
+                flow.mergeWith(loadPage(cached, page + 1))
+            } else {
+                flow
+            }
+        }
+    }
+
+    private fun forcedReload(cached: MutableSet<String>) =
+            cached.toFlowable().parallel().runOn(Schedulers.io()).map {
+                runCatching {
+                    Repo(it).update()
+                }.getOrElse { Timber.e(it) }
+            }.sequential()
+
+    private fun String.trimEtag() = substring(indexOf('\"'), lastIndexOf('\"') + 1)
+
+    operator fun invoke(forced: Boolean = false) : Single<Unit> {
+        val cached = Collections.synchronizedSet(HashSet(repoDB.repoIDList))
+        return loadPage(cached, etag = repoDB.etagKey).doOnComplete {
+            repoDB.removeRepos(cached)
+        }.onErrorResumeNext { it: Throwable ->
+            if (it is CachedException) {
+                if (forced)
+                    return@onErrorResumeNext forcedReload(cached)
+            } else {
+                Timber.e(it)
+            }
+            Flowable.empty()
+        }.ignoreElements().toSingleDefault(Unit)
+    }
+
+    object CachedException : Exception()
+}
+
+private val dateFormat: SimpleDateFormat =
+        SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss'Z'", Locale.US).apply {
+            timeZone = TimeZone.getTimeZone("UTC")
+        }
+
+@JsonSerializable
+data class GithubRepoInfo(
+    val name: String,
+    val pushed_at: String
+) {
+    val id get() = name
+
+    @Transient
+    val pushDate = dateFormat.parse(pushed_at)!!
+}

app/src/main/java/com/topjohnwu/magisk/tasks/UpdateRepos.java

@@ -1,186 +0,0 @@
-package com.topjohnwu.magisk.tasks;
-
-import android.database.Cursor;
-import android.util.Pair;
-
-import androidx.annotation.NonNull;
-
-import com.topjohnwu.magisk.App;
-import com.topjohnwu.magisk.Config;
-import com.topjohnwu.magisk.Const;
-import com.topjohnwu.magisk.data.database.RepoDatabaseHelper;
-import com.topjohnwu.magisk.model.entity.Repo;
-import com.topjohnwu.magisk.utils.Logger;
-import com.topjohnwu.magisk.utils.Utils;
-import com.topjohnwu.net.Networking;
-import com.topjohnwu.net.Request;
-
-import org.json.JSONArray;
-import org.json.JSONException;
-import org.json.JSONObject;
-
-import java.net.HttpURLConnection;
-import java.text.DateFormat;
-import java.text.ParseException;
-import java.text.SimpleDateFormat;
-import java.util.Collections;
-import java.util.Date;
-import java.util.Locale;
-import java.util.Queue;
-import java.util.Set;
-import java.util.TimeZone;
-import java.util.concurrent.ConcurrentLinkedQueue;
-import java.util.concurrent.ExecutionException;
-import java.util.concurrent.Future;
-
-import io.reactivex.Single;
-
-@Deprecated
-public class UpdateRepos {
-    private static final DateFormat DATE_FORMAT;
-
-    static {
-        DATE_FORMAT = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss'Z'", Locale.US);
-        DATE_FORMAT.setTimeZone(TimeZone.getTimeZone("UTC"));
-    }
-
-    @NonNull
-    private final RepoDatabaseHelper repoDB;
-    private Set<String> cached;
-    private Queue<Pair<String, Date>> moduleQueue;
-
-    public UpdateRepos(@NonNull RepoDatabaseHelper repoDatabase) {
-        repoDB = repoDatabase;
-    }
-
-    private void runTasks(Runnable task) {
-        Future[] futures = new Future[App.THREAD_POOL.getMaximumPoolSize() - 1];
-        for (int i = 0; i < futures.length; ++i) {
-            futures[i] = App.THREAD_POOL.submit(task);
-        }
-        for (Future f : futures) {
-            while (true) {
-                try {
-                    f.get();
-                } catch (InterruptedException e) {
-                    continue;
-                } catch (ExecutionException ignored) {
-                }
-                break;
-            }
-        }
-    }
-
-    /* We sort repos by last push, which means that we only need to check whether the
-     * first page is updated to determine whether the online repo database is changed
-     */
-    private boolean parsePage(int page) {
-        Request req = Networking.get(Utils.INSTANCE.fmt(Const.Url.REPO_URL, page + 1));
-        if (page == 0) {
-            String etag = Config.getEtagKey();
-            if (!etag.isEmpty())
-                req.addHeaders(Const.Key.IF_NONE_MATCH, etag);
-        }
-        Request.Result<JSONArray> res = req.execForJSONArray();
-        // JSON not updated
-        if (res.getCode() == HttpURLConnection.HTTP_NOT_MODIFIED)
-            return false;
-        // Network error
-        if (res.getResult() == null) {
-            cached.clear();
-            return true;
-        }
-        // Current page is the last page
-        if (res.getResult().length() == 0)
-            return true;
-
-        try {
-            for (int i = 0; i < res.getResult().length(); i++) {
-                JSONObject rawRepo = res.getResult().getJSONObject(i);
-                String id = rawRepo.getString("name");
-                Date date = DATE_FORMAT.parse(rawRepo.getString("pushed_at"));
-                moduleQueue.offer(new Pair<>(id, date));
-            }
-        } catch (JSONException | ParseException e) {
-            // Should not happen, but if exception occurs, page load fails
-            return false;
-        }
-
-        // Update ETAG
-        if (page == 0) {
-            String etag = res.getConnection().getHeaderField(Config.Key.ETAG_KEY);
-            if (etag != null) {
-                etag = etag.substring(etag.indexOf('\"'), etag.lastIndexOf('\"') + 1);
-                Config.setEtagKey(etag);
-            }
-        }
-
-        String links = res.getConnection().getHeaderField(Const.Key.LINK_KEY);
-        return links == null || !links.contains("next") || parsePage(page + 1);
-    }
-
-    private boolean loadPages() {
-        if (!parsePage(0))
-            return false;
-        runTasks(() -> {
-            while (true) {
-                Pair<String, Date> pair = moduleQueue.poll();
-                if (pair == null)
-                    return;
-                Repo repo = repoDB.getRepo(pair.first);
-                try {
-                    if (repo == null)
-                        repo = new Repo(pair.first);
-                    else
-                        cached.remove(pair.first);
-                    repo.update(pair.second);
-                    repoDB.addRepo(repo);
-                } catch (Repo.IllegalRepoException e) {
-                    Logger.debug(e.getMessage());
-                    repoDB.removeRepo(pair.first);
-                }
-            }
-        });
-        return true;
-    }
-
-    private void fullReload() {
-        Cursor c = repoDB.getRawCursor();
-        runTasks(() -> {
-            while (true) {
-                Repo repo;
-                synchronized (c) {
-                    if (!c.moveToNext())
-                        return;
-                    repo = new Repo(c);
-                }
-                try {
-                    repo.update();
-                    repoDB.addRepo(repo);
-                } catch (Repo.IllegalRepoException e) {
-                    Logger.debug(e.getMessage());
-                    repoDB.removeRepo(repo);
-                }
-            }
-        });
-    }
-
-    public Single<Boolean> exec(boolean force) {
-        return Single.fromCallable(() -> {
-            cached = Collections.synchronizedSet(repoDB.getRepoIDSet());
-            moduleQueue = new ConcurrentLinkedQueue<>();
-
-            if (loadPages()) {
-                // The leftover cached means they are removed from online repo
-                repoDB.removeRepo(cached);
-            } else if (force) {
-                fullReload();
-            }
-            return force; // not important
-        });
-    }
-
-    public Single<Boolean> exec() {
-        return exec(false);
-    }
-}

app/src/main/java/com/topjohnwu/magisk/ui/MainActivity.kt

@@ -4,6 +4,7 @@ import android.content.Intent
 import android.os.Bundle
 import androidx.core.view.GravityCompat
 import androidx.fragment.app.Fragment
+import com.skoumal.teanity.extensions.addOnPropertyChangedCallback
 import com.topjohnwu.magisk.ClassMap
 import com.topjohnwu.magisk.Config
 import com.topjohnwu.magisk.Const.Key.OPEN_SECTION
@@ -20,7 +21,6 @@ import com.topjohnwu.magisk.ui.module.ReposFragment
 import com.topjohnwu.magisk.ui.settings.SettingsFragment
 import com.topjohnwu.magisk.ui.superuser.SuperuserFragment
 import com.topjohnwu.magisk.utils.Utils
-import com.topjohnwu.net.Networking
 import com.topjohnwu.superuser.Shell
 import org.koin.androidx.viewmodel.ext.android.viewModel
 import kotlin.reflect.KClass
@@ -57,6 +57,10 @@ open class MainActivity : MagiskActivity<MainViewModel, ActivityMainBinding>() {
         checkHideSection()
         setSupportActionBar(binding.mainInclude.mainToolbar)
 
+        viewModel.isConnected.addOnPropertyChangedCallback {
+            checkHideSection()
+        }
+
         if (savedInstanceState == null) {
             intent.getStringExtra(OPEN_SECTION)?.let {
                 onEventDispatched(Navigation.fromSection(it))
@@ -110,7 +114,7 @@ open class MainActivity : MagiskActivity<MainViewModel, ActivityMainBinding>() {
         menu.findItem(R.id.modulesFragment).isVisible =
             Shell.rootAccess() && Info.magiskVersionCode >= 0
         menu.findItem(R.id.reposFragment).isVisible =
-            (Networking.checkNetworkStatus(this) && Shell.rootAccess() && Info.magiskVersionCode >= 0)
+            (viewModel.isConnected.value && Shell.rootAccess() && Info.magiskVersionCode >= 0)
         menu.findItem(R.id.logFragment).isVisible =
             Shell.rootAccess()
         menu.findItem(R.id.superuserFragment).isVisible =

app/src/main/java/com/topjohnwu/magisk/ui/SplashActivity.kt

@@ -5,16 +5,11 @@ import android.os.Bundle
 import android.text.TextUtils
 import androidx.appcompat.app.AlertDialog
 import androidx.appcompat.app.AppCompatActivity
-import com.skoumal.teanity.extensions.subscribeK
 import com.topjohnwu.magisk.*
-import com.topjohnwu.magisk.data.database.SettingsDao
-import com.topjohnwu.magisk.tasks.UpdateRepos
 import com.topjohnwu.magisk.utils.Utils
 import com.topjohnwu.magisk.view.Notifications
 import com.topjohnwu.magisk.view.Shortcuts
-import com.topjohnwu.net.Networking
 import com.topjohnwu.superuser.Shell
-import org.koin.android.ext.android.get
 
 open class SplashActivity : AppCompatActivity() {
 
@@ -38,7 +33,7 @@ open class SplashActivity : AppCompatActivity() {
     private fun initAndStart() {
         val pkg = Config.suManager
         if (Config.suManager.isNotEmpty() && packageName == BuildConfig.APPLICATION_ID) {
-            get<SettingsDao>().delete(Config.Key.SU_MANAGER)
+            Config.suManager = ""
             Shell.su("pm uninstall $pkg").submit()
         }
         if (TextUtils.equals(pkg, packageName)) {
@@ -56,19 +51,11 @@ open class SplashActivity : AppCompatActivity() {
         Notifications.setup(this)
 
         // Schedule periodic update checks
-        Utils.scheduleUpdateCheck()
+        Utils.scheduleUpdateCheck(this)
 
         // Setup shortcuts
         Shortcuts.setup(this)
 
-        // Magisk working as expected
-        if (Shell.rootAccess() && Info.magiskVersionCode > 0) {
-            // Load repos
-            if (Networking.checkNetworkStatus(this)) {
-                get<UpdateRepos>().exec().subscribeK()
-            }
-        }
-
         val intent = Intent(this, ClassMap[MainActivity::class.java])
         intent.putExtra(Const.Key.OPEN_SECTION, getIntent().getStringExtra(Const.Key.OPEN_SECTION))
         DONE = true

app/src/main/java/com/topjohnwu/magisk/ui/base/BasePreferenceFragment.kt

@@ -11,7 +11,6 @@ import androidx.core.view.children
 import androidx.core.view.isVisible
 import androidx.preference.*
 import androidx.recyclerview.widget.RecyclerView
-import com.topjohnwu.magisk.App
 import com.topjohnwu.magisk.R
 import org.koin.android.ext.android.inject
 
@@ -19,7 +18,7 @@ abstract class BasePreferenceFragment : PreferenceFragmentCompat(),
     SharedPreferences.OnSharedPreferenceChangeListener {
 
     protected val prefs: SharedPreferences by inject()
-    protected val app: App by inject()
+    protected val activity get() = requireActivity() as MagiskActivity<*, *>
 
     override fun onCreateView(
         inflater: LayoutInflater,
@@ -60,8 +59,4 @@ abstract class BasePreferenceFragment : PreferenceFragmentCompat(),
         else
             view.setPadding(0, view.paddingTop, view.paddingRight, view.paddingBottom)
     }
-
-    protected fun <T: Preference> findPref(key: CharSequence): T {
-        return findPreference(key) as T
-    }
 }

app/src/main/java/com/topjohnwu/magisk/ui/base/MagiskActivity.kt

@@ -22,6 +22,7 @@ import com.ncapdevi.fragnav.FragNavTransactionOptions
 import com.skoumal.teanity.view.TeanityActivity
 import com.skoumal.teanity.viewevents.ViewEvent
 import com.topjohnwu.magisk.Config
+import com.topjohnwu.magisk.extensions.set
 import com.topjohnwu.magisk.model.events.BackPressEvent
 import com.topjohnwu.magisk.model.events.PermissionEvent
 import com.topjohnwu.magisk.model.events.ViewActionEvent
@@ -31,7 +32,7 @@ import com.topjohnwu.magisk.model.navigation.Navigator
 import com.topjohnwu.magisk.model.permissions.PermissionRequestBuilder
 import com.topjohnwu.magisk.utils.LocaleManager
 import com.topjohnwu.magisk.utils.Utils
-import com.topjohnwu.magisk.utils.set
+import com.topjohnwu.magisk.utils.currentLocale
 import timber.log.Timber
 import kotlin.reflect.KClass
 
@@ -68,12 +69,12 @@ abstract class MagiskActivity<ViewModel : MagiskViewModel, Binding : ViewDataBin
 
     override fun applyOverrideConfiguration(config: Configuration?) {
         // Force applying our preferred local
-        config?.setLocale(LocaleManager.locale)
+        config?.setLocale(currentLocale)
         super.applyOverrideConfiguration(config)
     }
 
     override fun attachBaseContext(base: Context) {
-        super.attachBaseContext(LocaleManager.getLocaleContext(base, LocaleManager.locale))
+        super.attachBaseContext(LocaleManager.getLocaleContext(base))
     }
 
     override fun onCreate(savedInstanceState: Bundle?) {

app/src/main/java/com/topjohnwu/magisk/ui/base/MagiskFragment.kt

@@ -17,21 +17,21 @@ import kotlin.reflect.KClass
 abstract class MagiskFragment<ViewModel : MagiskViewModel, Binding : ViewDataBinding> :
     TeanityFragment<ViewModel, Binding>(), Navigator {
 
-    protected val magiskActivity get() = activity as MagiskActivity<*, *>
+    protected val activity get() = requireActivity() as MagiskActivity<*, *>
 
     // We don't need nested fragments
     override val baseFragments: List<KClass<Fragment>> = listOf()
 
-    override fun navigateTo(event: MagiskNavigationEvent) = magiskActivity.navigateTo(event)
+    override fun navigateTo(event: MagiskNavigationEvent) = activity.navigateTo(event)
 
     @CallSuper
     override fun onEventDispatched(event: ViewEvent) {
         super.onEventDispatched(event)
         when (event) {
-            is BackPressEvent -> magiskActivity.onBackPressed()
+            is BackPressEvent -> activity.onBackPressed()
             is MagiskNavigationEvent -> navigateTo(event)
             is ViewActionEvent -> event.action(requireActivity())
-            is PermissionEvent -> magiskActivity.withPermissions(*event.permissions.toTypedArray()) {
+            is PermissionEvent -> activity.withPermissions(*event.permissions.toTypedArray()) {
                 onSuccess { event.callback.onNext(true) }
                 onFailure {
                     event.callback.onNext(false)
@@ -42,10 +42,10 @@ abstract class MagiskFragment<ViewModel : MagiskViewModel, Binding : ViewDataBin
     }
 
     fun withPermissions(vararg permissions: String, builder: PermissionRequestBuilder.() -> Unit) {
-        magiskActivity.withPermissions(*permissions, builder = builder)
+        activity.withPermissions(*permissions, builder = builder)
     }
 
-    fun openLink(url: String) = magiskActivity.openUrl(url)
+    fun openLink(url: String) = activity.openUrl(url)
 
     open fun onBackPressed(): Boolean = false
 

app/src/main/java/com/topjohnwu/magisk/ui/base/MagiskViewModel.kt

@@ -1,8 +1,12 @@
 package com.topjohnwu.magisk.ui.base
 
 import android.app.Activity
+import com.github.pwittchen.reactivenetwork.library.rx2.ReactiveNetwork
 import com.skoumal.teanity.extensions.doOnSubscribeUi
+import com.skoumal.teanity.extensions.subscribeK
+import com.skoumal.teanity.util.KObservableField
 import com.skoumal.teanity.viewmodel.LoadingViewModel
+import com.topjohnwu.magisk.extensions.get
 import com.topjohnwu.magisk.model.events.BackPressEvent
 import com.topjohnwu.magisk.model.events.PermissionEvent
 import com.topjohnwu.magisk.model.events.ViewActionEvent
@@ -10,7 +14,17 @@ import io.reactivex.Observable
 import io.reactivex.subjects.PublishSubject
 
 
-abstract class MagiskViewModel : LoadingViewModel() {
+abstract class MagiskViewModel(
+    initialState: State = State.LOADING
+) : LoadingViewModel(initialState) {
+
+    val isConnected = KObservableField(true)
+
+    init {
+        ReactiveNetwork.observeNetworkConnectivity(get())
+            .subscribeK { isConnected.value = it.available() }
+            .add()
+    }
 
     fun withView(action: Activity.() -> Unit) {
         ViewActionEvent(action).publish()

app/src/main/java/com/topjohnwu/magisk/ui/flash/FlashActivity.kt

@@ -1,19 +1,35 @@
 package com.topjohnwu.magisk.ui.flash
 
+import android.content.Context
+import android.content.Intent
+import android.net.Uri
+import android.os.Bundle
+import androidx.core.app.NotificationManagerCompat
+import androidx.core.net.toUri
+import com.topjohnwu.magisk.ClassMap
 import com.topjohnwu.magisk.Const
 import com.topjohnwu.magisk.R
 import com.topjohnwu.magisk.databinding.ActivityFlashBinding
 import com.topjohnwu.magisk.ui.base.MagiskActivity
 import org.koin.androidx.viewmodel.ext.android.viewModel
 import org.koin.core.parameter.parametersOf
+import java.io.File
 
 open class FlashActivity : MagiskActivity<FlashViewModel, ActivityFlashBinding>() {
 
     override val layoutRes: Int = R.layout.activity_flash
     override val viewModel: FlashViewModel by viewModel {
-        val uri = intent.data
+        val uri = intent.data ?: let { finish(); Uri.EMPTY }
+        val additionalUri = intent.getParcelableExtra(Const.Key.FLASH_DATA) ?: uri
         val action = intent.getStringExtra(Const.Key.FLASH_ACTION) ?: let { finish();"" }
-        parametersOf(action, uri)
+        parametersOf(action, uri, additionalUri)
+    }
+
+    override fun onCreate(savedInstanceState: Bundle?) {
+        super.onCreate(savedInstanceState)
+        val id = intent.getIntExtra(Const.Key.DISMISS_ID, -1)
+        if (id != -1)
+            NotificationManagerCompat.from(this).cancel(id)
     }
 
     override fun onBackPressed() {
@@ -21,4 +37,56 @@ open class FlashActivity : MagiskActivity<FlashViewModel, ActivityFlashBinding>(
         super.onBackPressed()
     }
 
+    companion object {
+
+        private fun intent(context: Context) = Intent(context, ClassMap[FlashActivity::class.java])
+            .addFlags(Intent.FLAG_ACTIVITY_NEW_TASK)
+        private fun intent(context: Context, file: File) = intent(context).setData(file.toUri())
+
+        private fun flashType(isSecondSlot: Boolean) =
+            if (isSecondSlot) Const.Value.FLASH_INACTIVE_SLOT else Const.Value.FLASH_MAGISK
+
+        /* Flashing is understood as installing / flashing magisk itself */
+
+        fun flashIntent(context: Context, file: File, isSecondSlot: Boolean, id : Int = -1)
+            = intent(context, file)
+            .putExtra(Const.Key.FLASH_ACTION, flashType(isSecondSlot))
+            .putExtra(Const.Key.DISMISS_ID, id)
+
+        fun flash(context: Context, file: File, isSecondSlot: Boolean, id: Int) =
+            context.startActivity(flashIntent(context, file, isSecondSlot, id))
+
+        /* Patching is understood as injecting img files with magisk */
+
+        fun patchIntent(context: Context, file: File, uri: Uri, id : Int = -1)
+            = intent(context, file)
+            .putExtra(Const.Key.FLASH_DATA, uri)
+            .putExtra(Const.Key.FLASH_ACTION, Const.Value.PATCH_FILE)
+            .putExtra(Const.Key.DISMISS_ID, id)
+
+        fun patch(context: Context, file: File, uri: Uri, id: Int) =
+            context.startActivity(patchIntent(context, file, uri, id))
+
+        /* Uninstalling is understood as removing magisk entirely */
+
+        fun uninstallIntent(context: Context, file: File, id : Int = -1)
+            = intent(context, file)
+            .putExtra(Const.Key.FLASH_ACTION, Const.Value.UNINSTALL)
+            .putExtra(Const.Key.DISMISS_ID, id)
+
+        fun uninstall(context: Context, file: File, id: Int) =
+            context.startActivity(uninstallIntent(context, file, id))
+
+        /* Installing is understood as flashing modules / zips */
+
+        fun installIntent(context: Context, file: File, id : Int = -1)
+            = intent(context, file)
+            .putExtra(Const.Key.FLASH_ACTION, Const.Value.FLASH_ZIP)
+            .putExtra(Const.Key.DISMISS_ID, id)
+
+        fun install(context: Context, file: File, id: Int) =
+            context.startActivity(installIntent(context, file, id))
+
+    }
+
 }

app/src/main/java/com/topjohnwu/magisk/ui/flash/FlashViewModel.kt

@@ -13,14 +13,15 @@ import com.skoumal.teanity.util.DiffObservableList
 import com.skoumal.teanity.util.KObservableField
 import com.skoumal.teanity.viewevents.SnackbarEvent
 import com.topjohnwu.magisk.BR
+import com.topjohnwu.magisk.Config
 import com.topjohnwu.magisk.Const
 import com.topjohnwu.magisk.R
+import com.topjohnwu.magisk.extensions.*
 import com.topjohnwu.magisk.model.entity.recycler.ConsoleRvItem
 import com.topjohnwu.magisk.model.flash.FlashResultListener
 import com.topjohnwu.magisk.model.flash.Flashing
 import com.topjohnwu.magisk.model.flash.Patching
 import com.topjohnwu.magisk.ui.base.MagiskViewModel
-import com.topjohnwu.magisk.utils.*
 import com.topjohnwu.superuser.Shell
 import me.tatarka.bindingcollectionadapter2.ItemBinding
 import java.io.File
@@ -28,7 +29,8 @@ import java.util.*
 
 class FlashViewModel(
     action: String,
-    uri: Uri?,
+    installer: Uri,
+    uri: Uri,
     private val resources: Resources
 ) : MagiskViewModel(), FlashResultListener {
 
@@ -52,22 +54,21 @@ class FlashViewModel(
 
         state = State.LOADING
 
-        val uri = uri ?: Uri.EMPTY
         when (action) {
             Const.Value.FLASH_ZIP -> Flashing
-                .Install(uri, outItems, logItems, this)
+                .Install(installer, outItems, logItems, this)
                 .exec()
             Const.Value.UNINSTALL -> Flashing
-                .Uninstall(uri, outItems, logItems, this)
+                .Uninstall(installer, outItems, logItems, this)
                 .exec()
             Const.Value.FLASH_MAGISK -> Patching
-                .Direct(outItems, logItems, this)
+                .Direct(installer, outItems, logItems, this)
                 .exec()
             Const.Value.FLASH_INACTIVE_SLOT -> Patching
-                .SecondSlot(outItems, logItems, this)
+                .SecondSlot(installer, outItems, logItems, this)
                 .exec()
             Const.Value.PATCH_FILE -> Patching
-                .File(uri, outItems, logItems, this)
+                .File(installer, uri, outItems, logItems, this)
                 .exec()
         }
     }
@@ -90,7 +91,7 @@ class FlashViewModel(
         .map { now }
         .map { it.toTime(timeFormatStandard) }
         .map { Const.MAGISK_INSTALL_LOG_FILENAME.format(it) }
-        .map { File(Const.EXTERNAL_PATH, it) }
+        .map { File(Config.downloadDirectory, it) }
         .map { file ->
             file.bufferedWriter().use { writer ->
                 logItems.forEach {

app/src/main/java/com/topjohnwu/magisk/ui/hide/HideViewModel.kt

@@ -9,13 +9,13 @@ import com.skoumal.teanity.util.DiffObservableList
 import com.skoumal.teanity.util.KObservableField
 import com.topjohnwu.magisk.BR
 import com.topjohnwu.magisk.data.repository.MagiskRepository
+import com.topjohnwu.magisk.extensions.toSingle
+import com.topjohnwu.magisk.extensions.update
 import com.topjohnwu.magisk.model.entity.recycler.HideProcessRvItem
 import com.topjohnwu.magisk.model.entity.recycler.HideRvItem
 import com.topjohnwu.magisk.model.entity.state.IndeterminateState
 import com.topjohnwu.magisk.model.events.HideProcessEvent
 import com.topjohnwu.magisk.ui.base.MagiskViewModel
-import com.topjohnwu.magisk.utils.toSingle
-import com.topjohnwu.magisk.utils.update
 import me.tatarka.bindingcollectionadapter2.OnItemBind
 import timber.log.Timber
 

app/src/main/java/com/topjohnwu/magisk/ui/hide/MagiskHideFragment.kt

@@ -25,8 +25,22 @@ class MagiskHideFragment : MagiskFragment<HideViewModel, FragmentMagiskHideBindi
     override fun onCreateOptionsMenu(menu: Menu, inflater: MenuInflater) {
         inflater.inflate(R.menu.menu_magiskhide, menu)
         menu.apply {
-            (findItem(R.id.app_search).actionView as? SearchView)
-                ?.setOnQueryTextListener(this@MagiskHideFragment)
+            val query = viewModel.query.value
+            val searchItem = menu.findItem(R.id.app_search)
+            val searchView = searchItem.actionView as? SearchView
+
+            searchView?.run {
+                setOnQueryTextListener(this@MagiskHideFragment)
+                setQuery(query, false)
+            }
+
+            if (query.isNotBlank()) {
+                searchItem.expandActionView()
+                searchView?.isIconified = false
+            } else {
+                searchItem.collapseActionView()
+                searchView?.isIconified = true
+            }
 
             val showSystem = Config.showSystemApp