self review

CONTRIBUTING.md

@@ -50,11 +50,11 @@ You can execute the following commands in the following directories:
 - The projects root directory: all tests in the project are executed
 
 ```sh
-# Run unit and integration tests once
-pnpm run test -- --passWithNoTests
+# Run all once
+pnpm test
 
-# Rerun unit and integration tests on file changes
-pnpm run test:watch -- --passWithNoTests
+# Rerun tests on file changes
+pnpm test:watch
 ```
 
 ### Developing Against Your Local ZITADEL Instance

apps/login/ui/Input.tsx

@@ -8,7 +8,6 @@ import React, {
   InputHTMLAttributes,
   ReactNode,
 } from "react";
-import { v4 as uuidv4 } from "uuid";
 
 export type TextInputProps = DetailedHTMLProps<
   InputHTMLAttributes<HTMLInputElement>,
@@ -55,7 +54,6 @@ export const TextInput = forwardRef<HTMLInputElement, TextInputProps>(
     },
     ref
   ) => {
-    const id = uuidv4();
     return (
       <label className="flex flex-col text-12px text-input-light-label dark:text-input-dark-label">
         <span

packages/zitadel-client/src/middleware.test.ts

@@ -27,7 +27,7 @@ describe('authMiddleware', () => {
       it(name, async () => {
 
         const mockNext = jest.fn().mockImplementation(async function*() { });
-        const mockRequest = {}; // Ersetze dies mit einem geeigneten Mock Request-Objekt
+        const mockRequest = {};
 
         const mockMethodDescriptor: MethodDescriptor = {
             options: {idempotencyLevel: undefined},
@@ -38,7 +38,7 @@ describe('authMiddleware', () => {
 
         const mockCall: ClientMiddlewareCall<unknown, unknown> = {
             method: mockMethodDescriptor,
-            requestStream: false, // Setze diese Werte entsprechend deiner Testbedingungen
+            requestStream: false,
             responseStream: false,
             request: mockRequest,
             next: mockNext,

packages/zitadel-server/src/middleware.test.ts

@@ -27,7 +27,7 @@ describe('authMiddleware', () => {
       it(name, async () => {
 
         const mockNext = jest.fn().mockImplementation(async function*() { });
-        const mockRequest = {}; // Ersetze dies mit einem geeigneten Mock Request-Objekt
+        const mockRequest = {};
 
         const mockMethodDescriptor: MethodDescriptor = {
             options: {idempotencyLevel: undefined},
@@ -38,7 +38,7 @@ describe('authMiddleware', () => {
 
         const mockCall: ClientMiddlewareCall<unknown, unknown> = {
             method: mockMethodDescriptor,
-            requestStream: false, // Setze diese Werte entsprechend deiner Testbedingungen
+            requestStream: false,
             responseStream: false,
             request: mockRequest,
             next: mockNext,